Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129542/?format=api
{ "id": 129542, "url": "http://patches.dpdk.org/api/patches/129542/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230714124102.6546-1-ivan.malov@arknetworks.am/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230714124102.6546-1-ivan.malov@arknetworks.am>", "list_archive_url": "https://inbox.dpdk.org/dev/20230714124102.6546-1-ivan.malov@arknetworks.am", "date": "2023-07-14T12:41:02", "name": "[1/1] net/sfc: add explicit fail path for unknown tunnel flow type", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8da0047e68285348d9e71052ce57ef6c23d117b8", "submitter": { "id": 2962, "url": "http://patches.dpdk.org/api/people/2962/?format=api", "name": "Ivan Malov", "email": "ivan.malov@arknetworks.am" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230714124102.6546-1-ivan.malov@arknetworks.am/mbox/", "series": [ { "id": 28942, "url": "http://patches.dpdk.org/api/series/28942/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28942", "date": "2023-07-14T12:41:02", "name": "[1/1] net/sfc: add explicit fail path for unknown tunnel flow type", "version": 1, "mbox": "http://patches.dpdk.org/series/28942/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/129542/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/129542/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6DC3D42E70;\n\tFri, 14 Jul 2023 14:41:13 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F3081406B8;\n\tFri, 14 Jul 2023 14:41:12 +0200 (CEST)", "from agw.arknetworks.am (agw.arknetworks.am [79.141.165.80])\n by mails.dpdk.org (Postfix) with ESMTP id 8679140685;\n Fri, 14 Jul 2023 14:41:11 +0200 (CEST)", "from localhost.localdomain (unknown [78.109.74.178])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by agw.arknetworks.am (Postfix) with ESMTPSA id B56FDE0922;\n Fri, 14 Jul 2023 16:41:10 +0400 (+04)" ], "From": "Ivan Malov <ivan.malov@arknetworks.am>", "To": "dev@dpdk.org", "Cc": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Ferruh Yigit <ferruh.yigit@amd.com>, stable@dpdk.org", "Subject": "[PATCH 1/1] net/sfc: add explicit fail path for unknown tunnel flow\n type", "Date": "Fri, 14 Jul 2023 16:41:02 +0400", "Message-Id": "<20230714124102.6546-1-ivan.malov@arknetworks.am>", "X-Mailer": "git-send-email 2.39.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The driver supports flow tunnel offload. When the parsed rule\ntype is unknown, which must not happen, the driver does not\nproperly indicate the failure in non-debug builds. That\npresumably makes Coverity report possible NULL pointer\ndereference in regard with uninitialised HW match\nspecification (which gets properly initialised\nwhen the rule type check is successful).\n\nIn order to fix this, replace the debug\nassert with a proper runtime fail path.\n\nCoverity issue: 393675\nFixes: 73e01736868b (\"net/sfc: turn MAE flow action rules into shareable resources\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ivan Malov <ivan.malov@arknetworks.am>\n---\n drivers/net/sfc/sfc_mae.c | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_mae.c b/drivers/net/sfc/sfc_mae.c\nindex 60a54fd425..f5fe55b46f 100644\n--- a/drivers/net/sfc/sfc_mae.c\n+++ b/drivers/net/sfc/sfc_mae.c\n@@ -3460,8 +3460,10 @@ sfc_mae_rule_parse_pattern(struct sfc_adapter *sa,\n \t\t}\n \t\tbreak;\n \tdefault:\n-\t\tSFC_ASSERT(B_FALSE);\n-\t\tbreak;\n+\t\trc = rte_flow_error_set(error, EINVAL,\n+\t\t\tRTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,\n+\t\t\t\"FT: unexpected rule type\");\n+\t\tgoto fail_unexpected_ft_rule_type;\n \t}\n \n \t/*\n@@ -3531,6 +3533,7 @@ sfc_mae_rule_parse_pattern(struct sfc_adapter *sa,\n \tif (ctx_mae.match_spec_action != NULL)\n \t\tefx_mae_match_spec_fini(sa->nic, ctx_mae.match_spec_action);\n \n+fail_unexpected_ft_rule_type:\n fail_init_match_spec_action:\n fail_priority_check:\n \treturn rc;\n", "prefixes": [ "1/1" ] }