Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129054/?format=api
{ "id": 129054, "url": "http://patches.dpdk.org/api/patches/129054/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230628132004.340074-2-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230628132004.340074-2-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230628132004.340074-2-david.marchand@redhat.com", "date": "2023-06-28T13:20:03", "name": "[v5,1/2] build: select deprecated libraries", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9d64218d5cf4397420274b20385dbaf241b2d4d0", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230628132004.340074-2-david.marchand@redhat.com/mbox/", "series": [ { "id": 28689, "url": "http://patches.dpdk.org/api/series/28689/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28689", "date": "2023-06-28T13:20:03", "name": "Select optional libraries", "version": 5, "mbox": "http://patches.dpdk.org/series/28689/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/129054/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/129054/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B1B6742D80;\n\tWed, 28 Jun 2023 15:21:44 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9F3EF42BDA;\n\tWed, 28 Jun 2023 15:21:44 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id D636142BC9\n for <dev@dpdk.org>; Wed, 28 Jun 2023 15:21:43 +0200 (CEST)", "from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com\n [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-191-52XZTSdZMQmynIrJR6z5Vg-1; Wed, 28 Jun 2023 09:21:37 -0400", "from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com\n [10.11.54.3])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 02D6F385558B;\n Wed, 28 Jun 2023 13:20:13 +0000 (UTC)", "from dmarchan.redhat.com (unknown [10.45.224.210])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 1F10C111F3B6;\n Wed, 28 Jun 2023 13:20:10 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1687958503;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Rrefn73wQrzzFjj5z/aIHwvbq0GjQDSlqYRQo2xQpBc=;\n b=NXcEQZJpYRzuw3LtvOaNPyD3YD5o3eU8CSFdUWszJUrEkkwNMNnUGOQ0rpYE99CK3QkGhp\n 14MNJ9v2vCLos4q3FYtbU8qF8iQa/GQS7KCz4s61ePjAsgBA/GK7/8fpPljRUhv+pD1OJW\n MLpaiDZUfcW/VGWeS83UYMKj6Yzbrx4=", "X-MC-Unique": "52XZTSdZMQmynIrJR6z5Vg-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, bluca@debian.org, tredaelli@redhat.com,\n i.maximets@ovn.org, james.r.harris@intel.com, mohammed@hawari.fr,\n Aaron Conole <aconole@redhat.com>,\n Michael Santana <maicolgabriel@hotmail.com>,\n Bruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH v5 1/2] build: select deprecated libraries", "Date": "Wed, 28 Jun 2023 15:20:03 +0200", "Message-Id": "<20230628132004.340074-2-david.marchand@redhat.com>", "In-Reply-To": "<20230628132004.340074-1-david.marchand@redhat.com>", "References": "<20211117112847.7362-6-david.marchand@redhat.com>\n <20230628132004.340074-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.3", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Rework deprecated libraries selection by introducing a new configuration\noption.\n\nThis breaks existing configurations that were relying on disable_libs=''\nfor enabling deprecated libraries.\nOn the other hand, it will make enabling optional libraries more\nstraightforward by taking the deprecated libraries out of the picture.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\nChanges since v4:\n- changed the option to a list of libraries instead of a global on/off\n knob,\n- moved all deprecated libs checks under a single block for readability,\n\n---\n .ci/linux-build.sh | 2 +-\n devtools/test-meson-builds.sh | 8 ++++----\n lib/meson.build | 28 ++++++++++++++++++++--------\n meson_options.txt | 4 +++-\n 4 files changed, 28 insertions(+), 14 deletions(-)", "diff": "diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh\nindex 45f2729996..e0b62bac90 100755\n--- a/.ci/linux-build.sh\n+++ b/.ci/linux-build.sh\n@@ -97,7 +97,7 @@ if [ \"$MINI\" = \"true\" ]; then\n OPTS=\"$OPTS -Denable_drivers=net/null\"\n OPTS=\"$OPTS -Ddisable_libs=*\"\n else\n- OPTS=\"$OPTS -Ddisable_libs=\"\n+ OPTS=\"$OPTS -Denable_deprecated_libs=*\"\n fi\n OPTS=\"$OPTS -Dlibdir=lib\"\n \ndiff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh\nindex 84b907d2ea..c41659d28b 100755\n--- a/devtools/test-meson-builds.sh\n+++ b/devtools/test-meson-builds.sh\n@@ -120,10 +120,10 @@ config () # <dir> <builddir> <meson options>\n \t\treturn\n \tfi\n \toptions=\n-\t# deprecated libs may be disabled by default, so for complete builds ensure\n-\t# no libs are disabled\n-\tif ! echo $* | grep -q -- 'disable_libs' ; then\n-\t\toptions=\"$options -Ddisable_libs=\"\n+\t# deprecated libs are disabled by default, so for complete builds\n+\t# enable them\n+\tif ! echo $* | grep -q -- 'enable_deprecated_libs' ; then\n+\t\toptions=\"$options -Denable_deprecated_libs=*\"\n \tfi\n \tif echo $* | grep -qw -- '--default-library=shared' ; then\n \t\toptions=\"$options -Dexamples=all\"\ndiff --git a/lib/meson.build b/lib/meson.build\nindex fac2f52cad..73afd90b38 100644\n--- a/lib/meson.build\n+++ b/lib/meson.build\n@@ -93,6 +93,15 @@ dpdk_libs_deprecated += [\n 'kni',\n ]\n \n+enable_deprecated_libs = []\n+foreach l:run_command(list_dir_globs, get_option('enable_deprecated_libs'),\n+ check: true).stdout().split()\n+ if not dpdk_libs_deprecated.contains(l)\n+ continue\n+ endif\n+ enable_deprecated_libs += l\n+endforeach\n+\n disabled_libs = []\n opt_disabled_libs = run_command(list_dir_globs, get_option('disable_libs'),\n check: true).stdout().split()\n@@ -137,16 +146,19 @@ foreach l:libraries\n deps += ['eal']\n endif\n \n- if disabled_libs.contains(l)\n- build = false\n- reason = 'explicitly disabled via build config'\n- if dpdk_libs_deprecated.contains(l)\n- reason += ' (deprecated lib)'\n- endif\n- else\n- if dpdk_libs_deprecated.contains(l)\n+ if dpdk_libs_deprecated.contains(l)\n+ if not enable_deprecated_libs.contains(l)\n+ build = false\n+ reason = 'not in enabled deprecated libraries build config'\n+ else\n warning('Enabling deprecated library, \"@0@\"'.format(l))\n endif\n+ elif disabled_libs.contains(l)\n+ build = false\n+ reason = 'explicitly disabled via build config'\n+ endif\n+\n+ if build\n subdir(l)\n endif\n if name != l\ndiff --git a/meson_options.txt b/meson_options.txt\nindex 82c8297065..839d4266c6 100644\n--- a/meson_options.txt\n+++ b/meson_options.txt\n@@ -10,7 +10,7 @@ option('disable_apps', type: 'string', value: '', description:\n 'Comma-separated list of apps to explicitly disable.')\n option('disable_drivers', type: 'string', value: '', description:\n 'Comma-separated list of drivers to explicitly disable.')\n-option('disable_libs', type: 'string', value: 'flow_classify,kni', description:\n+option('disable_libs', type: 'string', value: '', description:\n 'Comma-separated list of libraries to explicitly disable. [NOTE: not all libs can be disabled]')\n option('drivers_install_subdir', type: 'string', value: 'dpdk/pmds-<VERSION>', description:\n 'Subdirectory of libdir where to install PMDs. Defaults to using a versioned subdirectory.')\n@@ -18,6 +18,8 @@ option('enable_docs', type: 'boolean', value: false, description:\n 'build documentation')\n option('enable_apps', type: 'string', value: '', description:\n 'Comma-separated list of apps to build. If unspecified, build all apps.')\n+option('enable_deprecated_libs', type: 'string', value: '', description:\n+ 'Comma-separated list of deprecated libraries to explicitly enable.')\n option('enable_drivers', type: 'string', value: '', description:\n 'Comma-separated list of drivers to build. If unspecified, build all drivers.')\n option('enable_driver_sdk', type: 'boolean', value: false, description:\n", "prefixes": [ "v5", "1/2" ] }