Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/128493/?format=api
{ "id": 128493, "url": "http://patches.dpdk.org/api/patches/128493/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230609191245.252521-13-zhirun.yan@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230609191245.252521-13-zhirun.yan@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230609191245.252521-13-zhirun.yan@intel.com", "date": "2023-06-09T19:12:41", "name": "[v12,12/16] graph: introduce graph walk by cross-core dispatch", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6365af4fc8cca11a356dabb9121419a64e75fd07", "submitter": { "id": 1154, "url": "http://patches.dpdk.org/api/people/1154/?format=api", "name": "Yan, Zhirun", "email": "zhirun.yan@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230609191245.252521-13-zhirun.yan@intel.com/mbox/", "series": [ { "id": 28444, "url": "http://patches.dpdk.org/api/series/28444/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28444", "date": "2023-06-09T19:12:29", "name": "graph enhancement for multi-core dispatch", "version": 12, "mbox": "http://patches.dpdk.org/series/28444/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/128493/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/128493/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BA30A42C71;\n\tFri, 9 Jun 2023 21:21:25 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 89AF242D69;\n\tFri, 9 Jun 2023 21:20:26 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id 5DF7B42D77\n for <dev@dpdk.org>; Fri, 9 Jun 2023 21:20:24 +0200 (CEST)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Jun 2023 12:20:23 -0700", "from dpdk-zhirun-lmm.sh.intel.com ([10.67.119.94])\n by fmsmga006.fm.intel.com with ESMTP; 09 Jun 2023 12:20:21 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1686338424; x=1717874424;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=mr9iwvNxhZ7hGShL923CB2ZRxK/tbZrY7A7RG2Y8TbA=;\n b=BKuvwAv2e0bdkpQ7Xvh49Fm09NHmQWBppAiaTnn6CxGr3YaBatCL03GJ\n 4/+S05IKUw9DnAvt+TXuXJpS1GS5QWSzUeRe8ePgXK5QthOkhr0h0zknZ\n oglzmBsMqRrD0MoXcTGY8oUltaetQtNk+O0M0NpALQJLDvIjz/jAkv41i\n G9BPIBPvuv2IccBL8h1U3M93ASL4EmcZVd6SK1zM77aD1QMabdGfH2WRo\n CuNOpo008pn2mgFfQz0X/ihmZoZDn16m9qa4mQCvTx9idUrjpaP4wJUQq\n Zg3DYGAw0luhZIw2D/4/a5XOn7o1sm/r0eQ43nSRPzJDqH7XGBPqICPpk Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10736\"; a=\"360155115\"", "E=Sophos;i=\"6.00,230,1681196400\"; d=\"scan'208\";a=\"360155115\"", "E=McAfee;i=\"6600,9927,10736\"; a=\"957254692\"", "E=Sophos;i=\"6.00,230,1681196400\"; d=\"scan'208\";a=\"957254692\"" ], "X-ExtLoop1": "1", "From": "Zhirun Yan <zhirun.yan@intel.com>", "To": "dev@dpdk.org, jerinj@marvell.com, kirankumark@marvell.com,\n ndabilpuram@marvell.com, stephen@networkplumber.org,\n pbhagavatula@marvell.com, jerinjacobk@gmail.com, david.marchand@redhat.com", "Cc": "cunming.liang@intel.com, haiyue.wang@intel.com,\n mattias.ronnblom@ericsson.com, Zhirun Yan <zhirun.yan@intel.com>", "Subject": "[PATCH v12 12/16] graph: introduce graph walk by cross-core dispatch", "Date": "Sat, 10 Jun 2023 03:12:41 +0800", "Message-Id": "<20230609191245.252521-13-zhirun.yan@intel.com>", "X-Mailer": "git-send-email 2.37.2", "In-Reply-To": "<20230609191245.252521-1-zhirun.yan@intel.com>", "References": "<20230608151844.1823783-1-zhirun.yan@intel.com>\n <20230609191245.252521-1-zhirun.yan@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch introduces the task scheduler mechanism to enable dispatching\ntasks to another worker cores. Currently, there is only a local work\nqueue for one graph to walk. We introduce a scheduler worker queue in\neach worker core for dispatching tasks. It will perform the walk on\nscheduler work queue first, then handle the local work queue.\n\nSigned-off-by: Haiyue Wang <haiyue.wang@intel.com>\nSigned-off-by: Cunming Liang <cunming.liang@intel.com>\nSigned-off-by: Zhirun Yan <zhirun.yan@intel.com>\nAcked-by: Jerin Jacob <jerinj@marvell.com>\nAcked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>\n---\n lib/graph/rte_graph_model_mcore_dispatch.h | 44 ++++++++++++++++++++++\n 1 file changed, 44 insertions(+)", "diff": "diff --git a/lib/graph/rte_graph_model_mcore_dispatch.h b/lib/graph/rte_graph_model_mcore_dispatch.h\nindex 6163f96c37..c78a3bbdf9 100644\n--- a/lib/graph/rte_graph_model_mcore_dispatch.h\n+++ b/lib/graph/rte_graph_model_mcore_dispatch.h\n@@ -83,6 +83,50 @@ __rte_experimental\n int rte_graph_model_mcore_dispatch_node_lcore_affinity_set(const char *name,\n \t\t\t\t\t\t\t unsigned int lcore_id);\n \n+/**\n+ * Perform graph walk on the circular buffer and invoke the process function\n+ * of the nodes and collect the stats.\n+ *\n+ * @param graph\n+ * Graph pointer returned from rte_graph_lookup function.\n+ *\n+ * @see rte_graph_lookup()\n+ */\n+__rte_experimental\n+static inline void\n+rte_graph_walk_mcore_dispatch(struct rte_graph *graph)\n+{\n+\tconst rte_graph_off_t *cir_start = graph->cir_start;\n+\tconst rte_node_t mask = graph->cir_mask;\n+\tuint32_t head = graph->head;\n+\tstruct rte_node *node;\n+\n+\tRTE_ASSERT(graph->parent_id != RTE_GRAPH_ID_INVALID);\n+\tif (graph->dispatch.wq != NULL)\n+\t\t__rte_graph_mcore_dispatch_sched_wq_process(graph);\n+\n+\twhile (likely(head != graph->tail)) {\n+\t\tnode = (struct rte_node *)RTE_PTR_ADD(graph, cir_start[(int32_t)head++]);\n+\n+\t\t/* skip the src nodes which not bind with current worker */\n+\t\tif ((int32_t)head < 0 && node->dispatch.lcore_id != graph->dispatch.lcore_id)\n+\t\t\tcontinue;\n+\n+\t\t/* Schedule the node until all task/objs are done */\n+\t\tif (node->dispatch.lcore_id != RTE_MAX_LCORE &&\n+\t\t graph->dispatch.lcore_id != node->dispatch.lcore_id &&\n+\t\t graph->dispatch.rq != NULL &&\n+\t\t __rte_graph_mcore_dispatch_sched_node_enqueue(node, graph->dispatch.rq))\n+\t\t\tcontinue;\n+\n+\t\t__rte_node_process(graph, node);\n+\n+\t\thead = likely((int32_t)head > 0) ? head & mask : head;\n+\t}\n+\n+\tgraph->tail = 0;\n+}\n+\n #ifdef __cplusplus\n }\n #endif\n", "prefixes": [ "v12", "12/16" ] }