Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 128311,
    "url": "http://patches.dpdk.org/api/patches/128311/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230607130245.8048-23-ivan.malov@arknetworks.am/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20230607130245.8048-23-ivan.malov@arknetworks.am>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20230607130245.8048-23-ivan.malov@arknetworks.am",
    "date": "2023-06-07T13:02:33",
    "name": "[v4,22/34] common/sfc_efx/base: add API to read back MAE match criteria",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "1bfb2b1497635eff9e8eb83c1d243b9ac33da487",
    "submitter": {
        "id": 2962,
        "url": "http://patches.dpdk.org/api/people/2962/?format=api",
        "name": "Ivan Malov",
        "email": "ivan.malov@arknetworks.am"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230607130245.8048-23-ivan.malov@arknetworks.am/mbox/",
    "series": [
        {
            "id": 28390,
            "url": "http://patches.dpdk.org/api/series/28390/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28390",
            "date": "2023-06-07T13:02:11",
            "name": "net/sfc: support HW conntrack assistance",
            "version": 4,
            "mbox": "http://patches.dpdk.org/series/28390/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/128311/comments/",
    "check": "warning",
    "checks": "http://patches.dpdk.org/api/patches/128311/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 14C9042C4D;\n\tWed,  7 Jun 2023 15:06:07 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E7E9142F94;\n\tWed,  7 Jun 2023 15:03:14 +0200 (CEST)",
            "from agw.arknetworks.am (agw.arknetworks.am [79.141.165.80])\n by mails.dpdk.org (Postfix) with ESMTP id 610D0427F2\n for <dev@dpdk.org>; Wed,  7 Jun 2023 15:02:59 +0200 (CEST)",
            "from localhost.localdomain (unknown [78.109.69.83])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by agw.arknetworks.am (Postfix) with ESMTPSA id E107CE12C3;\n Wed,  7 Jun 2023 17:02:58 +0400 (+04)"
        ],
        "From": "Ivan Malov <ivan.malov@arknetworks.am>",
        "To": "dev@dpdk.org",
        "Cc": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Ferruh Yigit <ferruh.yigit@amd.com>, Andy Moreton <amoreton@xilinx.com>",
        "Subject": "[PATCH v4 22/34] common/sfc_efx/base: add API to read back MAE match\n criteria",
        "Date": "Wed,  7 Jun 2023 17:02:33 +0400",
        "Message-Id": "<20230607130245.8048-23-ivan.malov@arknetworks.am>",
        "X-Mailer": "git-send-email 2.30.2",
        "In-Reply-To": "<20230607130245.8048-1-ivan.malov@arknetworks.am>",
        "References": "<20230601195538.8265-1-ivan.malov@arknetworks.am>\n <20230607130245.8048-1-ivan.malov@arknetworks.am>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Later patches of the series provide support for HW conntrack\nassistance in the DPDK driver. In order to detect flows that\nare subject to such assistance, the driver needs to retrieve\n5-tuple match data from an already constructed specification.\n\nA dedicated API to selectively read back match criteria will\nmake a neat solution to keep the implementation less complex.\n\nSigned-off-by: Ivan Malov <ivan.malov@arknetworks.am>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/common/sfc_efx/base/efx.h     |  10 ++\n drivers/common/sfc_efx/base/efx_mae.c | 131 ++++++++++++++++++++++++++\n drivers/common/sfc_efx/version.map    |   1 +\n 3 files changed, 142 insertions(+)",
    "diff": "diff --git a/drivers/common/sfc_efx/base/efx.h b/drivers/common/sfc_efx/base/efx.h\nindex 97271f0f00..bc5117653f 100644\n--- a/drivers/common/sfc_efx/base/efx.h\n+++ b/drivers/common/sfc_efx/base/efx.h\n@@ -4430,6 +4430,16 @@ efx_mae_match_spec_field_set(\n \t__in\t\t\t\tsize_t mask_size,\n \t__in_bcount(mask_size)\t\tconst uint8_t *mask);\n \n+LIBEFX_API\n+extern\t__checkReturn\t\t\tefx_rc_t\n+efx_mae_match_spec_field_get(\n+\t__in\t\t\t\tconst efx_mae_match_spec_t *spec,\n+\t__in\t\t\t\tefx_mae_field_id_t field_id,\n+\t__in\t\t\t\tsize_t value_size,\n+\t__out_bcount_opt(value_size)\tuint8_t *value,\n+\t__in\t\t\t\tsize_t mask_size,\n+\t__out_bcount_opt(mask_size)\tuint8_t *mask);\n+\n /* The corresponding mask will be set to B_TRUE. */\n LIBEFX_API\n extern\t__checkReturn\t\t\tefx_rc_t\ndiff --git a/drivers/common/sfc_efx/base/efx_mae.c b/drivers/common/sfc_efx/base/efx_mae.c\nindex 43dfba518a..011f38d298 100644\n--- a/drivers/common/sfc_efx/base/efx_mae.c\n+++ b/drivers/common/sfc_efx/base/efx_mae.c\n@@ -1054,6 +1054,137 @@ efx_mae_match_spec_field_set(\n \n \treturn (0);\n \n+fail5:\n+\tEFSYS_PROBE(fail5);\n+fail4:\n+\tEFSYS_PROBE(fail4);\n+fail3:\n+\tEFSYS_PROBE(fail3);\n+fail2:\n+\tEFSYS_PROBE(fail2);\n+fail1:\n+\tEFSYS_PROBE1(fail1, efx_rc_t, rc);\n+\treturn (rc);\n+}\n+\n+\t__checkReturn\t\t\tefx_rc_t\n+efx_mae_match_spec_field_get(\n+\t__in\t\t\t\tconst efx_mae_match_spec_t *spec,\n+\t__in\t\t\t\tefx_mae_field_id_t field_id,\n+\t__in\t\t\t\tsize_t value_size,\n+\t__out_bcount_opt(value_size)\tuint8_t *value,\n+\t__in\t\t\t\tsize_t mask_size,\n+\t__out_bcount_opt(mask_size)\tuint8_t *mask)\n+{\n+\tconst efx_mae_mv_desc_t *descp;\n+\tunsigned int desc_set_nentries;\n+\tconst uint8_t *mvp;\n+\tefx_rc_t rc;\n+\n+\tswitch (spec->emms_type) {\n+\tcase EFX_MAE_RULE_OUTER:\n+\t\tdesc_set_nentries =\n+\t\t    EFX_ARRAY_SIZE(__efx_mae_outer_rule_mv_desc_set);\n+\t\tdescp = &__efx_mae_outer_rule_mv_desc_set[field_id];\n+\t\tmvp = spec->emms_mask_value_pairs.outer;\n+\t\tbreak;\n+\tcase EFX_MAE_RULE_ACTION:\n+\t\tdesc_set_nentries =\n+\t\t    EFX_ARRAY_SIZE(__efx_mae_action_rule_mv_desc_set);\n+\t\tdescp = &__efx_mae_action_rule_mv_desc_set[field_id];\n+\t\tmvp = spec->emms_mask_value_pairs.action;\n+\t\tbreak;\n+\tdefault:\n+\t\trc = ENOTSUP;\n+\t\tgoto fail1;\n+\t}\n+\n+\tif ((unsigned int)field_id >= desc_set_nentries) {\n+\t\trc = EINVAL;\n+\t\tgoto fail2;\n+\t}\n+\n+\tif (descp->emmd_mask_size == 0) {\n+\t\t/* The ID points to a gap in the array of field descriptors. */\n+\t\trc = EINVAL;\n+\t\tgoto fail3;\n+\t}\n+\n+\tif (value != NULL && value_size != descp->emmd_value_size) {\n+\t\trc = EINVAL;\n+\t\tgoto fail4;\n+\t}\n+\n+\tif (mask != NULL && mask_size != descp->emmd_mask_size) {\n+\t\trc = EINVAL;\n+\t\tgoto fail5;\n+\t}\n+\n+\tif (value == NULL && value_size != 0) {\n+\t\trc = EINVAL;\n+\t\tgoto fail6;\n+\t}\n+\n+\tif (mask == NULL && mask_size != 0) {\n+\t\trc = EINVAL;\n+\t\tgoto fail7;\n+\t}\n+\n+\tif (descp->emmd_endianness == EFX_MAE_FIELD_BE) {\n+\t\t/*\n+\t\t * The MCDI request field is in network (big endian) order.\n+\t\t * The mask/value are also big endian.\n+\t\t */\n+\t\tmemcpy(value, mvp + descp->emmd_value_offset, value_size);\n+\t\tmemcpy(mask, mvp + descp->emmd_mask_offset, mask_size);\n+\t} else {\n+\t\tefx_dword_t dword;\n+\n+\t\t/*\n+\t\t * The MCDI request field is little endian.\n+\t\t * The mask/value are in host byte order.\n+\t\t */\n+\t\tswitch (value_size) {\n+\t\tcase 4:\n+\t\t\tmemcpy(&dword, mvp + descp->emmd_value_offset,\n+\t\t\t    sizeof (dword));\n+\n+\t\t\t*(uint32_t *)value =\n+\t\t\t    EFX_DWORD_FIELD(dword, EFX_DWORD_0);\n+\t\t\tbreak;\n+\t\tcase 1:\n+\t\t\tmemcpy(value, mvp + descp->emmd_value_offset, 1);\n+\t\t\tbreak;\n+\t\tcase 0:\n+\t\t\tbreak;\n+\t\tdefault:\n+\t\t\tEFSYS_ASSERT(B_FALSE);\n+\t\t}\n+\n+\t\tswitch (mask_size) {\n+\t\tcase 4:\n+\t\t\tmemcpy(&dword, mvp + descp->emmd_mask_offset,\n+\t\t\t    sizeof (dword));\n+\n+\t\t\t*(uint32_t *)mask =\n+\t\t\t    EFX_DWORD_FIELD(dword, EFX_DWORD_0);\n+\t\t\tbreak;\n+\t\tcase 1:\n+\t\t\tmemcpy(mask, mvp + descp->emmd_mask_offset, 1);\n+\t\t\tbreak;\n+\t\tcase 0:\n+\t\t\tbreak;\n+\t\tdefault:\n+\t\t\tEFSYS_ASSERT(B_FALSE);\n+\t\t}\n+\t}\n+\n+\treturn (0);\n+\n+fail7:\n+\tEFSYS_PROBE(fail7);\n+fail6:\n+\tEFSYS_PROBE(fail6);\n fail5:\n \tEFSYS_PROBE(fail5);\n fail4:\ndiff --git a/drivers/common/sfc_efx/version.map b/drivers/common/sfc_efx/version.map\nindex 931d556e80..b1ca8e1215 100644\n--- a/drivers/common/sfc_efx/version.map\n+++ b/drivers/common/sfc_efx/version.map\n@@ -125,6 +125,7 @@ INTERNAL {\n \tefx_mae_mac_addr_free;\n \tefx_mae_match_spec_bit_set;\n \tefx_mae_match_spec_clone;\n+\tefx_mae_match_spec_field_get;\n \tefx_mae_match_spec_field_set;\n \tefx_mae_match_spec_fini;\n \tefx_mae_match_spec_init;\n",
    "prefixes": [
        "v4",
        "22/34"
    ]
}