Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/128215/?format=api
{ "id": 128215, "url": "http://patches.dpdk.org/api/patches/128215/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230606144746.708388-10-zhirun.yan@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230606144746.708388-10-zhirun.yan@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230606144746.708388-10-zhirun.yan@intel.com", "date": "2023-06-06T14:47:38", "name": "[v8,09/17] graph: add structure for stream moving between cores", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "614b9186a2bf1a14099f7b446fe44a609b9d28b3", "submitter": { "id": 1154, "url": "http://patches.dpdk.org/api/people/1154/?format=api", "name": "Yan, Zhirun", "email": "zhirun.yan@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230606144746.708388-10-zhirun.yan@intel.com/mbox/", "series": [ { "id": 28374, "url": "http://patches.dpdk.org/api/series/28374/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28374", "date": "2023-06-06T14:47:29", "name": "graph enhancement for multi-core dispatch", "version": 8, "mbox": "http://patches.dpdk.org/series/28374/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/128215/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/128215/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2772842C40;\n\tTue, 6 Jun 2023 16:55:43 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CF32542D4F;\n\tTue, 6 Jun 2023 16:55:23 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by mails.dpdk.org (Postfix) with ESMTP id D55BF40ED6\n for <dev@dpdk.org>; Tue, 6 Jun 2023 16:55:21 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 06 Jun 2023 07:55:10 -0700", "from dpdk-zhirun-lmm.sh.intel.com ([10.67.119.94])\n by fmsmga005.fm.intel.com with ESMTP; 06 Jun 2023 07:55:08 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1686063322; x=1717599322;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=RDGTOqIp59nln+TXHODTWAD7ZO8gdwrWyHlQiwA66OE=;\n b=eUiezQgdkGAODcXA4uvlLoYzWSn8hcq8IDKPQtdzn091iKqXnvyS2vpN\n Z4zBhsWjTctwnB5vUCYiew/P65NVmjysLwXf2qTr+KeUyu/tASf/6ytG4\n m9LZP8qsGuzg5ajUoOVO4zWni98cfV34Ok/XDOswO6KaEWEO+Xd4VFu8G\n mH1dQJCu2V39CjAk3A24I/yQ45PtTjPwwbyxCT6fpR6oe4SWETHVe6lbC\n EMF7kSgM6Lccfh43XzzXMrNGRYip6lknQNmclJ2BfgsXKb6U7O39W3uY5\n zeGBv7XIaXd3JaY8zof8EHeEorY3yw70zocem9NVVE5/a5oRTRWTr4XOp A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10733\"; a=\"356705372\"", "E=Sophos;i=\"6.00,221,1681196400\"; d=\"scan'208\";a=\"356705372\"", "E=McAfee;i=\"6600,9927,10733\"; a=\"1039222717\"", "E=Sophos;i=\"6.00,221,1681196400\"; d=\"scan'208\";a=\"1039222717\"" ], "X-ExtLoop1": "1", "From": "Zhirun Yan <zhirun.yan@intel.com>", "To": "dev@dpdk.org, jerinj@marvell.com, kirankumark@marvell.com,\n ndabilpuram@marvell.com, stephen@networkplumber.org,\n pbhagavatula@marvell.com, jerinjacobk@gmail.com", "Cc": "cunming.liang@intel.com, haiyue.wang@intel.com,\n mattias.ronnblom@ericsson.com, Zhirun Yan <zhirun.yan@intel.com>", "Subject": "[PATCH v8 09/17] graph: add structure for stream moving between cores", "Date": "Tue, 6 Jun 2023 22:47:38 +0800", "Message-Id": "<20230606144746.708388-10-zhirun.yan@intel.com>", "X-Mailer": "git-send-email 2.37.2", "In-Reply-To": "<20230606144746.708388-1-zhirun.yan@intel.com>", "References": "<20230605111923.3772260-1-zhirun.yan@intel.com>\n <20230606144746.708388-1-zhirun.yan@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add graph_mcore_dispatch_wq_node to hold graph scheduling workqueue\nnode.\n\nSigned-off-by: Haiyue Wang <haiyue.wang@intel.com>\nSigned-off-by: Cunming Liang <cunming.liang@intel.com>\nSigned-off-by: Zhirun Yan <zhirun.yan@intel.com>\n---\n lib/graph/graph.c | 2 ++\n lib/graph/graph_populate.c | 1 +\n lib/graph/graph_private.h | 12 ++++++++++++\n lib/graph/rte_graph_worker_common.h | 29 +++++++++++++++++++++++++++++\n 4 files changed, 44 insertions(+)", "diff": "diff --git a/lib/graph/graph.c b/lib/graph/graph.c\nindex 84e01d11d0..1fee835804 100644\n--- a/lib/graph/graph.c\n+++ b/lib/graph/graph.c\n@@ -289,6 +289,7 @@ rte_graph_model_mcore_dispatch_core_bind(rte_graph_t id, int lcore)\n \n \tRTE_ASSERT(graph->graph->model == RTE_GRAPH_MODEL_MCORE_DISPATCH);\n \tgraph->lcore_id = lcore;\n+\tgraph->graph->dispatch.lcore_id = graph->lcore_id;\n \tgraph->socket = rte_lcore_to_socket_id(lcore);\n \n \t/* check the availability of source node */\n@@ -312,6 +313,7 @@ rte_graph_model_mcore_dispatch_core_unbind(rte_graph_t id)\n \t\t\tbreak;\n \n \tgraph->lcore_id = RTE_MAX_LCORE;\n+\tgraph->graph->dispatch.lcore_id = RTE_MAX_LCORE;\n \n fail:\n \treturn;\ndiff --git a/lib/graph/graph_populate.c b/lib/graph/graph_populate.c\nindex 2c0844ce92..ed596a7711 100644\n--- a/lib/graph/graph_populate.c\n+++ b/lib/graph/graph_populate.c\n@@ -89,6 +89,7 @@ graph_nodes_populate(struct graph *_graph)\n \t\t}\n \t\tnode->id = graph_node->node->id;\n \t\tnode->parent_id = pid;\n+\t\tnode->dispatch.lcore_id = graph_node->node->lcore_id;\n \t\tnb_edges = graph_node->node->nb_edges;\n \t\tnode->nb_edges = nb_edges;\n \t\toff += sizeof(struct rte_node);\ndiff --git a/lib/graph/graph_private.h b/lib/graph/graph_private.h\nindex 354dc8ac0a..d84174b667 100644\n--- a/lib/graph/graph_private.h\n+++ b/lib/graph/graph_private.h\n@@ -64,6 +64,18 @@ struct node {\n \tchar next_nodes[][RTE_NODE_NAMESIZE]; /**< Names of next nodes. */\n };\n \n+/**\n+ * @internal\n+ *\n+ * Structure that holds the graph scheduling workqueue node stream.\n+ * Used for mcore dispatch model.\n+ */\n+struct graph_mcore_dispatch_wq_node {\n+\trte_graph_off_t node_off;\n+\tuint16_t nb_objs;\n+\tvoid *objs[RTE_GRAPH_BURST_SIZE];\n+} __rte_cache_aligned;\n+\n /**\n * @internal\n *\ndiff --git a/lib/graph/rte_graph_worker_common.h b/lib/graph/rte_graph_worker_common.h\nindex 5dba3c0edd..a9a72a6005 100644\n--- a/lib/graph/rte_graph_worker_common.h\n+++ b/lib/graph/rte_graph_worker_common.h\n@@ -36,12 +36,20 @@ extern \"C\" {\n #define RTE_GRAPH_MODEL_MCORE_DISPATCH 1\n /**< Dispatch model to support cross-core dispatching within core affinity. */\n \n+/**\n+ * @internal\n+ *\n+ * Singly-linked list head for graph schedule run-queue.\n+ */\n+SLIST_HEAD(rte_graph_rq_head, rte_graph);\n+\n /**\n * @internal\n *\n * Data structure to hold graph data.\n */\n struct rte_graph {\n+\t/* Fast path area. */\n \tuint32_t tail;\t\t /**< Tail of circular buffer. */\n \tuint32_t head;\t\t /**< Head of circular buffer. */\n \tuint32_t cir_mask;\t /**< Circular buffer wrap around mask. */\n@@ -49,6 +57,20 @@ struct rte_graph {\n \trte_graph_off_t *cir_start; /**< Pointer to circular buffer. */\n \trte_graph_off_t nodes_start; /**< Offset at which node memory starts. */\n \tuint32_t model;\t\t /**< graph model */\n+\tRTE_STD_C11\n+\tunion {\n+\t\t/* Fast schedule area for mcore dispatch model */\n+\t\tstruct {\n+\t\t\tstruct rte_graph_rq_head *rq __rte_cache_aligned; /* The run-queue */\n+\t\t\tstruct rte_graph_rq_head rq_head; /* The head for run-queue list */\n+\n+\t\t\tSLIST_ENTRY(rte_graph) rq_next; /* The next for run-queue list */\n+\t\t\tunsigned int lcore_id; /**< The graph running Lcore. */\n+\t\t\tstruct rte_ring *wq; /**< The work-queue for pending streams. */\n+\t\t\tstruct rte_mempool *mp; /**< The mempool for scheduling streams. */\n+\t\t} dispatch; /** Only used by dispatch model */\n+\t};\n+\t/* End of Fast path area.*/\n \trte_graph_t id;\t/**< Graph identifier. */\n \tint socket;\t/**< Socket ID where memory is allocated. */\n \tchar name[RTE_GRAPH_NAMESIZE];\t/**< Name of the graph. */\n@@ -81,6 +103,13 @@ struct rte_node {\n \t/** Original process function when pcap is enabled. */\n \trte_node_process_t original_process;\n \n+\tRTE_STD_C11\n+\tunion {\n+\t\t/* Fast schedule area for mcore dispatch model */\n+\t\tstruct {\n+\t\t\tunsigned int lcore_id; /**< Node running lcore. */\n+\t\t} dispatch;\n+\t};\n \t/* Fast path area */\n #define RTE_NODE_CTX_SZ 16\n \tuint8_t ctx[RTE_NODE_CTX_SZ] __rte_cache_aligned; /**< Node Context. */\n", "prefixes": [ "v8", "09/17" ] }