Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127906/?format=api
{ "id": 127906, "url": "http://patches.dpdk.org/api/patches/127906/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230601195538.8265-34-ivan.malov@arknetworks.am/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230601195538.8265-34-ivan.malov@arknetworks.am>", "list_archive_url": "https://inbox.dpdk.org/dev/20230601195538.8265-34-ivan.malov@arknetworks.am", "date": "2023-06-01T19:55:37", "name": "[33/34] common/sfc_efx/base: support conntrack assistance counters", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "dd824d3210415b84b339205de8dd11c9e5eed8c1", "submitter": { "id": 2962, "url": "http://patches.dpdk.org/api/people/2962/?format=api", "name": "Ivan Malov", "email": "ivan.malov@arknetworks.am" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230601195538.8265-34-ivan.malov@arknetworks.am/mbox/", "series": [ { "id": 28307, "url": "http://patches.dpdk.org/api/series/28307/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28307", "date": "2023-06-01T19:55:04", "name": "net/sfc: support HW conntrack assistance", "version": 1, "mbox": "http://patches.dpdk.org/series/28307/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/127906/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/127906/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1780242C07;\n\tThu, 1 Jun 2023 21:59:18 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3C36643020;\n\tThu, 1 Jun 2023 21:56:23 +0200 (CEST)", "from agw.arknetworks.am (agw.arknetworks.am [79.141.165.80])\n by mails.dpdk.org (Postfix) with ESMTP id 3DD1B42D17\n for <dev@dpdk.org>; Thu, 1 Jun 2023 21:55:59 +0200 (CEST)", "from localhost.localdomain (unknown [78.109.69.146])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by agw.arknetworks.am (Postfix) with ESMTPSA id C436DE1B92;\n Thu, 1 Jun 2023 23:55:58 +0400 (+04)" ], "From": "Ivan Malov <ivan.malov@arknetworks.am>", "To": "dev@dpdk.org", "Cc": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Ferruh Yigit <ferruh.yigit@amd.com>, Andy Moreton <amoreton@xilinx.com>", "Subject": "[PATCH 33/34] common/sfc_efx/base: support conntrack assistance\n counters", "Date": "Thu, 1 Jun 2023 23:55:37 +0400", "Message-Id": "<20230601195538.8265-34-ivan.malov@arknetworks.am>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20230601195538.8265-1-ivan.malov@arknetworks.am>", "References": "<20230601195538.8265-1-ivan.malov@arknetworks.am>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Counters that can be referenced by HW conntrack assistance\ntable work similar to those of the action rules. However,\ntheir IDs belong to a separate (CT-specific) namespace.\n\nThese are 1-bit saturating counters with no byte count.\n\nSigned-off-by: Ivan Malov <ivan.malov@arknetworks.am>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/common/sfc_efx/base/efx.h | 2 ++\n drivers/common/sfc_efx/base/efx_impl.h | 1 +\n drivers/common/sfc_efx/base/efx_mae.c | 35 +++++++++++++++++++++++---\n 3 files changed, 34 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/common/sfc_efx/base/efx.h b/drivers/common/sfc_efx/base/efx.h\nindex 10908d97ef..0534179381 100644\n--- a/drivers/common/sfc_efx/base/efx.h\n+++ b/drivers/common/sfc_efx/base/efx.h\n@@ -4195,6 +4195,7 @@ typedef struct efx_mae_limits_s {\n \t\tuint32_t\t\teml_max_n_counters;\n \t\tuint32_t\t\teml_max_n_action_counters;\n \t};\n+\tuint32_t\t\t\teml_max_n_conntrack_counters;\n } efx_mae_limits_t;\n \n LIBEFX_API\n@@ -4789,6 +4790,7 @@ efx_mae_action_set_fill_in_eh_id(\n */\n typedef enum efx_counter_type_e {\n \tEFX_COUNTER_TYPE_ACTION = 0,\n+\tEFX_COUNTER_TYPE_CONNTRACK,\n } efx_counter_type_t;\n \n typedef struct efx_counter_s {\ndiff --git a/drivers/common/sfc_efx/base/efx_impl.h b/drivers/common/sfc_efx/base/efx_impl.h\nindex 7e5701e801..09b1e95c59 100644\n--- a/drivers/common/sfc_efx/base/efx_impl.h\n+++ b/drivers/common/sfc_efx/base/efx_impl.h\n@@ -842,6 +842,7 @@ typedef struct efx_mae_s {\n \tefx_mae_field_cap_t\t\t*em_outer_rule_field_caps;\n \tsize_t\t\t\t\tem_outer_rule_field_caps_size;\n \tuint32_t\t\t\tem_max_n_action_counters;\n+\tuint32_t\t\t\tem_max_n_conntrack_counters;\n } efx_mae_t;\n \n #endif /* EFSYS_OPT_MAE */\ndiff --git a/drivers/common/sfc_efx/base/efx_mae.c b/drivers/common/sfc_efx/base/efx_mae.c\nindex eddba0e71c..9ff887e04b 100644\n--- a/drivers/common/sfc_efx/base/efx_mae.c\n+++ b/drivers/common/sfc_efx/base/efx_mae.c\n@@ -16,7 +16,7 @@ efx_mae_get_capabilities(\n \tefx_mcdi_req_t req;\n \tEFX_MCDI_DECLARE_BUF(payload,\n \t MC_CMD_MAE_GET_CAPS_IN_LEN,\n-\t MC_CMD_MAE_GET_CAPS_OUT_LEN);\n+\t MC_CMD_MAE_GET_CAPS_V2_OUT_LEN);\n \tstruct efx_mae_s *maep = enp->en_maep;\n \tefx_rc_t rc;\n \n@@ -24,7 +24,7 @@ efx_mae_get_capabilities(\n \treq.emr_in_buf = payload;\n \treq.emr_in_length = MC_CMD_MAE_GET_CAPS_IN_LEN;\n \treq.emr_out_buf = payload;\n-\treq.emr_out_length = MC_CMD_MAE_GET_CAPS_OUT_LEN;\n+\treq.emr_out_length = MC_CMD_MAE_GET_CAPS_V2_OUT_LEN;\n \n \tefx_mcdi_execute(enp, &req);\n \n@@ -70,6 +70,13 @@ efx_mae_get_capabilities(\n \tmaep->em_max_n_action_counters =\n \t MCDI_OUT_DWORD(req, MAE_GET_CAPS_OUT_AR_COUNTERS);\n \n+\tif (req.emr_out_length_used >= MC_CMD_MAE_GET_CAPS_V2_OUT_LEN) {\n+\t\tmaep->em_max_n_conntrack_counters =\n+\t\t MCDI_OUT_DWORD(req, MAE_GET_CAPS_V2_OUT_CT_COUNTERS);\n+\t} else {\n+\t\tmaep->em_max_n_conntrack_counters = 0;\n+\t}\n+\n \treturn (0);\n \n fail2:\n@@ -375,6 +382,7 @@ efx_mae_get_limits(\n \temlp->eml_encap_header_size_limit =\n \t MC_CMD_MAE_ENCAP_HEADER_ALLOC_IN_HDR_DATA_MAXNUM_MCDI2;\n \temlp->eml_max_n_action_counters = maep->em_max_n_action_counters;\n+\temlp->eml_max_n_conntrack_counters = maep->em_max_n_conntrack_counters;\n \n \treturn (0);\n \n@@ -3282,11 +3290,15 @@ efx_mae_counters_alloc_type(\n \tefx_rc_t rc;\n \n \tEFX_STATIC_ASSERT(EFX_COUNTER_TYPE_ACTION == MAE_COUNTER_TYPE_AR);\n+\tEFX_STATIC_ASSERT(EFX_COUNTER_TYPE_CONNTRACK == MAE_COUNTER_TYPE_CT);\n \n \tswitch (type) {\n \tcase EFX_COUNTER_TYPE_ACTION:\n \t\tmax_n_counters = maep->em_max_n_action_counters;\n \t\tbreak;\n+\tcase EFX_COUNTER_TYPE_CONNTRACK:\n+\t\tmax_n_counters = maep->em_max_n_conntrack_counters;\n+\t\tbreak;\n \tdefault:\n \t\trc = EINVAL;\n \t\tgoto fail1;\n@@ -3403,6 +3415,9 @@ efx_mae_counters_free_type(\n \tcase EFX_COUNTER_TYPE_ACTION:\n \t\tmax_n_counters = maep->em_max_n_action_counters;\n \t\tbreak;\n+\tcase EFX_COUNTER_TYPE_CONNTRACK:\n+\t\tmax_n_counters = maep->em_max_n_conntrack_counters;\n+\t\tbreak;\n \tdefault:\n \t\trc = EINVAL;\n \t\tgoto fail1;\n@@ -3505,8 +3520,11 @@ efx_mae_counters_stream_start(\n \t__out\t\t\t\tuint32_t *flags_out)\n {\n \tefx_mcdi_req_t req;\n-\tEFX_MCDI_DECLARE_BUF(payload, MC_CMD_MAE_COUNTERS_STREAM_START_IN_LEN,\n+\tEFX_MCDI_DECLARE_BUF(payload,\n+\t\t\t MC_CMD_MAE_COUNTERS_STREAM_START_V2_IN_LEN,\n \t\t\t MC_CMD_MAE_COUNTERS_STREAM_START_OUT_LEN);\n+\tstruct efx_mae_s *maep = enp->en_maep;\n+\tuint32_t counter_types;\n \tefx_rc_t rc;\n \n \tEFX_STATIC_ASSERT(EFX_MAE_COUNTERS_STREAM_IN_ZERO_SQUASH_DISABLE ==\n@@ -3517,7 +3535,7 @@ efx_mae_counters_stream_start(\n \n \treq.emr_cmd = MC_CMD_MAE_COUNTERS_STREAM_START;\n \treq.emr_in_buf = payload;\n-\treq.emr_in_length = MC_CMD_MAE_COUNTERS_STREAM_START_IN_LEN;\n+\treq.emr_in_length = MC_CMD_MAE_COUNTERS_STREAM_START_V2_IN_LEN;\n \treq.emr_out_buf = payload;\n \treq.emr_out_length = MC_CMD_MAE_COUNTERS_STREAM_START_OUT_LEN;\n \n@@ -3526,6 +3544,15 @@ efx_mae_counters_stream_start(\n \t\t\t packet_size);\n \tMCDI_IN_SET_DWORD(req, MAE_COUNTERS_STREAM_START_IN_FLAGS, flags_in);\n \n+\tcounter_types = (1U << MAE_COUNTER_TYPE_AR);\n+\n+\tif (maep->em_max_n_conntrack_counters != 0)\n+\t\tcounter_types |= (1U << MAE_COUNTER_TYPE_CT);\n+\n+\tMCDI_IN_SET_DWORD(req,\n+\t\t\t MAE_COUNTERS_STREAM_START_V2_IN_COUNTER_TYPES_MASK,\n+\t\t\t counter_types);\n+\n \tefx_mcdi_execute(enp, &req);\n \n \tif (req.emr_rc != 0) {\n", "prefixes": [ "33/34" ] }