Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127268/?format=api
{ "id": 127268, "url": "http://patches.dpdk.org/api/patches/127268/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230523213157.3905696-5-michaelba@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230523213157.3905696-5-michaelba@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230523213157.3905696-5-michaelba@nvidia.com", "date": "2023-05-23T21:31:56", "name": "[v5,4/5] ethdev: add GENEVE TLV option modification support", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "74560c6f925b863713040d8915ec2f7d6b7b7180", "submitter": { "id": 1949, "url": "http://patches.dpdk.org/api/people/1949/?format=api", "name": "Michael Baum", "email": "michaelba@nvidia.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230523213157.3905696-5-michaelba@nvidia.com/mbox/", "series": [ { "id": 28142, "url": "http://patches.dpdk.org/api/series/28142/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28142", "date": "2023-05-23T21:31:52", "name": "ethdev: modify field API for multiple headers", "version": 5, "mbox": "http://patches.dpdk.org/series/28142/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/127268/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/127268/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9004142B73;\n\tTue, 23 May 2023 23:32:51 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E472542D63;\n\tTue, 23 May 2023 23:32:31 +0200 (CEST)", "from NAM02-SN1-obe.outbound.protection.outlook.com\n (mail-sn1nam02on2056.outbound.protection.outlook.com [40.107.96.56])\n by mails.dpdk.org (Postfix) with ESMTP id 2379E42D61\n for <dev@dpdk.org>; Tue, 23 May 2023 23:32:30 +0200 (CEST)", "from MW4PR03CA0355.namprd03.prod.outlook.com (2603:10b6:303:dc::30)\n by SA1PR12MB7198.namprd12.prod.outlook.com (2603:10b6:806:2bf::21)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Tue, 23 May\n 2023 21:32:27 +0000", "from CO1NAM11FT046.eop-nam11.prod.protection.outlook.com\n (2603:10b6:303:dc:cafe::6c) by MW4PR03CA0355.outlook.office365.com\n (2603:10b6:303:dc::30) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.14 via Frontend\n Transport; Tue, 23 May 2023 21:32:27 +0000", "from mail.nvidia.com (216.228.117.161) by\n CO1NAM11FT046.mail.protection.outlook.com (10.13.174.203) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.6411.30 via Frontend Transport; Tue, 23 May 2023 21:32:27 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Tue, 23 May 2023\n 14:32:14 -0700", "from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Tue, 23 May\n 2023 14:32:14 -0700", "from nvidia.com (10.127.8.13) by mail.nvidia.com (10.129.68.7) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37 via Frontend\n Transport; Tue, 23 May 2023 14:32:12 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=Ngw6/bgyuZN6bHYjFGUUUx+BWVhD3zB+Npn2kdH0eye/x6XQ0O86uNybReTdloeLHnsxAUlrh2CU4RWmxXQhKPWJs/6T+DWIeUtFwQ5BkDT3ivt/hKU9oA4mdkZ32nR2o4znmWLoQxokQwgy6uDgzrfJwjgb8WmTksHaazrBIYFCIKxusojDJrPXw0a51m0KB4Wczx75hRocvkrtJ8Us92MddrDRf/gaESu9eF93rt+iQqzjm6vdQS+Pa7Xts2XiBZ069ZWmOUXxnjZ9nniz7qO/X3Dk7P5cAWFswk8p+f6oJd6gy5liKhIwoboc3OfCeTgB3FCgtTz5bh2JGxnygw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=9buUDCd18YyXtIhw72tFmB6J+3nRaPdUBWn7LzVSvHE=;\n b=K4AnLhaoLLNpZezzVw5Zs9HnffjxOmGvpgXY8Ar//VTPiJFCHyQHr9REXJBjsXAdGHh0EMLVlgDPt13Pi4mF4/Y4Y24EzWcui5sudSRZsV3o3jXe6KPevHzCY6r2+YkJUHe8YTyP5Pc/5EnyY1ldgAT63Efy2roTfCuIBY/AtnLRZQ28GsVNrVgW562nTqM/Qz3e05d8dyldRBD2f5vLdNn2/3XWcskXiABpLDZyxsmNGWoQXghO8SqehkNkeWEyOF6gYZmVmuRTBlWDyOB/IgDZ4D6bGBoJDpUh5o7Fv0B+Ca8rsozHYU3KnYAzflFiBwDQFc2hZY9h4IBP/PeYYw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=9buUDCd18YyXtIhw72tFmB6J+3nRaPdUBWn7LzVSvHE=;\n b=bm86t0Fj5XNC2Y+GakhJmnHeMQJLK7zgrRqH2Mgqm8cC3LExHRa+Fp4bZzUViKTlNZ7R4l9duMWOdhqsIhQFPoFdHoBpIEX5xhS5IjlI2bN6aS7XPyH8RfDTxNFV1rRNVNu36RjTZtvdoxmLlizg0zCscGMlvB9nCjuCkq6xb7o6UHs8lDWaoDQ8b+41ZTc9k9SpjHU8UOCWnslQ31VDUfcY3n4VaSkQdltFCF/AYfbTnlgu6nmYervvyoWw4y/WJcraS/d/Ux78DYmOIOMSrevJFp74Okl7s++YW9Phzc6+dafQkb2ZCOHnE6P1mrpH3gR524KH+1uUI58HsL2e6g==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.161)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.161 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C", "From": "Michael Baum <michaelba@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "Ori Kam <orika@nvidia.com>, Aman Singh <aman.deep.singh@intel.com>,\n \"Yuying Zhang\" <yuying.zhang@intel.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n \"Thomas Monjalon\" <thomas@monjalon.net>", "Subject": "[PATCH v5 4/5] ethdev: add GENEVE TLV option modification support", "Date": "Wed, 24 May 2023 00:31:56 +0300", "Message-ID": "<20230523213157.3905696-5-michaelba@nvidia.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230523213157.3905696-1-michaelba@nvidia.com>", "References": "<20230523124805.3846360-1-michaelba@nvidia.com>\n <20230523213157.3905696-1-michaelba@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CO1NAM11FT046:EE_|SA1PR12MB7198:EE_", "X-MS-Office365-Filtering-Correlation-Id": "62e47fae-72dc-4ebe-ed95-08db5bd534d3", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n YIpsB9yrJUlebtJh5OVpfKRvtjoa0UjuAlz8cPJj8KZ6ZEYxVCtU/PbuwlUd9rpzYcndEThkZlp1T1ZwyNlh3Xh6ZTCi3DOz387BKWUm4JKM1+qBlxu2JOJD6vlC5nosXOdgtZSCpq0hf7KfMw3yyaM+NEIM6roFx/duc8R/0h8AHg5ujdOn3UQtHyd05swDxjv+OEXXjtnpwWgJwcVMmke3IfAF8p1BxCzlqr3ioNAcH9MQIIGCWjPQ9Ab+9ai0473YeBVOMpKDwExl33nsbTVaIhljJ6dIHCq/AfspQc8i8JyZ8NWpHE+/kA78DPpTJEz26M3ac2xK2YJ0yJgNsb9Ai4afhnA0GeOUfjrObeo5QHOqT73sOqs1gLQ9VP8Nm2yPOc0P/wmbktWfuNX4NZf4a+PgBUB+MgOOjTRYShn1SFuRCAndxbksaxQ6J6sTCPt/edKe8PD9LqC7pWaNU0MvFli1+hTY6K2Mw9zJX5GcHrYzQt+v+caI/NusLh0daWLdkJrYB411VSWl382tgbrh21Cab2sg5HgLIEQz4inlOTcfbeaj/8ca313IninQl0bb2RGOG/RvcDig9usTMMb6kb2USV+4xAPopFUgKmPHnPr0FcfsQQUywRwUp49OXC7IrL7+rjg11c+a9J+HKlBGJpte2soBmFVfzbdD9pYBWBhgW0yMYJeCVl8xqQkeV15Qg9q7HJbV3FSpQuSc+nR6tuOVIV+EZrIg77gcIDbLCAIU43X6qZ9K3a8ZLPr9DwfWR/yV3YV3gDUFrS0icg==", "X-Forefront-Antispam-Report": "CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE;\n SFS:(13230028)(4636009)(39860400002)(396003)(136003)(376002)(346002)(451199021)(46966006)(36840700001)(40470700004)(478600001)(55016003)(40480700001)(26005)(1076003)(316002)(6666004)(54906003)(41300700001)(7696005)(70206006)(6916009)(4326008)(70586007)(5660300002)(40460700003)(82740400003)(36860700001)(83380400001)(47076005)(86362001)(7636003)(356005)(2616005)(426003)(336012)(2906002)(8676002)(36756003)(30864003)(8936002)(82310400005)(186003)(6286002)(21314003);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "23 May 2023 21:32:27.4429 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 62e47fae-72dc-4ebe-ed95-08db5bd534d3", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT046.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SA1PR12MB7198", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add modify field support for GENEVE option fields:\n - \"RTE_FLOW_FIELD_GENEVE_OPT_TYPE\"\n - \"RTE_FLOW_FIELD_GENEVE_OPT_CLASS\"\n - \"RTE_FLOW_FIELD_GENEVE_OPT_DATA\"\n\nEach GENEVE TLV option is identified by both its \"class\" and \"type\", so\n2 new fields were added to \"rte_flow_action_modify_data\" structure to\nhelp specify which option to modify.\n\nTo get room for those 2 new fields, the \"level\" field move to use\n\"uint8_t\" which is more than enough for encapsulation level.\nThis patch also reduces all modify field encapsulation level \"fully\nmasked\" initializations to use UINT8_MAX instead of UINT32_MAX.\nThis change avoids compilation warning caused by this API changing.\n\nSigned-off-by: Michael Baum <michaelba@nvidia.com>\nAcked-by: Ori Kam <orika@nvidia.com>\n---\n app/test-pmd/cmdline_flow.c | 48 +++++++++++++++++++++++++-\n doc/guides/prog_guide/rte_flow.rst | 23 ++++++++++++\n doc/guides/rel_notes/release_23_07.rst | 3 ++\n drivers/net/mlx5/mlx5_flow_hw.c | 22 ++++++------\n lib/ethdev/rte_flow.h | 48 +++++++++++++++++++++++++-\n 5 files changed, 131 insertions(+), 13 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c\nindex 58939ec321..8c1dea53c0 100644\n--- a/app/test-pmd/cmdline_flow.c\n+++ b/app/test-pmd/cmdline_flow.c\n@@ -636,11 +636,15 @@ enum index {\n \tACTION_MODIFY_FIELD_DST_TYPE_VALUE,\n \tACTION_MODIFY_FIELD_DST_LEVEL,\n \tACTION_MODIFY_FIELD_DST_LEVEL_VALUE,\n+\tACTION_MODIFY_FIELD_DST_TYPE_ID,\n+\tACTION_MODIFY_FIELD_DST_CLASS_ID,\n \tACTION_MODIFY_FIELD_DST_OFFSET,\n \tACTION_MODIFY_FIELD_SRC_TYPE,\n \tACTION_MODIFY_FIELD_SRC_TYPE_VALUE,\n \tACTION_MODIFY_FIELD_SRC_LEVEL,\n \tACTION_MODIFY_FIELD_SRC_LEVEL_VALUE,\n+\tACTION_MODIFY_FIELD_SRC_TYPE_ID,\n+\tACTION_MODIFY_FIELD_SRC_CLASS_ID,\n \tACTION_MODIFY_FIELD_SRC_OFFSET,\n \tACTION_MODIFY_FIELD_SRC_VALUE,\n \tACTION_MODIFY_FIELD_SRC_POINTER,\n@@ -854,7 +858,9 @@ static const char *const modify_field_ids[] = {\n \t\"ipv4_ecn\", \"ipv6_ecn\", \"gtp_psc_qfi\", \"meter_color\",\n \t\"ipv6_proto\",\n \t\"flex_item\",\n-\t\"hash_result\", NULL\n+\t\"hash_result\",\n+\t\"geneve_opt_type\", \"geneve_opt_class\", \"geneve_opt_data\",\n+\tNULL\n };\n \n static const char *const meter_colors[] = {\n@@ -2295,6 +2301,8 @@ static const enum index next_action_sample[] = {\n \n static const enum index action_modify_field_dst[] = {\n \tACTION_MODIFY_FIELD_DST_LEVEL,\n+\tACTION_MODIFY_FIELD_DST_TYPE_ID,\n+\tACTION_MODIFY_FIELD_DST_CLASS_ID,\n \tACTION_MODIFY_FIELD_DST_OFFSET,\n \tACTION_MODIFY_FIELD_SRC_TYPE,\n \tZERO,\n@@ -2302,6 +2310,8 @@ static const enum index action_modify_field_dst[] = {\n \n static const enum index action_modify_field_src[] = {\n \tACTION_MODIFY_FIELD_SRC_LEVEL,\n+\tACTION_MODIFY_FIELD_SRC_TYPE_ID,\n+\tACTION_MODIFY_FIELD_SRC_CLASS_ID,\n \tACTION_MODIFY_FIELD_SRC_OFFSET,\n \tACTION_MODIFY_FIELD_SRC_VALUE,\n \tACTION_MODIFY_FIELD_SRC_POINTER,\n@@ -6388,6 +6398,24 @@ static const struct token token_list[] = {\n \t\t.call = parse_vc_modify_field_level,\n \t\t.comp = comp_none,\n \t},\n+\t[ACTION_MODIFY_FIELD_DST_TYPE_ID] = {\n+\t\t.name = \"dst_type_id\",\n+\t\t.help = \"destination field type ID\",\n+\t\t.next = NEXT(action_modify_field_dst,\n+\t\t\t NEXT_ENTRY(COMMON_UNSIGNED)),\n+\t\t.args = ARGS(ARGS_ENTRY(struct rte_flow_action_modify_field,\n+\t\t\t\t\tdst.type)),\n+\t\t.call = parse_vc_conf,\n+\t},\n+\t[ACTION_MODIFY_FIELD_DST_CLASS_ID] = {\n+\t\t.name = \"dst_class\",\n+\t\t.help = \"destination field class ID\",\n+\t\t.next = NEXT(action_modify_field_dst,\n+\t\t\t NEXT_ENTRY(COMMON_UNSIGNED)),\n+\t\t.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_action_modify_field,\n+\t\t\t\t\t dst.class_id)),\n+\t\t.call = parse_vc_conf,\n+\t},\n \t[ACTION_MODIFY_FIELD_DST_OFFSET] = {\n \t\t.name = \"dst_offset\",\n \t\t.help = \"destination field bit offset\",\n@@ -6423,6 +6451,24 @@ static const struct token token_list[] = {\n \t\t.call = parse_vc_modify_field_level,\n \t\t.comp = comp_none,\n \t},\n+\t[ACTION_MODIFY_FIELD_SRC_TYPE_ID] = {\n+\t\t.name = \"src_type_id\",\n+\t\t.help = \"source field type ID\",\n+\t\t.next = NEXT(action_modify_field_src,\n+\t\t\t NEXT_ENTRY(COMMON_UNSIGNED)),\n+\t\t.args = ARGS(ARGS_ENTRY(struct rte_flow_action_modify_field,\n+\t\t\t\t\tsrc.type)),\n+\t\t.call = parse_vc_conf,\n+\t},\n+\t[ACTION_MODIFY_FIELD_SRC_CLASS_ID] = {\n+\t\t.name = \"src_class\",\n+\t\t.help = \"source field class ID\",\n+\t\t.next = NEXT(action_modify_field_src,\n+\t\t\t NEXT_ENTRY(COMMON_UNSIGNED)),\n+\t\t.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_action_modify_field,\n+\t\t\t\t\t src.class_id)),\n+\t\t.call = parse_vc_conf,\n+\t},\n \t[ACTION_MODIFY_FIELD_SRC_OFFSET] = {\n \t\t.name = \"src_offset\",\n \t\t.help = \"source field bit offset\",\ndiff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst\nindex 25b57bf86d..ec812de335 100644\n--- a/doc/guides/prog_guide/rte_flow.rst\n+++ b/doc/guides/prog_guide/rte_flow.rst\n@@ -2937,6 +2937,14 @@ as well as any tag element in the tag array:\n For the tag array (in case of multiple tags are supported and present)\n ``level`` translates directly into the array index.\n \n+``type`` is used to specify (along with ``class_id``) the Geneve option which\n+is being modified.\n+This field is relevant only for ``RTE_FLOW_FIELD_GENEVE_OPT_XXXX`` type.\n+\n+``class_id`` is used to specify (along with ``type``) the Geneve option which\n+is being modified.\n+This field is relevant only for ``RTE_FLOW_FIELD_GENEVE_OPT_XXXX`` type.\n+\n ``flex_handle`` is used to specify the flex item pointer which is being\n modified. ``flex_handle`` and ``level`` are mutually exclusive.\n \n@@ -2967,6 +2975,17 @@ to replace the third byte of MAC address with value 0x85, application should\n specify destination width as 8, destination offset as 16, and provide immediate\n value as sequence of bytes {xxx, xxx, 0x85, xxx, xxx, xxx}.\n \n+The ``RTE_FLOW_FIELD_GENEVE_OPT_DATA`` type supports modifying only one DW in\n+single action and align to 32 bits. For example, for modifying 16 bits start\n+from offset 24, 2 different actions should be prepared. The first one includs\n+``offset=24`` and ``width=8``, and the seconde one includs ``offset=32`` and\n+``width=8``.\n+Application should provide the data in immediate value memory only for the\n+single DW even though the offset is related to start of first DW. For example,\n+to replace the third byte of second DW in Geneve option data with value 0x85,\n+application should specify destination width as 8, destination offset as 48,\n+and provide immediate value 0xXXXX85XX.\n+\n .. _table_rte_flow_action_modify_field:\n \n .. table:: MODIFY_FIELD\n@@ -2994,6 +3013,10 @@ value as sequence of bytes {xxx, xxx, 0x85, xxx, xxx, xxx}.\n +-----------------+----------------------------------------------------------+\n | ``level`` | encapsulation level of a packet field or tag array index |\n +-----------------+----------------------------------------------------------+\n+ | ``type`` | geneve option type |\n+ +-----------------+----------------------------------------------------------+\n+ | ``class_id`` | geneve option class ID |\n+ +-----------------+----------------------------------------------------------+\n | ``flex_handle`` | flex item handle of a packet field |\n +-----------------+----------------------------------------------------------+\n | ``offset`` | number of bits to skip at the beginning |\ndiff --git a/doc/guides/rel_notes/release_23_07.rst b/doc/guides/rel_notes/release_23_07.rst\nindex a9b1293689..ce1755096f 100644\n--- a/doc/guides/rel_notes/release_23_07.rst\n+++ b/doc/guides/rel_notes/release_23_07.rst\n@@ -84,6 +84,9 @@ API Changes\n Also, make sure to start the actual text at the margin.\n =======================================================\n \n+* The ``level`` field in experimental structure\n+ ``struct rte_flow_action_modify_data`` was reduced to 8 bits.\n+\n \n ABI Changes\n -----------\ndiff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c\nindex 7e0ee8d883..1b68a19900 100644\n--- a/drivers/net/mlx5/mlx5_flow_hw.c\n+++ b/drivers/net/mlx5/mlx5_flow_hw.c\n@@ -3565,7 +3565,7 @@ flow_hw_validate_action_modify_field(const struct rte_flow_action *action,\n \t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION, action,\n \t\t\t\t\"immediate value, pointer and hash result cannot be used as destination\");\n-\tif (mask_conf->dst.level != UINT32_MAX)\n+\tif (mask_conf->dst.level != UINT8_MAX)\n \t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\tRTE_FLOW_ERROR_TYPE_ACTION, action,\n \t\t\t\"destination encapsulation level must be fully masked\");\n@@ -3579,7 +3579,7 @@ flow_hw_validate_action_modify_field(const struct rte_flow_action *action,\n \t\t\t\t\"destination field mask and template are not equal\");\n \tif (action_conf->src.field != RTE_FLOW_FIELD_POINTER &&\n \t action_conf->src.field != RTE_FLOW_FIELD_VALUE) {\n-\t\tif (mask_conf->src.level != UINT32_MAX)\n+\t\tif (mask_conf->src.level != UINT8_MAX)\n \t\t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION, action,\n \t\t\t\t\"source encapsulation level must be fully masked\");\n@@ -4450,7 +4450,7 @@ flow_hw_set_vlan_vid(struct rte_eth_dev *dev,\n \t\t.operation = RTE_FLOW_MODIFY_SET,\n \t\t.dst = {\n \t\t\t.field = RTE_FLOW_FIELD_VLAN_ID,\n-\t\t\t.level = 0xffffffff, .offset = 0xffffffff,\n+\t\t\t.level = 0xff, .offset = 0xffffffff,\n \t\t},\n \t\t.src = {\n \t\t\t.field = RTE_FLOW_FIELD_VALUE,\n@@ -4583,12 +4583,12 @@ flow_hw_actions_template_create(struct rte_eth_dev *dev,\n \t\t.operation = RTE_FLOW_MODIFY_SET,\n \t\t.dst = {\n \t\t\t.field = (enum rte_flow_field_id)MLX5_RTE_FLOW_FIELD_META_REG,\n-\t\t\t.level = UINT32_MAX,\n+\t\t\t.level = UINT8_MAX,\n \t\t\t.offset = UINT32_MAX,\n \t\t},\n \t\t.src = {\n \t\t\t.field = (enum rte_flow_field_id)MLX5_RTE_FLOW_FIELD_META_REG,\n-\t\t\t.level = UINT32_MAX,\n+\t\t\t.level = UINT8_MAX,\n \t\t\t.offset = UINT32_MAX,\n \t\t},\n \t\t.width = UINT32_MAX,\n@@ -5653,7 +5653,7 @@ flow_hw_create_tx_repr_tag_jump_acts_tmpl(struct rte_eth_dev *dev)\n \t\t.operation = RTE_FLOW_MODIFY_SET,\n \t\t.dst = {\n \t\t\t.field = (enum rte_flow_field_id)MLX5_RTE_FLOW_FIELD_META_REG,\n-\t\t\t.level = UINT32_MAX,\n+\t\t\t.level = UINT8_MAX,\n \t\t\t.offset = UINT32_MAX,\n \t\t},\n \t\t.src = {\n@@ -5677,12 +5677,12 @@ flow_hw_create_tx_repr_tag_jump_acts_tmpl(struct rte_eth_dev *dev)\n \t\t.operation = RTE_FLOW_MODIFY_SET,\n \t\t.dst = {\n \t\t\t.field = (enum rte_flow_field_id)MLX5_RTE_FLOW_FIELD_META_REG,\n-\t\t\t.level = UINT32_MAX,\n+\t\t\t.level = UINT8_MAX,\n \t\t\t.offset = UINT32_MAX,\n \t\t},\n \t\t.src = {\n \t\t\t.field = (enum rte_flow_field_id)MLX5_RTE_FLOW_FIELD_META_REG,\n-\t\t\t.level = UINT32_MAX,\n+\t\t\t.level = UINT8_MAX,\n \t\t\t.offset = UINT32_MAX,\n \t\t},\n \t\t.width = UINT32_MAX,\n@@ -6009,7 +6009,7 @@ flow_hw_create_ctrl_regc_jump_actions_template(struct rte_eth_dev *dev)\n \t\t.operation = RTE_FLOW_MODIFY_SET,\n \t\t.dst = {\n \t\t\t.field = (enum rte_flow_field_id)MLX5_RTE_FLOW_FIELD_META_REG,\n-\t\t\t.level = UINT32_MAX,\n+\t\t\t.level = UINT8_MAX,\n \t\t\t.offset = UINT32_MAX,\n \t\t},\n \t\t.src = {\n@@ -6182,12 +6182,12 @@ flow_hw_create_tx_default_mreg_copy_actions_template(struct rte_eth_dev *dev)\n \t\t.operation = RTE_FLOW_MODIFY_SET,\n \t\t.dst = {\n \t\t\t.field = (enum rte_flow_field_id)MLX5_RTE_FLOW_FIELD_META_REG,\n-\t\t\t.level = UINT32_MAX,\n+\t\t\t.level = UINT8_MAX,\n \t\t\t.offset = UINT32_MAX,\n \t\t},\n \t\t.src = {\n \t\t\t.field = (enum rte_flow_field_id)MLX5_RTE_FLOW_FIELD_META_REG,\n-\t\t\t.level = UINT32_MAX,\n+\t\t\t.level = UINT8_MAX,\n \t\t\t.offset = UINT32_MAX,\n \t\t},\n \t\t.width = UINT32_MAX,\ndiff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h\nindex 713ba8b65c..f30d4b033f 100644\n--- a/lib/ethdev/rte_flow.h\n+++ b/lib/ethdev/rte_flow.h\n@@ -3773,6 +3773,9 @@ enum rte_flow_field_id {\n \tRTE_FLOW_FIELD_IPV6_PROTO,\t/**< IPv6 next header. */\n \tRTE_FLOW_FIELD_FLEX_ITEM,\t/**< Flex item. */\n \tRTE_FLOW_FIELD_HASH_RESULT,\t/**< Hash result. */\n+\tRTE_FLOW_FIELD_GENEVE_OPT_TYPE,\t/**< GENEVE option type */\n+\tRTE_FLOW_FIELD_GENEVE_OPT_CLASS,/**< GENEVE option class */\n+\tRTE_FLOW_FIELD_GENEVE_OPT_DATA\t/**< GENEVE option data */\n };\n \n /**\n@@ -3788,7 +3791,50 @@ struct rte_flow_action_modify_data {\n \t\tstruct {\n \t\t\t/** Encapsulation level or tag index or flex item handle. */\n \t\t\tunion {\n-\t\t\t\tuint32_t level;\n+\t\t\t\tstruct {\n+\t\t\t\t\t/**\n+\t\t\t\t\t * Packet encapsulation level containing\n+\t\t\t\t\t * the field modify to.\n+\t\t\t\t\t *\n+\t\t\t\t\t * - @p 0 requests the default behavior.\n+\t\t\t\t\t * Depending on the packet type, it\n+\t\t\t\t\t * can mean outermost, innermost or\n+\t\t\t\t\t * anything in between.\n+\t\t\t\t\t *\n+\t\t\t\t\t * It basically stands for the\n+\t\t\t\t\t * innermost encapsulation level\n+\t\t\t\t\t * modification can be performed on\n+\t\t\t\t\t * according to PMD and device\n+\t\t\t\t\t * capabilities.\n+\t\t\t\t\t *\n+\t\t\t\t\t * - @p 1 requests modification to be\n+\t\t\t\t\t * performed on the outermost packet\n+\t\t\t\t\t * encapsulation level.\n+\t\t\t\t\t *\n+\t\t\t\t\t * - @p 2 and subsequent values request\n+\t\t\t\t\t * modification to be performed on\n+\t\t\t\t\t * the specified inner packet\n+\t\t\t\t\t * encapsulation level, from\n+\t\t\t\t\t * outermost to innermost (lower to\n+\t\t\t\t\t * higher values).\n+\t\t\t\t\t *\n+\t\t\t\t\t * Values other than @p 0 are not\n+\t\t\t\t\t * necessarily supported.\n+\t\t\t\t\t */\n+\t\t\t\t\tuint8_t level;\n+\t\t\t\t\t/**\n+\t\t\t\t\t * Geneve option type. relevant only\n+\t\t\t\t\t * for RTE_FLOW_FIELD_GENEVE_OPT_XXXX\n+\t\t\t\t\t * modification type.\n+\t\t\t\t\t */\n+\t\t\t\t\tuint8_t type;\n+\t\t\t\t\t/**\n+\t\t\t\t\t * Geneve option class. relevant only\n+\t\t\t\t\t * for RTE_FLOW_FIELD_GENEVE_OPT_XXXX\n+\t\t\t\t\t * modification type.\n+\t\t\t\t\t */\n+\t\t\t\t\trte_be16_t class_id;\n+\t\t\t\t};\n \t\t\t\tstruct rte_flow_item_flex_handle *flex_handle;\n \t\t\t};\n \t\t\t/** Number of bits to skip from a field. */\n", "prefixes": [ "v5", "4/5" ] }