Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 1269,
    "url": "http://patches.dpdk.org/api/patches/1269/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/546579A3.3010804@igel.co.jp/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<546579A3.3010804@igel.co.jp>",
    "list_archive_url": "https://inbox.dpdk.org/dev/546579A3.3010804@igel.co.jp",
    "date": "2014-11-14T03:40:19",
    "name": "[dpdk-dev] vhost-user technical isssues",
    "commit_ref": null,
    "pull_url": null,
    "state": "rejected",
    "archived": true,
    "hash": "e9a925db93240934f34de5058eb4b658713f41fe",
    "submitter": {
        "id": 64,
        "url": "http://patches.dpdk.org/api/people/64/?format=api",
        "name": "Tetsuya Mukawa",
        "email": "mukawa@igel.co.jp"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/546579A3.3010804@igel.co.jp/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/1269/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/1269/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 59D077F6C;\n\tFri, 14 Nov 2014 04:30:26 +0100 (CET)",
            "from mail-pa0-f53.google.com (mail-pa0-f53.google.com\n\t[209.85.220.53]) by dpdk.org (Postfix) with ESMTP id D56E77F29\n\tfor <dev@dpdk.org>; Fri, 14 Nov 2014 04:30:21 +0100 (CET)",
            "by mail-pa0-f53.google.com with SMTP id kx10so16670849pab.40\n\tfor <dev@dpdk.org>; Thu, 13 Nov 2014 19:40:22 -0800 (PST)",
            "from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132])\n\tby mx.google.com with ESMTPSA id\n\tyl6sm26004175pbc.91.2014.11.13.19.40.21 for <multiple recipients>\n\t(version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);\n\tThu, 13 Nov 2014 19:40:22 -0800 (PST)"
        ],
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:message-id:date:from:user-agent:mime-version:to\n\t:cc:subject:references:in-reply-to:content-type\n\t:content-transfer-encoding;\n\tbh=5hkRPvKPakoJorv0PqM1mA0U25uqy1n5RlwCjozpMZE=;\n\tb=eW0QIAe6mPc3keKlcRDu0veqg2JxgiahjlOtUnx2MBNLdHmD9vkEfzbLC7uN4vTfqd\n\th9V/PnSlIn/fh8M1mu7hK8eu3A1UCbGToXPJq2mMTdogHEVZISeeJ+c8xl3bsTYVbyzh\n\ttwjx6MEwCoArxWwGMQBzwn5vGTJ+q9o6X5P3ZaMKTpcXu9bt5bVkAkhO8hfekW7NmcYQ\n\t4NOHT598es8BSMBHiFUhb6atpDa68ZFHkofRFQioZyZuROd3qy+FrCk/WFQVZIFsXKDQ\n\tWysFTDftiW9ZX85OJS1iqOn38C87YqDladpb3aAfp2/zP4RrC1NA9qI95EgfePYP8dTe\n\tU+5w==",
        "X-Gm-Message-State": "ALoCoQlb2WFe1DG56/FM8p+x62xEeKYN89rWZguQkzCymCh1XI8vX9UUe0mL4pKlxJn7hiTUygT4",
        "X-Received": "by 10.67.1.39 with SMTP id bd7mr6976696pad.57.1415936422670;\n\tThu, 13 Nov 2014 19:40:22 -0800 (PST)",
        "Message-ID": "<546579A3.3010804@igel.co.jp>",
        "Date": "Fri, 14 Nov 2014 12:40:19 +0900",
        "From": "Tetsuya Mukawa <mukawa@igel.co.jp>",
        "User-Agent": "Mozilla/5.0 (Windows NT 6.1; WOW64;\n\trv:24.0) Gecko/20100101 Thunderbird/24.6.0",
        "MIME-Version": "1.0",
        "To": "Linhaifeng <haifeng.lin@huawei.com>, \"Xie, Huawei\" <huawei.xie@intel.com>",
        "References": "<C37D651A908B024F974696C65296B57B0F2F19EF@SHSMSX101.ccr.corp.intel.com>\n\t<5462DE39.1070006@igel.co.jp> <54645007.3010301@huawei.com>\n\t<54656950.1050204@igel.co.jp> <54657365.7090504@huawei.com>",
        "In-Reply-To": "<54657365.7090504@huawei.com>",
        "Content-Type": "text/plain; charset=ISO-2022-JP",
        "Content-Transfer-Encoding": "7bit",
        "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>",
        "Subject": "Re: [dpdk-dev] vhost-user technical isssues",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Hi Lin,\n\n(2014/11/14 12:13), Linhaifeng wrote:\n>\n> size should be same as mmap and\n> guest_mem -= (memory.regions[i].mmap_offset / sizeof(*guest_mem));\n>\n\nThanks. It should be.\nHow about following patch?\n\n-------------------------------------------------------\n#define QEMU_CMD_CHR \" -chardev socket,id=chr0,path=%s\"\n#define QEMU_CMD_NETDEV \" -netdev\nvhost-user,id=net0,chardev=chr0,vhostforce\"\n@@ -221,13 +221,16 @@ static void read_guest_mem(void)\n\n/* check for sanity */\ng_assert_cmpint(fds_num, >, 0);\n- g_assert_cmpint(fds_num, ==, memory.nregions);\n+ //g_assert_cmpint(fds_num, ==, memory.nregions);\n\n+ fprintf(stderr, \"%s(%d)\\n\", __func__, __LINE__);\n/* iterate all regions */\nfor (i = 0; i < fds_num; i++) {\n+ int ret = 0;\n\n/* We'll check only the region statring at 0x0*/\n- if (memory.regions[i].guest_phys_addr != 0x0) {\n+ if (memory.regions[i].guest_phys_addr == 0x0) {\n+ close(fds[i]);\ncontinue;\n}\n\n@@ -237,6 +240,7 @@ static void read_guest_mem(void)\n\nguest_mem = mmap(0, size, PROT_READ | PROT_WRITE,\nMAP_SHARED, fds[i], 0);\n+ fprintf(stderr, \"region=%d, mmap=%p, size=%lu\\n\", i, guest_mem, size);\n\ng_assert(guest_mem != MAP_FAILED);\nguest_mem += (memory.regions[i].mmap_offset / sizeof(*guest_mem));\n@@ -247,8 +251,10 @@ static void read_guest_mem(void)\n\ng_assert_cmpint(a, ==, b);\n}\n-\n- munmap(guest_mem, memory.regions[i].memory_size);\n+ guest_mem -= (memory.regions[i].mmap_offset / sizeof(*guest_mem));\n+ ret = munmap(guest_mem, memory.regions[i].memory_size);\n+ fprintf(stderr, \"region=%d, munmap=%p, size=%lu, ret=%d\\n\",\n+ i, guest_mem, size, ret);\n}\n\ng_assert_cmpint(1, ==, 1);\n-------------------------------------------------------\nI am using 1GB hugepage size.\n\n$ sudo QTEST_HUGETLBFS_PATH=/mnt/huge make check\nregion=0, mmap=0x2aaac0000000, size=6291456000\nregion=0, munmap=0x2aaac0000000, size=6291456000, ret=-1 << failed\n\n6291456000 is not aligned by 1GB.\nWhen I specify 4096MB as guest memory size, munmap() doesn't return\nerror like following.\n\n$ sudo QTEST_HUGETLBFS_PATH=/mnt/huge make check\nregion=0, mmap=0x2aaac0000000, size=4294967296\nregion=0, munmap=0x2aaac0000000, size=4294967296, ret=0\n\nThanks,\nTetsuya",
    "diff": "diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c\nindex 75fedf0..be4b171 100644\n--- a/tests/vhost-user-test.c\n+++ b/tests/vhost-user-test.c\n@@ -37,7 +37,7 @@\n#endif\n\n#define QEMU_CMD_ACCEL \" -machine accel=tcg\"\n-#define QEMU_CMD_MEM \" -m 512 -object\nmemory-backend-file,id=mem,size=512M,\"\\\n+#define QEMU_CMD_MEM \" -m 6000 -object\nmemory-backend-file,id=mem,size=6000M,\"\\\n\"mem-path=%s,share=on -numa node,memdev=mem\"\n",
    "prefixes": [
        "dpdk-dev"
    ]
}