Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126898/?format=api
{ "id": 126898, "url": "http://patches.dpdk.org/api/patches/126898/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230516152422.606617-7-ciara.power@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230516152422.606617-7-ciara.power@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230516152422.606617-7-ciara.power@intel.com", "date": "2023-05-16T15:24:20", "name": "[v2,6/8] crypto/ipsec_mb: optimize for GCM case", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a1f8eaf703dd5eb4d718f758322722eadacfe9fb", "submitter": { "id": 978, "url": "http://patches.dpdk.org/api/people/978/?format=api", "name": "Power, Ciara", "email": "ciara.power@intel.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230516152422.606617-7-ciara.power@intel.com/mbox/", "series": [ { "id": 28014, "url": "http://patches.dpdk.org/api/series/28014/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28014", "date": "2023-05-16T15:24:14", "name": "add AESNI_MB optimisations", "version": 2, "mbox": "http://patches.dpdk.org/series/28014/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/126898/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/126898/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AA36042B24;\n\tTue, 16 May 2023 17:25:07 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 980EF42D4E;\n\tTue, 16 May 2023 17:24:40 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id 7914F4114A\n for <dev@dpdk.org>; Tue, 16 May 2023 17:24:38 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 May 2023 08:24:37 -0700", "from silpixa00400355.ir.intel.com (HELO\n silpixa00400355.ger.corp.intel.com) ([10.237.222.80])\n by orsmga007.jf.intel.com with ESMTP; 16 May 2023 08:24:36 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1684250678; x=1715786678;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=TVkvwoNBoCgq6n9k66F5KOsrzOjom8I2G6X1R8BuvjI=;\n b=B/qERBfSnZmIg+jUtqoqLCYvNXPIQk2PZKa5xzUTHJe9Mz8dcCPlH2Ea\n xbhc7HvoaPqu6m9POttF0oB5s4A4vaCnQR+vg6rTghc+P+aDM9ETbL2fn\n 4sibzkJOp0/60CRayDqhT4o8nupAcuj4AEuxm8KaN8yc/Tm2NHu3/OEWY\n 83mAPEfMdXL5a1nQV547K5p3mNfPH1tyMbAbEqQO6IAWULiA0PwkJuy9O\n HnO6Z+822I+EifeHxdrlf4aTqx00h/HepvMKNjrDcOvxoKN4gCVng2ahf\n tWpq3b2XuFPCR5l3cyxfpaP2ZTilredrMhelN/6EGpiov8MHq+dFn0GmX A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10712\"; a=\"353789138\"", "E=Sophos;i=\"5.99,278,1677571200\"; d=\"scan'208\";a=\"353789138\"", "E=McAfee;i=\"6600,9927,10712\"; a=\"695500715\"", "E=Sophos;i=\"5.99,278,1677571200\"; d=\"scan'208\";a=\"695500715\"" ], "X-ExtLoop1": "1", "From": "Ciara Power <ciara.power@intel.com>", "To": "dev@dpdk.org", "Cc": "kai.ji@intel.com, gakhil@marvell.com,\n Pablo de Lara <pablo.de.lara.guarch@intel.com>,\n Ciara Power <ciara.power@intel.com>", "Subject": "[PATCH v2 6/8] crypto/ipsec_mb: optimize for GCM case", "Date": "Tue, 16 May 2023 15:24:20 +0000", "Message-Id": "<20230516152422.606617-7-ciara.power@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230516152422.606617-1-ciara.power@intel.com>", "References": "<20230421131221.1732314-1-ciara.power@intel.com>\n <20230516152422.606617-1-ciara.power@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n\nUse a separate code path when dealing with AES-GCM.\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\nSigned-off-by: Ciara Power <ciara.power@intel.com>\n---\n drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 88 +++++++++++++++++++++++---\n 1 file changed, 79 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c\nindex 80f59e75de..58faf3502c 100644\n--- a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c\n+++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c\n@@ -1366,6 +1366,70 @@ multi_sgl_job(IMB_JOB *job, struct rte_crypto_op *op,\n \t}\n \treturn 0;\n }\n+\n+static inline int\n+set_gcm_job(IMB_MGR *mb_mgr, IMB_JOB *job, const uint8_t sgl,\n+\tstruct aesni_mb_qp_data *qp_data,\n+\tstruct rte_crypto_op *op, uint8_t *digest_idx,\n+\tconst struct aesni_mb_session *session,\n+\tstruct rte_mbuf *m_src, struct rte_mbuf *m_dst,\n+\tconst int oop)\n+{\n+\tconst uint32_t m_offset = op->sym->aead.data.offset;\n+\n+\tjob->u.GCM.aad = op->sym->aead.aad.data;\n+\tif (sgl) {\n+\t\tjob->u.GCM.ctx = &qp_data->gcm_sgl_ctx;\n+\t\tjob->cipher_mode = IMB_CIPHER_GCM_SGL;\n+\t\tjob->hash_alg = IMB_AUTH_GCM_SGL;\n+\t\tjob->hash_start_src_offset_in_bytes = 0;\n+\t\tjob->msg_len_to_hash_in_bytes = 0;\n+\t\tjob->msg_len_to_cipher_in_bytes = 0;\n+\t\tjob->cipher_start_src_offset_in_bytes = 0;\n+\t} else {\n+\t\tjob->hash_start_src_offset_in_bytes =\n+\t\t\t\top->sym->aead.data.offset;\n+\t\tjob->msg_len_to_hash_in_bytes =\n+\t\t\t\top->sym->aead.data.length;\n+\t\tjob->cipher_start_src_offset_in_bytes =\n+\t\t\top->sym->aead.data.offset;\n+\t\tjob->msg_len_to_cipher_in_bytes = op->sym->aead.data.length;\n+\t}\n+\n+\tif (session->auth.operation == RTE_CRYPTO_AUTH_OP_VERIFY) {\n+\t\tjob->auth_tag_output = qp_data->temp_digests[*digest_idx];\n+\t\t*digest_idx = (*digest_idx + 1) % IMB_MAX_JOBS;\n+\t} else {\n+\t\tjob->auth_tag_output = op->sym->aead.digest.data;\n+\t}\n+\n+\tjob->iv = rte_crypto_op_ctod_offset(op, uint8_t *,\n+\t\t\tsession->iv.offset);\n+\n+\t/* Set user data to be crypto operation data struct */\n+\tjob->user_data = op;\n+\n+\tif (sgl) {\n+\t\tjob->src = NULL;\n+\t\tjob->dst = NULL;\n+\n+#if IMB_VERSION(1, 2, 0) < IMB_VERSION_NUM\n+\t\tif (m_src->nb_segs <= MAX_NUM_SEGS)\n+\t\t\treturn single_sgl_job(job, op, oop,\n+\t\t\t\t\tm_offset, m_src, m_dst,\n+\t\t\t\t\tqp_data->sgl_segs);\n+\t\telse\n+#endif\n+\t\t\treturn multi_sgl_job(job, op, oop,\n+\t\t\t\t\tm_offset, m_src, m_dst, mb_mgr);\n+\t} else {\n+\t\tjob->src = rte_pktmbuf_mtod(m_src, uint8_t *);\n+\t\tjob->dst = rte_pktmbuf_mtod_offset(m_dst, uint8_t *, m_offset);\n+\t}\n+\n+\treturn 0;\n+}\n+\n /**\n * Process a crypto operation and complete a IMB_JOB job structure for\n * submission to the multi buffer library for processing.\n@@ -1403,10 +1467,10 @@ set_mb_job_params(IMB_JOB *job, struct ipsec_mb_qp *qp,\n \t\treturn -1;\n \t}\n \n-\tmemcpy(job, &session->template_job, sizeof(IMB_JOB));\n+\tconst IMB_CIPHER_MODE cipher_mode =\n+\t\t\tsession->template_job.cipher_mode;\n \n-\t/* Set authentication parameters */\n-\tconst int aead = is_aead_algo(job->hash_alg, job->cipher_mode);\n+\tmemcpy(job, &session->template_job, sizeof(IMB_JOB));\n \n \tif (!op->sym->m_dst) {\n \t\t/* in-place operation */\n@@ -1424,10 +1488,17 @@ set_mb_job_params(IMB_JOB *job, struct ipsec_mb_qp *qp,\n \n \tif (m_src->nb_segs > 1 || m_dst->nb_segs > 1) {\n \t\tsgl = 1;\n-\t\tif (!imb_lib_support_sgl_algo(job->cipher_mode))\n+\t\tif (!imb_lib_support_sgl_algo(cipher_mode))\n \t\t\tlb_sgl = 1;\n \t}\n \n+\tif (cipher_mode == IMB_CIPHER_GCM)\n+\t\treturn set_gcm_job(mb_mgr, job, sgl, qp_data,\n+\t\t\t\top, digest_idx, session, m_src, m_dst, oop);\n+\n+\t/* Set authentication parameters */\n+\tconst int aead = is_aead_algo(job->hash_alg, cipher_mode);\n+\n \tswitch (job->hash_alg) {\n \tcase IMB_AUTH_AES_CCM:\n \t\tjob->u.CCM.aad = op->sym->aead.aad.data + 18;\n@@ -1474,13 +1545,12 @@ set_mb_job_params(IMB_JOB *job, struct ipsec_mb_qp *qp,\n \telse\n \t\tm_offset = op->sym->cipher.data.offset;\n \n-\tif (job->cipher_mode == IMB_CIPHER_ZUC_EEA3) {\n+\tif (cipher_mode == IMB_CIPHER_ZUC_EEA3)\n \t\tm_offset >>= 3;\n-\t} else if (job->cipher_mode == IMB_CIPHER_SNOW3G_UEA2_BITLEN) {\n+\telse if (cipher_mode == IMB_CIPHER_SNOW3G_UEA2_BITLEN)\n \t\tm_offset = 0;\n-\t} else if (job->cipher_mode == IMB_CIPHER_KASUMI_UEA1_BITLEN) {\n+\telse if (cipher_mode == IMB_CIPHER_KASUMI_UEA1_BITLEN)\n \t\tm_offset = 0;\n-\t}\n \n \t/* Set digest output location */\n \tif (job->hash_alg != IMB_AUTH_NULL &&\n@@ -1642,7 +1712,7 @@ set_mb_job_params(IMB_JOB *job, struct ipsec_mb_qp *qp,\n \t\tjob->msg_len_to_cipher_in_bytes = op->sym->cipher.data.length;\n \t}\n \n-\tif (job->cipher_mode == IMB_CIPHER_NULL && oop) {\n+\tif (cipher_mode == IMB_CIPHER_NULL && oop) {\n \t\tmemcpy(job->dst + job->cipher_start_src_offset_in_bytes,\n \t\t\tjob->src + job->cipher_start_src_offset_in_bytes,\n \t\t\tjob->msg_len_to_cipher_in_bytes);\n", "prefixes": [ "v2", "6/8" ] }