Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126031/?format=api
{ "id": 126031, "url": "http://patches.dpdk.org/api/patches/126031/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230413132704.17586-5-nipun.gupta@amd.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230413132704.17586-5-nipun.gupta@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230413132704.17586-5-nipun.gupta@amd.com", "date": "2023-04-13T13:27:02", "name": "[v2,4/6] bus/cdx: support plug unplug and dev iterator", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fe272761260413ef5a3a10353e5db26a55894190", "submitter": { "id": 2928, "url": "http://patches.dpdk.org/api/people/2928/?format=api", "name": "Gupta, Nipun", "email": "nipun.gupta@amd.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230413132704.17586-5-nipun.gupta@amd.com/mbox/", "series": [ { "id": 27696, "url": "http://patches.dpdk.org/api/series/27696/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27696", "date": "2023-04-13T13:27:01", "name": "add support for CDX bus", "version": 2, "mbox": "http://patches.dpdk.org/series/27696/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/126031/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/126031/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8E73F42933;\n\tThu, 13 Apr 2023 15:28:13 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EE6C442B8E;\n\tThu, 13 Apr 2023 15:27:56 +0200 (CEST)", "from NAM11-CO1-obe.outbound.protection.outlook.com\n (mail-co1nam11on2087.outbound.protection.outlook.com [40.107.220.87])\n by mails.dpdk.org (Postfix) with ESMTP id 9D861427EE\n for <dev@dpdk.org>; Thu, 13 Apr 2023 15:27:52 +0200 (CEST)", "from BN8PR04CA0056.namprd04.prod.outlook.com (2603:10b6:408:d4::30)\n by IA1PR12MB6387.namprd12.prod.outlook.com (2603:10b6:208:389::7)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.35; Thu, 13 Apr\n 2023 13:27:50 +0000", "from BN8NAM11FT071.eop-nam11.prod.protection.outlook.com\n (2603:10b6:408:d4:cafe::3a) by BN8PR04CA0056.outlook.office365.com\n (2603:10b6:408:d4::30) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.40 via Frontend\n Transport; Thu, 13 Apr 2023 13:27:50 +0000", "from SATLEXMB03.amd.com (165.204.84.17) by\n BN8NAM11FT071.mail.protection.outlook.com (10.13.177.92) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 13:27:50 +0000", "from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com\n (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr\n 2023 08:27:49 -0500", "from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com\n (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr\n 2023 06:27:49 -0700", "from xhdipdslab41.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com\n (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via\n Frontend Transport; Thu, 13 Apr 2023 08:27:46 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=YMpObqWTBtkPDagRGmNFj3PI5tvsymO35UR1NefvybvcCH5o0w+8ZqypvvObjGTtE/YTtrawHE+CCIRm12Ui5wipWZuVKCymP9Yd/4aDcLr/S97LItjyFcp7Mm6JUh4P9xhmhRdfvk9bp2CSEPakcjJQEyRUkpXCBPom8RqqG/4bSh/85CKiucp5/Omd0jpiXc1Q7sp95uMXe7fEFhnvmnv0ppte4QpYb8CkLwJABBMK1/NAclBvFCq9WhMSeufxR+ui9QqU5TqcFU5Szc7YAvYbY+ClZapPxmmspTtBxpNKwOoBCc7aWcaSUUZ7FZC3YhQODx5MQvu49IzdQThUTg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=8Fa2szLpIv5GizHbGSFyJlpq+ARV9q5QrwoYNSxfBjs=;\n b=myiZS6+0CL+PS3qlrWD77SUpwVDzSpd8bfUFznzzcN5HeWRn006JP6RgzbQLcBIek2dPR1UDl0/fJwTUgci2UFc7f4Cbijc9cCp36vjr1L0t8wIinlmW+Y3zwU5P59ObNtg6BBtK/Fz2uGavjY2gpo3/N+Uonw6gofL3X9oQ+Ha9nH4IJdYxZ94I+1JjCGe3CnqBJ0WNFMAI0jAGejR5uXsCFlUfLaDSi6Df7o7LYRBWMGIuDQDV4L5qLaiObLxzvc2D/vCPLkU+IDohao/pDDtZU3QW4NAD9jezv9pnyP3jkcdVb6KUeXpdqglbdOTyagWieFSdbPCWMDnw7pCrAQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=8Fa2szLpIv5GizHbGSFyJlpq+ARV9q5QrwoYNSxfBjs=;\n b=jbL/oxyCxJ0DR46Ti+LfyShKVns3aCdTN9HGPu2kb1bewHuy64bfF393OHY3GeZ9wNiknRk89E/i3fJ4L3Q/JssNvJsO7yQxQ064R/cYIFDCJ0LwXF77gJ3ZJMTrSlH4lLU7PUH8GyVog8XmY8qpouveVg2GxE70fjPo7CR+t3A=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C", "From": "Nipun Gupta <nipun.gupta@amd.com>", "To": "<dev@dpdk.org>, <thomas@monjalon.net>, <david.marchand@redhat.com>", "CC": "<ferruh.yigit@amd.com>, <harpreet.anand@amd.com>,\n <nikhil.agarwal@amd.com>, Nipun Gupta <nipun.gupta@amd.com>", "Subject": "[PATCH v2 4/6] bus/cdx: support plug unplug and dev iterator", "Date": "Thu, 13 Apr 2023 18:57:02 +0530", "Message-ID": "<20230413132704.17586-5-nipun.gupta@amd.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20230413132704.17586-1-nipun.gupta@amd.com>", "References": "<20230124140746.594066-1-nipun.gupta@amd.com>\n <20230413132704.17586-1-nipun.gupta@amd.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "BN8NAM11FT071:EE_|IA1PR12MB6387:EE_", "X-MS-Office365-Filtering-Correlation-Id": "10315c29-4dc4-4531-e19d-08db3c22e0cc", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n m2/yrhdGrDNbFFcYexcosKjkR+DMhVT4LNGOpcuqJx1JsXeAnttf6lZV0Bfz8t3u5/SpgfK50UZcJ/ShxMOmttszrkInFNqASNzvUOIBcP2C0wJlpB+6MWP0Kqh8qAK6n5rDqbn+IQTHw9HRnbgq/l/Hq5ifrqFtHrXY2e/+R73rIoZCmoSnh4XBCWUHQE86tNXv5en4WbvUXSiMJHuTXnRB5l7u24bWTlne9bv64cpy3hLwiIAFdlvO7z7oQbrxC5s7PJ1kQ1cc5uzQh92K0iKar1qSTlMZEQ4QLe8dS/eZt0BYhHWZas2eQpT1GjyQ5wkWY3/QYmbPsdXVh8mg4pmbJI7PL9XGaU6oBZnXxD4d1BeHXkU12bm40Ska2RkZn+kaoKym7Z2TfT+W7ybgVy09Ry0D4rW74U7aMP3x4s5TPAhTgyXwsR0eq9pXWItM0wKA1DrHSDfyv5wgsTp8FvojAn+FDvquQ5xVv5A0C7acmlo/+fNun+LNE7eJGTPq7WwbG5R6NeCvHK4dxFqKxsXT72sArnYQmk0cMhTJZu0gt5QzhMAGZVJt3kzUdt/HfeeSONG+qcd8mipBS5d8HQ6EfmKlxcDKUtfmSI0yudA34Up+jMFYTYJYCG2eNBAJ95BrE5rHJ6Rk3nSNB3QuZn5rLEdl0A0GstgdzQpKE9pZJwB7nBjagA8AigKgmRQ2L8Tp/zWemIF+Z5EbktWZ15nZ7zZjD9ZrLb7V71GutI0=", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB03.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230028)(4636009)(396003)(376002)(136003)(346002)(39860400002)(451199021)(40470700004)(36840700001)(46966006)(6666004)(478600001)(40460700003)(47076005)(336012)(36756003)(82740400003)(81166007)(356005)(36860700001)(2616005)(86362001)(426003)(2906002)(40480700001)(44832011)(316002)(26005)(5660300002)(1076003)(110136005)(186003)(8676002)(82310400005)(41300700001)(4326008)(8936002)(70586007)(54906003)(70206006)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "13 Apr 2023 13:27:50.0510 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 10315c29-4dc4-4531-e19d-08db3c22e0cc", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB03.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BN8NAM11FT071.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "IA1PR12MB6387", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This change adds support for plugging and unplugging\nCDX devices on the CDX bus. Also, CDX dev iterator support\nhas been added for the CDX bus.\n\nSigned-off-by: Nipun Gupta <nipun.gupta@amd.com>\n---\n drivers/bus/cdx/bus_cdx_driver.h | 1 +\n drivers/bus/cdx/cdx.c | 122 +++++++++++++++++++++++++++++++\n 2 files changed, 123 insertions(+)", "diff": "diff --git a/drivers/bus/cdx/bus_cdx_driver.h b/drivers/bus/cdx/bus_cdx_driver.h\nindex fdeaf46664..3d89e7c054 100644\n--- a/drivers/bus/cdx/bus_cdx_driver.h\n+++ b/drivers/bus/cdx/bus_cdx_driver.h\n@@ -69,6 +69,7 @@ struct rte_cdx_id {\n struct rte_cdx_device {\n \tRTE_TAILQ_ENTRY(rte_cdx_device) next;\t/**< Next probed CDX device. */\n \tstruct rte_device device;\t\t/**< Inherit core device */\n+\tstruct rte_cdx_driver *driver;\t\t/**< CDX driver used in probing */\n \tstruct rte_cdx_id id;\t\t\t/**< CDX ID. */\n \tstruct rte_mem_resource mem_resource[CDX_MAX_RESOURCE];\n \t\t\t\t\t\t/**< CDX Memory Resource */\ndiff --git a/drivers/bus/cdx/cdx.c b/drivers/bus/cdx/cdx.c\nindex f34736a54a..e69ee503aa 100644\n--- a/drivers/bus/cdx/cdx.c\n+++ b/drivers/bus/cdx/cdx.c\n@@ -68,6 +68,7 @@\n #include <rte_eal_paging.h>\n #include <rte_errno.h>\n #include <rte_devargs.h>\n+#include <rte_kvargs.h>\n #include <rte_malloc.h>\n #include <rte_memcpy.h>\n #include <rte_vfio.h>\n@@ -82,6 +83,15 @@\n #define CDX_BUS_NAME\tcdx\n #define CDX_DEV_PREFIX\t\"cdx-\"\n \n+enum cdx_params {\n+\tRTE_CDX_PARAM_NAME,\n+};\n+\n+static const char * const cdx_params_keys[] = {\n+\t[RTE_CDX_PARAM_NAME] = \"name\",\n+\tNULL,\n+};\n+\n /**\n * @file\n * CDX probing using Linux sysfs.\n@@ -400,6 +410,7 @@ cdx_probe_one_driver(struct rte_cdx_driver *dr,\n \t} else {\n \t\tdev->device.driver = &dr->driver;\n \t}\n+\tdev->driver = dr;\n \n \treturn ret;\n \n@@ -517,6 +528,71 @@ cdx_find_device(const struct rte_device *start, rte_dev_cmp_t cmp,\n \treturn NULL;\n }\n \n+/* Remove a device from CDX bus */\n+static void\n+cdx_remove_device(struct rte_cdx_device *cdx_dev)\n+{\n+\tTAILQ_REMOVE(&rte_cdx_bus.device_list, cdx_dev, next);\n+}\n+\n+/*\n+ * If vendor/device ID match, call the remove() function of the\n+ * driver.\n+ */\n+static int\n+cdx_detach_dev(struct rte_cdx_device *dev)\n+{\n+\tstruct rte_cdx_driver *dr;\n+\tint ret = 0;\n+\n+\tif (dev == NULL)\n+\t\treturn -EINVAL;\n+\n+\tdr = dev->driver;\n+\n+\tCDX_BUS_DEBUG(\"detach device %s using driver: %s\",\n+\t\tdev->device.name, dr->driver.name);\n+\n+\tif (dr->remove) {\n+\t\tret = dr->remove(dev);\n+\t\tif (ret < 0)\n+\t\t\treturn ret;\n+\t}\n+\n+\t/* clear driver structure */\n+\tdev->driver = NULL;\n+\tdev->device.driver = NULL;\n+\n+\trte_cdx_unmap_device(dev);\n+\n+\trte_intr_instance_free(dev->intr_handle);\n+\tdev->intr_handle = NULL;\n+\n+\treturn 0;\n+}\n+\n+static int\n+cdx_plug(struct rte_device *dev)\n+{\n+\treturn cdx_probe_all_drivers(RTE_DEV_TO_CDX_DEV(dev));\n+}\n+\n+static int\n+cdx_unplug(struct rte_device *dev)\n+{\n+\tstruct rte_cdx_device *cdx_dev;\n+\tint ret;\n+\n+\tcdx_dev = RTE_DEV_TO_CDX_DEV(dev);\n+\tret = cdx_detach_dev(cdx_dev);\n+\tif (ret == 0) {\n+\t\tcdx_remove_device(cdx_dev);\n+\t\trte_devargs_remove(dev->devargs);\n+\t\tfree(cdx_dev);\n+\t}\n+\treturn ret;\n+}\n+\n static int\n cdx_dma_map(struct rte_device *dev, void *addr, uint64_t iova, size_t len)\n {\n@@ -554,15 +630,61 @@ cdx_get_iommu_class(void)\n \treturn RTE_IOVA_VA;\n }\n \n+static int\n+cdx_dev_match(const struct rte_device *dev,\n+\t\tconst void *_kvlist)\n+{\n+\tconst struct rte_kvargs *kvlist = _kvlist;\n+\tconst char *key = cdx_params_keys[RTE_CDX_PARAM_NAME];\n+\tconst char *name;\n+\n+\t/* no kvlist arg, all devices match */\n+\tif (kvlist == NULL)\n+\t\treturn 0;\n+\n+\t/* if key is present in kvlist and does not match, filter device */\n+\tname = rte_kvargs_get(kvlist, key);\n+\tif (name != NULL && strcmp(name, dev->name))\n+\t\treturn -1;\n+\n+\treturn 0;\n+}\n+\n+static void *\n+cdx_dev_iterate(const void *start,\n+\t\tconst char *str,\n+\t\tconst struct rte_dev_iterator *it __rte_unused)\n+{\n+\trte_bus_find_device_t find_device;\n+\tstruct rte_kvargs *kvargs = NULL;\n+\tstruct rte_device *dev;\n+\n+\tif (str != NULL) {\n+\t\tkvargs = rte_kvargs_parse(str, cdx_params_keys);\n+\t\tif (kvargs == NULL) {\n+\t\t\tCDX_BUS_ERR(\"cannot parse argument list %s\", str);\n+\t\t\trte_errno = EINVAL;\n+\t\t\treturn NULL;\n+\t\t}\n+\t}\n+\tfind_device = rte_cdx_bus.bus.find_device;\n+\tdev = find_device(start, cdx_dev_match, kvargs);\n+\trte_kvargs_free(kvargs);\n+\treturn dev;\n+}\n+\n struct rte_cdx_bus rte_cdx_bus = {\n \t.bus = {\n \t\t.scan = cdx_scan,\n \t\t.probe = cdx_probe,\n \t\t.find_device = cdx_find_device,\n+\t\t.plug = cdx_plug,\n+\t\t.unplug = cdx_unplug,\n \t\t.parse = cdx_parse,\n \t\t.dma_map = cdx_dma_map,\n \t\t.dma_unmap = cdx_dma_unmap,\n \t\t.get_iommu_class = cdx_get_iommu_class,\n+\t\t.dev_iterate = cdx_dev_iterate,\n \t},\n \t.device_list = TAILQ_HEAD_INITIALIZER(rte_cdx_bus.device_list),\n \t.driver_list = TAILQ_HEAD_INITIALIZER(rte_cdx_bus.driver_list),\n", "prefixes": [ "v2", "4/6" ] }