Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126009/?format=api
{ "id": 126009, "url": "http://patches.dpdk.org/api/patches/126009/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230413094502.1714755-8-wenjing.qiao@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230413094502.1714755-8-wenjing.qiao@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230413094502.1714755-8-wenjing.qiao@intel.com", "date": "2023-04-13T09:44:51", "name": "[07/18] common/idpf: add virtchnl2 error codes", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c30830bbc2049516aa8fdd49f44e2b5a80cd7cd4", "submitter": { "id": 2680, "url": "http://patches.dpdk.org/api/people/2680/?format=api", "name": "Wenjing Qiao", "email": "wenjing.qiao@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230413094502.1714755-8-wenjing.qiao@intel.com/mbox/", "series": [ { "id": 27692, "url": "http://patches.dpdk.org/api/series/27692/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27692", "date": "2023-04-13T09:44:44", "name": "update idpf shared code", "version": 1, "mbox": "http://patches.dpdk.org/series/27692/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/126009/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/126009/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E292242931;\n\tThu, 13 Apr 2023 11:51:03 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D1EAC42D33;\n\tThu, 13 Apr 2023 11:50:25 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id BCC504114B\n for <dev@dpdk.org>; Thu, 13 Apr 2023 11:50:23 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2023 02:50:23 -0700", "from dpdk-wenjing-01.sh.intel.com ([10.67.119.244])\n by FMSMGA003.fm.intel.com with ESMTP; 13 Apr 2023 02:50:21 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1681379423; x=1712915423;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=na+DY3kJkdubMbrHkHHTx9PtdNDzHvcFhNbY3+/qo3k=;\n b=kcH8RwPMUh7+ZXkTq1zs+1tGiXV2sJWfm5kc61Yuq7G6eNIDoZYeXK/F\n muhhG4gsr0Qgkjwd8NrdyBRBNPjHz1OUeGfcjSx7a+bAbbQwzwsKvvnnf\n 04JJTjsY1kF6I7iL/Q6gT1NINibG0XBFeZeIg0A0I1xqEZSJPf0RgOJ8b\n n+enu9rgBvujJULWW4N0Ugm7eIHuK87QSFSVhvwEMPD9sBIcXR3T/u1AH\n Bz6HP2AOPHHTkU5Mdv3vzCXsxEThE42m0GmZPjQgWKnTWC8osxRwvkm3Z\n vMhZlP3g8LTbW6v4VC/Gf4iuV1GDNG1m5Np6tCUovxqNrOsTwruGevS0u A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10678\"; a=\"409290430\"", "E=Sophos;i=\"5.98,341,1673942400\"; d=\"scan'208\";a=\"409290430\"", "E=McAfee;i=\"6600,9927,10678\"; a=\"778699284\"", "E=Sophos;i=\"5.98,341,1673942400\"; d=\"scan'208\";a=\"778699284\"" ], "X-ExtLoop1": "1", "From": "Wenjing Qiao <wenjing.qiao@intel.com>", "To": "jingjing.wu@intel.com,\n\tbeilei.xing@intel.com,\n\tqi.z.zhang@intel.com", "Cc": "dev@dpdk.org, Wenjing Qiao <wenjing.qiao@intel.com>,\n Kazatsker Kirill <kirill.kazatsker@intel.com>,\n Pavan Kumar Linga <pavan.kumar.linga@intel.com>", "Subject": "[PATCH 07/18] common/idpf: add virtchnl2 error codes", "Date": "Thu, 13 Apr 2023 05:44:51 -0400", "Message-Id": "<20230413094502.1714755-8-wenjing.qiao@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230413094502.1714755-1-wenjing.qiao@intel.com>", "References": "<20230413094502.1714755-1-wenjing.qiao@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Virtchnl2 error codes are required for meaningful failure\ninformation sharing between CP and PF/VF. Introduce the\nnecessary error codes.\n\nNew error codes were introduced removing the old ones. So\nthe references to the old one should be modified to avoid\nCI build failures.\n\nUse appropriate error codes wherever necessary.\n\nSigned-off-by: Kazatsker Kirill <kirill.kazatsker@intel.com>\nSigned-off-by: Pavan Kumar Linga <pavan.kumar.linga@intel.com>\nSigned-off-by: Wenjing Qiao <wenjing.qiao@intel.com>\n---\n drivers/common/idpf/base/virtchnl2.h | 40 +++++++++++++++++++++-------\n 1 file changed, 30 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/common/idpf/base/virtchnl2.h b/drivers/common/idpf/base/virtchnl2.h\nindex edf3f200b3..415e90358e 100644\n--- a/drivers/common/idpf/base/virtchnl2.h\n+++ b/drivers/common/idpf/base/virtchnl2.h\n@@ -12,14 +12,34 @@\n \n #include \"virtchnl2_lan_desc.h\"\n \n-/* Error Codes\n- * Note that many older versions of various iAVF drivers convert the reported\n- * status code directly into an iavf_status enumeration. For this reason, it\n- * is important that the values of these enumerations line up.\n- */\n-#define\t\tVIRTCHNL2_STATUS_SUCCESS\t\t0\n-#define\t\tVIRTCHNL2_STATUS_ERR_PARAM\t\t-5\n-#define\t\tVIRTCHNL2_STATUS_ERR_OPCODE_MISMATCH\t-38\n+/* VIRTCHNL2_ERROR_CODES */\n+/* success */\n+#define\tVIRTCHNL2_STATUS_SUCCESS\t0\n+/* Operation not permitted, used in case of command not permitted for sender */\n+#define\tVIRTCHNL2_STATUS_ERR_EPERM\t1\n+/* Bad opcode - virtchnl interface problem */\n+#define\tVIRTCHNL2_STATUS_ERR_ESRCH\t3\n+/* I/O error - HW access error */\n+#define\tVIRTCHNL2_STATUS_ERR_EIO\t5\n+/* No such resource - Referenced resource is not allacated */\n+#define\tVIRTCHNL2_STATUS_ERR_ENXIO\t6\n+/* Permission denied - Resource is not permitted to caller */\n+#define\tVIRTCHNL2_STATUS_ERR_EACCES\t13\n+/* Device or resource busy - In case shared resource is in use by others */\n+#define\tVIRTCHNL2_STATUS_ERR_EBUSY\t16\n+/* Object already exists and not free */\n+#define\tVIRTCHNL2_STATUS_ERR_EEXIST\t17\n+/* Invalid input argument in command */\n+#define\tVIRTCHNL2_STATUS_ERR_EINVAL\t22\n+/* No space left or allocation failure */\n+#define\tVIRTCHNL2_STATUS_ERR_ENOSPC\t28\n+/* Parameter out of range */\n+#define\tVIRTCHNL2_STATUS_ERR_ERANGE\t34\n+\n+/* Op not allowed in current dev mode */\n+#define\tVIRTCHNL2_STATUS_ERR_EMODE\t200\n+/* State Machine error - Command sequence problem */\n+#define\tVIRTCHNL2_STATUS_ERR_ESM\t201\n \n /* These macros are used to generate compilation errors if a structure/union\n * is not exactly the correct length. It gives a divide by zero error if the\n@@ -1445,11 +1465,11 @@ virtchnl2_vc_validate_vf_msg(__rte_unused struct virtchnl2_version_info *ver, u3\n \tcase VIRTCHNL2_OP_EVENT:\n \tcase VIRTCHNL2_OP_UNKNOWN:\n \tdefault:\n-\t\treturn VIRTCHNL2_STATUS_ERR_PARAM;\n+\t\treturn VIRTCHNL2_STATUS_ERR_ESRCH;\n \t}\n \t/* few more checks */\n \tif (err_msg_format || valid_len != msglen)\n-\t\treturn VIRTCHNL2_STATUS_ERR_OPCODE_MISMATCH;\n+\t\treturn VIRTCHNL2_STATUS_ERR_EINVAL;\n \n \treturn 0;\n }\n", "prefixes": [ "07/18" ] }