Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 125532,
    "url": "http://patches.dpdk.org/api/patches/125532/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1679927420-26737-4-git-send-email-roretzla@linux.microsoft.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1679927420-26737-4-git-send-email-roretzla@linux.microsoft.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1679927420-26737-4-git-send-email-roretzla@linux.microsoft.com",
    "date": "2023-03-27T14:30:20",
    "name": "[3/3] eal: use C11 memory model GCC builtin atomics",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "64a0fe20fcbe91506d0ff2929c0fa41a9e17dc46",
    "submitter": {
        "id": 2077,
        "url": "http://patches.dpdk.org/api/people/2077/?format=api",
        "name": "Tyler Retzlaff",
        "email": "roretzla@linux.microsoft.com"
    },
    "delegate": {
        "id": 24651,
        "url": "http://patches.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1679927420-26737-4-git-send-email-roretzla@linux.microsoft.com/mbox/",
    "series": [
        {
            "id": 27552,
            "url": "http://patches.dpdk.org/api/series/27552/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27552",
            "date": "2023-03-27T14:30:17",
            "name": "use C11 memory model GCC builtin atomics",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/27552/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/125532/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/125532/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 03B094284B;\n\tMon, 27 Mar 2023 16:30:41 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 55F7542BC9;\n\tMon, 27 Mar 2023 16:30:27 +0200 (CEST)",
            "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 0CF6A410D0\n for <dev@dpdk.org>; Mon, 27 Mar 2023 16:30:23 +0200 (CEST)",
            "by linux.microsoft.com (Postfix, from userid 1086)\n id 5847620FD8C1; Mon, 27 Mar 2023 07:30:22 -0700 (PDT)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 5847620FD8C1",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1679927422;\n bh=0nJcKkIRDMULe+xr8PDhyshCqH7Bu9Us1x08O+t/IaI=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=Kiej0t80OVqifkC1JcWPlayBBB4TgflU9w/8AKvzTbOlPqDbuPjLsGfZ5nZXaa2Vh\n tFtv9BRZY1lPTogjgwbyJbt1Qa3OSLvV7ADFlNLXo6JcCF8Ooj+oqwz83V4WJaqlDW\n sZ8EIdp1Gq0DUt+a7o9z/rZ7vBBfK1JZG13USHK8=",
        "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>",
        "To": "dev@dpdk.org",
        "Cc": "Honnappa.Nagarahalli@arm.com, Ruifeng.Wang@arm.com, thomas@monjalon.net,\n Tyler Retzlaff <roretzla@linux.microsoft.com>",
        "Subject": "[PATCH 3/3] eal: use C11 memory model GCC builtin atomics",
        "Date": "Mon, 27 Mar 2023 07:30:20 -0700",
        "Message-Id": "<1679927420-26737-4-git-send-email-roretzla@linux.microsoft.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "In-Reply-To": "<1679927420-26737-1-git-send-email-roretzla@linux.microsoft.com>",
        "References": "<1679927420-26737-1-git-send-email-roretzla@linux.microsoft.com>",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Replace use of __sync_fetch_and_add and __sync_fetch_and_sub with\n__atomic_fetch_add and __atomic_fetch_sub.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/eal/include/generic/rte_atomic.h | 32 ++++++++++++++++----------------\n 1 file changed, 16 insertions(+), 16 deletions(-)",
    "diff": "diff --git a/lib/eal/include/generic/rte_atomic.h b/lib/eal/include/generic/rte_atomic.h\nindex 234b268..58df843 100644\n--- a/lib/eal/include/generic/rte_atomic.h\n+++ b/lib/eal/include/generic/rte_atomic.h\n@@ -243,7 +243,7 @@\n static inline void\n rte_atomic16_add(rte_atomic16_t *v, int16_t inc)\n {\n-\t__sync_fetch_and_add(&v->cnt, inc);\n+\t__atomic_fetch_add(&v->cnt, inc, __ATOMIC_SEQ_CST);\n }\n \n /**\n@@ -257,7 +257,7 @@\n static inline void\n rte_atomic16_sub(rte_atomic16_t *v, int16_t dec)\n {\n-\t__sync_fetch_and_sub(&v->cnt, dec);\n+\t__atomic_fetch_sub(&v->cnt, dec, __ATOMIC_SEQ_CST);\n }\n \n /**\n@@ -310,7 +310,7 @@\n static inline int16_t\n rte_atomic16_add_return(rte_atomic16_t *v, int16_t inc)\n {\n-\treturn __sync_add_and_fetch(&v->cnt, inc);\n+\treturn __atomic_fetch_add(&v->cnt, inc, __ATOMIC_SEQ_CST) + inc;\n }\n \n /**\n@@ -330,7 +330,7 @@\n static inline int16_t\n rte_atomic16_sub_return(rte_atomic16_t *v, int16_t dec)\n {\n-\treturn __sync_sub_and_fetch(&v->cnt, dec);\n+\treturn __atomic_fetch_sub(&v->cnt, dec, __ATOMIC_SEQ_CST) - dec;\n }\n \n /**\n@@ -349,7 +349,7 @@\n #ifdef RTE_FORCE_INTRINSICS\n static inline int rte_atomic16_inc_and_test(rte_atomic16_t *v)\n {\n-\treturn __sync_add_and_fetch(&v->cnt, 1) == 0;\n+\treturn __atomic_fetch_add(&v->cnt, 1, __ATOMIC_SEQ_CST) + 1 == 0;\n }\n #endif\n \n@@ -369,7 +369,7 @@ static inline int rte_atomic16_inc_and_test(rte_atomic16_t *v)\n #ifdef RTE_FORCE_INTRINSICS\n static inline int rte_atomic16_dec_and_test(rte_atomic16_t *v)\n {\n-\treturn __sync_sub_and_fetch(&v->cnt, 1) == 0;\n+\treturn __atomic_fetch_sub(&v->cnt, 1, __ATOMIC_SEQ_CST) - 1 == 0;\n }\n #endif\n \n@@ -522,7 +522,7 @@ static inline void rte_atomic16_clear(rte_atomic16_t *v)\n static inline void\n rte_atomic32_add(rte_atomic32_t *v, int32_t inc)\n {\n-\t__sync_fetch_and_add(&v->cnt, inc);\n+\t__atomic_fetch_add(&v->cnt, inc, __ATOMIC_SEQ_CST);\n }\n \n /**\n@@ -536,7 +536,7 @@ static inline void rte_atomic16_clear(rte_atomic16_t *v)\n static inline void\n rte_atomic32_sub(rte_atomic32_t *v, int32_t dec)\n {\n-\t__sync_fetch_and_sub(&v->cnt, dec);\n+\t__atomic_fetch_sub(&v->cnt, dec, __ATOMIC_SEQ_CST);\n }\n \n /**\n@@ -589,7 +589,7 @@ static inline void rte_atomic16_clear(rte_atomic16_t *v)\n static inline int32_t\n rte_atomic32_add_return(rte_atomic32_t *v, int32_t inc)\n {\n-\treturn __sync_add_and_fetch(&v->cnt, inc);\n+\treturn __atomic_fetch_add(&v->cnt, inc, __ATOMIC_SEQ_CST) + inc;\n }\n \n /**\n@@ -609,7 +609,7 @@ static inline void rte_atomic16_clear(rte_atomic16_t *v)\n static inline int32_t\n rte_atomic32_sub_return(rte_atomic32_t *v, int32_t dec)\n {\n-\treturn __sync_sub_and_fetch(&v->cnt, dec);\n+\treturn __atomic_fetch_sub(&v->cnt, dec, __ATOMIC_SEQ_CST) - dec;\n }\n \n /**\n@@ -628,7 +628,7 @@ static inline void rte_atomic16_clear(rte_atomic16_t *v)\n #ifdef RTE_FORCE_INTRINSICS\n static inline int rte_atomic32_inc_and_test(rte_atomic32_t *v)\n {\n-\treturn __sync_add_and_fetch(&v->cnt, 1) == 0;\n+\treturn __atomic_fetch_add(&v->cnt, 1, __ATOMIC_SEQ_CST) + 1 == 0;\n }\n #endif\n \n@@ -648,7 +648,7 @@ static inline int rte_atomic32_inc_and_test(rte_atomic32_t *v)\n #ifdef RTE_FORCE_INTRINSICS\n static inline int rte_atomic32_dec_and_test(rte_atomic32_t *v)\n {\n-\treturn __sync_sub_and_fetch(&v->cnt, 1) == 0;\n+\treturn __atomic_fetch_sub(&v->cnt, 1, __ATOMIC_SEQ_CST) - 1 == 0;\n }\n #endif\n \n@@ -854,7 +854,7 @@ static inline void rte_atomic32_clear(rte_atomic32_t *v)\n static inline void\n rte_atomic64_add(rte_atomic64_t *v, int64_t inc)\n {\n-\t__sync_fetch_and_add(&v->cnt, inc);\n+\t__atomic_fetch_add(&v->cnt, inc, __ATOMIC_SEQ_CST);\n }\n #endif\n \n@@ -873,7 +873,7 @@ static inline void rte_atomic32_clear(rte_atomic32_t *v)\n static inline void\n rte_atomic64_sub(rte_atomic64_t *v, int64_t dec)\n {\n-\t__sync_fetch_and_sub(&v->cnt, dec);\n+\t__atomic_fetch_sub(&v->cnt, dec, __ATOMIC_SEQ_CST);\n }\n #endif\n \n@@ -931,7 +931,7 @@ static inline void rte_atomic32_clear(rte_atomic32_t *v)\n static inline int64_t\n rte_atomic64_add_return(rte_atomic64_t *v, int64_t inc)\n {\n-\treturn __sync_add_and_fetch(&v->cnt, inc);\n+\treturn __atomic_fetch_add(&v->cnt, inc, __ATOMIC_SEQ_CST) + inc;\n }\n #endif\n \n@@ -955,7 +955,7 @@ static inline void rte_atomic32_clear(rte_atomic32_t *v)\n static inline int64_t\n rte_atomic64_sub_return(rte_atomic64_t *v, int64_t dec)\n {\n-\treturn __sync_sub_and_fetch(&v->cnt, dec);\n+\treturn __atomic_fetch_sub(&v->cnt, dec, __ATOMIC_SEQ_CST) - dec;\n }\n #endif\n \n",
    "prefixes": [
        "3/3"
    ]
}