Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125474/?format=api
{ "id": 125474, "url": "http://patches.dpdk.org/api/patches/125474/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1679610881-25997-7-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1679610881-25997-7-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1679610881-25997-7-git-send-email-roretzla@linux.microsoft.com", "date": "2023-03-23T22:34:40", "name": "[v2,6/7] net/null: replace rte atomics with GCC builtin atomics", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "bcde026bcef9ae21cf650c3e0674f32b145963d5", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1679610881-25997-7-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 27529, "url": "http://patches.dpdk.org/api/series/27529/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27529", "date": "2023-03-23T22:34:35", "name": "replace rte atomics with GCC builtin atomics", "version": 2, "mbox": "http://patches.dpdk.org/series/27529/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/125474/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/125474/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CE9634280D;\n\tThu, 23 Mar 2023 23:35:28 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7472842D2D;\n\tThu, 23 Mar 2023 23:34:52 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 7CF3240E09\n for <dev@dpdk.org>; Thu, 23 Mar 2023 23:34:44 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 267AB20E9BEE; Thu, 23 Mar 2023 15:34:42 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 267AB20E9BEE", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1679610883;\n bh=ZT6l0o+ssAGv2zFHrbpg7Va8iMBklMOM7tV6qMhChYE=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=PZwtIHCNUQrNq9zqhcQpcOiXLRw8uP0z9CyrVOmNY/ruZZ8uwz3+0HDTUxaRmKRAI\n aBs8vWd4VNwXu1f/0xfmBn5GGlikPVyC6gMCakVLS+zQLtHCuDka3nuEJZLpf7tJhe\n K77qrc/00Llkb1ACMz8+w5HGBJtu40X/j7Pn4EKc=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Honnappa.Nagarahalli@arm.com, Ruifeng.Wang@arm.com, thomas@monjalon.net,\n stephen@networkplumber.org, mb@smartsharesystems.com,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v2 6/7] net/null: replace rte atomics with GCC builtin atomics", "Date": "Thu, 23 Mar 2023 15:34:40 -0700", "Message-Id": "<1679610881-25997-7-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1679610881-25997-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1679084388-19267-1-git-send-email-roretzla@linux.microsoft.com>\n <1679610881-25997-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Replace the use of rte_atomic.h types and functions, instead use GCC\nsupplied C++11 memory model builtins.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n drivers/net/null/rte_eth_null.c | 28 ++++++++++++++++++----------\n 1 file changed, 18 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c\nindex 47d9554..6a115f8 100644\n--- a/drivers/net/null/rte_eth_null.c\n+++ b/drivers/net/null/rte_eth_null.c\n@@ -37,8 +37,8 @@ struct null_queue {\n \tstruct rte_mempool *mb_pool;\n \tstruct rte_mbuf *dummy_packet;\n \n-\trte_atomic64_t rx_pkts;\n-\trte_atomic64_t tx_pkts;\n+\tuint64_t rx_pkts;\n+\tuint64_t tx_pkts;\n };\n \n struct pmd_options {\n@@ -101,7 +101,8 @@ struct pmd_internals {\n \t\tbufs[i]->port = h->internals->port_id;\n \t}\n \n-\trte_atomic64_add(&(h->rx_pkts), i);\n+\t// NOTE: review for potential ordering optimization\n+\t__atomic_fetch_add(&h->rx_pkts, i, __ATOMIC_SEQ_CST);\n \n \treturn i;\n }\n@@ -128,7 +129,8 @@ struct pmd_internals {\n \t\tbufs[i]->port = h->internals->port_id;\n \t}\n \n-\trte_atomic64_add(&(h->rx_pkts), i);\n+\t// NOTE: review for potential ordering optimization\n+\t__atomic_fetch_add(&h->rx_pkts, i, __ATOMIC_SEQ_CST);\n \n \treturn i;\n }\n@@ -152,7 +154,8 @@ struct pmd_internals {\n \tfor (i = 0; i < nb_bufs; i++)\n \t\trte_pktmbuf_free(bufs[i]);\n \n-\trte_atomic64_add(&(h->tx_pkts), i);\n+\t// NOTE: review for potential ordering optimization\n+\t__atomic_fetch_add(&h->tx_pkts, i, __ATOMIC_SEQ_CST);\n \n \treturn i;\n }\n@@ -174,7 +177,8 @@ struct pmd_internals {\n \t\trte_pktmbuf_free(bufs[i]);\n \t}\n \n-\trte_atomic64_add(&(h->tx_pkts), i);\n+\t// NOTE: review for potential ordering optimization\n+\t__atomic_fetch_add(&h->tx_pkts, i, __ATOMIC_SEQ_CST);\n \n \treturn i;\n }\n@@ -316,8 +320,9 @@ struct pmd_internals {\n \t\t\tRTE_MIN(dev->data->nb_rx_queues,\n \t\t\t\tRTE_DIM(internal->rx_null_queues)));\n \tfor (i = 0; i < num_stats; i++) {\n+\t\t// NOTE: review for atomic access\n \t\tigb_stats->q_ipackets[i] =\n-\t\t\tinternal->rx_null_queues[i].rx_pkts.cnt;\n+\t\t\tinternal->rx_null_queues[i].rx_pkts;\n \t\trx_total += igb_stats->q_ipackets[i];\n \t}\n \n@@ -325,8 +330,9 @@ struct pmd_internals {\n \t\t\tRTE_MIN(dev->data->nb_tx_queues,\n \t\t\t\tRTE_DIM(internal->tx_null_queues)));\n \tfor (i = 0; i < num_stats; i++) {\n+\t\t// NOTE: review for atomic access\n \t\tigb_stats->q_opackets[i] =\n-\t\t\tinternal->tx_null_queues[i].tx_pkts.cnt;\n+\t\t\tinternal->tx_null_queues[i].tx_pkts;\n \t\ttx_total += igb_stats->q_opackets[i];\n \t}\n \n@@ -347,9 +353,11 @@ struct pmd_internals {\n \n \tinternal = dev->data->dev_private;\n \tfor (i = 0; i < RTE_DIM(internal->rx_null_queues); i++)\n-\t\tinternal->rx_null_queues[i].rx_pkts.cnt = 0;\n+\t\t// NOTE: review for atomic access\n+\t\tinternal->rx_null_queues[i].rx_pkts = 0;\n \tfor (i = 0; i < RTE_DIM(internal->tx_null_queues); i++)\n-\t\tinternal->tx_null_queues[i].tx_pkts.cnt = 0;\n+\t\t// NOTE: review for atomic access\n+\t\tinternal->tx_null_queues[i].tx_pkts = 0;\n \n \treturn 0;\n }\n", "prefixes": [ "v2", "6/7" ] }