Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125342/?format=api
{ "id": 125342, "url": "http://patches.dpdk.org/api/patches/125342/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1679338836-21321-10-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1679338836-21321-10-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1679338836-21321-10-git-send-email-roretzla@linux.microsoft.com", "date": "2023-03-20T19:00:29", "name": "[v3,09/16] net/mlx5: use previous value atomic fetch operations", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0f5cdd48ad3eef29df5683713b5c8c7986b1b6b5", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1679338836-21321-10-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 27471, "url": "http://patches.dpdk.org/api/series/27471/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27471", "date": "2023-03-20T19:00:21", "name": "replace __atomic operations returning new value", "version": 3, "mbox": "http://patches.dpdk.org/series/27471/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/125342/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/125342/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6AD72427E5;\n\tMon, 20 Mar 2023 20:02:26 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 495D242D47;\n\tMon, 20 Mar 2023 20:01:21 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 67B7941141\n for <dev@dpdk.org>; Mon, 20 Mar 2023 20:01:03 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 37ADD20FB411; Mon, 20 Mar 2023 12:01:01 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 37ADD20FB411", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1679338862;\n bh=I7Fn0I1Vcl/rgt7s4W7767V5jxNjmcE3iMARipwE5cs=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=CtfsfxaS9WRHLuSvziBQJ8FoJsKrpwAPlLDzPcjr232qpJoHXAkJsgmPKuJmjg/8/\n lQA786Uq1lqc/lUShPlO13XX00tAWkEy7BqFtD/WzTjxHgWOvHb8MH7RNP3ACjl+B1\n Q+zk1sGiJLeHoordYg1/5amNtd3+bUjCQNm8RijQ=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Honnappa.Nagarahalli@arm.com, Ruifeng.Wang@arm.com, thomas@monjalon.net,\n pbhagavatula@marvell.com, ndabilpuram@marvell.com,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v3 09/16] net/mlx5: use previous value atomic fetch operations", "Date": "Mon, 20 Mar 2023 12:00:29 -0700", "Message-Id": "<1679338836-21321-10-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1679338836-21321-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1678486530-20688-1-git-send-email-roretzla@linux.microsoft.com>\n <1679338836-21321-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Use __atomic_fetch_{add,and,or,sub,xor} instead of\n__atomic_{add,and,or,sub,xor}_fetch adding the necessary code to\nallow consumption of the resulting value.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n drivers/net/mlx5/linux/mlx5_verbs.c | 2 +-\n drivers/net/mlx5/mlx5.c | 4 ++--\n drivers/net/mlx5/mlx5_flow.c | 8 ++++----\n drivers/net/mlx5/mlx5_flow_dv.c | 12 ++++++------\n drivers/net/mlx5/mlx5_flow_hw.c | 14 +++++++-------\n drivers/net/mlx5/mlx5_hws_cnt.c | 4 ++--\n drivers/net/mlx5/mlx5_rxq.c | 6 +++---\n drivers/net/mlx5/mlx5_txq.c | 2 +-\n 8 files changed, 26 insertions(+), 26 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/linux/mlx5_verbs.c b/drivers/net/mlx5/linux/mlx5_verbs.c\nindex 67a7bec..ee5d072 100644\n--- a/drivers/net/mlx5/linux/mlx5_verbs.c\n+++ b/drivers/net/mlx5/linux/mlx5_verbs.c\n@@ -1183,7 +1183,7 @@\n \tif (!priv->lb_used)\n \t\treturn;\n \tMLX5_ASSERT(__atomic_load_n(&sh->self_lb.refcnt, __ATOMIC_RELAXED));\n-\tif (!(__atomic_sub_fetch(&sh->self_lb.refcnt, 1, __ATOMIC_RELAXED))) {\n+\tif (!(__atomic_fetch_sub(&sh->self_lb.refcnt, 1, __ATOMIC_RELAXED) - 1)) {\n \t\tif (sh->self_lb.qp) {\n \t\t\tclaim_zero(mlx5_glue->destroy_qp(sh->self_lb.qp));\n \t\t\tsh->self_lb.qp = NULL;\ndiff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex 41b1b12..044012d 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -1068,7 +1068,7 @@ static LIST_HEAD(, mlx5_dev_ctx_shared) mlx5_dev_ctx_list =\n \t\tDRV_LOG(ERR, \"Dynamic flex parser is not supported\");\n \t\treturn -ENOTSUP;\n \t}\n-\tif (__atomic_add_fetch(&priv->sh->srh_flex_parser.refcnt, 1, __ATOMIC_RELAXED) > 1)\n+\tif (__atomic_fetch_add(&priv->sh->srh_flex_parser.refcnt, 1, __ATOMIC_RELAXED) + 1 > 1)\n \t\treturn 0;\n \n \tnode.header_length_mode = MLX5_GRAPH_NODE_LEN_FIELD;\n@@ -1123,7 +1123,7 @@ static LIST_HEAD(, mlx5_dev_ctx_shared) mlx5_dev_ctx_list =\n \tstruct mlx5_priv *priv = dev->data->dev_private;\n \tstruct mlx5_internal_flex_parser_profile *fp = &priv->sh->srh_flex_parser;\n \n-\tif (__atomic_sub_fetch(&fp->refcnt, 1, __ATOMIC_RELAXED))\n+\tif (__atomic_fetch_sub(&fp->refcnt, 1, __ATOMIC_RELAXED) - 1)\n \t\treturn;\n \tif (fp->fp)\n \t\tmlx5_devx_cmd_destroy(fp->fp);\ndiff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex 19f7f92..c742675 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -7833,7 +7833,7 @@ struct rte_flow *\n \n \t\ttunnel = mlx5_find_tunnel_id(dev, flow->tunnel_id);\n \t\tRTE_VERIFY(tunnel);\n-\t\tif (!__atomic_sub_fetch(&tunnel->refctn, 1, __ATOMIC_RELAXED))\n+\t\tif (!(__atomic_fetch_sub(&tunnel->refctn, 1, __ATOMIC_RELAXED) - 1))\n \t\t\tmlx5_flow_tunnel_free(dev, tunnel);\n \t}\n \tflow_mreg_del_copy_action(dev, flow);\n@@ -9746,9 +9746,9 @@ struct mlx5_flow_workspace*\n \t\t\t\t\t __ATOMIC_RELAXED);\n \t\t\tcontinue;\n \t\t}\n-\t\tif (__atomic_add_fetch(&age_param->sec_since_last_hit,\n+\t\tif (__atomic_fetch_add(&age_param->sec_since_last_hit,\n \t\t\t\t time_delta,\n-\t\t\t\t __ATOMIC_RELAXED) <= age_param->timeout)\n+\t\t\t\t __ATOMIC_RELAXED) + time_delta <= age_param->timeout)\n \t\t\tcontinue;\n \t\t/**\n \t\t * Hold the lock first, or if between the\n@@ -11391,7 +11391,7 @@ struct tunnel_db_element_release_ctx {\n {\n \tstruct tunnel_db_element_release_ctx *ctx = x;\n \tctx->ret = 0;\n-\tif (!__atomic_sub_fetch(&tunnel->refctn, 1, __ATOMIC_RELAXED))\n+\tif (!(__atomic_fetch_sub(&tunnel->refctn, 1, __ATOMIC_RELAXED) - 1))\n \t\tmlx5_flow_tunnel_free(dev, tunnel);\n }\n \ndiff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex ca26f39..f04160e 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -6723,8 +6723,8 @@ struct mlx5_list_entry *\n \t\t * indirect action API, shared info is 1 before the reduction,\n \t\t * so this condition is failed and function doesn't return here.\n \t\t */\n-\t\tif (__atomic_sub_fetch(&cnt->shared_info.refcnt, 1,\n-\t\t\t\t __ATOMIC_RELAXED))\n+\t\tif (__atomic_fetch_sub(&cnt->shared_info.refcnt, 1,\n+\t\t\t\t __ATOMIC_RELAXED) - 1)\n \t\t\treturn;\n \t}\n \tcnt->pool = pool;\n@@ -12797,7 +12797,7 @@ struct mlx5_list_entry *\n \tstruct mlx5_priv *priv = dev->data->dev_private;\n \tstruct mlx5_aso_age_mng *mng = priv->sh->aso_age_mng;\n \tstruct mlx5_aso_age_action *age = flow_aso_age_get_by_idx(dev, age_idx);\n-\tuint32_t ret = __atomic_sub_fetch(&age->refcnt, 1, __ATOMIC_RELAXED);\n+\tuint32_t ret = __atomic_fetch_sub(&age->refcnt, 1, __ATOMIC_RELAXED) - 1;\n \n \tif (!ret) {\n \t\tflow_dv_aso_age_remove_from_age(dev, age);\n@@ -13193,7 +13193,7 @@ struct mlx5_list_entry *\n \t/* Cannot release when CT is in the ASO SQ. */\n \tif (state == ASO_CONNTRACK_WAIT || state == ASO_CONNTRACK_QUERY)\n \t\treturn -1;\n-\tret = __atomic_sub_fetch(&ct->refcnt, 1, __ATOMIC_RELAXED);\n+\tret = __atomic_fetch_sub(&ct->refcnt, 1, __ATOMIC_RELAXED) - 1;\n \tif (!ret) {\n \t\tif (ct->dr_action_orig) {\n #ifdef HAVE_MLX5_DR_ACTION_ASO_CT\n@@ -15582,8 +15582,8 @@ struct mlx5_list_entry *\n \t\t\t\tsh->geneve_tlv_option_resource;\n \trte_spinlock_lock(&sh->geneve_tlv_opt_sl);\n \tif (geneve_opt_resource) {\n-\t\tif (!(__atomic_sub_fetch(&geneve_opt_resource->refcnt, 1,\n-\t\t\t\t\t __ATOMIC_RELAXED))) {\n+\t\tif (!(__atomic_fetch_sub(&geneve_opt_resource->refcnt, 1,\n+\t\t\t\t\t __ATOMIC_RELAXED) - 1)) {\n \t\t\tclaim_zero(mlx5_devx_cmd_destroy\n \t\t\t\t\t(geneve_opt_resource->obj));\n \t\t\tmlx5_free(sh->geneve_tlv_option_resource);\ndiff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c\nindex a4328a9..8882fc7 100644\n--- a/drivers/net/mlx5/mlx5_flow_hw.c\n+++ b/drivers/net/mlx5/mlx5_flow_hw.c\n@@ -458,7 +458,7 @@ static int flow_hw_translate_group(struct rte_eth_dev *dev,\n \t}\n \n \tif (acts->mark)\n-\t\tif (!__atomic_sub_fetch(&priv->hws_mark_refcnt, 1, __ATOMIC_RELAXED))\n+\t\tif (!(__atomic_fetch_sub(&priv->hws_mark_refcnt, 1, __ATOMIC_RELAXED) - 1))\n \t\t\tflow_hw_rxq_flag_set(dev, false);\n \n \tif (acts->jump) {\n@@ -3268,8 +3268,8 @@ static rte_be32_t vlan_hdr_to_be32(const struct rte_flow_action *actions)\n \t\t\trte_errno = EINVAL;\n \t\t\tgoto it_error;\n \t\t}\n-\t\tret = __atomic_add_fetch(&item_templates[i]->refcnt, 1,\n-\t\t\t\t\t __ATOMIC_RELAXED);\n+\t\tret = __atomic_fetch_add(&item_templates[i]->refcnt, 1,\n+\t\t\t\t\t __ATOMIC_RELAXED) + 1;\n \t\tif (ret <= 1) {\n \t\t\trte_errno = EINVAL;\n \t\t\tgoto it_error;\n@@ -3282,8 +3282,8 @@ static rte_be32_t vlan_hdr_to_be32(const struct rte_flow_action *actions)\n \tfor (i = 0; i < nb_action_templates; i++) {\n \t\tuint32_t ret;\n \n-\t\tret = __atomic_add_fetch(&action_templates[i]->refcnt, 1,\n-\t\t\t\t\t __ATOMIC_RELAXED);\n+\t\tret = __atomic_fetch_add(&action_templates[i]->refcnt, 1,\n+\t\t\t\t\t __ATOMIC_RELAXED) + 1;\n \t\tif (ret <= 1) {\n \t\t\trte_errno = EINVAL;\n \t\t\tgoto at_error;\n@@ -7726,8 +7726,8 @@ void flow_hw_clear_tags_set(struct rte_eth_dev *dev)\n {\n \tuint32_t refcnt;\n \n-\trefcnt = __atomic_sub_fetch(&mlx5_flow_hw_flow_metadata_config_refcnt, 1,\n-\t\t\t\t __ATOMIC_RELAXED);\n+\trefcnt = __atomic_fetch_sub(&mlx5_flow_hw_flow_metadata_config_refcnt, 1,\n+\t\t\t\t __ATOMIC_RELAXED) - 1;\n \tif (refcnt > 0)\n \t\treturn;\n \tmlx5_flow_hw_flow_metadata_esw_en = 0;\ndiff --git a/drivers/net/mlx5/mlx5_hws_cnt.c b/drivers/net/mlx5/mlx5_hws_cnt.c\nindex d6a017a..d98df68 100644\n--- a/drivers/net/mlx5/mlx5_hws_cnt.c\n+++ b/drivers/net/mlx5/mlx5_hws_cnt.c\n@@ -192,8 +192,8 @@\n \t\t\t}\n \t\t\tparam->accumulator_hits = 0;\n \t\t}\n-\t\tif (__atomic_add_fetch(¶m->sec_since_last_hit, time_delta,\n-\t\t\t\t __ATOMIC_RELAXED) <=\n+\t\tif (__atomic_fetch_add(¶m->sec_since_last_hit, time_delta,\n+\t\t\t\t __ATOMIC_RELAXED) + time_delta <=\n \t\t __atomic_load_n(¶m->timeout, __ATOMIC_RELAXED))\n \t\t\tcontinue;\n \t\t/* Prepare the relevant ring for this AGE parameter */\ndiff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c\nindex 6e99c4d..ad8fd13 100644\n--- a/drivers/net/mlx5/mlx5_rxq.c\n+++ b/drivers/net/mlx5/mlx5_rxq.c\n@@ -2042,7 +2042,7 @@ struct mlx5_rxq_priv *\n \n \tif (rxq == NULL)\n \t\treturn 0;\n-\treturn __atomic_sub_fetch(&rxq->refcnt, 1, __ATOMIC_RELAXED);\n+\treturn __atomic_fetch_sub(&rxq->refcnt, 1, __ATOMIC_RELAXED) - 1;\n }\n \n /**\n@@ -2141,7 +2141,7 @@ struct mlx5_external_rxq *\n {\n \tstruct mlx5_external_rxq *rxq = mlx5_ext_rxq_get(dev, idx);\n \n-\treturn __atomic_sub_fetch(&rxq->refcnt, 1, __ATOMIC_RELAXED);\n+\treturn __atomic_fetch_sub(&rxq->refcnt, 1, __ATOMIC_RELAXED) - 1;\n }\n \n /**\n@@ -2462,7 +2462,7 @@ struct mlx5_ind_table_obj *\n \tunsigned int ret;\n \n \trte_rwlock_write_lock(&priv->ind_tbls_lock);\n-\tret = __atomic_sub_fetch(&ind_tbl->refcnt, 1, __ATOMIC_RELAXED);\n+\tret = __atomic_fetch_sub(&ind_tbl->refcnt, 1, __ATOMIC_RELAXED) - 1;\n \tif (!ret)\n \t\tLIST_REMOVE(ind_tbl, next);\n \trte_rwlock_write_unlock(&priv->ind_tbls_lock);\ndiff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c\nindex 1e0e61a..8cb52b0 100644\n--- a/drivers/net/mlx5/mlx5_txq.c\n+++ b/drivers/net/mlx5/mlx5_txq.c\n@@ -1203,7 +1203,7 @@ struct mlx5_txq_ctrl *\n \tif (priv->txqs == NULL || (*priv->txqs)[idx] == NULL)\n \t\treturn 0;\n \ttxq_ctrl = container_of((*priv->txqs)[idx], struct mlx5_txq_ctrl, txq);\n-\tif (__atomic_sub_fetch(&txq_ctrl->refcnt, 1, __ATOMIC_RELAXED) > 1)\n+\tif (__atomic_fetch_sub(&txq_ctrl->refcnt, 1, __ATOMIC_RELAXED) - 1 > 1)\n \t\treturn 1;\n \tif (txq_ctrl->obj) {\n \t\tpriv->obj_ops.txq_obj_release(txq_ctrl->obj);\n", "prefixes": [ "v3", "09/16" ] }