Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 125030,
    "url": "http://patches.dpdk.org/api/patches/125030/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1678486530-20688-16-git-send-email-roretzla@linux.microsoft.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1678486530-20688-16-git-send-email-roretzla@linux.microsoft.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1678486530-20688-16-git-send-email-roretzla@linux.microsoft.com",
    "date": "2023-03-10T22:15:29",
    "name": "[15/16] mbuf: use previous value atomic fetch operations",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "73325692c2d0bbda32055b1fa0c42ed9a6f0a4d5",
    "submitter": {
        "id": 2077,
        "url": "http://patches.dpdk.org/api/people/2077/?format=api",
        "name": "Tyler Retzlaff",
        "email": "roretzla@linux.microsoft.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1678486530-20688-16-git-send-email-roretzla@linux.microsoft.com/mbox/",
    "series": [
        {
            "id": 27337,
            "url": "http://patches.dpdk.org/api/series/27337/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27337",
            "date": "2023-03-10T22:15:16",
            "name": "use __atomic operations returning new value",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/27337/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/125030/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/125030/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7426441E6D;\n\tFri, 10 Mar 2023 23:17:06 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7436542D48;\n\tFri, 10 Mar 2023 23:15:53 +0100 (CET)",
            "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 7AE6240685\n for <dev@dpdk.org>; Fri, 10 Mar 2023 23:15:37 +0100 (CET)",
            "by linux.microsoft.com (Postfix, from userid 1086)\n id 4089A20C343F; Fri, 10 Mar 2023 14:15:35 -0800 (PST)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 4089A20C343F",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1678486536;\n bh=EvTRhZ/G3hZiE8a8339jFsa+CvgSNFF3uTPKvIElqVQ=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=dI8nG+9o1IiWJ+Toi5RVBA1IhzXpSJyhDiwq9k90jVAqJGJGO4qs/j8iaVAOPym42\n lLiyk7Sm2ZUfTLZysWNSpQ2ZU/+XtxOwYzN9CJtpNLYmpbfmaR5NHd/3SMVNbfX/sM\n QAfUIMgTi2jQjrD3RaoCr7SksxcrZgC0af5XJxZc=",
        "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>",
        "To": "dev@dpdk.org",
        "Cc": "Honnappa.Nagarahalli@arm.com, Ruifeng.Wang@arm.com, thomas@monjalon.net,\n Tyler Retzlaff <roretzla@linux.microsoft.com>",
        "Subject": "[PATCH 15/16] mbuf: use previous value atomic fetch operations",
        "Date": "Fri, 10 Mar 2023 14:15:29 -0800",
        "Message-Id": "<1678486530-20688-16-git-send-email-roretzla@linux.microsoft.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "In-Reply-To": "<1678486530-20688-1-git-send-email-roretzla@linux.microsoft.com>",
        "References": "<1678486530-20688-1-git-send-email-roretzla@linux.microsoft.com>",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Use __atomic_fetch_{add,and,or,sub,xor} instead of\n__atomic_{add,and,or,sub,xor}_fetch adding the necessary code to\nallow consumption of the resulting value.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/mbuf/rte_mbuf.h | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)",
    "diff": "diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h\nindex 3a82eb1..5da4cbe 100644\n--- a/lib/mbuf/rte_mbuf.h\n+++ b/lib/mbuf/rte_mbuf.h\n@@ -381,8 +381,8 @@ struct rte_pktmbuf_pool_private {\n static inline uint16_t\n __rte_mbuf_refcnt_update(struct rte_mbuf *m, int16_t value)\n {\n-\treturn __atomic_add_fetch(&m->refcnt, (uint16_t)value,\n-\t\t\t\t __ATOMIC_ACQ_REL);\n+\treturn __atomic_fetch_add(&m->refcnt, (uint16_t)value,\n+\t\t\t\t __ATOMIC_ACQ_REL) + (uint16_t)value;\n }\n \n /**\n@@ -502,8 +502,8 @@ struct rte_pktmbuf_pool_private {\n \t\treturn (uint16_t)value;\n \t}\n \n-\treturn __atomic_add_fetch(&shinfo->refcnt, (uint16_t)value,\n-\t\t\t\t __ATOMIC_ACQ_REL);\n+\treturn __atomic_fetch_add(&shinfo->refcnt, (uint16_t)value,\n+\t\t\t\t __ATOMIC_ACQ_REL) + (uint16_t)value;\n }\n \n /** Mbuf prefetch */\n@@ -1315,8 +1315,8 @@ static inline int __rte_pktmbuf_pinned_extbuf_decref(struct rte_mbuf *m)\n \t * Direct usage of add primitive to avoid\n \t * duplication of comparing with one.\n \t */\n-\tif (likely(__atomic_add_fetch(&shinfo->refcnt, (uint16_t)-1,\n-\t\t\t\t     __ATOMIC_ACQ_REL)))\n+\tif (likely(__atomic_fetch_add(&shinfo->refcnt, (uint16_t)-1,\n+\t\t\t\t     __ATOMIC_ACQ_REL) + (uint16_t)-1))\n \t\treturn 1;\n \n \t/* Reinitialize counter before mbuf freeing. */\n",
    "prefixes": [
        "15/16"
    ]
}