Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/124796/?format=api
{ "id": 124796, "url": "http://patches.dpdk.org/api/patches/124796/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230303130006.831257-1-harry.van.haaren@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230303130006.831257-1-harry.van.haaren@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230303130006.831257-1-harry.van.haaren@intel.com", "date": "2023-03-03T13:00:06", "name": "[v2] service: split tests to perf and autotest to avoid spurious CI failures", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "88f1e272e6f1437321e01e433b6992e229b42e5d", "submitter": { "id": 317, "url": "http://patches.dpdk.org/api/people/317/?format=api", "name": "Van Haaren, Harry", "email": "harry.van.haaren@intel.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230303130006.831257-1-harry.van.haaren@intel.com/mbox/", "series": [ { "id": 27244, "url": "http://patches.dpdk.org/api/series/27244/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27244", "date": "2023-03-03T13:00:06", "name": "[v2] service: split tests to perf and autotest to avoid spurious CI failures", "version": 2, "mbox": "http://patches.dpdk.org/series/27244/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/124796/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/124796/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D1E2D41DC8;\n\tFri, 3 Mar 2023 14:00:57 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4325D427E9;\n\tFri, 3 Mar 2023 14:00:57 +0100 (CET)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by mails.dpdk.org (Postfix) with ESMTP id 3D8EC400D6;\n Fri, 3 Mar 2023 14:00:55 +0100 (CET)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 03 Mar 2023 05:00:44 -0800", "from silpixa00401454.ir.intel.com ([10.55.128.122])\n by orsmga007.jf.intel.com with ESMTP; 03 Mar 2023 05:00:41 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1677848455; x=1709384455;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=oABTV7c/HZLorwWe9twTPl/bTZuMvraWa/0ioVO375c=;\n b=lpfJPrlmTnbSTBr/buCTkcmzSTKZ+aG2dgkQd/xcCShX99fCeXhgkX0n\n fOA2dxdzKKGbyTzla7OfukkYpsYdNkdamzmpcqztw8YcV7fnLefyMEnVa\n Q6RFt1Amv4+3bnSicAHJmKWojbViTciOCLXwCBkBoX1HsbuZaceFb6SK/\n kVtOUj+6hRc1hcpuU1Xn3HQCzJNiR8DFBXNHRYfJUxiRwN8KCa4urLGiu\n I6MVfJkuqU7dC5C/DLx+lU+UicGvsUjPAH2T8c++cO1NIbadNlDM25Iwk\n gIAb9CW2SZW7i8LqTdx1koFSQ15hCI8OP0M8fW0PsVGp+TruDxm8CCrik g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10637\"; a=\"318858334\"", "E=Sophos;i=\"5.98,230,1673942400\"; d=\"scan'208\";a=\"318858334\"", "E=McAfee;i=\"6500,9779,10637\"; a=\"668648147\"", "E=Sophos;i=\"5.98,230,1673942400\"; d=\"scan'208\";a=\"668648147\"" ], "X-ExtLoop1": "1", "From": "Harry van Haaren <harry.van.haaren@intel.com>", "To": "dev@dpdk.org", "Cc": "david.marchand@redhat.com, dpdklab@iol.unh.edu, ci@dpdk.org,\n Honnappa.Nagarahalli@arm.com, mattias.ronnblom@ericsson.com,\n mb@smartsharesystems.com, roretzla@linux.microsoft.com, aconole@redhat.com,\n bruce.richardson@intel.com, Harry van Haaren <harry.van.haaren@intel.com>", "Subject": "[PATCH v2] service: split tests to perf and autotest to avoid\n spurious CI failures", "Date": "Fri, 3 Mar 2023 13:00:06 +0000", "Message-Id": "<20230303130006.831257-1-harry.van.haaren@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230224173637.243266-1-harry.van.haaren@intel.com>", "References": "<20230224173637.243266-1-harry.van.haaren@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "On some CI runs, some service-cores tests spuriously fail as the\nservice lcore thread is not actually scheduled by the OS in the\ngiven amount of time.\n\nIncreasing timeouts has not resolved the issue in the CI, so the\nsolution in this patch is to move them to a separate perf test\nsuite.\n\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\n\n---\n\nv2:\n- Add \"performance\" to suite name (David)\n- Remove comment above perf-test suite (David)\n\nSee DPDK ML discussion in this thread:\nhttp://mails.dpdk.org/archives/dev/2023-February/263523.html\n---\n app/test/meson.build | 1 +\n app/test/test_service_cores.c | 27 ++++++++++++++++++++++-----\n 2 files changed, 23 insertions(+), 5 deletions(-)", "diff": "diff --git a/app/test/meson.build b/app/test/meson.build\nindex f34d19e3c3..2db5ccf4ff 100644\n--- a/app/test/meson.build\n+++ b/app/test/meson.build\n@@ -287,6 +287,7 @@ perf_test_names = [\n 'pie_perf',\n 'distributor_perf_autotest',\n 'pmd_perf_autotest',\n+ 'service_perf_autotest',\n 'stack_perf_autotest',\n 'stack_lf_perf_autotest',\n 'rand_perf_autotest',\ndiff --git a/app/test/test_service_cores.c b/app/test/test_service_cores.c\nindex 637fcd7cf9..c8b6a27c69 100644\n--- a/app/test/test_service_cores.c\n+++ b/app/test/test_service_cores.c\n@@ -1022,17 +1022,12 @@ static struct unit_test_suite service_tests = {\n \t\tTEST_CASE_ST(dummy_register, NULL, service_name),\n \t\tTEST_CASE_ST(dummy_register, NULL, service_get_by_name),\n \t\tTEST_CASE_ST(dummy_register, NULL, service_dump),\n-\t\tTEST_CASE_ST(dummy_register, NULL, service_attr_get),\n-\t\tTEST_CASE_ST(dummy_register, NULL, service_lcore_attr_get),\n \t\tTEST_CASE_ST(dummy_register, NULL, service_probe_capability),\n \t\tTEST_CASE_ST(dummy_register, NULL, service_start_stop),\n \t\tTEST_CASE_ST(dummy_register, NULL, service_lcore_add_del),\n-\t\tTEST_CASE_ST(dummy_register, NULL, service_lcore_start_stop),\n \t\tTEST_CASE_ST(dummy_register, NULL, service_lcore_en_dis_able),\n \t\tTEST_CASE_ST(dummy_register, NULL, service_mt_unsafe_poll),\n \t\tTEST_CASE_ST(dummy_register, NULL, service_mt_safe_poll),\n-\t\tTEST_CASE_ST(dummy_register, NULL, service_app_lcore_mt_safe),\n-\t\tTEST_CASE_ST(dummy_register, NULL, service_app_lcore_mt_unsafe),\n \t\tTEST_CASE_ST(dummy_register, NULL, service_may_be_active),\n \t\tTEST_CASE_ST(dummy_register, NULL, service_active_two_cores),\n \t\tTEST_CASES_END() /**< NULL terminate unit test array */\n@@ -1046,3 +1041,25 @@ test_service_common(void)\n }\n \n REGISTER_TEST_COMMAND(service_autotest, test_service_common);\n+\n+static struct unit_test_suite service_perf_tests = {\n+\t.suite_name = \"service core performance test suite\",\n+\t.setup = testsuite_setup,\n+\t.teardown = testsuite_teardown,\n+\t.unit_test_cases = {\n+\t\tTEST_CASE_ST(dummy_register, NULL, service_attr_get),\n+\t\tTEST_CASE_ST(dummy_register, NULL, service_lcore_attr_get),\n+\t\tTEST_CASE_ST(dummy_register, NULL, service_lcore_start_stop),\n+\t\tTEST_CASE_ST(dummy_register, NULL, service_app_lcore_mt_safe),\n+\t\tTEST_CASE_ST(dummy_register, NULL, service_app_lcore_mt_unsafe),\n+\t\tTEST_CASES_END() /**< NULL terminate unit test array */\n+\t}\n+};\n+\n+static int\n+test_service_perf(void)\n+{\n+\treturn unit_test_suite_runner(&service_perf_tests);\n+}\n+\n+REGISTER_TEST_COMMAND(service_perf_autotest, test_service_perf);\n", "prefixes": [ "v2" ] }