Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/124751/?format=api
{ "id": 124751, "url": "http://patches.dpdk.org/api/patches/124751/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230302202211.170017-15-hernan.vargas@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230302202211.170017-15-hernan.vargas@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230302202211.170017-15-hernan.vargas@intel.com", "date": "2023-03-02T20:22:08", "name": "[v3,14/17] test/bbdev: remove iteration count check", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3c670fe2a82c89c3b0bb4b77415ca6e5a5c4acc5", "submitter": { "id": 2659, "url": "http://patches.dpdk.org/api/people/2659/?format=api", "name": "Hernan Vargas", "email": "hernan.vargas@intel.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230302202211.170017-15-hernan.vargas@intel.com/mbox/", "series": [ { "id": 27233, "url": "http://patches.dpdk.org/api/series/27233/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27233", "date": "2023-03-02T20:21:54", "name": "test/bbdev: changes for 23.03", "version": 3, "mbox": "http://patches.dpdk.org/series/27233/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/124751/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/124751/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9AFFC41DB8;\n\tThu, 2 Mar 2023 21:23:37 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4976842D63;\n\tThu, 2 Mar 2023 21:22:15 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by mails.dpdk.org (Postfix) with ESMTP id 3968742D33\n for <dev@dpdk.org>; Thu, 2 Mar 2023 21:22:06 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 02 Mar 2023 12:22:05 -0800", "from unknown (HELO csl-npg-qt0.la.intel.com) ([10.233.181.103])\n by orsmga008.jf.intel.com with ESMTP; 02 Mar 2023 12:22:05 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1677788526; x=1709324526;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=p8ENaeeRE0HqMWbEYSs3ihOj54vg71NUCVc6wydhFZI=;\n b=mTeSv9jSIutMdmaNTf5l+yHPePiw+krowc5kcqgRZE8DezzaVfGEJDNa\n eu1wAF1h18ZzoKcA9iBXCdzVqdvk8M7/cIdHUCtUWbA6i6RCoF8KjWE1A\n zvsYSI6ZlWUdpCR/b7zGq12OhM49ZusAMqDuqFZHONTIX2PXru5GCAPWv\n XAbw65XQmEaGIaQFRVEK7ZyFDJ6GQOAzLanooKEZCY9B8bUP0sNNdozoa\n J0rblXOoZKaaILlu796RHNfFj7ch1QB6/ChpMGucyhlN7jzw8duhuFSRU\n jGftqRqIfLZQp5cYFpz5Cs8SCVB4xbOZzJu9Nr+VHMYC2GFSZn/oOHoOA A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10637\"; a=\"334871227\"", "E=Sophos;i=\"5.98,228,1673942400\"; d=\"scan'208\";a=\"334871227\"", "E=McAfee;i=\"6500,9779,10637\"; a=\"705398133\"", "E=Sophos;i=\"5.98,228,1673942400\"; d=\"scan'208\";a=\"705398133\"" ], "X-ExtLoop1": "1", "From": "Hernan Vargas <hernan.vargas@intel.com>", "To": "dev@dpdk.org, gakhil@marvell.com, trix@redhat.com,\n maxime.coquelin@redhat.com", "Cc": "nicolas.chautru@intel.com, qi.z.zhang@intel.com,\n Hernan Vargas <hernan.vargas@intel.com>", "Subject": "[PATCH v3 14/17] test/bbdev: remove iteration count check", "Date": "Thu, 2 Mar 2023 12:22:08 -0800", "Message-Id": "<20230302202211.170017-15-hernan.vargas@intel.com>", "X-Mailer": "git-send-email 2.37.1", "In-Reply-To": "<20230302202211.170017-1-hernan.vargas@intel.com>", "References": "<20230302202211.170017-1-hernan.vargas@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "To make the test compatible with devices that do not support early\ntermination, the iteration count assert can be removed.\n\nSigned-off-by: Hernan Vargas <hernan.vargas@intel.com>\nReviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n app/test-bbdev/test_bbdev_perf.c | 24 ++++++++----------------\n 1 file changed, 8 insertions(+), 16 deletions(-)", "diff": "diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c\nindex 635c0a5eab48..da5c3a4bc9a7 100644\n--- a/app/test-bbdev/test_bbdev_perf.c\n+++ b/app/test-bbdev/test_bbdev_perf.c\n@@ -2300,7 +2300,7 @@ validate_op_so_chain(struct rte_bbdev_op_data *op,\n \n static int\n validate_dec_op(struct rte_bbdev_dec_op **ops, const uint16_t n,\n-\t\tstruct rte_bbdev_dec_op *ref_op, const int vector_mask)\n+\t\tstruct rte_bbdev_dec_op *ref_op)\n {\n \tunsigned int i;\n \tint ret;\n@@ -2311,17 +2311,12 @@ validate_dec_op(struct rte_bbdev_dec_op **ops, const uint16_t n,\n \tstruct rte_bbdev_op_turbo_dec *ops_td;\n \tstruct rte_bbdev_op_data *hard_output;\n \tstruct rte_bbdev_op_data *soft_output;\n-\tstruct rte_bbdev_op_turbo_dec *ref_td = &ref_op->turbo_dec;\n \n \tfor (i = 0; i < n; ++i) {\n \t\tops_td = &ops[i]->turbo_dec;\n \t\thard_output = &ops_td->hard_output;\n \t\tsoft_output = &ops_td->soft_output;\n \n-\t\tif (vector_mask & TEST_BBDEV_VF_EXPECTED_ITER_COUNT)\n-\t\t\tTEST_ASSERT(ops_td->iter_count <= ref_td->iter_count,\n-\t\t\t\t\t\"Returned iter_count (%d) > expected iter_count (%d)\",\n-\t\t\t\t\tops_td->iter_count, ref_td->iter_count);\n \t\tret = check_dec_status_and_ordering(ops[i], i, ref_op->status);\n \t\tTEST_ASSERT_SUCCESS(ret,\n \t\t\t\t\"Checking status and ordering for decoder failed\");\n@@ -3070,8 +3065,7 @@ dequeue_event_callback(uint16_t dev_id,\n \n \tif (test_vector.op_type == RTE_BBDEV_OP_TURBO_DEC) {\n \t\tstruct rte_bbdev_dec_op *ref_op = tp->op_params->ref_dec_op;\n-\t\tret = validate_dec_op(tp->dec_ops, num_ops, ref_op,\n-\t\t\t\ttp->op_params->vector_mask);\n+\t\tret = validate_dec_op(tp->dec_ops, num_ops, ref_op);\n \t\t/* get the max of iter_count for all dequeued ops */\n \t\tfor (i = 0; i < num_ops; ++i)\n \t\t\ttp->iter_count = RTE_MAX(\n@@ -3683,8 +3677,7 @@ throughput_pmd_lcore_dec(void *arg)\n \t}\n \n \tif (test_vector.op_type != RTE_BBDEV_OP_NONE) {\n-\t\tret = validate_dec_op(ops_deq, num_ops, ref_op,\n-\t\t\t\ttp->op_params->vector_mask);\n+\t\tret = validate_dec_op(ops_deq, num_ops, ref_op);\n \t\tTEST_ASSERT_SUCCESS(ret, \"Validation failed!\");\n \t}\n \n@@ -4743,7 +4736,7 @@ throughput_test(struct active_device *ad,\n static int\n latency_test_dec(struct rte_mempool *mempool,\n \t\tstruct test_buffers *bufs, struct rte_bbdev_dec_op *ref_op,\n-\t\tint vector_mask, uint16_t dev_id, uint16_t queue_id,\n+\t\tuint16_t dev_id, uint16_t queue_id,\n \t\tconst uint16_t num_to_process, uint16_t burst_sz,\n \t\tuint64_t *total_time, uint64_t *min_time, uint64_t *max_time, bool disable_et)\n {\n@@ -4809,8 +4802,7 @@ latency_test_dec(struct rte_mempool *mempool,\n \t\t*total_time += last_time;\n \n \t\tif (test_vector.op_type != RTE_BBDEV_OP_NONE) {\n-\t\t\tret = validate_dec_op(ops_deq, burst_sz, ref_op,\n-\t\t\t\t\tvector_mask);\n+\t\t\tret = validate_dec_op(ops_deq, burst_sz, ref_op);\n \t\t\tTEST_ASSERT_SUCCESS(ret, \"Validation failed!\");\n \t\t}\n \n@@ -5175,9 +5167,9 @@ validation_latency_test(struct active_device *ad,\n \n \tif (op_type == RTE_BBDEV_OP_TURBO_DEC)\n \t\titer = latency_test_dec(op_params->mp, bufs,\n-\t\t\t\top_params->ref_dec_op, op_params->vector_mask,\n-\t\t\t\tad->dev_id, queue_id, num_to_process,\n-\t\t\t\tburst_sz, &total_time, &min_time, &max_time, latency_flag);\n+\t\t\t\top_params->ref_dec_op, ad->dev_id, queue_id,\n+\t\t\t\tnum_to_process, burst_sz, &total_time,\n+\t\t\t\t&min_time, &max_time, latency_flag);\n \telse if (op_type == RTE_BBDEV_OP_LDPC_ENC)\n \t\titer = latency_test_ldpc_enc(op_params->mp, bufs,\n \t\t\t\top_params->ref_enc_op, ad->dev_id, queue_id,\n", "prefixes": [ "v3", "14/17" ] }