Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/124626/?format=api
{ "id": 124626, "url": "http://patches.dpdk.org/api/patches/124626/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1677718068-2412-6-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1677718068-2412-6-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1677718068-2412-6-git-send-email-roretzla@linux.microsoft.com", "date": "2023-03-02T00:47:36", "name": "[05/17] distributor: use previous value atomic fetch operations", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e83d123544e2a261867465f8527808d4b093371a", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1677718068-2412-6-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 27214, "url": "http://patches.dpdk.org/api/series/27214/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27214", "date": "2023-03-02T00:47:32", "name": "use __atomic operations returning previous value", "version": 1, "mbox": "http://patches.dpdk.org/series/27214/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/124626/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/124626/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A10F941DAF;\n\tThu, 2 Mar 2023 01:48:41 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0BA7942D0B;\n\tThu, 2 Mar 2023 01:48:11 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 6C64F40DFB\n for <dev@dpdk.org>; Thu, 2 Mar 2023 01:48:03 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 28A8020B9C3E; Wed, 1 Mar 2023 16:48:01 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 28A8020B9C3E", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1677718082;\n bh=AqnZY5l2+yPYsMACL2klO8iL2TX6L2qcZhv5Uj7ufd4=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=roW5W0Ul/WWtJh1wg+cq9M4B9z7kA1A26EbqHbvCuqhv9OQ0Eadhh9LmHstWIoWb6\n UTsKKb43fWLK9RHNa6CYQzbCaAmRycFOcuC9R00x8B9zkkgYb1VhyrWTSCrH90rvkW\n XWZBkYRX1DbxaI+UzgUJf8L2HDpAHkFUH7pr5jfU=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Honnappa.Nagarahalli@arm.com, thomas@monjalon.net,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH 05/17] distributor: use previous value atomic fetch operations", "Date": "Wed, 1 Mar 2023 16:47:36 -0800", "Message-Id": "<1677718068-2412-6-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1677718068-2412-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1677718068-2412-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Use __atomic_fetch_{add,and,or,sub,xor} instead of\n__atomic_{add,and,or,sub,xor}_fetch when we have no interest in the\nresult of the operation.\n\nReduces unnecessary codegen that provided the result of the atomic\noperation that was not used.\n\nChange brings closer alignment with atomics available in C11 standard\nand will reduce review effort when they are integrated.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/distributor/rte_distributor.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/lib/distributor/rte_distributor.c b/lib/distributor/rte_distributor.c\nindex 3969b2e..68840ce 100644\n--- a/lib/distributor/rte_distributor.c\n+++ b/lib/distributor/rte_distributor.c\n@@ -200,7 +200,7 @@\n \t * we won't read any mbufs from there even if GET_BUF is set.\n \t * This allows distributor to retrieve in-flight already sent packets.\n \t */\n-\t__atomic_or_fetch(&(buf->bufptr64[0]), RTE_DISTRIB_RETURN_BUF,\n+\t__atomic_fetch_or(&(buf->bufptr64[0]), RTE_DISTRIB_RETURN_BUF,\n \t\t__ATOMIC_ACQ_REL);\n \n \t/* set the RETURN_BUF on retptr64 even if we got no returns.\n", "prefixes": [ "05/17" ] }