Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/124542/?format=api
{ "id": 124542, "url": "http://patches.dpdk.org/api/patches/124542/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230224173637.243266-1-harry.van.haaren@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230224173637.243266-1-harry.van.haaren@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230224173637.243266-1-harry.van.haaren@intel.com", "date": "2023-02-24T17:36:37", "name": "service: split tests to perf and autotest to avoid spurious CI failures", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ad3dd435c9499a4c610c7f4c981fd740b31265dc", "submitter": { "id": 317, "url": "http://patches.dpdk.org/api/people/317/?format=api", "name": "Van Haaren, Harry", "email": "harry.van.haaren@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230224173637.243266-1-harry.van.haaren@intel.com/mbox/", "series": [ { "id": 27174, "url": "http://patches.dpdk.org/api/series/27174/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27174", "date": "2023-02-24T17:36:37", "name": "service: split tests to perf and autotest to avoid spurious CI failures", "version": 1, "mbox": "http://patches.dpdk.org/series/27174/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/124542/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/124542/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 28F1B41D64;\n\tFri, 24 Feb 2023 19:04:01 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C900340A87;\n\tFri, 24 Feb 2023 19:04:00 +0100 (CET)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by mails.dpdk.org (Postfix) with ESMTP id F1B2E40697;\n Fri, 24 Feb 2023 19:03:58 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 24 Feb 2023 10:03:57 -0800", "from silpixa00401454.ir.intel.com ([10.55.128.122])\n by orsmga008.jf.intel.com with ESMTP; 24 Feb 2023 09:36:42 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1677261839; x=1708797839;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=fuBJ3BmwuYv1ntn4nhCXVHPVNBD1+/KG8cnAv+qN9f0=;\n b=LLRIrZ6KVb0jt/ZlJ2r7Wot6PbLvPFObIqMRwvfFgryalfDqs9uCToSs\n fN629Th/XEbrUqOudwO3zytTe1oHJ9IJDojRoeVn4/gE9h8NU+edJzuy5\n LtiHF0OV4M/yV9B3LBIhHZQjqG0vTqkuYGAJmxWESzrg8H3KAvANyUzWX\n aLFft+tsAKTL55FSRB696Gu9gOqIRyApYt5I/BsdpPLE5ONFmJKo4rYKG\n KRSZDzG8hXCsTCTP2Y0OtPV6nsZNlwCzbXQxHnEuI6jCtnGWmaxP83Qx7\n T5BKWRFnnr4FuioeR7zFBBeDfsXVgfoMHNKciSy5XGcqTBZd439p42PtI A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10631\"; a=\"332227838\"", "E=Sophos;i=\"5.97,325,1669104000\"; d=\"scan'208\";a=\"332227838\"", "E=McAfee;i=\"6500,9779,10631\"; a=\"703257874\"", "E=Sophos;i=\"5.97,325,1669104000\"; d=\"scan'208\";a=\"703257874\"" ], "X-ExtLoop1": "1", "From": "Harry van Haaren <harry.van.haaren@intel.com>", "To": "dev@dpdk.org", "Cc": "david.marchand@redhat.com, dpdklab@iol.unh.edu, ci@dpdk.org,\n Honnappa.Nagarahalli@arm.com, mattias.ronnblom@ericsson.com,\n mb@smartsharesystems.com, roretzla@linux.microsoft.com, aconole@redhat.com,\n bruce.richardson@intel.com, Harry van Haaren <harry.van.haaren@intel.com>", "Subject": "[PATCH] service: split tests to perf and autotest to avoid spurious\n CI failures", "Date": "Fri, 24 Feb 2023 17:36:37 +0000", "Message-Id": "<20230224173637.243266-1-harry.van.haaren@intel.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "On some CI runs, some service-cores tests spuriously fail as the\nservice lcore thread is not actually scheduled by the OS in the\ngiven amount of time.\n\nIncreasing timeouts has not resolved the issue in the CI, so the\nsolution in this patch is to move them to a separate perf test\nsuite.\n\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\n\n---\n\nSee DPDK ML discussion in this thread:\nhttp://mails.dpdk.org/archives/dev/2023-February/263523.html\n---\n app/test/meson.build | 1 +\n app/test/test_service_cores.c | 32 +++++++++++++++++++++++++++-----\n 2 files changed, 28 insertions(+), 5 deletions(-)", "diff": "diff --git a/app/test/meson.build b/app/test/meson.build\nindex f34d19e3c3..2db5ccf4ff 100644\n--- a/app/test/meson.build\n+++ b/app/test/meson.build\n@@ -287,6 +287,7 @@ perf_test_names = [\n 'pie_perf',\n 'distributor_perf_autotest',\n 'pmd_perf_autotest',\n+ 'service_perf_autotest',\n 'stack_perf_autotest',\n 'stack_lf_perf_autotest',\n 'rand_perf_autotest',\ndiff --git a/app/test/test_service_cores.c b/app/test/test_service_cores.c\nindex 637fcd7cf9..06653dfdef 100644\n--- a/app/test/test_service_cores.c\n+++ b/app/test/test_service_cores.c\n@@ -1022,17 +1022,12 @@ static struct unit_test_suite service_tests = {\n \t\tTEST_CASE_ST(dummy_register, NULL, service_name),\n \t\tTEST_CASE_ST(dummy_register, NULL, service_get_by_name),\n \t\tTEST_CASE_ST(dummy_register, NULL, service_dump),\n-\t\tTEST_CASE_ST(dummy_register, NULL, service_attr_get),\n-\t\tTEST_CASE_ST(dummy_register, NULL, service_lcore_attr_get),\n \t\tTEST_CASE_ST(dummy_register, NULL, service_probe_capability),\n \t\tTEST_CASE_ST(dummy_register, NULL, service_start_stop),\n \t\tTEST_CASE_ST(dummy_register, NULL, service_lcore_add_del),\n-\t\tTEST_CASE_ST(dummy_register, NULL, service_lcore_start_stop),\n \t\tTEST_CASE_ST(dummy_register, NULL, service_lcore_en_dis_able),\n \t\tTEST_CASE_ST(dummy_register, NULL, service_mt_unsafe_poll),\n \t\tTEST_CASE_ST(dummy_register, NULL, service_mt_safe_poll),\n-\t\tTEST_CASE_ST(dummy_register, NULL, service_app_lcore_mt_safe),\n-\t\tTEST_CASE_ST(dummy_register, NULL, service_app_lcore_mt_unsafe),\n \t\tTEST_CASE_ST(dummy_register, NULL, service_may_be_active),\n \t\tTEST_CASE_ST(dummy_register, NULL, service_active_two_cores),\n \t\tTEST_CASES_END() /**< NULL terminate unit test array */\n@@ -1046,3 +1041,30 @@ test_service_common(void)\n }\n \n REGISTER_TEST_COMMAND(service_autotest, test_service_common);\n+\n+\n+/* The tests below have been split from the auto-test suite, as the\n+ * when they are run in a cloud CI environment they can give false-positive\n+ * errors, due to the service-cores not being scheduled by the OS.\n+ */\n+static struct unit_test_suite service_perf_tests = {\n+\t.suite_name = \"service core test suite\",\n+\t.setup = testsuite_setup,\n+\t.teardown = testsuite_teardown,\n+\t.unit_test_cases = {\n+\t\tTEST_CASE_ST(dummy_register, NULL, service_attr_get),\n+\t\tTEST_CASE_ST(dummy_register, NULL, service_lcore_attr_get),\n+\t\tTEST_CASE_ST(dummy_register, NULL, service_lcore_start_stop),\n+\t\tTEST_CASE_ST(dummy_register, NULL, service_app_lcore_mt_safe),\n+\t\tTEST_CASE_ST(dummy_register, NULL, service_app_lcore_mt_unsafe),\n+\t\tTEST_CASES_END() /**< NULL terminate unit test array */\n+\t}\n+};\n+\n+static int\n+test_service_perf(void)\n+{\n+\treturn unit_test_suite_runner(&service_perf_tests);\n+}\n+\n+REGISTER_TEST_COMMAND(service_perf_autotest, test_service_perf);\n", "prefixes": [] }