Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/124503/?format=api
{ "id": 124503, "url": "http://patches.dpdk.org/api/patches/124503/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230224081642.2566619-14-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230224081642.2566619-14-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230224081642.2566619-14-david.marchand@redhat.com", "date": "2023-02-24T08:16:41", "name": "[13/14] vdpa/sfc: inherit lock annotations", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f280e02a1e6a58a3208f1ccaadba51d479de2ab2", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230224081642.2566619-14-david.marchand@redhat.com/mbox/", "series": [ { "id": 27167, "url": "http://patches.dpdk.org/api/series/27167/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27167", "date": "2023-02-24T08:16:28", "name": "Enable lock annotations on most libraries and drivers", "version": 1, "mbox": "http://patches.dpdk.org/series/27167/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/124503/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/124503/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AB2CF41D5D;\n\tFri, 24 Feb 2023 09:18:16 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C9DFF42D3D;\n\tFri, 24 Feb 2023 09:17:35 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id 7769D42D1D\n for <dev@dpdk.org>; Fri, 24 Feb 2023 09:17:34 +0100 (CET)", "from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com\n [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-586-9GK8Mw8WNKGoWvEdgLZkOA-1; Fri, 24 Feb 2023 03:17:30 -0500", "from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com\n [10.11.54.4])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 125C438041D0;\n Fri, 24 Feb 2023 08:17:30 +0000 (UTC)", "from dmarchan.redhat.com (unknown [10.45.224.55])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 4A59A2026D4B;\n Fri, 24 Feb 2023 08:17:29 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1677226654;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=xCxK/xLB+oxeBoLgNQJynT94ZXelKq+BK0zch25nYyc=;\n b=bQ4XUZbx1qN1EdaGqbdnNSw0VTArbfF7BADFkhFsXtkxKiQBzJJRLtWRYbwUhGkM27hyHK\n su+UI5UvqocGrg5z8K2k53uj6EPWRKYTVBGaaqFh1ou/lqg45LcCgNOWCQOE174yrz82c/\n js/5tyOcEKJs0R5jK/+go2YnMoes9co=", "X-MC-Unique": "9GK8Mw8WNKGoWvEdgLZkOA-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net,\n\tVijay Kumar Srivastava <vsrivast@xilinx.com>", "Subject": "[PATCH 13/14] vdpa/sfc: inherit lock annotations", "Date": "Fri, 24 Feb 2023 09:16:41 +0100", "Message-Id": "<20230224081642.2566619-14-david.marchand@redhat.com>", "In-Reply-To": "<20230224081642.2566619-1-david.marchand@redhat.com>", "References": "<20230224081642.2566619-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Due to clang limitation, inline helpers don't inherit lock annotations\nfrom the EAL lock API.\nReplace them with macros.\n\nsfc_vdpa_ops.c was relying on an implicit cast of the dev_handle to a\nvdpa adapter object. Add an explicit conversion.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n drivers/vdpa/sfc/sfc_vdpa.h | 41 +++++----------------------------\n drivers/vdpa/sfc/sfc_vdpa_ops.c | 14 +++++------\n 2 files changed, 13 insertions(+), 42 deletions(-)", "diff": "diff --git a/drivers/vdpa/sfc/sfc_vdpa.h b/drivers/vdpa/sfc/sfc_vdpa.h\nindex b25eb3a5fe..2b843e563d 100644\n--- a/drivers/vdpa/sfc/sfc_vdpa.h\n+++ b/drivers/vdpa/sfc/sfc_vdpa.h\n@@ -122,40 +122,11 @@ sfc_vdpa_adapter_by_dev_handle(void *dev_handle)\n * Add wrapper functions to acquire/release lock to be able to remove or\n * change the lock in one place.\n */\n-static inline void\n-sfc_vdpa_adapter_lock_init(struct sfc_vdpa_adapter *sva)\n-{\n-\trte_spinlock_init(&sva->lock);\n-}\n-\n-static inline int\n-sfc_vdpa_adapter_is_locked(struct sfc_vdpa_adapter *sva)\n-{\n-\treturn rte_spinlock_is_locked(&sva->lock);\n-}\n-\n-static inline void\n-sfc_vdpa_adapter_lock(struct sfc_vdpa_adapter *sva)\n-{\n-\trte_spinlock_lock(&sva->lock);\n-}\n-\n-static inline int\n-sfc_vdpa_adapter_trylock(struct sfc_vdpa_adapter *sva)\n-{\n-\treturn rte_spinlock_trylock(&sva->lock);\n-}\n-\n-static inline void\n-sfc_vdpa_adapter_unlock(struct sfc_vdpa_adapter *sva)\n-{\n-\trte_spinlock_unlock(&sva->lock);\n-}\n-\n-static inline void\n-sfc_vdpa_adapter_lock_fini(__rte_unused struct sfc_vdpa_adapter *sva)\n-{\n-\t/* Just for symmetry of the API */\n-}\n+#define sfc_vdpa_adapter_lock_init(sva) rte_spinlock_init(&(sva)->lock)\n+#define sfc_vdpa_adapter_is_locked(sva) rte_spinlock_is_locked(&(sva)->lock)\n+#define sfc_vdpa_adapter_lock(sva) rte_spinlock_lock(&(sva)->lock)\n+#define sfc_vdpa_adapter_trylock(sva) rte_spinlock_trylock(&(sva)->lock)\n+#define sfc_vdpa_adapter_unlock(sva) rte_spinlock_unlock(&(sva)->lock)\n+#define sfc_vdpa_adapter_lock_fini(sva) RTE_SET_USED(sva)\n \n #endif /* _SFC_VDPA_H */\ndiff --git a/drivers/vdpa/sfc/sfc_vdpa_ops.c b/drivers/vdpa/sfc/sfc_vdpa_ops.c\nindex 6401d4e16f..afa6b7e8ef 100644\n--- a/drivers/vdpa/sfc/sfc_vdpa_ops.c\n+++ b/drivers/vdpa/sfc/sfc_vdpa_ops.c\n@@ -577,7 +577,7 @@ sfc_vdpa_notify_ctrl(void *arg)\n \tif (ops_data == NULL)\n \t\treturn NULL;\n \n-\tsfc_vdpa_adapter_lock(ops_data->dev_handle);\n+\tsfc_vdpa_adapter_lock(sfc_vdpa_adapter_by_dev_handle(ops_data->dev_handle));\n \n \tvid = ops_data->vid;\n \n@@ -586,7 +586,7 @@ sfc_vdpa_notify_ctrl(void *arg)\n \t\t\t \"vDPA (%s): Notifier could not get configured\",\n \t\t\t ops_data->vdpa_dev->device->name);\n \n-\tsfc_vdpa_adapter_unlock(ops_data->dev_handle);\n+\tsfc_vdpa_adapter_unlock(sfc_vdpa_adapter_by_dev_handle(ops_data->dev_handle));\n \n \treturn NULL;\n }\n@@ -637,7 +637,7 @@ sfc_vdpa_dev_config(int vid)\n \n \tops_data->vid = vid;\n \n-\tsfc_vdpa_adapter_lock(ops_data->dev_handle);\n+\tsfc_vdpa_adapter_lock(sfc_vdpa_adapter_by_dev_handle(ops_data->dev_handle));\n \n \tsfc_vdpa_log_init(ops_data->dev_handle, \"configuring\");\n \trc = sfc_vdpa_configure(ops_data);\n@@ -653,7 +653,7 @@ sfc_vdpa_dev_config(int vid)\n \tif (rc != 0)\n \t\tgoto fail_vdpa_notify;\n \n-\tsfc_vdpa_adapter_unlock(ops_data->dev_handle);\n+\tsfc_vdpa_adapter_unlock(sfc_vdpa_adapter_by_dev_handle(ops_data->dev_handle));\n \n \tsfc_vdpa_log_init(ops_data->dev_handle, \"done\");\n \n@@ -666,7 +666,7 @@ sfc_vdpa_dev_config(int vid)\n \tsfc_vdpa_close(ops_data);\n \n fail_vdpa_config:\n-\tsfc_vdpa_adapter_unlock(ops_data->dev_handle);\n+\tsfc_vdpa_adapter_unlock(sfc_vdpa_adapter_by_dev_handle(ops_data->dev_handle));\n \n \treturn -1;\n }\n@@ -688,7 +688,7 @@ sfc_vdpa_dev_close(int vid)\n \t\treturn -1;\n \t}\n \n-\tsfc_vdpa_adapter_lock(ops_data->dev_handle);\n+\tsfc_vdpa_adapter_lock(sfc_vdpa_adapter_by_dev_handle(ops_data->dev_handle));\n \tif (ops_data->is_notify_thread_started == true) {\n \t\tvoid *status;\n \t\tret = pthread_cancel(ops_data->notify_tid);\n@@ -710,7 +710,7 @@ sfc_vdpa_dev_close(int vid)\n \tsfc_vdpa_stop(ops_data);\n \tsfc_vdpa_close(ops_data);\n \n-\tsfc_vdpa_adapter_unlock(ops_data->dev_handle);\n+\tsfc_vdpa_adapter_unlock(sfc_vdpa_adapter_by_dev_handle(ops_data->dev_handle));\n \n \treturn 0;\n }\n", "prefixes": [ "13/14" ] }