Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/124064/?format=api
{ "id": 124064, "url": "http://patches.dpdk.org/api/patches/124064/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230216110919.373385-4-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230216110919.373385-4-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230216110919.373385-4-bruce.richardson@intel.com", "date": "2023-02-16T11:09:16", "name": "[v3,3/6] dma/ioat: fix incorrect error reporting on restart", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f37c7da3f5e4f13a0b0b1f77e21c22294ce139a0", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230216110919.373385-4-bruce.richardson@intel.com/mbox/", "series": [ { "id": 27043, "url": "http://patches.dpdk.org/api/series/27043/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27043", "date": "2023-02-16T11:09:13", "name": "dma/ioat: fix issues with stopping and restarting device", "version": 3, "mbox": "http://patches.dpdk.org/series/27043/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/124064/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/124064/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AFB0941CB1;\n\tThu, 16 Feb 2023 12:09:50 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3D85D42D31;\n\tThu, 16 Feb 2023 12:09:39 +0100 (CET)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by mails.dpdk.org (Postfix) with ESMTP id 7FB4B40E0F;\n Thu, 16 Feb 2023 12:09:37 +0100 (CET)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 Feb 2023 03:09:37 -0800", "from silpixa00401385.ir.intel.com ([10.237.214.22])\n by orsmga001.jf.intel.com with ESMTP; 16 Feb 2023 03:09:35 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1676545777; x=1708081777;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=dMoWY5wrq3Ago+KRNoPAWQZDtZIlccwlIsaL57iVgnY=;\n b=Ffd0qc7uFs+r5JrXjUbD4BJRYckszqNP4zwOXNfWPksQqkIkQkmjPMU2\n Dez6i1cjGR+9K2v5eOp7R9KheAuyhhPF3Bfmut3m556UZloKRHZMkfCEV\n VCce8lIAdxxEmpBZwuJx1VwxL6kgC2+CBbHNnZvRTT1y9ixmuWBfRh7Cl\n LxBCg8LH0j38VoM/YoetCYOXYz2fPx7tIfJKtCalx3nBVkCUtg6IzkaFN\n 80DXHK0vWfY/bKgf8LAR+ufC4pbUygYM0QjYr+vtQwPrcoZonN9NubqIe\n ROFj15BMLffAbrj0w6f9SdFSG5+VBdYNsrWFCcP+9Ojfj0Zr4DwsM7rVs A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10622\"; a=\"315368164\"", "E=Sophos;i=\"5.97,302,1669104000\"; d=\"scan'208\";a=\"315368164\"", "E=McAfee;i=\"6500,9779,10622\"; a=\"702522830\"", "E=Sophos;i=\"5.97,302,1669104000\"; d=\"scan'208\";a=\"702522830\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "fengchengwen@huawei.com, Bruce Richardson <bruce.richardson@intel.com>,\n conor.walsh@intel.com, stable@dpdk.org, Kevin Laatz <kevin.laatz@intel.com>", "Subject": "[PATCH v3 3/6] dma/ioat: fix incorrect error reporting on restart", "Date": "Thu, 16 Feb 2023 11:09:16 +0000", "Message-Id": "<20230216110919.373385-4-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.37.2", "In-Reply-To": "<20230216110919.373385-1-bruce.richardson@intel.com>", "References": "<20230116153714.554470-1-bruce.richardson@intel.com>\n <20230216110919.373385-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When the DMA device was stopped and restarted by the driver, the control\nregister specifying the behaviour on error was not getting correctly\nreset. This caused unit tests to fail as explicitly introduced errors\nwere got getting reported back.\n\nFix by moving the setting of the register to the start function from the\nprobe function.\n\nFixes: 583f046dd404 (\"dma/ioat: add start and stop\")\nCc: conor.walsh@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nReviewed-by: Conor Walsh <conor.walsh@intel.com>\nAcked-by: Kevin Laatz <kevin.laatz@intel.com>\n---\n drivers/dma/ioat/ioat_dmadev.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/dma/ioat/ioat_dmadev.c b/drivers/dma/ioat/ioat_dmadev.c\nindex 072eb17cd9..57c18c081d 100644\n--- a/drivers/dma/ioat/ioat_dmadev.c\n+++ b/drivers/dma/ioat/ioat_dmadev.c\n@@ -142,6 +142,9 @@ ioat_dev_start(struct rte_dma_dev *dev)\n \tioat->regs->chainaddr = ioat->ring_addr;\n \t/* Inform hardware of where to write the status/completions. */\n \tioat->regs->chancmp = ioat->status_addr;\n+\t/* Ensure channel control is set to abort on error, so we get status writeback. */\n+\tioat->regs->chanctrl = IOAT_CHANCTRL_ANY_ERR_ABORT_EN |\n+\t\t\tIOAT_CHANCTRL_ERR_COMPLETION_EN;\n \n \t/* Prime the status register to be set to the last element. */\n \tioat->status = ioat->ring_addr + ((ioat->qcfg.nb_desc - 1) * DESC_SZ);\n@@ -682,8 +685,6 @@ ioat_dmadev_create(const char *name, struct rte_pci_device *dev)\n \t\t\treturn -EIO;\n \t\t}\n \t}\n-\tioat->regs->chanctrl = IOAT_CHANCTRL_ANY_ERR_ABORT_EN |\n-\t\t\tIOAT_CHANCTRL_ERR_COMPLETION_EN;\n \n \tdmadev->fp_obj->dev_private = ioat;\n \n", "prefixes": [ "v3", "3/6" ] }