Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/123684/?format=api
{ "id": 123684, "url": "http://patches.dpdk.org/api/patches/123684/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230210151044.229324-1-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230210151044.229324-1-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230210151044.229324-1-maxime.coquelin@redhat.com", "date": "2023-02-10T15:10:44", "name": "net/virtio-user: fix number of vrings calculation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c619a6656bdb0ff63ab2c398f5035a3bbfa02db1", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230210151044.229324-1-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 26951, "url": "http://patches.dpdk.org/api/series/26951/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=26951", "date": "2023-02-10T15:10:44", "name": "net/virtio-user: fix number of vrings calculation", "version": 1, "mbox": "http://patches.dpdk.org/series/26951/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/123684/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/123684/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 35B0941C61;\n\tFri, 10 Feb 2023 16:10:52 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0F56B410D3;\n\tFri, 10 Feb 2023 16:10:52 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id 9345F410D0\n for <dev@dpdk.org>; Fri, 10 Feb 2023 16:10:50 +0100 (CET)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-480-kvD5LaLHNkOqcrkNZlR6Og-1; Fri, 10 Feb 2023 10:10:47 -0500", "from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com\n [10.11.54.5])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 474BB885622;\n Fri, 10 Feb 2023 15:10:47 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.39.208.22])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 0A061175AD;\n Fri, 10 Feb 2023 15:10:45 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1676041850;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=4IeFHnUxV7C4CJ2N2yz9vZCcuAnqdIWT4s5jgPohl+s=;\n b=jBipb5jqEHMhn041ApT+R78Os4LaBVSw7YmK6Cr2xxTNGorwJ7tGjNWmdVm2SKaEGffAkr\n 4GGCWNP0Tpblfpw5JYD/9VT2UW2GdLsPfC/31//fGHKU8xqqTnZbzUwZBOECJyNl2CZJpQ\n 6piF3RAoiC1lay8EhG1/z+AQJHTRO5I=", "X-MC-Unique": "kvD5LaLHNkOqcrkNZlR6Og-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, chenbo.xia@intel.com, david.marchand@redhat.com,\n eperezma@redhat.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Subject": "[PATCH] net/virtio-user: fix number of vrings calculation", "Date": "Fri, 10 Feb 2023 16:10:44 +0100", "Message-Id": "<20230210151044.229324-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.5", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When moving to dynamic allocation of vrings metadata, the\nnumber of vrings to allocate was incremented if the backend\nsupports control queue.\n\nThe problem is that the control queue metadata have to be\nallocated even if the backend does not use it directly,\nsince the control queue is managed by the Virtio-user layer\nas soon as multiqueue is negotiated..\n\nThis patch fixes this by incrementing the number of vrings\nas soon as the device features have VIRTIO_NET_F_MQ.\n\nFixes: d57c3a601e44 (\"net/virtio-user: remove max queues limitation\")\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n\nI plan to squash it with faulty commit in the Virtio branch\nsince it has not been pulled yet by Thomas once acked and\nif no objection.\n\n drivers/net/virtio/virtio_user/virtio_user_dev.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c\nindex cf58b63029..ccb4d7326b 100644\n--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c\n+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c\n@@ -575,7 +575,7 @@ virtio_user_alloc_vrings(struct virtio_user_dev *dev)\n \tbool packed_ring = !!(dev->device_features & (1ull << VIRTIO_F_RING_PACKED));\n \n \tnr_vrings = dev->max_queue_pairs * 2;\n-\tif (dev->hw_cvq)\n+\tif (dev->device_features & (1ull << VIRTIO_NET_F_MQ))\n \t\tnr_vrings++;\n \n \tdev->callfds = rte_zmalloc(\"virtio_user_dev\", nr_vrings * sizeof(*dev->callfds), 0);\n", "prefixes": [] }