Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/123028/?format=api
{ "id": 123028, "url": "http://patches.dpdk.org/api/patches/123028/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230203094340.8103-15-beilei.xing@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230203094340.8103-15-beilei.xing@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230203094340.8103-15-beilei.xing@intel.com", "date": "2023-02-03T09:43:35", "name": "[v6,14/19] common/idpf: add vec queue setup", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "88a1bf96deb56495b00521a54f4ff479e318355b", "submitter": { "id": 410, "url": "http://patches.dpdk.org/api/people/410/?format=api", "name": "Xing, Beilei", "email": "beilei.xing@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230203094340.8103-15-beilei.xing@intel.com/mbox/", "series": [ { "id": 26786, "url": "http://patches.dpdk.org/api/series/26786/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=26786", "date": "2023-02-03T09:43:21", "name": "net/idpf: introduce idpf common modle", "version": 6, "mbox": "http://patches.dpdk.org/series/26786/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/123028/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/123028/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2C64741BBB;\n\tFri, 3 Feb 2023 11:11:44 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1FB3542DBF;\n\tFri, 3 Feb 2023 11:10:42 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id CF80142D13\n for <dev@dpdk.org>; Fri, 3 Feb 2023 11:10:35 +0100 (CET)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 03 Feb 2023 02:10:34 -0800", "from dpdk-beileix-3.sh.intel.com ([10.67.110.253])\n by orsmga007.jf.intel.com with ESMTP; 03 Feb 2023 02:10:33 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1675419036; x=1706955036;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=5xc93LBcreQLjAPdAIUewBDyEsgjAj1cOKS/UfO5nRc=;\n b=TZzphPYkoJI/CAkroku9/1jFNtOV3fsjokGUcCCms35DY9CIs+wxH+XX\n /TcBfGKDRq8jTujsU3xClsOFKZtjADgVLtdLzaA8xX05GhSV2FYg4KP4G\n ifnP3RsVnAmP3sIoQWEEaEWLDByXCbPk8KA3XjCY7Onxb2QZ7asOWugMR\n FS4hn9CzNQLc3Gh1YsBKgRO86GAVUJ32dgGDW2NmdInjJeIyIbJlo+up3\n 6FEGE3Uz361YnyxpjDjAyM7bFMhjHE+S9WljI93jmuu1pEWA7QlBe45gV\n KU4M0+2QwChxRTXnK1vEdhdbqYc3Yz/FGJcdRrnroZ8vtgI6E7Bg70JWi Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10609\"; a=\"356052850\"", "E=Sophos;i=\"5.97,270,1669104000\"; d=\"scan'208\";a=\"356052850\"", "E=McAfee;i=\"6500,9779,10609\"; a=\"659047908\"", "E=Sophos;i=\"5.97,270,1669104000\"; d=\"scan'208\";a=\"659047908\"" ], "X-ExtLoop1": "1", "From": "beilei.xing@intel.com", "To": "jingjing.wu@intel.com", "Cc": "dev@dpdk.org,\n\tqi.z.zhang@intel.com,\n\tBeilei Xing <beilei.xing@intel.com>", "Subject": "[PATCH v6 14/19] common/idpf: add vec queue setup", "Date": "Fri, 3 Feb 2023 09:43:35 +0000", "Message-Id": "<20230203094340.8103-15-beilei.xing@intel.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20230203094340.8103-1-beilei.xing@intel.com>", "References": "<20230202095357.37929-1-beilei.xing@intel.com>\n <20230203094340.8103-1-beilei.xing@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Beilei Xing <beilei.xing@intel.com>\n\nMove vector queue setup for single queue model to common module.\n\nSigned-off-by: Beilei Xing <beilei.xing@intel.com>\n---\n drivers/common/idpf/idpf_common_rxtx.c | 57 ++++++++++++++++++++++++++\n drivers/common/idpf/idpf_common_rxtx.h | 2 +\n drivers/common/idpf/version.map | 1 +\n drivers/net/idpf/idpf_rxtx.c | 57 --------------------------\n drivers/net/idpf/idpf_rxtx.h | 1 -\n 5 files changed, 60 insertions(+), 58 deletions(-)", "diff": "diff --git a/drivers/common/idpf/idpf_common_rxtx.c b/drivers/common/idpf/idpf_common_rxtx.c\nindex 459057f20e..bc95fef6bc 100644\n--- a/drivers/common/idpf/idpf_common_rxtx.c\n+++ b/drivers/common/idpf/idpf_common_rxtx.c\n@@ -1399,3 +1399,60 @@ idpf_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts,\n \n \treturn i;\n }\n+\n+static void __rte_cold\n+release_rxq_mbufs_vec(struct idpf_rx_queue *rxq)\n+{\n+\tconst uint16_t mask = rxq->nb_rx_desc - 1;\n+\tuint16_t i;\n+\n+\tif (rxq->sw_ring == NULL || rxq->rxrearm_nb >= rxq->nb_rx_desc)\n+\t\treturn;\n+\n+\t/* free all mbufs that are valid in the ring */\n+\tif (rxq->rxrearm_nb == 0) {\n+\t\tfor (i = 0; i < rxq->nb_rx_desc; i++) {\n+\t\t\tif (rxq->sw_ring[i] != NULL)\n+\t\t\t\trte_pktmbuf_free_seg(rxq->sw_ring[i]);\n+\t\t}\n+\t} else {\n+\t\tfor (i = rxq->rx_tail; i != rxq->rxrearm_start; i = (i + 1) & mask) {\n+\t\t\tif (rxq->sw_ring[i] != NULL)\n+\t\t\t\trte_pktmbuf_free_seg(rxq->sw_ring[i]);\n+\t\t}\n+\t}\n+\n+\trxq->rxrearm_nb = rxq->nb_rx_desc;\n+\n+\t/* set all entries to NULL */\n+\tmemset(rxq->sw_ring, 0, sizeof(rxq->sw_ring[0]) * rxq->nb_rx_desc);\n+}\n+\n+static const struct idpf_rxq_ops def_singleq_rx_ops_vec = {\n+\t.release_mbufs = release_rxq_mbufs_vec,\n+};\n+\n+static inline int\n+idpf_singleq_rx_vec_setup_default(struct idpf_rx_queue *rxq)\n+{\n+\tuintptr_t p;\n+\tstruct rte_mbuf mb_def = { .buf_addr = 0 }; /* zeroed mbuf */\n+\n+\tmb_def.nb_segs = 1;\n+\tmb_def.data_off = RTE_PKTMBUF_HEADROOM;\n+\tmb_def.port = rxq->port_id;\n+\trte_mbuf_refcnt_set(&mb_def, 1);\n+\n+\t/* prevent compiler reordering: rearm_data covers previous fields */\n+\trte_compiler_barrier();\n+\tp = (uintptr_t)&mb_def.rearm_data;\n+\trxq->mbuf_initializer = *(uint64_t *)p;\n+\treturn 0;\n+}\n+\n+int __rte_cold\n+idpf_singleq_rx_vec_setup(struct idpf_rx_queue *rxq)\n+{\n+\trxq->ops = &def_singleq_rx_ops_vec;\n+\treturn idpf_singleq_rx_vec_setup_default(rxq);\n+}\ndiff --git a/drivers/common/idpf/idpf_common_rxtx.h b/drivers/common/idpf/idpf_common_rxtx.h\nindex 827f791505..74d6081638 100644\n--- a/drivers/common/idpf/idpf_common_rxtx.h\n+++ b/drivers/common/idpf/idpf_common_rxtx.h\n@@ -252,5 +252,7 @@ uint16_t idpf_singleq_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n __rte_internal\n uint16_t idpf_prep_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t\tuint16_t nb_pkts);\n+__rte_internal\n+int idpf_singleq_rx_vec_setup(struct idpf_rx_queue *rxq);\n \n #endif /* _IDPF_COMMON_RXTX_H_ */\ndiff --git a/drivers/common/idpf/version.map b/drivers/common/idpf/version.map\nindex 03aab598b4..511705e5b0 100644\n--- a/drivers/common/idpf/version.map\n+++ b/drivers/common/idpf/version.map\n@@ -25,6 +25,7 @@ INTERNAL {\n \tidpf_reset_split_tx_descq;\n \tidpf_rx_queue_release;\n \tidpf_singleq_recv_pkts;\n+\tidpf_singleq_rx_vec_setup;\n \tidpf_singleq_xmit_pkts;\n \tidpf_splitq_recv_pkts;\n \tidpf_splitq_xmit_pkts;\ndiff --git a/drivers/net/idpf/idpf_rxtx.c b/drivers/net/idpf/idpf_rxtx.c\nindex 1066789386..c0c622d64b 100644\n--- a/drivers/net/idpf/idpf_rxtx.c\n+++ b/drivers/net/idpf/idpf_rxtx.c\n@@ -743,63 +743,6 @@ idpf_stop_queues(struct rte_eth_dev *dev)\n \t}\n }\n \n-static void __rte_cold\n-release_rxq_mbufs_vec(struct idpf_rx_queue *rxq)\n-{\n-\tconst uint16_t mask = rxq->nb_rx_desc - 1;\n-\tuint16_t i;\n-\n-\tif (rxq->sw_ring == NULL || rxq->rxrearm_nb >= rxq->nb_rx_desc)\n-\t\treturn;\n-\n-\t/* free all mbufs that are valid in the ring */\n-\tif (rxq->rxrearm_nb == 0) {\n-\t\tfor (i = 0; i < rxq->nb_rx_desc; i++) {\n-\t\t\tif (rxq->sw_ring[i] != NULL)\n-\t\t\t\trte_pktmbuf_free_seg(rxq->sw_ring[i]);\n-\t\t}\n-\t} else {\n-\t\tfor (i = rxq->rx_tail; i != rxq->rxrearm_start; i = (i + 1) & mask) {\n-\t\t\tif (rxq->sw_ring[i] != NULL)\n-\t\t\t\trte_pktmbuf_free_seg(rxq->sw_ring[i]);\n-\t\t}\n-\t}\n-\n-\trxq->rxrearm_nb = rxq->nb_rx_desc;\n-\n-\t/* set all entries to NULL */\n-\tmemset(rxq->sw_ring, 0, sizeof(rxq->sw_ring[0]) * rxq->nb_rx_desc);\n-}\n-\n-static const struct idpf_rxq_ops def_singleq_rx_ops_vec = {\n-\t.release_mbufs = release_rxq_mbufs_vec,\n-};\n-\n-static inline int\n-idpf_singleq_rx_vec_setup_default(struct idpf_rx_queue *rxq)\n-{\n-\tuintptr_t p;\n-\tstruct rte_mbuf mb_def = { .buf_addr = 0 }; /* zeroed mbuf */\n-\n-\tmb_def.nb_segs = 1;\n-\tmb_def.data_off = RTE_PKTMBUF_HEADROOM;\n-\tmb_def.port = rxq->port_id;\n-\trte_mbuf_refcnt_set(&mb_def, 1);\n-\n-\t/* prevent compiler reordering: rearm_data covers previous fields */\n-\trte_compiler_barrier();\n-\tp = (uintptr_t)&mb_def.rearm_data;\n-\trxq->mbuf_initializer = *(uint64_t *)p;\n-\treturn 0;\n-}\n-\n-int __rte_cold\n-idpf_singleq_rx_vec_setup(struct idpf_rx_queue *rxq)\n-{\n-\trxq->ops = &def_singleq_rx_ops_vec;\n-\treturn idpf_singleq_rx_vec_setup_default(rxq);\n-}\n-\n void\n idpf_set_rx_function(struct rte_eth_dev *dev)\n {\ndiff --git a/drivers/net/idpf/idpf_rxtx.h b/drivers/net/idpf/idpf_rxtx.h\nindex eab363c3e7..a985dc2cf5 100644\n--- a/drivers/net/idpf/idpf_rxtx.h\n+++ b/drivers/net/idpf/idpf_rxtx.h\n@@ -44,7 +44,6 @@ void idpf_dev_rx_queue_release(struct rte_eth_dev *dev, uint16_t qid);\n int idpf_tx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,\n \t\t\tuint16_t nb_desc, unsigned int socket_id,\n \t\t\tconst struct rte_eth_txconf *tx_conf);\n-int idpf_singleq_rx_vec_setup(struct idpf_rx_queue *rxq);\n int idpf_tx_queue_init(struct rte_eth_dev *dev, uint16_t tx_queue_id);\n int idpf_tx_queue_start(struct rte_eth_dev *dev, uint16_t tx_queue_id);\n int idpf_tx_queue_stop(struct rte_eth_dev *dev, uint16_t tx_queue_id);\n", "prefixes": [ "v6", "14/19" ] }