Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/122715/?format=api
{ "id": 122715, "url": "http://patches.dpdk.org/api/patches/122715/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230131065229.290041-1-simei.su@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230131065229.290041-1-simei.su@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230131065229.290041-1-simei.su@intel.com", "date": "2023-01-31T06:52:29", "name": "[v2] net/i40e: rework maximum frame size configuration", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "02421cc9183ca8a199832728926d0eb57bfe1aa4", "submitter": { "id": 1298, "url": "http://patches.dpdk.org/api/people/1298/?format=api", "name": "Simei Su", "email": "simei.su@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230131065229.290041-1-simei.su@intel.com/mbox/", "series": [ { "id": 26704, "url": "http://patches.dpdk.org/api/series/26704/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=26704", "date": "2023-01-31T06:52:29", "name": "[v2] net/i40e: rework maximum frame size configuration", "version": 2, "mbox": "http://patches.dpdk.org/series/26704/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/122715/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/122715/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5DE5741B89;\n\tTue, 31 Jan 2023 07:53:24 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8E6E341148;\n\tTue, 31 Jan 2023 07:53:22 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id A2017410F6;\n Tue, 31 Jan 2023 07:53:18 +0100 (CET)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 Jan 2023 22:53:17 -0800", "from unknown (HELO npg-dpdk-simeisu-cvl-119d218.sh.intel.com)\n ([10.67.119.208])\n by fmsmga007.fm.intel.com with ESMTP; 30 Jan 2023 22:53:15 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1675147999; x=1706683999;\n h=from:to:cc:subject:date:message-id:in-reply-to: references;\n bh=3ukZ8CZ0+U+iA+aofo6NIDKlRtfbsA1gSMron1xxyKE=;\n b=SC0fj5WMZZWZIlldpLu5D4+Rw76sk/CpOAN/fcztgKcS3MeA2JoDzU4M\n uR8TpFBtuUT7kjN8tR9gfHzpGt8y1Oiv+EbafuGxsQoGOiEx6/qawjT2b\n 1zRKhtRxXoHET/Qcrbpn5JXDbDMQ6qQQnp59u3eDFyEd0Jm5oBrDKSO7z\n RNzlDKP020LaCE9/9eaBXxNlBAQTm345mnIxp2ounwVN+hhkuE5XH5AWJ\n tzRVtENFJ097w68be18hVRzbpoiIKZhurHDKhpzDgx3G7y2vxEDYaeQb6\n KVpW+b8nCBjcVk9Ofrc7kV28a2sJt6N6sWJ8aHs3M1UO6cR5FJY66UHG8 Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10606\"; a=\"329037923\"", "E=Sophos;i=\"5.97,259,1669104000\"; d=\"scan'208\";a=\"329037923\"", "E=McAfee;i=\"6500,9779,10606\"; a=\"666376030\"", "E=Sophos;i=\"5.97,259,1669104000\"; d=\"scan'208\";a=\"666376030\"" ], "X-ExtLoop1": "1", "From": "Simei Su <simei.su@intel.com>", "To": "beilei.xing@intel.com, yuying.zhang@intel.com, david.marchand@redhat.com", "Cc": "dev@dpdk.org, qi.z.zhang@intel.com, qiming.yang@intel.com,\n Simei Su <simei.su@intel.com>, stable@dpdk.org", "Subject": "[PATCH v2] net/i40e: rework maximum frame size configuration", "Date": "Tue, 31 Jan 2023 14:52:29 +0800", "Message-Id": "<20230131065229.290041-1-simei.su@intel.com>", "X-Mailer": "git-send-email 2.9.5", "In-Reply-To": "<20230116105318.19412-1-simei.su@intel.com>", "References": "<20230116105318.19412-1-simei.su@intel.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch removes unnecessary link status check and adds link update.\n\nFixes: a4ba77367923 (\"net/i40e: enable maximum frame size at port level\")\nFixes: 2184f7cdeeaa (\"net/i40e: fix max frame size config at port level\")\nFixes: 719469f13b11 (\"net/i40e: fix jumbo frame Rx with X722\")\nCc: stable@dpdk.org\n\nSigned-off-by: Simei Su <simei.su@intel.com>\n---\nv2:\n* Refine commit log.\n* Add link update.\n\n drivers/net/i40e/i40e_ethdev.c | 54 +++++++++++-------------------------------\n 1 file changed, 14 insertions(+), 40 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex 7726a89d..a3100ec 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -387,7 +387,6 @@ static int i40e_set_default_mac_addr(struct rte_eth_dev *dev,\n \t\t\t\t struct rte_ether_addr *mac_addr);\n \n static int i40e_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu);\n-static void i40e_set_mac_max_frame(struct rte_eth_dev *dev, uint16_t size);\n \n static int i40e_ethertype_filter_convert(\n \tconst struct rte_eth_ethertype_filter *input,\n@@ -2467,8 +2466,18 @@ i40e_dev_start(struct rte_eth_dev *dev)\n \t\t\t \"please call hierarchy_commit() \"\n \t\t\t \"before starting the port\");\n \n-\tmax_frame_size = dev->data->mtu + I40E_ETH_OVERHEAD;\n-\ti40e_set_mac_max_frame(dev, max_frame_size);\n+\ti40e_dev_link_update(dev, 1);\n+\n+\tmax_frame_size = dev->data->mtu ?\n+\t\tdev->data->mtu + I40E_ETH_OVERHEAD :\n+\t\tI40E_FRAME_SIZE_MAX;\n+\n+\t/* Set the max frame size to HW*/\n+\tret = i40e_aq_set_mac_config(hw, max_frame_size, TRUE, false, 0, NULL);\n+\tif (ret) {\n+\t\tPMD_DRV_LOG(ERR, \"Fail to set mac config\");\n+\t\treturn ret;\n+\t}\n \n \treturn I40E_SUCCESS;\n \n@@ -2809,9 +2818,6 @@ i40e_dev_set_link_down(struct rte_eth_dev *dev)\n \treturn i40e_phy_conf_link(hw, abilities, speed, false);\n }\n \n-#define CHECK_INTERVAL 100 /* 100ms */\n-#define MAX_REPEAT_TIME 10 /* 1s (10 * 100ms) in total */\n-\n static __rte_always_inline void\n update_link_reg(struct i40e_hw *hw, struct rte_eth_link *link)\n {\n@@ -2878,6 +2884,8 @@ static __rte_always_inline void\n update_link_aq(struct i40e_hw *hw, struct rte_eth_link *link,\n \tbool enable_lse, int wait_to_complete)\n {\n+#define CHECK_INTERVAL 100 /* 100ms */\n+#define MAX_REPEAT_TIME 10 /* 1s (10 * 100ms) in total */\n \tuint32_t rep_cnt = MAX_REPEAT_TIME;\n \tstruct i40e_link_status link_status;\n \tint status;\n@@ -12123,40 +12131,6 @@ i40e_cloud_filter_qinq_create(struct i40e_pf *pf)\n \treturn ret;\n }\n \n-static void\n-i40e_set_mac_max_frame(struct rte_eth_dev *dev, uint16_t size)\n-{\n-\tstruct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n-\tuint32_t rep_cnt = MAX_REPEAT_TIME;\n-\tstruct rte_eth_link link;\n-\tenum i40e_status_code status;\n-\tbool can_be_set = true;\n-\n-\t/*\n-\t * I40E_MEDIA_TYPE_BASET link up can be ignored\n-\t * I40E_MEDIA_TYPE_BASET link down that hw->phy.media_type\n-\t * is I40E_MEDIA_TYPE_UNKNOWN\n-\t */\n-\tif (hw->phy.media_type != I40E_MEDIA_TYPE_BASET &&\n-\t hw->phy.media_type != I40E_MEDIA_TYPE_UNKNOWN) {\n-\t\tdo {\n-\t\t\tupdate_link_reg(hw, &link);\n-\t\t\tif (link.link_status)\n-\t\t\t\tbreak;\n-\t\t\trte_delay_ms(CHECK_INTERVAL);\n-\t\t} while (--rep_cnt);\n-\t\tcan_be_set = !!link.link_status;\n-\t}\n-\n-\tif (can_be_set) {\n-\t\tstatus = i40e_aq_set_mac_config(hw, size, TRUE, 0, false, NULL);\n-\t\tif (status != I40E_SUCCESS)\n-\t\t\tPMD_DRV_LOG(ERR, \"Failed to set max frame size at port level\");\n-\t} else {\n-\t\tPMD_DRV_LOG(ERR, \"Set max frame size at port level not applicable on link down\");\n-\t}\n-}\n-\n RTE_LOG_REGISTER_SUFFIX(i40e_logtype_init, init, NOTICE);\n RTE_LOG_REGISTER_SUFFIX(i40e_logtype_driver, driver, NOTICE);\n #ifdef RTE_ETHDEV_DEBUG_RX\n", "prefixes": [ "v2" ] }