Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/122179/?format=api
{ "id": 122179, "url": "http://patches.dpdk.org/api/patches/122179/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230117101646.2521875-1-didier.pallard@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230117101646.2521875-1-didier.pallard@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230117101646.2521875-1-didier.pallard@6wind.com", "date": "2023-01-17T10:16:46", "name": "[RFC] Fix cryptodev socket id for devices on unknown NUMA node", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b637b8e5eff19d9edc108a7121fa25ae7f0093fb", "submitter": { "id": 126, "url": "http://patches.dpdk.org/api/people/126/?format=api", "name": "Didier Pallard", "email": "didier.pallard@6wind.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230117101646.2521875-1-didier.pallard@6wind.com/mbox/", "series": [ { "id": 26575, "url": "http://patches.dpdk.org/api/series/26575/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=26575", "date": "2023-01-17T10:16:46", "name": "[RFC] Fix cryptodev socket id for devices on unknown NUMA node", "version": 1, "mbox": "http://patches.dpdk.org/series/26575/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/122179/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/122179/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C75AC423FB;\n\tTue, 17 Jan 2023 11:16:59 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 724C340151;\n\tTue, 17 Jan 2023 11:16:59 +0100 (CET)", "from mail-wm1-f42.google.com (mail-wm1-f42.google.com\n [209.85.128.42]) by mails.dpdk.org (Postfix) with ESMTP id 496C9400D4\n for <dev@dpdk.org>; Tue, 17 Jan 2023 11:16:58 +0100 (CET)", "by mail-wm1-f42.google.com with SMTP id q8so10012152wmo.5\n for <dev@dpdk.org>; Tue, 17 Jan 2023 02:16:58 -0800 (PST)", "from arion.dev.6wind.com ([185.13.181.2])\n by smtp.gmail.com with ESMTPSA id\n q6-20020a05600c46c600b003d1f3e9df3csm43887051wmo.7.2023.01.17.02.16.57\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 17 Jan 2023 02:16:57 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=XtW8ZDo2kcc2A7BDE4rC8D8tWtcaew3TI8576rfjrKE=;\n b=A4v+b0hMEuCwAa0+7byHs9AyiNrL1RhzJ+q0W3OrG0PZKjRAOvMnELAbj/5TdrpGKb\n ov6SbNszADB6eLNoRtAFSna/gSJlNNHSzZhmUPqI6+CEcMPgniAFagc1JX6KHdXcBCa0\n Q7nO2nHk4kJdtbQgflMctlrVu55UmOlESw301q0jbL+SaEYyipVYXc2kCdBCcSTyVV2n\n h4rhUnIBDvEoNhrcF6KWNUbojCgoKAkeyOnPZc4d7/I9HPHYv2hIlI3c2Zcr4a65PnBp\n RiMifRrIumr3YQDkUEF8VPZ96+FTQLEp8279LJJRdNIe8XGR0dKRq7HF4lOjcMt3fMp1\n Lccw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=XtW8ZDo2kcc2A7BDE4rC8D8tWtcaew3TI8576rfjrKE=;\n b=RTWS8Kkv2iSqkElELvDtkq39xmk5V1+G6lYBl4E2Oh+5o2SpoqK84GkEmg5em233TV\n hYwxGiWpIFlIJHEm3MPlL/qAGdGbwz9gQE0PzmykLX+p1a9x4w4PMAZNkgdQd5+Q37Hl\n zZaYxKztpyUtfgwsCUfCAsGB+nPdUt16R2nuwa/gSYb7VYudSrIRW/pFBDblfloX/8y8\n Fh4i3ML0Qr+vAzfal+yZHTgwMjqGbz497WBtEvBZnzesINRtaRSM3jGU4mLNEW9Neo/q\n hbrHyM+Pv2vesH4VSX1QQucNvLrn4t1jXPOhGNuHqSlYs2x7NQ+EjC3Yc24zxuQ7jznc\n 2yGA==", "X-Gm-Message-State": "AFqh2kpKub804TpBeSYxeMVyU7PFnSAsSWKtmKbcz8mNlWa6474V2A7Y\n 04rH08uSJ8AMyxv9/WcgeSreFw==", "X-Google-Smtp-Source": "\n AMrXdXsvhWs9NGYW0PnsWl4en6FNhUpp4bLhyhm83U0jxG2ZJ+QSCZQH5raxub4lYniBhUUQbF0THA==", "X-Received": "by 2002:a05:600c:4f4a:b0:3db:5f1:53a5 with SMTP id\n m10-20020a05600c4f4a00b003db05f153a5mr2175527wmq.20.1673950617951;\n Tue, 17 Jan 2023 02:16:57 -0800 (PST)", "From": "Didier Pallard <didier.pallard@6wind.com>", "To": "Akhil Goyal <gakhil@marvell.com>, Fan Zhang <fanzhang.oss@gmail.com>,\n Olivier Matz <olivier.matz@6wind.com>", "Cc": "dev@dpdk.org", "Subject": "[RFC] Fix cryptodev socket id for devices on unknown NUMA node", "Date": "Tue, 17 Jan 2023 11:16:46 +0100", "Message-Id": "<20230117101646.2521875-1-didier.pallard@6wind.com>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Since DPDK 22.11 and below commit:\nhttps://git.dpdk.org/dpdk/commit/?id=7dcd73e37965ba0bfa430efeac362fe183ed0ae2\nrte_cryptodev_socket_id() could return an incorrect value of 255.\nProblem has been seen during configuration of the qat device\non an Atom C3000 architecture. On this arch, PCI is not depending on\nany numa socket, causing device numa_node to be equal to SOCKET_ID_ANY.\nDue to incorrect cast to uint8_t, this value is stored as 255\nin cryptodev structure and returned as such by rte_cryptodev_socket_id()\nfunction.\n\nBelow patch proposes one way to fix the issue: casting to a signed int8_t\ninstead of the uint8_t. (it could also be casted to an int, that is the\nusual type for numa_node, but this may break the ABI). This makes the\nSOCKET_ID_ANY being propagated up to the user.\nAnother solution could be to always store a valid numa_node in this field\ninstead of just copying the numa_node field of the device, but this\nrequires to fix most crypto PMDs, that are currently just copying the\ndevice value.\n\nWhat is the preferred solution?\n\n---\ncryptodev: fix numa_node type\n\nSince below commit, numa_node can be set to SOCKET_ID_ANY.\nDo not cast numa_node to an unsigned uint8, else SOCKET_ID_ANY\nis converted to 255, causing rte_cryptodev_socket_id to return\nan incorrect value.\n\nFixes: 7dcd73e37965 (\"drivers/bus: set device NUMA node to unknown by default\")\nSigned-off-by: Didier Pallard <didier.pallard@6wind.com>\n---\n lib/cryptodev/cryptodev_pmd.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/cryptodev/cryptodev_pmd.h b/lib/cryptodev/cryptodev_pmd.h\nindex 0020102eb7db..db4745d620f4 100644\n--- a/lib/cryptodev/cryptodev_pmd.h\n+++ b/lib/cryptodev/cryptodev_pmd.h\n@@ -64,8 +64,8 @@ struct rte_cryptodev_pmd_init_params {\n struct rte_cryptodev_data {\n \t/** Device ID for this instance */\n \tuint8_t dev_id;\n-\t/** Socket ID where memory is allocated */\n-\tuint8_t socket_id;\n+\t/** Socket ID of the device */\n+\tint8_t socket_id;\n \t/** Unique identifier name */\n \tchar name[RTE_CRYPTODEV_NAME_MAX_LEN];\n \n", "prefixes": [ "RFC" ] }