Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/12217/?format=api
{ "id": 12217, "url": "http://patches.dpdk.org/api/patches/12217/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/4685487.eCM9t2Cvuq@xps13/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<4685487.eCM9t2Cvuq@xps13>", "list_archive_url": "https://inbox.dpdk.org/dev/4685487.eCM9t2Cvuq@xps13", "date": "2016-04-22T21:14:35", "name": "[dpdk-dev,4/4] eal: add assert macro for debug", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "795ff25f9c77b5eae654ed2ab21a018834585182", "submitter": { "id": 1, "url": "http://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/4685487.eCM9t2Cvuq@xps13/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/12217/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/12217/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 6B69A2BE3;\n\tFri, 22 Apr 2016 23:14:59 +0200 (CEST)", "from mail-wm0-f50.google.com (mail-wm0-f50.google.com\n\t[74.125.82.50]) by dpdk.org (Postfix) with ESMTP id C99232BD9\n\tfor <dev@dpdk.org>; Fri, 22 Apr 2016 23:14:58 +0200 (CEST)", "by mail-wm0-f50.google.com with SMTP id u206so44427505wme.1\n\tfor <dev@dpdk.org>; Fri, 22 Apr 2016 14:14:58 -0700 (PDT)", "from xps13.localnet (APoitiers-658-1-63-44.w86-221.abo.wanadoo.fr.\n\t[86.221.58.44]) by smtp.gmail.com with ESMTPSA id\n\to73sm5134040wme.16.2016.04.22.14.14.57\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tFri, 22 Apr 2016 14:14:57 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:organization:user-agent\n\t:in-reply-to:references:mime-version:content-transfer-encoding;\n\tbh=VSZKBWPp/xo3FEdjlVoTIOFBP5vtOawGxw2OaUyATyY=;\n\tb=yZ/DbrngRlYdqIFpBC4DPjFlryQQo1S2WQ/EcA/Cbi3OchSG63wTtd78DH15PUW7Yk\n\tkliDtwilAn7LBKoXlHOdi6z/tJAW77duU9cnXz2+cGm2cPIhrNR/hwsQQ+PC4Kj6/evH\n\t9TPA62TVXPnlojRMNC1nk8tI+/pH4lGdZpr8K7EbF9+hPtHwq1rQ6BzQ2uJh1HuU/rma\n\tp/JLu6W7gUQBxGuvmMzPiqgNVPrZO0E/KVrempIC8jugJIO7N4onz/3NECDxbHRV/8eg\n\tqUSNATXNa26nHZ7J6Y1Zl0drrxiL1u59oG8VAztG/lRPdo9Vaurjw/DN2s6RcADVshXd\n\tr6ag==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding;\n\tbh=VSZKBWPp/xo3FEdjlVoTIOFBP5vtOawGxw2OaUyATyY=;\n\tb=RzUcRq0/kV/S0SWZYTfcBhAUySOTeAwztnTRREeYbJ3M9JgrsWL5hXs6E8EFd4KOVc\n\tRzTHT5xqO69oO7URzvXVfG4n1WuLrmTJD/WzaNOxSd7BjHXvMej1QZeRFXFi05pJofQZ\n\t2aQmSF4yB9n0MHI2lr9cTxP0qoHWkBOw9ZcpHTa0Z7rIY/rOyQQGrRpnQTPYZyFFdP9a\n\tZfJB86Fh3aDCFMHu9MBuS/1T+XbXkmNBO6mLHQvDV85/+XnRYJATMHuSK5/0C/kLtdCA\n\tpMIuO+r4FqOGgzRDQBSCsA5tXWboKPWtA1UAgBNCH6ZU+L5MMzfFOl9HjQ77dUa1e1sY\n\tmjmQ==", "X-Gm-Message-State": "AOPr4FWLYDOqBAMtxgKw13pqpJMSG0p6bxiyG2lTYOsWFKb5dXS+UtAt/XF7mkA7luPdJOC/", "X-Received": "by 10.28.187.5 with SMTP id l5mr5548165wmf.17.1461359698589;\n\tFri, 22 Apr 2016 14:14:58 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "Yuanhan Liu <yuanhan.liu@linux.intel.com>", "Cc": "dev@dpdk.org", "Date": "Fri, 22 Apr 2016 23:14:35 +0200", "Message-ID": "<4685487.eCM9t2Cvuq@xps13>", "Organization": "6WIND", "User-Agent": "KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )", "In-Reply-To": "<20160422195110.GE7603@yliu-dev.sh.intel.com>", "References": "<1461332640-24273-1-git-send-email-thomas.monjalon@6wind.com>\n\t<1461332640-24273-5-git-send-email-thomas.monjalon@6wind.com>\n\t<20160422195110.GE7603@yliu-dev.sh.intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "Content-Type": "text/plain; charset=\"utf-8\"", "Subject": "Re: [dpdk-dev] [PATCH 4/4] eal: add assert macro for debug", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "2016-04-22 12:51, Yuanhan Liu:\n> On Fri, Apr 22, 2016 at 03:44:00PM +0200, Thomas Monjalon wrote:\n> > --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c\n> > +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c\n> > @@ -662,8 +662,8 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n> > \n> > \t\tPMD_RX_LOG(DEBUG, \"rxd idx: %d ring idx: %d.\", idx, ring_idx);\n> > \n> > -\t\tVMXNET3_ASSERT(rcd->len <= rxd->len);\n> > -\t\tVMXNET3_ASSERT(rbi->m);\n> > +\t\tRTE_ASSERT(rcd->len <= rxd->len);\n> > +\t\tRTE_ASSERT(rbi->m);\n> \n> Seems this piece of code introduces a build error:\n> \n> drivers/net/vmxnet3/vmxnet3_rxtx.c: In function ‘vmxnet3_recv_pkts’:\n> drivers/net/vmxnet3/vmxnet3_rxtx.c:635:18: error: variable ‘rxd’ set but not used\n> Vmxnet3_RxDesc *rxd;\n> ^\n\nIndeed it can be seen with gcc when debug is disabled.\nIt can be fixed this way:", "diff": "--- a/drivers/net/vmxnet3/vmxnet3_rxtx.c\n+++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c\n@@ -658,6 +658,7 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n idx = rcd->rxdIdx;\n ring_idx = (uint8_t)((rcd->rqID == rxq->qid1) ? 0 : 1);\n rxd = (Vmxnet3_RxDesc *)rxq->cmd_ring[ring_idx].base + idx;\n+ RTE_SET_USED(rxd); /* used only for assert when enabled */\n rbi = rxq->cmd_ring[ring_idx].buf_info + idx;\n \n PMD_RX_LOG(DEBUG, \"rxd idx: %d ring idx: %d.\", idx, ring_idx);\n", "prefixes": [ "dpdk-dev", "4/4" ] }