Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/122148/?format=api
{ "id": 122148, "url": "http://patches.dpdk.org/api/patches/122148/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230117072626.93796-9-beilei.xing@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230117072626.93796-9-beilei.xing@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230117072626.93796-9-beilei.xing@intel.com", "date": "2023-01-17T07:26:15", "name": "[v3,07/15] common/idpf: add irq map/unmap", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "dcf3f92fa88eade9d5de0784919e6d3315a23523", "submitter": { "id": 410, "url": "http://patches.dpdk.org/api/people/410/?format=api", "name": "Xing, Beilei", "email": "beilei.xing@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230117072626.93796-9-beilei.xing@intel.com/mbox/", "series": [ { "id": 26568, "url": "http://patches.dpdk.org/api/series/26568/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=26568", "date": "2023-01-17T07:26:07", "name": "net/idpf: introduce idpf common modle", "version": 3, "mbox": "http://patches.dpdk.org/series/26568/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/122148/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/122148/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3884C423FA;\n\tTue, 17 Jan 2023 08:51:56 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DA84E42D51;\n\tTue, 17 Jan 2023 08:51:05 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by mails.dpdk.org (Postfix) with ESMTP id 6B89942D51\n for <dev@dpdk.org>; Tue, 17 Jan 2023 08:51:04 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 Jan 2023 23:51:03 -0800", "from dpdk-beileix-3.sh.intel.com ([10.67.110.253])\n by fmsmga002.fm.intel.com with ESMTP; 16 Jan 2023 23:51:01 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1673941864; x=1705477864;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=0nGwDEiGIikY1QUu9NvnxGE2O5/OX69lQfZqpzRCq7c=;\n b=Og77VkDNJBIv3TsHNbjCIDumOSS531qva9GdyBskBY3zK1lOBchBaDl7\n Z+UeDAC03XdrADq78DY5S/LBG+WIdVj/6nURlyhxLnxD2/Ta5xNYebelF\n uVoF1QVO+UenhDyga6x9KDn/5iEKVk+KhVEZCcUSCwxjZpRVOMbtTaOew\n h4yt1vN60Y/aITLECFout0/RLGtGgeMXF4LXdMv65rcKoQG53X1dd1oPO\n sczmNzFLTFxT0eB5bShYoI6XsdYOrbOgrSphYD8aneaJcdi4X9/3OpTsq\n j9ohc2ylxNB5nanApz0XBGmoS+jQtT2HSLdY5aV8rBwt7/DRnYMcrNJeI Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10592\"; a=\"312497037\"", "E=Sophos;i=\"5.97,222,1669104000\"; d=\"scan'208\";a=\"312497037\"", "E=McAfee;i=\"6500,9779,10592\"; a=\"767174514\"", "E=Sophos;i=\"5.97,222,1669104000\"; d=\"scan'208\";a=\"767174514\"" ], "X-ExtLoop1": "1", "From": "beilei.xing@intel.com", "To": "jingjing.wu@intel.com", "Cc": "dev@dpdk.org,\n\tqi.z.zhang@intel.com,\n\tBeilei Xing <beilei.xing@intel.com>", "Subject": "[PATCH v3 07/15] common/idpf: add irq map/unmap", "Date": "Tue, 17 Jan 2023 07:26:15 +0000", "Message-Id": "<20230117072626.93796-9-beilei.xing@intel.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20230117072626.93796-1-beilei.xing@intel.com>", "References": "\n <https://patches.dpdk.org/project/dpdk/cover/20230106091627.13530-1-beilei.xing@intel.com/>\n <20230117072626.93796-1-beilei.xing@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Beilei Xing <beilei.xing@intel.com>\n\nIntroduce idpf_config_irq_map/idpf_config_irq_unmap functions\nin common module, and refine config rxq irqs function.\nRefine device start function with some irq error handling. Besides,\nvport->stopped should be initialized at the end of the function.\n\nSigned-off-by: Jingjing Wu <jingjing.wu@intel.com>\nSigned-off-by: Beilei Xing <beilei.xing@intel.com>\n---\n drivers/common/idpf/idpf_common_device.c | 99 ++++++++++++++++++++\n drivers/common/idpf/idpf_common_device.h | 6 ++\n drivers/common/idpf/idpf_common_virtchnl.c | 8 --\n drivers/common/idpf/idpf_common_virtchnl.h | 6 +-\n drivers/common/idpf/version.map | 2 +\n drivers/net/idpf/idpf_ethdev.c | 102 +++------------------\n drivers/net/idpf/idpf_ethdev.h | 1 -\n 7 files changed, 122 insertions(+), 102 deletions(-)", "diff": "diff --git a/drivers/common/idpf/idpf_common_device.c b/drivers/common/idpf/idpf_common_device.c\nindex eee96b5083..422b0b0304 100644\n--- a/drivers/common/idpf/idpf_common_device.c\n+++ b/drivers/common/idpf/idpf_common_device.c\n@@ -247,8 +247,21 @@ idpf_vport_init(struct idpf_vport *vport,\n \t\tgoto err_rss_lut;\n \t}\n \n+\t/* recv_vectors is used for VIRTCHNL2_OP_ALLOC_VECTORS response,\n+\t * reserve maximum size for it now, may need optimization in future.\n+\t */\n+\tvport->recv_vectors = rte_zmalloc(\"recv_vectors\", IDPF_DFLT_MBX_BUF_SIZE, 0);\n+\tif (vport->recv_vectors == NULL) {\n+\t\tDRV_LOG(ERR, \"Failed to allocate ecv_vectors\");\n+\t\tret = -ENOMEM;\n+\t\tgoto err_recv_vec;\n+\t}\n+\n \treturn 0;\n \n+err_recv_vec:\n+\trte_free(vport->rss_lut);\n+\tvport->rss_lut = NULL;\n err_rss_lut:\n \tvport->dev_data = NULL;\n \trte_free(vport->rss_key);\n@@ -261,6 +274,8 @@ idpf_vport_init(struct idpf_vport *vport,\n int\n idpf_vport_deinit(struct idpf_vport *vport)\n {\n+\trte_free(vport->recv_vectors);\n+\tvport->recv_vectors = NULL;\n \trte_free(vport->rss_lut);\n \tvport->rss_lut = NULL;\n \n@@ -298,4 +313,88 @@ idpf_config_rss(struct idpf_vport *vport)\n \n \treturn ret;\n }\n+\n+int\n+idpf_config_irq_map(struct idpf_vport *vport, uint16_t nb_rx_queues)\n+{\n+\tstruct idpf_adapter *adapter = vport->adapter;\n+\tstruct virtchnl2_queue_vector *qv_map;\n+\tstruct idpf_hw *hw = &adapter->hw;\n+\tuint32_t dynctl_val, itrn_val;\n+\tuint32_t dynctl_reg_start;\n+\tuint32_t itrn_reg_start;\n+\tuint16_t i;\n+\n+\tqv_map = rte_zmalloc(\"qv_map\",\n+\t\t\t nb_rx_queues *\n+\t\t\t sizeof(struct virtchnl2_queue_vector), 0);\n+\tif (qv_map == NULL) {\n+\t\tDRV_LOG(ERR, \"Failed to allocate %d queue-vector map\",\n+\t\t\tnb_rx_queues);\n+\t\tgoto qv_map_alloc_err;\n+\t}\n+\n+\t/* Rx interrupt disabled, Map interrupt only for writeback */\n+\n+\t/* The capability flags adapter->caps.other_caps should be\n+\t * compared with bit VIRTCHNL2_CAP_WB_ON_ITR here. The if\n+\t * condition should be updated when the FW can return the\n+\t * correct flag bits.\n+\t */\n+\tdynctl_reg_start =\n+\t\tvport->recv_vectors->vchunks.vchunks->dynctl_reg_start;\n+\titrn_reg_start =\n+\t\tvport->recv_vectors->vchunks.vchunks->itrn_reg_start;\n+\tdynctl_val = IDPF_READ_REG(hw, dynctl_reg_start);\n+\tDRV_LOG(DEBUG, \"Value of dynctl_reg_start is 0x%x\", dynctl_val);\n+\titrn_val = IDPF_READ_REG(hw, itrn_reg_start);\n+\tDRV_LOG(DEBUG, \"Value of itrn_reg_start is 0x%x\", itrn_val);\n+\t/* Force write-backs by setting WB_ON_ITR bit in DYN_CTL\n+\t * register. WB_ON_ITR and INTENA are mutually exclusive\n+\t * bits. Setting WB_ON_ITR bits means TX and RX Descs\n+\t * are written back based on ITR expiration irrespective\n+\t * of INTENA setting.\n+\t */\n+\t/* TBD: need to tune INTERVAL value for better performance. */\n+\titrn_val = (itrn_val == 0) ? IDPF_DFLT_INTERVAL : itrn_val;\n+\tdynctl_val = VIRTCHNL2_ITR_IDX_0 <<\n+\t\t PF_GLINT_DYN_CTL_ITR_INDX_S |\n+\t\t PF_GLINT_DYN_CTL_WB_ON_ITR_M |\n+\t\t itrn_val << PF_GLINT_DYN_CTL_INTERVAL_S;\n+\tIDPF_WRITE_REG(hw, dynctl_reg_start, dynctl_val);\n+\n+\tfor (i = 0; i < nb_rx_queues; i++) {\n+\t\t/* map all queues to the same vector */\n+\t\tqv_map[i].queue_id = vport->chunks_info.rx_start_qid + i;\n+\t\tqv_map[i].vector_id =\n+\t\t\tvport->recv_vectors->vchunks.vchunks->start_vector_id;\n+\t}\n+\tvport->qv_map = qv_map;\n+\n+\tif (idpf_vc_config_irq_map_unmap(vport, nb_rx_queues, true) != 0) {\n+\t\tDRV_LOG(ERR, \"config interrupt mapping failed\");\n+\t\tgoto config_irq_map_err;\n+\t}\n+\n+\treturn 0;\n+\n+config_irq_map_err:\n+\trte_free(vport->qv_map);\n+\tvport->qv_map = NULL;\n+\n+qv_map_alloc_err:\n+\treturn -1;\n+}\n+\n+int\n+idpf_config_irq_unmap(struct idpf_vport *vport, uint16_t nb_rx_queues)\n+{\n+\tidpf_vc_config_irq_map_unmap(vport, nb_rx_queues, false);\n+\n+\trte_free(vport->qv_map);\n+\tvport->qv_map = NULL;\n+\n+\treturn 0;\n+}\n+\n RTE_LOG_REGISTER_SUFFIX(idpf_common_logtype, common, NOTICE);\ndiff --git a/drivers/common/idpf/idpf_common_device.h b/drivers/common/idpf/idpf_common_device.h\nindex 1d3bb06fef..d45c2b8777 100644\n--- a/drivers/common/idpf/idpf_common_device.h\n+++ b/drivers/common/idpf/idpf_common_device.h\n@@ -17,6 +17,8 @@\n \n #define IDPF_MAX_PKT_TYPE\t1024\n \n+#define IDPF_DFLT_INTERVAL\t16\n+\n struct idpf_adapter {\n \tstruct idpf_hw hw;\n \tstruct virtchnl2_version_info virtchnl_version;\n@@ -155,5 +157,9 @@ __rte_internal\n int idpf_vport_deinit(struct idpf_vport *vport);\n __rte_internal\n int idpf_config_rss(struct idpf_vport *vport);\n+__rte_internal\n+int idpf_config_irq_map(struct idpf_vport *vport, uint16_t nb_rx_queues);\n+__rte_internal\n+int idpf_config_irq_unmap(struct idpf_vport *vport, uint16_t nb_rx_queues);\n \n #endif /* _IDPF_COMMON_DEVICE_H_ */\ndiff --git a/drivers/common/idpf/idpf_common_virtchnl.c b/drivers/common/idpf/idpf_common_virtchnl.c\nindex 1531adccef..f670d2cc17 100644\n--- a/drivers/common/idpf/idpf_common_virtchnl.c\n+++ b/drivers/common/idpf/idpf_common_virtchnl.c\n@@ -573,14 +573,6 @@ idpf_vc_alloc_vectors(struct idpf_vport *vport, uint16_t num_vectors)\n \tif (err != 0)\n \t\tDRV_LOG(ERR, \"Failed to execute command VIRTCHNL2_OP_ALLOC_VECTORS\");\n \n-\tif (vport->recv_vectors == NULL) {\n-\t\tvport->recv_vectors = rte_zmalloc(\"recv_vectors\", len, 0);\n-\t\tif (vport->recv_vectors == NULL) {\n-\t\t\trte_free(alloc_vec);\n-\t\t\treturn -ENOMEM;\n-\t\t}\n-\t}\n-\n \trte_memcpy(vport->recv_vectors, args.out_buffer, len);\n \trte_free(alloc_vec);\n \treturn err;\ndiff --git a/drivers/common/idpf/idpf_common_virtchnl.h b/drivers/common/idpf/idpf_common_virtchnl.h\nindex bbc66d63c4..3c9f51e4cf 100644\n--- a/drivers/common/idpf/idpf_common_virtchnl.h\n+++ b/drivers/common/idpf/idpf_common_virtchnl.h\n@@ -23,6 +23,9 @@ int idpf_vc_set_rss_lut(struct idpf_vport *vport);\n __rte_internal\n int idpf_vc_set_rss_hash(struct idpf_vport *vport);\n __rte_internal\n+int idpf_vc_config_irq_map_unmap(struct idpf_vport *vport,\n+\t\t\t\t uint16_t nb_rxq, bool map);\n+__rte_internal\n int idpf_switch_queue(struct idpf_vport *vport, uint16_t qid,\n \t\t bool rx, bool on);\n __rte_internal\n@@ -30,9 +33,6 @@ int idpf_vc_ena_dis_queues(struct idpf_vport *vport, bool enable);\n __rte_internal\n int idpf_vc_ena_dis_vport(struct idpf_vport *vport, bool enable);\n __rte_internal\n-int idpf_vc_config_irq_map_unmap(struct idpf_vport *vport,\n-\t\t\t\t uint16_t nb_rxq, bool map);\n-__rte_internal\n int idpf_vc_alloc_vectors(struct idpf_vport *vport, uint16_t num_vectors);\n __rte_internal\n int idpf_vc_dealloc_vectors(struct idpf_vport *vport);\ndiff --git a/drivers/common/idpf/version.map b/drivers/common/idpf/version.map\nindex d8d5275b1c..da3b0feefc 100644\n--- a/drivers/common/idpf/version.map\n+++ b/drivers/common/idpf/version.map\n@@ -3,6 +3,8 @@ INTERNAL {\n \n \tidpf_adapter_deinit;\n \tidpf_adapter_init;\n+\tidpf_config_irq_map;\n+\tidpf_config_irq_unmap;\n \tidpf_config_rss;\n \tidpf_ctlq_clean_sq;\n \tidpf_ctlq_deinit;\ndiff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c\nindex f728318dad..d0799087a5 100644\n--- a/drivers/net/idpf/idpf_ethdev.c\n+++ b/drivers/net/idpf/idpf_ethdev.c\n@@ -281,84 +281,9 @@ static int\n idpf_config_rx_queues_irqs(struct rte_eth_dev *dev)\n {\n \tstruct idpf_vport *vport = dev->data->dev_private;\n-\tstruct idpf_adapter *adapter = vport->adapter;\n-\tstruct virtchnl2_queue_vector *qv_map;\n-\tstruct idpf_hw *hw = &adapter->hw;\n-\tuint32_t dynctl_reg_start;\n-\tuint32_t itrn_reg_start;\n-\tuint32_t dynctl_val, itrn_val;\n-\tuint16_t i;\n-\n-\tqv_map = rte_zmalloc(\"qv_map\",\n-\t\t\tdev->data->nb_rx_queues *\n-\t\t\tsizeof(struct virtchnl2_queue_vector), 0);\n-\tif (qv_map == NULL) {\n-\t\tPMD_DRV_LOG(ERR, \"Failed to allocate %d queue-vector map\",\n-\t\t\t dev->data->nb_rx_queues);\n-\t\tgoto qv_map_alloc_err;\n-\t}\n-\n-\t/* Rx interrupt disabled, Map interrupt only for writeback */\n-\n-\t/* The capability flags adapter->caps.other_caps should be\n-\t * compared with bit VIRTCHNL2_CAP_WB_ON_ITR here. The if\n-\t * condition should be updated when the FW can return the\n-\t * correct flag bits.\n-\t */\n-\tdynctl_reg_start =\n-\t\tvport->recv_vectors->vchunks.vchunks->dynctl_reg_start;\n-\titrn_reg_start =\n-\t\tvport->recv_vectors->vchunks.vchunks->itrn_reg_start;\n-\tdynctl_val = IDPF_READ_REG(hw, dynctl_reg_start);\n-\tPMD_DRV_LOG(DEBUG, \"Value of dynctl_reg_start is 0x%x\",\n-\t\t dynctl_val);\n-\titrn_val = IDPF_READ_REG(hw, itrn_reg_start);\n-\tPMD_DRV_LOG(DEBUG, \"Value of itrn_reg_start is 0x%x\", itrn_val);\n-\t/* Force write-backs by setting WB_ON_ITR bit in DYN_CTL\n-\t * register. WB_ON_ITR and INTENA are mutually exclusive\n-\t * bits. Setting WB_ON_ITR bits means TX and RX Descs\n-\t * are written back based on ITR expiration irrespective\n-\t * of INTENA setting.\n-\t */\n-\t/* TBD: need to tune INTERVAL value for better performance. */\n-\tif (itrn_val != 0)\n-\t\tIDPF_WRITE_REG(hw,\n-\t\t\t dynctl_reg_start,\n-\t\t\t VIRTCHNL2_ITR_IDX_0 <<\n-\t\t\t PF_GLINT_DYN_CTL_ITR_INDX_S |\n-\t\t\t PF_GLINT_DYN_CTL_WB_ON_ITR_M |\n-\t\t\t itrn_val <<\n-\t\t\t PF_GLINT_DYN_CTL_INTERVAL_S);\n-\telse\n-\t\tIDPF_WRITE_REG(hw,\n-\t\t\t dynctl_reg_start,\n-\t\t\t VIRTCHNL2_ITR_IDX_0 <<\n-\t\t\t PF_GLINT_DYN_CTL_ITR_INDX_S |\n-\t\t\t PF_GLINT_DYN_CTL_WB_ON_ITR_M |\n-\t\t\t IDPF_DFLT_INTERVAL <<\n-\t\t\t PF_GLINT_DYN_CTL_INTERVAL_S);\n-\n-\tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n-\t\t/* map all queues to the same vector */\n-\t\tqv_map[i].queue_id = vport->chunks_info.rx_start_qid + i;\n-\t\tqv_map[i].vector_id =\n-\t\t\tvport->recv_vectors->vchunks.vchunks->start_vector_id;\n-\t}\n-\tvport->qv_map = qv_map;\n-\n-\tif (idpf_vc_config_irq_map_unmap(vport, dev->data->nb_rx_queues, true) != 0) {\n-\t\tPMD_DRV_LOG(ERR, \"config interrupt mapping failed\");\n-\t\tgoto config_irq_map_err;\n-\t}\n-\n-\treturn 0;\n-\n-config_irq_map_err:\n-\trte_free(vport->qv_map);\n-\tvport->qv_map = NULL;\n+\tuint16_t nb_rx_queues = dev->data->nb_rx_queues;\n \n-qv_map_alloc_err:\n-\treturn -1;\n+\treturn idpf_config_irq_map(vport, nb_rx_queues);\n }\n \n static int\n@@ -404,8 +329,6 @@ idpf_dev_start(struct rte_eth_dev *dev)\n \tuint16_t req_vecs_num;\n \tint ret;\n \n-\tvport->stopped = 0;\n-\n \treq_vecs_num = IDPF_DFLT_Q_VEC_NUM;\n \tif (req_vecs_num + adapter->used_vecs_num > num_allocated_vectors) {\n \t\tPMD_DRV_LOG(ERR, \"The accumulated request vectors' number should be less than %d\",\n@@ -424,13 +347,13 @@ idpf_dev_start(struct rte_eth_dev *dev)\n \tret = idpf_config_rx_queues_irqs(dev);\n \tif (ret != 0) {\n \t\tPMD_DRV_LOG(ERR, \"Failed to configure irqs\");\n-\t\tgoto err_vec;\n+\t\tgoto err_irq;\n \t}\n \n \tret = idpf_start_queues(dev);\n \tif (ret != 0) {\n \t\tPMD_DRV_LOG(ERR, \"Failed to start queues\");\n-\t\tgoto err_vec;\n+\t\tgoto err_startq;\n \t}\n \n \tidpf_set_rx_function(dev);\n@@ -442,10 +365,16 @@ idpf_dev_start(struct rte_eth_dev *dev)\n \t\tgoto err_vport;\n \t}\n \n+\tvport->stopped = 0;\n+\n \treturn 0;\n \n err_vport:\n \tidpf_stop_queues(dev);\n+err_startq:\n+\tidpf_config_irq_unmap(vport, dev->data->nb_rx_queues);\n+err_irq:\n+\tidpf_vc_dealloc_vectors(vport);\n err_vec:\n \treturn ret;\n }\n@@ -462,10 +391,9 @@ idpf_dev_stop(struct rte_eth_dev *dev)\n \n \tidpf_stop_queues(dev);\n \n-\tidpf_vc_config_irq_map_unmap(vport, dev->data->nb_rx_queues, false);\n+\tidpf_config_irq_unmap(vport, dev->data->nb_rx_queues);\n \n-\tif (vport->recv_vectors != NULL)\n-\t\tidpf_vc_dealloc_vectors(vport);\n+\tidpf_vc_dealloc_vectors(vport);\n \n \tvport->stopped = 1;\n \n@@ -482,12 +410,6 @@ idpf_dev_close(struct rte_eth_dev *dev)\n \n \tidpf_vport_deinit(vport);\n \n-\trte_free(vport->recv_vectors);\n-\tvport->recv_vectors = NULL;\n-\n-\trte_free(vport->qv_map);\n-\tvport->qv_map = NULL;\n-\n \tadapter->cur_vports &= ~RTE_BIT32(vport->devarg_id);\n \tadapter->cur_vport_nb--;\n \tdev->data->dev_private = NULL;\ndiff --git a/drivers/net/idpf/idpf_ethdev.h b/drivers/net/idpf/idpf_ethdev.h\nindex 07ffe8e408..55be98a8ed 100644\n--- a/drivers/net/idpf/idpf_ethdev.h\n+++ b/drivers/net/idpf/idpf_ethdev.h\n@@ -32,7 +32,6 @@\n #define IDPF_RX_BUFQ_PER_GRP\t2\n \n #define IDPF_DFLT_Q_VEC_NUM\t1\n-#define IDPF_DFLT_INTERVAL\t16\n \n #define IDPF_MIN_BUF_SIZE\t1024\n #define IDPF_MAX_FRAME_SIZE\t9728\n", "prefixes": [ "v3", "07/15" ] }