Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/12207/?format=api
{ "id": 12207, "url": "http://patches.dpdk.org/api/patches/12207/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1461332640-24273-3-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1461332640-24273-3-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1461332640-24273-3-git-send-email-thomas.monjalon@6wind.com", "date": "2016-04-22T13:43:58", "name": "[dpdk-dev,2/4] log: increase default level to info", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1da5c181fc1f2d4577c0b510561c63c99a5f8917", "submitter": { "id": 1, "url": "http://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1461332640-24273-3-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/12207/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/12207/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 7C1E947D0;\n\tFri, 22 Apr 2016 15:44:25 +0200 (CEST)", "from mail-wm0-f52.google.com (mail-wm0-f52.google.com\n\t[74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 56D9837B2\n\tfor <dev@dpdk.org>; Fri, 22 Apr 2016 15:44:23 +0200 (CEST)", "by mail-wm0-f52.google.com with SMTP id u206so27729001wme.1\n\tfor <dev@dpdk.org>; Fri, 22 Apr 2016 06:44:23 -0700 (PDT)", "from XPS13.livebox.home\n\t(APoitiers-658-1-12-134.w86-213.abo.wanadoo.fr. [86.213.195.134])\n\tby smtp.gmail.com with ESMTPSA id\n\tqt3sm8149097wjc.32.2016.04.22.06.44.22\n\tfor <dev@dpdk.org> (version=TLSv1/SSLv3 cipher=OTHER);\n\tFri, 22 Apr 2016 06:44:22 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:subject:date:message-id:in-reply-to:references;\n\tbh=jioaCOEbw6/4o+8YL7YQcPuD2bZTs4swWjFOHKyUR8M=;\n\tb=oi9BiUv0pmv8SSna7TO9JnXTcxs/CbhLsCTgCKjstvSfVaepHnPNzy9xVWxYyoo+OF\n\tkB+pM3nH28/YUnceGPCnjJOEirAWg8Bvh2wEERCFPSPpPGd60qAj18kz/Zqe8u5kwZLO\n\t2VJvzdGQdoPlk63v2+nf2/iXURSuf0UKMg5B0zTIjjhywiKJDfuBREVnyDuD83+VPTMD\n\tBEjH1jTYJH1aMhDyNvWqkDfxy3W5SeeN25zqEr0xF8Dv4VLhqK8A0TXB8NmxtnBjFDt6\n\tlvDcKA5O+G9qdPpVnmGy/O9qh2Jn8ZZfzbeoUx45fwCN/Op3Fr3cJw3cVpG1UYg+/Qcz\n\tcktQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=jioaCOEbw6/4o+8YL7YQcPuD2bZTs4swWjFOHKyUR8M=;\n\tb=X0AHzMssIkuD4mFiOhZ9JHzepz/27kjvJCdgVaXpFClZYGmzbiaJL7J9+cJBWaR8UX\n\tpvpDIdctoZjp9TkCpdACP11Q/IHEDRth8rgOhvjhv7FrX83E4J7Kp+qUvj/IhWzNlOCb\n\tG2HktW3Q4boOVB490BXos1TAJqJ6D6gVEAyY7tQzkrs8FHmeVl7ojUUkLraCWyI2dihH\n\tqHA1m6wDcsqmLREPRHTtrVxF8VwpQ4MMZ49TaXrExOin6r46HU5GeJ6aBjukp3Z85WeX\n\t2dD23WxusM8lWGREpfKYNtCKqlfYoHFRWTSnx8lC552SDhCFXCQF2+SlYviaOgkhkvzM\n\tS2Vg==", "X-Gm-Message-State": "AOPr4FUXOn/U+7fkpVsNpD1SA7JpfLS6eLgSeXity0ryKTACcMJ+QIJltWC8/7BlMhHx4PsP", "X-Received": "by 10.28.27.17 with SMTP id b17mr2691255wmb.19.1461332663109;\n\tFri, 22 Apr 2016 06:44:23 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "dev@dpdk.org", "Date": "Fri, 22 Apr 2016 15:43:58 +0200", "Message-Id": "<1461332640-24273-3-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.7.0", "In-Reply-To": "<1461332640-24273-1-git-send-email-thomas.monjalon@6wind.com>", "References": "<1461332640-24273-1-git-send-email-thomas.monjalon@6wind.com>", "Subject": "[dpdk-dev] [PATCH 2/4] log: increase default level to info", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The default was to compile every logs (including debug) and set\nthe default level to debug.\nAs some debug logs may hurt performance, a notice is added and the\ndefault level is now info.\n\nIn order to enable debug logs, they must be compiled with\nRTE_LOG_LEVEL=RTE_LOG_DEBUG and enabled at runtime with --log-level=8.\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n config/common_base | 2 +-\n doc/guides/faq/faq.rst | 7 ++++---\n lib/librte_eal/common/eal_common_log.c | 5 +++++\n lib/librte_eal/common/eal_common_options.c | 4 ++++\n scripts/test-build.sh | 1 +\n 5 files changed, 15 insertions(+), 4 deletions(-)", "diff": "diff --git a/config/common_base b/config/common_base\nindex 1a54e4c..35d38d9 100644\n--- a/config/common_base\n+++ b/config/common_base\n@@ -88,7 +88,7 @@ CONFIG_RTE_MAX_NUMA_NODES=8\n CONFIG_RTE_MAX_MEMSEG=256\n CONFIG_RTE_MAX_MEMZONE=2560\n CONFIG_RTE_MAX_TAILQ=32\n-CONFIG_RTE_LOG_LEVEL=8\n+CONFIG_RTE_LOG_LEVEL=RTE_LOG_INFO\n CONFIG_RTE_LOG_HISTORY=256\n CONFIG_RTE_LIBEAL_USE_HPET=n\n CONFIG_RTE_EAL_ALLOW_INV_SOCKET_ID=n\ndiff --git a/doc/guides/faq/faq.rst b/doc/guides/faq/faq.rst\nindex 368374f..3228b92 100644\n--- a/doc/guides/faq/faq.rst\n+++ b/doc/guides/faq/faq.rst\n@@ -88,9 +88,7 @@ the wrong socket, the application simply will not start.\n On application startup, there is a lot of EAL information printed. Is there any way to reduce this?\n ---------------------------------------------------------------------------------------------------\n \n-Yes, each EAL has a configuration file that is located in the /config directory. Within each configuration file, you will find CONFIG_RTE_LOG_LEVEL=8.\n-You can change this to a lower value, such as 6 to reduce this printout of debug information. The following is a list of LOG levels that can be found in the rte_log.h file.\n-You must remove, then rebuild, the EAL directory for the change to become effective as the configuration file creates the rte_config.h file in the EAL directory.\n+Yes, the option ``--log-level=`` accepts one of these numbers:\n \n .. code-block:: c\n \n@@ -103,6 +101,9 @@ You must remove, then rebuild, the EAL directory for the change to become effect\n #define RTE_LOG_INFO 7U /* Informational. */\n #define RTE_LOG_DEBUG 8U /* Debug-level messages. */\n \n+It is also possible to change the maximum (and default level) at compile time\n+with ``CONFIG_RTE_LOG_LEVEL``.\n+\n \n How can I tune my network application to achieve lower latency?\n ---------------------------------------------------------------\ndiff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c\nindex 1ae8de7..64aa79f 100644\n--- a/lib/librte_eal/common/eal_common_log.c\n+++ b/lib/librte_eal/common/eal_common_log.c\n@@ -333,5 +333,10 @@ rte_eal_common_log_init(FILE *default_log)\n \n \tdefault_log_stream = default_log;\n \trte_openlog_stream(default_log);\n+\n+#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG\n+\tRTE_LOG(NOTICE, EAL, \"Debug logs available - lower performance\\n\");\n+#endif\n+\n \treturn 0;\n }\ndiff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c\nindex 2b418d5..3efc90f 100644\n--- a/lib/librte_eal/common/eal_common_options.c\n+++ b/lib/librte_eal/common/eal_common_options.c\n@@ -139,7 +139,11 @@ eal_reset_internal_config(struct internal_config *internal_cfg)\n \n \tinternal_cfg->syslog_facility = LOG_DAEMON;\n \t/* default value from build option */\n+#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG\n+\tinternal_cfg->log_level = RTE_LOG_INFO;\n+#else\n \tinternal_cfg->log_level = RTE_LOG_LEVEL;\n+#endif\n \n \tinternal_cfg->xen_dom0_support = 0;\n \ndiff --git a/scripts/test-build.sh b/scripts/test-build.sh\nindex 9de90f7..9685dea 100755\n--- a/scripts/test-build.sh\n+++ b/scripts/test-build.sh\n@@ -138,6 +138,7 @@ config () # <directory> <target> <options>\n \t\t! echo $3 | grep -q '+shared' || \\\n \t\tsed -ri 's,(SHARED_LIB=)n,\\1y,' $1/.config\n \t\t! echo $3 | grep -q '+debug' || ( \\\n+\t\tsed -ri 's,(RTE_LOG_LEVEL=).*,\\1RTE_LOG_DEBUG,' $1/.config\n \t\tsed -ri 's,(_DEBUG.*=)n,\\1y,' $1/.config\n \t\tsed -ri 's,(_STAT.*=)n,\\1y,' $1/.config\n \t\tsed -ri 's,(TEST_PMD_RECORD_.*=)n,\\1y,' $1/.config )\n", "prefixes": [ "dpdk-dev", "2/4" ] }