Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/121427/?format=api
{ "id": 121427, "url": "http://patches.dpdk.org/api/patches/121427/?format=api", "web_url": "http://patches.dpdk.org/project/dts/patch/20221228050850.33004-4-ke1.xu@intel.com/", "project": { "id": 3, "url": "http://patches.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<20221228050850.33004-4-ke1.xu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dts/20221228050850.33004-4-ke1.xu@intel.com", "date": "2022-12-28T05:08:48", "name": "[V2,3/5] tests/vf_offload: Use modified checksum_validate to replace checksum_validate_tunnel.", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f6976b86c2e64a1113217b5566ea616b21ffb370", "submitter": { "id": 2810, "url": "http://patches.dpdk.org/api/people/2810/?format=api", "name": "Ke Xu", "email": "ke1.xu@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dts/patch/20221228050850.33004-4-ke1.xu@intel.com/mbox/", "series": [ { "id": 26302, "url": "http://patches.dpdk.org/api/series/26302/?format=api", "web_url": "http://patches.dpdk.org/project/dts/list/?series=26302", "date": "2022-12-28T05:08:45", "name": "Improve checksum validate and tso packet counting.", "version": 2, "mbox": "http://patches.dpdk.org/series/26302/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/121427/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/121427/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CA9CEA04FD;\n\tWed, 28 Dec 2022 06:10:28 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C569F40FDF;\n\tWed, 28 Dec 2022 06:10:28 +0100 (CET)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by mails.dpdk.org (Postfix) with ESMTP id 5921342D12\n for <dts@dpdk.org>; Wed, 28 Dec 2022 06:10:26 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Dec 2022 21:10:26 -0800", "from dpdk-xuke-lab.sh.intel.com ([10.67.119.8])\n by fmsmga002.fm.intel.com with ESMTP; 27 Dec 2022 21:10:24 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1672204226; x=1703740226;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=CHXS1kQ3cpMVP4/aHEkZkJB5ITZ0QD5bAdFGV/Yvot8=;\n b=SqjdwduFij5O5UkwbNQCcpiZI1ZN1bs/Vr+0Z2pTz0QgZdpNcwlD//mN\n RN49LgBzGpyeGRNFslIdXZOKB1j9UD06jccCqSIIXZhwhltQFLmaNUQ3O\n ob6I0DbThdzFxKkb32SiW7AYurhmOsG5Dln0/xLkk/qZDotWeWUsRidRa\n WUWv28pXZhByDGEP/zMjmvLWFRREpcFkebo0Y9um2pXwlNU9iXTcUD+Ek\n WUvVZrl0tm/8+FEaoDVKehOlmY/raNzJxytoMOtE0bc9hamx/f0XcjdBl\n U5COLxix/gGM9dHLPyXSjfO6i3Vs+CYjO1CcIwXrDfFJ0HecwnmR52RkU w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10573\"; a=\"300499474\"", "E=Sophos;i=\"5.96,280,1665471600\"; d=\"scan'208\";a=\"300499474\"", "E=McAfee;i=\"6500,9779,10573\"; a=\"760536364\"", "E=Sophos;i=\"5.96,280,1665471600\"; d=\"scan'208\";a=\"760536364\"" ], "X-ExtLoop1": "1", "From": "Ke Xu <ke1.xu@intel.com>", "To": "dts@dpdk.org", "Cc": "qi.fu@intel.com, weiyuanx.li@intel.com, lijuan.tu@intel.com,\n ke1.xu@intel.com", "Subject": "[DTS][PATCH V2 3/5] tests/vf_offload: Use modified checksum_validate\n to replace checksum_validate_tunnel.", "Date": "Wed, 28 Dec 2022 13:08:48 +0800", "Message-Id": "<20221228050850.33004-4-ke1.xu@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20221228050850.33004-1-ke1.xu@intel.com>", "References": "<20221228050850.33004-1-ke1.xu@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org" }, "content": "Use checksum_validate method to validate and remove the tunnel one. The\n checksum_validate is updated to cover tunnel packet validation, the\n checksum_validate_tunnel is no longer necessary.\n\nSigned-off-by: Ke Xu <ke1.xu@intel.com>\n---\n tests/TestSuite_vf_offload.py | 62 ++---------------------------------\n 1 file changed, 3 insertions(+), 59 deletions(-)", "diff": "diff --git a/tests/TestSuite_vf_offload.py b/tests/TestSuite_vf_offload.py\nindex 42af482f..bccffb3d 100644\n--- a/tests/TestSuite_vf_offload.py\n+++ b/tests/TestSuite_vf_offload.py\n@@ -394,64 +394,6 @@ class TestVfOffload(TestCase):\n \n self.verify(len(result) == 0, \",\".join(list(result.values())))\n \n- def checksum_validate_tunnel(self, packets_sent, packets_expected):\n- \"\"\"\n- Validate the checksum.\n- \"\"\"\n- tx_interface = self.tester.get_interface(\n- self.tester.get_local_port(self.dut_ports[0])\n- )\n- rx_interface = self.tester.get_interface(\n- self.tester.get_local_port(self.dut_ports[1])\n- )\n- sniff_src = self.vm0_testpmd.get_port_mac(0)\n- checksum_pattern = re.compile(\"chksum.*=.*(0x[0-9a-z]+)\")\n- sniff_src = \"52:00:00:00:00:00\"\n- chksum = dict()\n- # self.tester.send_expect(\"scapy\", \">>> \")\n-\n- for packet_type in list(packets_expected.keys()):\n- self.tester.send_expect(\"scapy\", \">>> \")\n- self.tester.send_expect(\"p = %s\" % packets_expected[packet_type], \">>>\")\n- out = self.tester.send_expect(\"p.show2()\", \">>>\")\n- chksums = checksum_pattern.findall(out)\n- expected_chksum = chksums\n- chksum[packet_type] = chksums\n- print(packet_type, \": \", chksums)\n-\n- self.tester.send_expect(\"exit()\", \"#\")\n-\n- self.tester.scapy_background()\n- inst = self.tester.tcpdump_sniff_packets(\n- intf=rx_interface,\n- count=len(packets_sent),\n- filters=[{\"layer\": \"ether\", \"config\": {\"src\": sniff_src}}],\n- )\n-\n- # Send packet.\n- self.tester.scapy_foreground()\n-\n- self.tester.scapy_append(\n- 'sendp([%s], iface=\"%s\")' % (packets_sent[packet_type], tx_interface)\n- )\n- self.tester.scapy_execute()\n- out = self.tester.scapy_get_result()\n- p = self.tester.load_tcpdump_sniff_packets(inst)\n- nr_packets = len(p)\n- print(p)\n- chksums = checksum_pattern.findall(p[0].show2(dump=True))\n- packets_received = chksums\n- self.logger.debug(f\"packets_received: {packets_received}\")\n- self.logger.debug(f\"expected_chksum: {expected_chksum}\")\n- self.verify(\n- len(expected_chksum) == len(packets_received),\n- f\"The chksum type {packet_type} length of the actual result is inconsistent with the expected length!\",\n- )\n- self.verify(\n- packets_received == expected_chksum,\n- f\"The actually received chksum {packet_type} is inconsistent with the expectation\",\n- )\n-\n @check_supported_nic(\n [\"ICE_100G-E810C_QSFP\", \"ICE_25G-E810C_SFP\", \"ICE_25G-E810_XXV_SFP\"]\n )\n@@ -570,7 +512,7 @@ class TestVfOffload(TestCase):\n self.vm0_testpmd.execute_cmd(\"start\")\n self.vm0_testpmd.wait_link_status_up(0)\n self.vm0_testpmd.wait_link_status_up(1)\n- self.checksum_validate_tunnel(pkts, pkts_ref)\n+ result = self.checksum_validate(pkts, pkts_ref)\n # Validate checksum on the receive packet\n out = self.vm0_testpmd.execute_cmd(\"stop\")\n bad_outer_ipcsum = self.vm0_testpmd.get_pmd_value(\"Bad-outer-ipcsum:\", out)\n@@ -588,6 +530,8 @@ class TestVfOffload(TestCase):\n self.verify(bad_inner_ipcsum == 36, \"Bad-ipcsum check error\")\n self.verify(bad_inner_l4csum == 72, \"Bad-l4csum check error\")\n \n+ self.verify(len(result) == 0, \",\".join(list(result.values())))\n+\n def test_checksum_offload_disable(self):\n \"\"\"\n Enable SW checksum offload.\n", "prefixes": [ "V2", "3/5" ] }