Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/121144/?format=api
{ "id": 121144, "url": "http://patches.dpdk.org/api/patches/121144/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221221025202.31733-1-jesna.k.e@amd.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221221025202.31733-1-jesna.k.e@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221221025202.31733-1-jesna.k.e@amd.com", "date": "2022-12-21T02:52:01", "name": "[v1,1/2] net/axgbe: add multi-process support", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7ced5b7d24563f9954e0b986d694811c688cd24a", "submitter": { "id": 2920, "url": "http://patches.dpdk.org/api/people/2920/?format=api", "name": "Jesna K E", "email": "jesna.k.e@amd.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221221025202.31733-1-jesna.k.e@amd.com/mbox/", "series": [ { "id": 26203, "url": "http://patches.dpdk.org/api/series/26203/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=26203", "date": "2022-12-21T02:52:01", "name": "[v1,1/2] net/axgbe: add multi-process support", "version": 1, "mbox": "http://patches.dpdk.org/series/26203/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/121144/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/121144/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3499FA0545;\n\tWed, 21 Dec 2022 03:52:24 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1C6EE40698;\n\tWed, 21 Dec 2022 03:52:24 +0100 (CET)", "from NAM10-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam10on2057.outbound.protection.outlook.com [40.107.94.57])\n by mails.dpdk.org (Postfix) with ESMTP id 762B740684\n for <dev@dpdk.org>; Wed, 21 Dec 2022 03:52:22 +0100 (CET)", "from DM6PR05CA0040.namprd05.prod.outlook.com (2603:10b6:5:335::9) by\n MN2PR12MB4343.namprd12.prod.outlook.com (2603:10b6:208:26f::9) with\n Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.5924.16; Wed, 21 Dec 2022 02:52:20 +0000", "from DM6NAM11FT037.eop-nam11.prod.protection.outlook.com\n (2603:10b6:5:335:cafe::bf) by DM6PR05CA0040.outlook.office365.com\n (2603:10b6:5:335::9) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.5 via Frontend\n Transport; Wed, 21 Dec 2022 02:52:19 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n DM6NAM11FT037.mail.protection.outlook.com (10.13.172.122) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.5944.10 via Frontend Transport; Wed, 21 Dec 2022 02:52:19 +0000", "from cae-Bilby-RV1.amd.com (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 20 Dec\n 2022 20:52:17 -0600" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=fpsKIezJRAT+/F7RBE7xASzj+K51EXTTmQc1gJjnoKZq5rZDOl7c5W3NWyTsiQyosBeCWVVgAJqkRmISC3UemVpLvGdDx/qAU6YyK1d9jyh53qC1I+6F2kHvsur08Q2eBUVxXzavfqGXL0uOXg7B1L5ZUmCje8p87ieI4ZgfAOV9Q4VSEYoGcXSn3wd0uEHvcIc35oIhDdTILkHq+kgALpFK/WQWCUtXWr8w2kcHMl0atl4xTn8Unk/RqwqFBv0qDJX2FeHl1c0AIr+p6KvdybzwVIwJZmQyQi5uh4U/P5K6liJUEMzUsgAbRGvTRkwux285uPfR2Hj/iztN5+fR5g==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=rCXxSjgdKQdWKuPuJDRFEi2bRwqAfFNTtonLp7iHhfY=;\n b=UlONidqNyxvsN2dXXK9vAd4+sZG48TAnAe4CY0NUPAhA83LkFE6g87EubmS/vkNOio9tz0qZ8jd7LktcKRGId1otKREcmdugHkoxZf14X+V3M+1KkGcPzVlQ1LKMwJXxgPLMN8U5h0dzoqoghJ8prKXqba0LjeMLJTVUFwb19IMDI2KPW/jLH2Fbk2mDgg0W+ytyTl+EYkq8E2jcbuOlvQLOYFeKHLiWOZBPK3uPqYqglsk1ftt8nsgmX4M/qlX1cCQuCNFcjgE52XKzmF3NLiSZZniktDwQzhmS1uwRrsZckeUfYKlwr3AtUTCOHtJ/5Zt1aL8Iv9mzICi2UF5iMA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=rCXxSjgdKQdWKuPuJDRFEi2bRwqAfFNTtonLp7iHhfY=;\n b=CYqlzu/Cmpta2rJfFa0Si9g4OQvhaGOsbyB079noguuoNWnMU3fLtm46dQgw8cFPXxsnG7uUpcaO0JHOgPpRKJVXckwLzcXoJ8D82URXPNeNkZ797NXCLHtn63EDcpI9Ab8pQAq3RyM+8wYtxbWFZPqQB0ej/pGAJHZ3/do2q9A=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Jesna K E <jesna.k.e@amd.com>", "To": "<dev@dpdk.org>", "CC": "<Ferruh.Yigit@amd.com>, <Selwin.Sebastian@amd.com>, Jesna K E\n <jesna.k.e@amd.com>", "Subject": "[PATCH v1 1/2] net/axgbe: add multi-process support", "Date": "Wed, 21 Dec 2022 08:22:01 +0530", "Message-ID": "<20221221025202.31733-1-jesna.k.e@amd.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "DM6NAM11FT037:EE_|MN2PR12MB4343:EE_", "X-MS-Office365-Filtering-Correlation-Id": "56385877-a74f-443a-727c-08dae2fe60a1", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n JExV3oryTXOAgSv8IgxgqhLybP0h7h5pIajTomlXNVia/YXdD+QTIQofUwJMN8H1A8eFArjsNmb+cbcOvRyT7w9OY5EzC0jY0/bdra+xpYajoiaXoVV62X27ef0TJiaWw61c1HcCHBztEFAOSOpjvR0BCQq0HU33p/KbVHwGZGvQfsVJV0M2DoGgNX86wrAdAaIwT7KBAkqAAdXgehj3ulN3UzFDo0uN26vpCIwR7C/FJztB3msTNhc/huZ9LTrgJdTqLf4scl028tkmNE/+1jNr+d/ROt6z7a0pIHtqgWvhDZhkCauG/H6MhaYE7bdW3A1+g09dPh4JYBfB5scVU8NJBhxmxY1xbLZRlgjEHF64FFCMjNfKmtntVdoLYNs8jthxl0oxwxh7p3JsDSs0541o9RVpAbh4Yr8xlMgxKztFA84SPKdqroUmsOR/yF34Ix2aSy42kpW+Q9iRHpy9T0zQCfYzXdb1twqwO1asHf6eCpx+K6KJkC/iMwJlGx6DTUluFFGXsvAKR1Ulx5Mjy8yZiDS3V00ifboCTjNlo21/psSAkHj3rqoUyAmvJhnPqbhAjYWNMtXhh/5nJTG8NbGQ+fUk97WjpWYeWOy5pZfldUEeimMyNxTNtJ7NKZbAHDNrJUx5FR5KWbbt8JPcGaNFU5KZe6wvbem8mg3kxkpygkVpPdIl6c7uHn9kdwuQ6qYRDhvZVGmjfoqOVcZ4bl2snEQNSNY3XKFiVSrbvOU=", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230022)(4636009)(346002)(39860400002)(396003)(376002)(136003)(451199015)(46966006)(36840700001)(40470700004)(6666004)(82310400005)(356005)(186003)(7696005)(81166007)(26005)(82740400003)(478600001)(4326008)(336012)(41300700001)(54906003)(36860700001)(103116003)(6916009)(2616005)(8676002)(316002)(40480700001)(16526019)(70586007)(1076003)(70206006)(2906002)(83380400001)(36756003)(8936002)(426003)(40460700003)(47076005)(86362001)(5660300002)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "21 Dec 2022 02:52:19.6329 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 56385877-a74f-443a-727c-08dae2fe60a1", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DM6NAM11FT037.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MN2PR12MB4343", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Added multi-process support for axgbe PMD\nTo achieve multi-process support separate out TX and RX function\ninside the axgbe driver and call that from a secondary process\nwhen it is attaching to an already-configured NIC\n\nSigned-off-by: Jesna K E <jesna.k.e@amd.com>\n---\n doc/guides/nics/features/axgbe.ini | 1 +\n drivers/net/axgbe/axgbe_ethdev.c | 65 ++++++++++++++++++++++--------\n drivers/net/axgbe/axgbe_rxtx.c | 11 -----\n drivers/net/axgbe/axgbe_rxtx.h | 7 +++-\n 4 files changed, 55 insertions(+), 29 deletions(-)", "diff": "diff --git a/doc/guides/nics/features/axgbe.ini b/doc/guides/nics/features/axgbe.ini\nindex 821bb682d4..5e2d6498e5 100644\n--- a/doc/guides/nics/features/axgbe.ini\n+++ b/doc/guides/nics/features/axgbe.ini\n@@ -18,6 +18,7 @@ L3 checksum offload = Y\n L4 checksum offload = Y\n Basic stats = Y\n FW version = Y\n+Multiprocess aware = Y\n Linux = Y\n x86-32 = Y\n x86-64 = Y\ndiff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c\nindex b071e4e460..4b3d655bd3 100644\n--- a/drivers/net/axgbe/axgbe_ethdev.c\n+++ b/drivers/net/axgbe/axgbe_ethdev.c\n@@ -353,8 +353,6 @@ axgbe_dev_start(struct rte_eth_dev *dev)\n {\n \tstruct axgbe_port *pdata = dev->data->dev_private;\n \tint ret;\n-\tstruct rte_eth_dev_data *dev_data = dev->data;\n-\tuint16_t max_pkt_len;\n \n \tdev->dev_ops = &axgbe_eth_dev_ops;\n \n@@ -388,17 +386,8 @@ axgbe_dev_start(struct rte_eth_dev *dev)\n \trte_bit_relaxed_clear32(AXGBE_STOPPED, &pdata->dev_state);\n \trte_bit_relaxed_clear32(AXGBE_DOWN, &pdata->dev_state);\n \n-\tmax_pkt_len = dev_data->mtu + RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN;\n-\tif ((dev_data->dev_conf.rxmode.offloads & RTE_ETH_RX_OFFLOAD_SCATTER) ||\n-\t\t\t\tmax_pkt_len > pdata->rx_buf_size)\n-\t\tdev_data->scattered_rx = 1;\n-\n-\t/* Scatter Rx handling */\n-\tif (dev_data->scattered_rx)\n-\t\tdev->rx_pkt_burst = ð_axgbe_recv_scattered_pkts;\n-\telse\n-\t\tdev->rx_pkt_burst = &axgbe_recv_pkts;\n-\n+\taxgbe_set_rx_function(dev);\n+\taxgbe_set_tx_function(dev);\n \treturn 0;\n }\n \n@@ -2145,6 +2134,46 @@ get_pci_rc_devid(void)\n \treturn (uint16_t)device_id;\n }\n \n+/* Takes ethdev as parameter\n+ * Used in dev_start by primary process and then\n+ * in dev_init by secondary process when attaching to an existing ethdev.\n+ */\n+void\n+axgbe_set_tx_function(struct rte_eth_dev *dev)\n+{\n+\tstruct axgbe_port *pdata = dev->data->dev_private;\n+\tstruct axgbe_tx_queue *txq = dev->data->tx_queues[0];\n+\n+\tif (pdata->multi_segs_tx)\n+\t\tdev->tx_pkt_burst = &axgbe_xmit_pkts_seg;\n+#ifdef RTE_ARCH_X86\n+\tif (!txq->vector_disable &&\n+\t\t\trte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_128)\n+\t\tdev->tx_pkt_burst = &axgbe_xmit_pkts_vec;\n+#else\n+\t\tdev->tx_pkt_burst = &axgbe_xmit_pkts;\n+#endif\n+}\n+\n+void\n+axgbe_set_rx_function(struct rte_eth_dev *dev)\n+{\n+\tstruct rte_eth_dev_data *dev_data = dev->data;\n+\tuint16_t max_pkt_len;\n+\tstruct axgbe_port *pdata;\n+\n+\tpdata = dev->data->dev_private;\n+\tmax_pkt_len = dev_data->mtu + RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN;\n+\tif ((dev_data->dev_conf.rxmode.offloads & RTE_ETH_RX_OFFLOAD_SCATTER) ||\n+\t\t\tmax_pkt_len > pdata->rx_buf_size)\n+\t\tdev_data->scattered_rx = 1;\n+\t/* Scatter Rx handling */\n+\tif (dev_data->scattered_rx)\n+\t\tdev->rx_pkt_burst = ð_axgbe_recv_scattered_pkts;\n+\telse\n+\t\tdev->rx_pkt_burst = &axgbe_recv_pkts;\n+}\n+\n /*\n * It returns 0 on success.\n */\n@@ -2159,17 +2188,20 @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev)\n \tint ret;\n \n \teth_dev->dev_ops = &axgbe_eth_dev_ops;\n-\n \teth_dev->rx_descriptor_status = axgbe_dev_rx_descriptor_status;\n \teth_dev->tx_descriptor_status = axgbe_dev_tx_descriptor_status;\n \n+\teth_dev->tx_pkt_burst = &axgbe_xmit_pkts;\n+\teth_dev->rx_pkt_burst = &axgbe_recv_pkts;\n \t/*\n \t * For secondary processes, we don't initialise any further as primary\n \t * has already done this work.\n \t */\n-\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n+\tif (rte_eal_process_type() != RTE_PROC_PRIMARY) {\n+\t\taxgbe_set_tx_function(eth_dev);\n+\t\taxgbe_set_rx_function(eth_dev);\n \t\treturn 0;\n-\n+\t}\n \teth_dev->data->dev_flags |= RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS;\n \n \tpdata = eth_dev->data->dev_private;\n@@ -2177,7 +2209,6 @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev)\n \trte_bit_relaxed_set32(AXGBE_DOWN, &pdata->dev_state);\n \trte_bit_relaxed_set32(AXGBE_STOPPED, &pdata->dev_state);\n \tpdata->eth_dev = eth_dev;\n-\n \tpci_dev = RTE_DEV_TO_PCI(eth_dev->device);\n \tpdata->pci_dev = pci_dev;\n \ndiff --git a/drivers/net/axgbe/axgbe_rxtx.c b/drivers/net/axgbe/axgbe_rxtx.c\nindex 7cff79e030..9b283bd9d0 100644\n--- a/drivers/net/axgbe/axgbe_rxtx.c\n+++ b/drivers/net/axgbe/axgbe_rxtx.c\n@@ -629,17 +629,6 @@ int axgbe_dev_tx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,\n \t\t\t\tRTE_ETH_TX_OFFLOAD_MULTI_SEGS))\n \t\tpdata->multi_segs_tx = true;\n \n-\tif (pdata->multi_segs_tx)\n-\t\tdev->tx_pkt_burst = &axgbe_xmit_pkts_seg;\n-\telse if (txq->vector_disable ||\n-\t\t\trte_vect_get_max_simd_bitwidth() < RTE_VECT_SIMD_128)\n-\t\tdev->tx_pkt_burst = &axgbe_xmit_pkts;\n-\telse\n-#ifdef RTE_ARCH_X86\n-\t\tdev->tx_pkt_burst = &axgbe_xmit_pkts_vec;\n-#else\n-\t\tdev->tx_pkt_burst = &axgbe_xmit_pkts;\n-#endif\n \n \treturn 0;\n }\ndiff --git a/drivers/net/axgbe/axgbe_rxtx.h b/drivers/net/axgbe/axgbe_rxtx.h\nindex eeef908ceb..d5660f5c4b 100644\n--- a/drivers/net/axgbe/axgbe_rxtx.h\n+++ b/drivers/net/axgbe/axgbe_rxtx.h\n@@ -158,7 +158,12 @@ struct axgbe_tx_queue {\n * RX/TX function prototypes\n */\n \n-\n+/* Takes an ethdev and sets up the tx function to be used based on\n+ * the queue parameters. Used in dev_start by primary process and then\n+ * in dev_init by secondary process when attaching to an existing ethdev.\n+ */\n+void axgbe_set_tx_function(struct rte_eth_dev *dev);\n+void axgbe_set_rx_function(struct rte_eth_dev *dev);\n void axgbe_dev_tx_queue_release(struct rte_eth_dev *dev, uint16_t queue_idx);\n int axgbe_dev_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id,\n \t\t\t uint16_t nb_tx_desc, unsigned int socket_id,\n", "prefixes": [ "v1", "1/2" ] }