Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/12046/?format=api
{ "id": 12046, "url": "http://patches.dpdk.org/api/patches/12046/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1460629199-32489-10-git-send-email-olivier.matz@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1460629199-32489-10-git-send-email-olivier.matz@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1460629199-32489-10-git-send-email-olivier.matz@6wind.com", "date": "2016-04-14T10:19:32", "name": "[dpdk-dev,09/36] mempool: remove const qualifier in dump and audit", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f81b1419ba9224bfdd8731d80ebb3e1883d71c69", "submitter": { "id": 8, "url": "http://patches.dpdk.org/api/people/8/?format=api", "name": "Olivier Matz", "email": "olivier.matz@6wind.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1460629199-32489-10-git-send-email-olivier.matz@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/12046/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/12046/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 5AC48567A;\n\tThu, 14 Apr 2016 12:20:35 +0200 (CEST)", "from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com\n\t[62.23.145.76]) by dpdk.org (Postfix) with ESMTP id E9BEB298F\n\tfor <dev@dpdk.org>; Thu, 14 Apr 2016 12:20:23 +0200 (CEST)", "from glumotte.dev.6wind.com (unknown [10.16.0.195])\n\tby proxy.6wind.com (Postfix) with ESMTP id 9118128F36;\n\tThu, 14 Apr 2016 12:19:40 +0200 (CEST)" ], "From": "Olivier Matz <olivier.matz@6wind.com>", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com,\n\tstephen@networkplumber.org", "Date": "Thu, 14 Apr 2016 12:19:32 +0200", "Message-Id": "<1460629199-32489-10-git-send-email-olivier.matz@6wind.com>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": "<1460629199-32489-1-git-send-email-olivier.matz@6wind.com>", "References": "<1457540381-20274-1-git-send-email-olivier.matz@6wind.com>\n\t<1460629199-32489-1-git-send-email-olivier.matz@6wind.com>", "Subject": "[dpdk-dev] [PATCH 09/36] mempool: remove const qualifier in dump\n\tand audit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In next commits, we will use an iterator to walk through the objects in\nmempool in rte_mempool_audit(). This iterator takes a \"struct\nrte_mempool *\" as a parameter because it is assumed that the callback\nfunction can modify the mempool.\n\nThe previous approach was to introduce a RTE_DECONST() macro, but\nafter discussion it seems that removing the const qualifier is better\nto avoid fooling the compiler, and also because these functions are\nnot used in datapath (possible compiler optimizations due to const\nare not critical).\n\nSigned-off-by: Olivier Matz <olivier.matz@6wind.com>\n---\n lib/librte_mempool/rte_mempool.c | 8 ++++----\n lib/librte_mempool/rte_mempool.h | 4 ++--\n 2 files changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c\nindex 664a2bf..0fd244b 100644\n--- a/lib/librte_mempool/rte_mempool.c\n+++ b/lib/librte_mempool/rte_mempool.c\n@@ -781,7 +781,7 @@ mempool_obj_audit(void *arg, void *start, void *end, uint32_t idx)\n }\n \n static void\n-mempool_audit_cookies(const struct rte_mempool *mp)\n+mempool_audit_cookies(struct rte_mempool *mp)\n {\n \tuint32_t elt_sz, num;\n \tstruct mempool_audit_arg arg;\n@@ -839,7 +839,7 @@ mempool_audit_cache(const struct rte_mempool *mp)\n \n /* check the consistency of mempool (size, cookies, ...) */\n void\n-rte_mempool_audit(const struct rte_mempool *mp)\n+rte_mempool_audit(struct rte_mempool *mp)\n {\n \tmempool_audit_cache(mp);\n \tmempool_audit_cookies(mp);\n@@ -850,7 +850,7 @@ rte_mempool_audit(const struct rte_mempool *mp)\n \n /* dump the status of the mempool on the console */\n void\n-rte_mempool_dump(FILE *f, const struct rte_mempool *mp)\n+rte_mempool_dump(FILE *f, struct rte_mempool *mp)\n {\n #ifdef RTE_LIBRTE_MEMPOOL_DEBUG\n \tstruct rte_mempool_debug_stats sum;\n@@ -921,7 +921,7 @@ rte_mempool_dump(FILE *f, const struct rte_mempool *mp)\n void\n rte_mempool_list_dump(FILE *f)\n {\n-\tconst struct rte_mempool *mp = NULL;\n+\tstruct rte_mempool *mp = NULL;\n \tstruct rte_tailq_entry *te;\n \tstruct rte_mempool_list *mempool_list;\n \ndiff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h\nindex 54a5917..a80335f 100644\n--- a/lib/librte_mempool/rte_mempool.h\n+++ b/lib/librte_mempool/rte_mempool.h\n@@ -645,7 +645,7 @@ rte_dom0_mempool_create(const char *name, unsigned n, unsigned elt_size,\n * @param mp\n * A pointer to the mempool structure.\n */\n-void rte_mempool_dump(FILE *f, const struct rte_mempool *mp);\n+void rte_mempool_dump(FILE *f, struct rte_mempool *mp);\n \n /**\n * @internal Put several objects back in the mempool; used internally.\n@@ -1183,7 +1183,7 @@ rte_mempool_virt2phy(const struct rte_mempool *mp, const void *elt)\n * @param mp\n * A pointer to the mempool structure.\n */\n-void rte_mempool_audit(const struct rte_mempool *mp);\n+void rte_mempool_audit(struct rte_mempool *mp);\n \n /**\n * Return a pointer to the private data in an mempool structure.\n", "prefixes": [ "dpdk-dev", "09/36" ] }