Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/120452/?format=api
{ "id": 120452, "url": "http://patches.dpdk.org/api/patches/120452/?format=api", "web_url": "http://patches.dpdk.org/project/dts/patch/20221205095556.16862-1-weiyuanx.li@intel.com/", "project": { "id": 3, "url": "http://patches.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<20221205095556.16862-1-weiyuanx.li@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dts/20221205095556.16862-1-weiyuanx.li@intel.com", "date": "2022-12-05T09:55:56", "name": "[V1] tests/*: optimized and add more test points", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "eacd886d6aa310cc844e86494269e649bf258f25", "submitter": { "id": 2477, "url": "http://patches.dpdk.org/api/people/2477/?format=api", "name": "Weiyuan Li", "email": "weiyuanx.li@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dts/patch/20221205095556.16862-1-weiyuanx.li@intel.com/mbox/", "series": [ { "id": 25997, "url": "http://patches.dpdk.org/api/series/25997/?format=api", "web_url": "http://patches.dpdk.org/project/dts/list/?series=25997", "date": "2022-12-05T09:55:56", "name": "[V1] tests/*: optimized and add more test points", "version": 1, "mbox": "http://patches.dpdk.org/series/25997/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/120452/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/120452/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7EF8EA0547;\n\tMon, 5 Dec 2022 10:56:10 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 615B440F18;\n\tMon, 5 Dec 2022 10:56:10 +0100 (CET)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by mails.dpdk.org (Postfix) with ESMTP id 50CD540A87\n for <dts@dpdk.org>; Mon, 5 Dec 2022 10:56:08 +0100 (CET)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 05 Dec 2022 01:56:07 -0800", "from unknown (HELO localhost.localdomain) ([10.239.252.248])\n by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 05 Dec 2022 01:56:05 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1670234168; x=1701770168;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=4UMCGlb9nbX8r4TqvOV+STB1mTtw1Iw82iDoBgL02oM=;\n b=bkz0B/jmsP1ykyLxtnReaKBAMpJB3hwX4IIrnnzyvw/j6qSF0vSPvlmk\n v+27IUbyaGOwhV1QIKfEsX72irERKtEfEw++8tRVSMMWqxDdpfGnSbTq5\n HUbyedYcBIjpK3ul064huERH/a5Rf+zaR+Hu7UUJEDpDzIqSLIHr0S66r\n 32/hm84lzSYNXl2aWOfC06ctEL1T9HSDs9wue9448W5o1Ny/FBoY02JYG\n R3Ohf1grwg2AHOW62TZV5+zQTS20CHsbX6VRP3eXDWJnRJe+dzrgmeo2G\n mnxaDi/ZkP0EBY9WavbiZ3+n4LusJX9WO1bCYMfEXo26w+nNfSigiDE6Y A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10551\"; a=\"313956563\"", "E=Sophos;i=\"5.96,219,1665471600\"; d=\"scan'208\";a=\"313956563\"", "E=McAfee;i=\"6500,9779,10551\"; a=\"974626459\"", "E=Sophos;i=\"5.96,219,1665471600\"; d=\"scan'208\";a=\"974626459\"" ], "From": "Weiyuan Li <weiyuanx.li@intel.com>", "To": "dts@dpdk.org", "Cc": "Weiyuan Li <weiyuanx.li@intel.com>", "Subject": "[dts][PATCH V1] tests/*: optimized and add more test points", "Date": "Mon, 5 Dec 2022 17:55:56 +0800", "Message-Id": "<20221205095556.16862-1-weiyuanx.li@intel.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org" }, "content": "The judgment of rx and tx bytes by adding the test point on the suite stats_check.\n\nSigned-off-by: Weiyuan Li <weiyuanx.li@intel.com>\n---\n tests/TestSuite_stats_checks.py | 123 ++++++++++++++++++++++++++++----\n 1 file changed, 110 insertions(+), 13 deletions(-)", "diff": "diff --git a/tests/TestSuite_stats_checks.py b/tests/TestSuite_stats_checks.py\nindex f81d284e..7c2e6802 100644\n--- a/tests/TestSuite_stats_checks.py\n+++ b/tests/TestSuite_stats_checks.py\n@@ -23,7 +23,26 @@ from framework.test_case import TestCase\n ETHER_HEADER_LEN = 18\n IP_HEADER_LEN = 20\n RANDOM_IP_POOL = [\"192.168.10.222/0\"]\n-prefix_list = [\"rx_good_packets\", \"tx_good_packets\", \"rx_good_bytes\", \"tx_good_bytes\"]\n+prefix_list = [\n+ \"rx_good_packets\",\n+ \"tx_good_packets\",\n+ \"rx_good_bytes\",\n+ \"tx_good_bytes\",\n+ \"tx_size_64_packets\",\n+ \"tx_size_65_to_127_packets\",\n+ \"tx_size_128_to_255_packets\",\n+ \"tx_size_256_to_511_packets\",\n+ \"tx_size_512_to_1023_packets\",\n+ \"tx_size_1024_to_1522_packets\",\n+ \"tx_size_1523_to_max_packets\",\n+ \"rx_size_64_packets\",\n+ \"rx_size_65_to_127_packets\",\n+ \"rx_size_128_to_255_packets\",\n+ \"rx_size_256_to_511_packets\",\n+ \"rx_size_512_to_1023_packets\",\n+ \"rx_size_1024_to_1522_packets\",\n+ \"rx_size_1523_to_max_packets\",\n+]\n \n \n class TestStatsChecks(TestCase):\n@@ -99,6 +118,21 @@ class TestStatsChecks(TestCase):\n self.tester.get_local_port(self.dut_ports[0])\n ),\n )\n+ tester_intf = self.tester.get_interface(\n+ self.tester.get_local_port(self.dut_ports[0])\n+ )\n+ # enable tester mtu\n+ tester_port = self.tester.get_local_port(self.dut_ports[0])\n+ self.netobj = self.tester.ports_info[tester_port][\"port\"]\n+ self.netobj.enable_jumbo(framesize=3000)\n+ # add judgment on rx and tx bytes, not same on if add crc 4 bytes\n+ packets_length = [65, 128, 256, 512, 1024, 1523]\n+ for i in range(count):\n+ for len in packets_length:\n+ src_ip = self.get_random_ip()\n+ packet1 = f'sendp([Ether(dst=\"{mac}\", src=\"02:00:00:00:00:00\")/IP(src=\"{src_ip}\", dst=\"192.168.0.{i}\")/(\"X\"*{len})], iface=\"{tester_intf}\")'\n+ self.tester.scapy_append(packet1)\n+ self.tester.scapy_execute()\n \n def send_packet_of_size_to_tx_port(self, pktsize, received=True):\n \"\"\"\n@@ -110,9 +144,8 @@ class TestStatsChecks(TestCase):\n rx_pkts_ori, rx_err_ori, rx_bytes_ori = [\n int(_) for _ in self.get_port_status_tx(self.rx_port)\n ]\n-\n- out = self.send_packet_of_size_to_port(self.tx_port, pktsize)\n-\n+ self.used_tester_port = self.tester.get_local_port(self.dut_ports[1])\n+ out = self.send_packet_of_size_to_port(self.used_tester_port, pktsize)\n sleep(5)\n \n tx_pkts, tx_err, tx_bytes = [\n@@ -175,7 +208,7 @@ class TestStatsChecks(TestCase):\n return xstats_data\n \n def verify_results(\n- self, xstats_data, rx_port, tx_port, stats_data={}, if_zero=False\n+ self, xstats_data, rx_port, tx_port, if_vf, stats_data={}, if_zero=False\n ):\n if if_zero:\n for port in xstats_data.keys():\n@@ -190,7 +223,7 @@ class TestStatsChecks(TestCase):\n == stats_data[rx_port][\"RX-packets\"]\n == xstats_data[tx_port][\"tx_good_packets\"]\n == stats_data[tx_port][\"TX-packets\"]\n- == 100,\n+ == 700,\n \"pkt recieve or transport count error!\",\n )\n self.verify(\n@@ -200,24 +233,86 @@ class TestStatsChecks(TestCase):\n == stats_data[tx_port][\"TX-bytes\"],\n \"pkt recieve or transport bytes error!\",\n )\n+ # add judgment on rx and tx bytes, not same on if add crc 4 bytes\n+ if not if_vf and not if_zero:\n+ self.verify(\n+ xstats_data[rx_port][\"rx_size_64_packets\"] == 100,\n+ \"rx_size_64_packets pkt recieve or transport bytes error!\",\n+ )\n+ self.verify(\n+ xstats_data[rx_port][\"rx_size_65_to_127_packets\"] == 100,\n+ \"rx_size_65_to_127_packets pkt recieve or transport bytes error!\",\n+ )\n+ self.verify(\n+ xstats_data[rx_port][\"rx_size_128_to_255_packets\"] == 100,\n+ \"rx_size_128_to_255_packets pkt recieve or transport bytes error!\",\n+ )\n+ self.verify(\n+ xstats_data[rx_port][\"rx_size_256_to_511_packets\"] == 100,\n+ \"rx_size_256_to_511_packets pkt recieve or transport bytes error!\",\n+ )\n+ self.verify(\n+ xstats_data[rx_port][\"rx_size_512_to_1023_packets\"] == 100,\n+ \"rx_size_512_to_1023_packets pkt recieve or transport bytes error!\",\n+ )\n+ self.verify(\n+ xstats_data[rx_port][\"rx_size_1024_to_1522_packets\"] == 100,\n+ \"rx_size_1024_to_1522_packets pkt recieve or transport bytes error!\",\n+ )\n+ self.verify(\n+ xstats_data[rx_port][\"rx_size_1523_to_max_packets\"] == 100,\n+ \"rx_size_1523_to_max_packets pkt recieve or transport bytes error!\",\n+ )\n+ self.verify(\n+ xstats_data[tx_port][\"tx_size_64_packets\"] == 100,\n+ \"tx_size_64_packets pkt recieve or transport bytes error!\",\n+ )\n+ self.verify(\n+ xstats_data[tx_port][\"tx_size_65_to_127_packets\"] == 100,\n+ \"tx_size_65_to_127_packets pkt recieve or transport bytes error!\",\n+ )\n+ self.verify(\n+ xstats_data[tx_port][\"tx_size_128_to_255_packets\"] == 100,\n+ \"tx_size_128_to_255_packets pkt recieve or transport bytes error!\",\n+ )\n+ self.verify(\n+ xstats_data[tx_port][\"tx_size_256_to_511_packets\"] == 100,\n+ \"tx_size_256_to_511_packets pkt recieve or transport bytes error!\",\n+ )\n+ self.verify(\n+ xstats_data[tx_port][\"tx_size_512_to_1023_packets\"] == 100,\n+ \"tx_size_512_to_1023_packets pkt recieve or transport bytes error!\",\n+ )\n+ self.verify(\n+ xstats_data[tx_port][\"tx_size_1024_to_1522_packets\"] == 100,\n+ \"tx_size_1024_to_1522_packets pkt recieve or transport bytes error!\",\n+ )\n+ self.verify(\n+ xstats_data[tx_port][\"tx_size_1523_to_max_packets\"] == 100,\n+ \"tx_size_1523_to_max_packets pkt recieve or transport bytes error!\",\n+ )\n \n def xstats_check(self, rx_port, tx_port, if_vf=False):\n self.exec(\"port config all rss all\")\n self.exec(\"set fwd mac\")\n self.exec(\"clear port xstats all\")\n org_xstats = self.get_xstats([rx_port, tx_port])\n- self.verify_results(org_xstats, rx_port, tx_port, if_zero=True)\n+ self.verify_results(org_xstats, rx_port, tx_port, if_vf, if_zero=True)\n final_xstats, stats_data = self.sendpkt_get_xstats(rx_port, tx_port, if_vf)\n- self.verify_results(final_xstats, rx_port, tx_port, stats_data=stats_data)\n+ self.verify_results(\n+ final_xstats, rx_port, tx_port, if_vf, stats_data=stats_data\n+ )\n self.exec(\"clear port stats all\")\n clear_stats = self.get_xstats([rx_port, tx_port])\n- self.verify_results(clear_stats, rx_port, tx_port, if_zero=True)\n+ self.verify_results(clear_stats, rx_port, tx_port, if_vf, if_zero=True)\n \n final_xstats, stats_data = self.sendpkt_get_xstats(rx_port, tx_port, if_vf)\n- self.verify_results(final_xstats, rx_port, tx_port, stats_data=stats_data)\n+ self.verify_results(\n+ final_xstats, rx_port, tx_port, if_vf, stats_data=stats_data\n+ )\n self.exec(\"clear port xstats all\")\n clear_xstats = self.get_xstats([rx_port, tx_port])\n- self.verify_results(clear_xstats, rx_port, tx_port, if_zero=True)\n+ self.verify_results(clear_xstats, rx_port, tx_port, if_vf, if_zero=True)\n self.pmdout.quit()\n \n def sendpkt_get_xstats(self, rx_port, tx_port, if_vf):\n@@ -300,7 +395,7 @@ class TestStatsChecks(TestCase):\n self.pmdout.quit()\n \n def test_xstats_check_pf(self):\n- self.pmdout.start_testpmd(\"default\", \"--rxq=4 --txq=4\")\n+ self.pmdout.start_testpmd(\"default\", \"--rxq=4 --txq=4 --max-pkt-len=9000\")\n self.xstats_check(self.rx_port, self.tx_port)\n \n def test_xstats_check_vf(self):\n@@ -310,5 +405,7 @@ class TestStatsChecks(TestCase):\n self.vf_port = self.dut.ports_info[self.dut_ports[0]][\"vfs_port\"][0]\n self.vf_port.bind_driver(driver=\"vfio-pci\")\n self.vf_port_pci = self.dut.ports_info[self.dut_ports[0]][\"sriov_vfs_pci\"][0]\n- self.launch_testpmd(dcf_flag=self.dcf_mode, param=\"--txq=4 --rxq=4\")\n+ self.launch_testpmd(\n+ dcf_flag=self.dcf_mode, param=\"--txq=4 --rxq=4 --max-pkt-len=9000\"\n+ )\n self.xstats_check(0, 0, if_vf=True)\n", "prefixes": [ "V1" ] }