Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/120141/?format=api
{ "id": 120141, "url": "http://patches.dpdk.org/api/patches/120141/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221124203124.2253871-1-omer.yamac@ceng.metu.edu.tr/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221124203124.2253871-1-omer.yamac@ceng.metu.edu.tr>", "list_archive_url": "https://inbox.dpdk.org/dev/20221124203124.2253871-1-omer.yamac@ceng.metu.edu.tr", "date": "2022-11-24T20:31:24", "name": "[v7] examples/distributor: remove dead code and renaming Rx,Tx", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fea6719c3b9cba5dc493b5fe4d1be040345baf08", "submitter": { "id": 2668, "url": "http://patches.dpdk.org/api/people/2668/?format=api", "name": "Abdullah Ömer Yamaç", "email": "omer.yamac@ceng.metu.edu.tr" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221124203124.2253871-1-omer.yamac@ceng.metu.edu.tr/mbox/", "series": [ { "id": 25889, "url": "http://patches.dpdk.org/api/series/25889/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=25889", "date": "2022-11-24T20:31:24", "name": "[v7] examples/distributor: remove dead code and renaming Rx,Tx", "version": 7, "mbox": "http://patches.dpdk.org/series/25889/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/120141/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/120141/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 848E2A00C3;\n\tThu, 24 Nov 2022 21:31:33 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5BA8040150;\n\tThu, 24 Nov 2022 21:31:33 +0100 (CET)", "from guvercin.ceng.metu.edu.tr (guvercin.ceng.metu.edu.tr\n [144.122.171.43])\n by mails.dpdk.org (Postfix) with ESMTP id 7A3684014F\n for <dev@dpdk.org>; Thu, 24 Nov 2022 21:31:31 +0100 (CET)", "from localhost (localhost [127.0.0.1])\n by guvercin.ceng.metu.edu.tr (Postfix) with ESMTP id 07BB62CE67;\n Thu, 24 Nov 2022 23:31:31 +0300 (+03)", "from guvercin.ceng.metu.edu.tr ([127.0.0.1])\n by localhost (guvercin.ceng.metu.edu.tr [127.0.0.1]) (amavisd-new,\n port 10024)\n with ESMTP id iNHSlLOevWHs; Thu, 24 Nov 2022 23:31:27 +0300 (+03)", "from dmu.otak.ist (unknown [212.156.37.190])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested) (Authenticated sender: e1885458)\n by guvercin.ceng.metu.edu.tr (Postfix) with ESMTPSA id 8F9582C670;\n Thu, 24 Nov 2022 23:31:26 +0300 (+03)" ], "X-Virus-Scanned": "Debian amavisd-new at ceng.metu.edu.tr", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ceng.metu.edu.tr;\n s=mail; t=1669321887;\n bh=DDgeyRpoVntdBKs2Vd9legAn/nAMq+nTu8757u4dTRE=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=Mf1C2LrhSMjFrgL2Yv3BS2sm92FoYLwPzQGaoFlvVvWq3oUAHAqXxxE8HHZ7SmMaT\n UwaFsGdLaxSN1yGM9jTRiwDrNIGdWg7m1Xw9J2DCG8qyFfBjbLSJ3VRk7GkoCfoEc5\n GdS1qk802fgu4WKM2KgHfocLG5NKX2NtRSNOxH30=", "From": "=?utf-8?b?QWJkdWxsYWggw5ZtZXIgWWFtYcOn?= <omer.yamac@ceng.metu.edu.tr>", "To": "dev@dpdk.org", "Cc": "=?utf-8?b?QWJkdWxsYWggw5ZtZXIgWWFtYcOn?= <omer.yamac@ceng.metu.edu.tr>,\n Thomas Monjalon <thomas@monjalon.net>", "Subject": "[PATCH v7] examples/distributor: remove dead code and renaming Rx,Tx", "Date": "Thu, 24 Nov 2022 23:31:24 +0300", "Message-Id": "<20221124203124.2253871-1-omer.yamac@ceng.metu.edu.tr>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20221124202251.2239852-1-omer.yamac@ceng.metu.edu.tr>", "References": "<20221124202251.2239852-1-omer.yamac@ceng.metu.edu.tr>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "One line of commented code was dead code, this line and related\ncomments are removed. Naming of rx,RX and tx,TX are replaced by Rx and\nTx.\n\nSigned-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>\n---\nCC: Thomas Monjalon <thomas@monjalon.net>\n---\n examples/distributor/main.c | 55 +++++++++++++++++--------------------\n 1 file changed, 25 insertions(+), 30 deletions(-)", "diff": "diff --git a/examples/distributor/main.c b/examples/distributor/main.c\nindex 21304d6618..9280a2694e 100644\n--- a/examples/distributor/main.c\n+++ b/examples/distributor/main.c\n@@ -104,7 +104,7 @@ struct output_buffer {\n static void print_stats(void);\n \n /*\n- * Initialises a given port using global settings and with the rx buffers\n+ * Initialises a given port using global settings and with the Rx buffers\n * coming from the mbuf_pool passed as parameter\n */\n static inline int\n@@ -259,12 +259,7 @@ lcore_rx(struct lcore_params *p)\n \t\t}\n \t\tapp_stats.rx.rx_pkts += nb_rx;\n \n-\t\t/*\n-\t\t * Swap the following two lines if you want the rx traffic\n-\t\t * to go directly to tx, no distribution.\n-\t\t */\n \t\tstruct rte_ring *out_ring = p->rx_dist_ring;\n-\t\t/* struct rte_ring *out_ring = p->dist_tx_ring; */\n \n \t\tuint16_t sent = rte_ring_enqueue_burst(out_ring,\n \t\t\t\t(void *)bufs, nb_rx, NULL);\n@@ -282,7 +277,7 @@ lcore_rx(struct lcore_params *p)\n \t}\n \tif (power_lib_initialised)\n \t\trte_power_exit(rte_lcore_id());\n-\tprintf(\"\\nCore %u exiting rx task.\\n\", rte_lcore_id());\n+\tprintf(\"\\nCore %u exiting Rx task.\\n\", rte_lcore_id());\n \t/* set distributor threads quit flag */\n \tquit_signal_dist = 1;\n \treturn 0;\n@@ -305,11 +300,11 @@ lcore_rx_and_distributor(struct lcore_params *p)\n \t\tif (rte_eth_dev_socket_id(port) > 0 &&\n \t\t\t\trte_eth_dev_socket_id(port) != socket_id)\n \t\t\tprintf(\"WARNING, port %u is on remote NUMA node to \"\n-\t\t\t\t\t\"RX thread.\\n\\tPerformance will not \"\n+\t\t\t\t\t\"Rx thread.\\n\\tPerformance will not \"\n \t\t\t\t\t\"be optimal.\\n\", port);\n \t}\n \n-\tprintf(\"\\nCore %u doing packet RX and Distributor.\\n\", rte_lcore_id());\n+\tprintf(\"\\nCore %u doing packet Rx and Distributor.\\n\", rte_lcore_id());\n \tport = 0;\n \twhile (!quit_signal_rx) {\n \n@@ -329,8 +324,8 @@ lcore_rx_and_distributor(struct lcore_params *p)\n \t\tapp_stats.rx.rx_pkts += nb_rx;\n \n \t\t/*\n-\t\t * Run the distributor on the rx core. Returned\n-\t\t * packets are then send straight to the tx core.\n+\t\t * Run the distributor on the Rx core. Returned\n+\t\t * packets are then send straight to the Tx core.\n \t\t */\n \t\trte_distributor_process(d, bufs, nb_rx);\n \t\tconst uint16_t nb_ret = rte_distributor_returned_pkts(d,\n@@ -360,8 +355,8 @@ lcore_rx_and_distributor(struct lcore_params *p)\n \t}\n \tif (power_lib_initialised)\n \t\trte_power_exit(rte_lcore_id());\n-\tprintf(\"\\nCore %u exiting rx task.\\n\", rte_lcore_id());\n-\t/* set tx threads quit flag */\n+\tprintf(\"\\nCore %u exiting Rx task.\\n\", rte_lcore_id());\n+\t/* set Tx threads quit flag */\n \tquit_signal = 1;\n \t/* set worker threads quit flag */\n \tquit_signal_work = 1;\n@@ -448,7 +443,7 @@ lcore_distributor(struct lcore_params *p)\n \tif (power_lib_initialised)\n \t\trte_power_exit(rte_lcore_id());\n \tprintf(\"\\nCore %u exiting distributor task.\\n\", rte_lcore_id());\n-\t/* set tx threads quit flag */\n+\t/* set Tx threads quit flag */\n \tquit_signal = 1;\n \t/* set worker threads quit flag */\n \tquit_signal_work = 1;\n@@ -478,7 +473,7 @@ lcore_tx(struct rte_ring *in_r)\n \t\t\t\t\t\"be optimal.\\n\", port);\n \t}\n \n-\tprintf(\"\\nCore %u doing packet TX.\\n\", rte_lcore_id());\n+\tprintf(\"\\nCore %u doing packet Tx.\\n\", rte_lcore_id());\n \twhile (!quit_signal) {\n \n \t\tRTE_ETH_FOREACH_DEV(port) {\n@@ -524,7 +519,7 @@ lcore_tx(struct rte_ring *in_r)\n \t}\n \tif (power_lib_initialised)\n \t\trte_power_exit(rte_lcore_id());\n-\tprintf(\"\\nCore %u exiting tx task.\\n\", rte_lcore_id());\n+\tprintf(\"\\nCore %u exiting Tx task.\\n\", rte_lcore_id());\n \treturn 0;\n }\n \n@@ -532,7 +527,7 @@ static void\n int_handler(int sig_num)\n {\n \tprintf(\"Exiting on signal %d\\n\", sig_num);\n-\t/* set quit flag for rx thread to exit */\n+\t/* set quit flag for Rx thread to exit */\n \tquit_signal_rx = 1;\n }\n \n@@ -698,7 +693,7 @@ print_usage(const char *prgname)\n {\n \tprintf(\"%s [EAL options] -- -p PORTMASK [-c]\\n\"\n \t\t\t\" -p PORTMASK: hexadecimal bitmask of ports to configure\\n\"\n-\t\t\t\" -c: Combines the RX core with the distribution core\\n\",\n+\t\t\t\" -c: Combines the Rx core with the distribution core\\n\",\n \t\t\tprgname);\n }\n \n@@ -798,11 +793,11 @@ main(int argc, char *argv[])\n \t\trte_exit(EXIT_FAILURE, \"Invalid distributor parameters\\n\");\n \n \tif (enable_lcore_rx_distributor) {\n-\t/* RX and distributor combined, 3 fixed function cores (stat, TX, at least 1 worker) */\n+\t/* Rx and distributor combined, 3 fixed function cores (stat, Tx, at least 1 worker) */\n \t\tmin_cores = 4;\n \t\tnum_workers = rte_lcore_count() - 3;\n \t} else {\n-\t/* separate RX and distributor, 3 fixed function cores (stat, TX, at least 1 worker) */\n+\t/* separate Rx and distributor, 3 fixed function cores (stat, Tx, at least 1 worker) */\n \t\tmin_cores = 5;\n \t\tnum_workers = rte_lcore_count() - 4;\n \t}\n@@ -811,8 +806,8 @@ main(int argc, char *argv[])\n \t\trte_exit(EXIT_FAILURE, \"Error, This application needs at \"\n \t\t\t\t\"least 4 logical cores to run:\\n\"\n \t\t\t\t\"1 lcore for stats (can be core 0)\\n\"\n-\t\t\t\t\"1 or 2 lcore for packet RX and distribution\\n\"\n-\t\t\t\t\"1 lcore for packet TX\\n\"\n+\t\t\t\t\"1 or 2 lcore for packet Rx and distribution\\n\"\n+\t\t\t\t\"1 lcore for packet Tx\\n\"\n \t\t\t\t\"and at least 1 lcore for worker threads\\n\");\n \n \tif (init_power_library() == 0)\n@@ -875,13 +870,13 @@ main(int argc, char *argv[])\n \n \tif (power_lib_initialised) {\n \t\t/*\n-\t\t * Here we'll pre-assign lcore ids to the rx, tx and\n+\t\t * Here we'll pre-assign lcore ids to the Rx, Tx and\n \t\t * distributor workloads if there's higher frequency\n \t\t * on those cores e.g. if Turbo Boost is enabled.\n \t\t * It's also worth mentioning that it will assign cores in a\n \t\t * specific order, so that if there's less than three\n \t\t * available, the higher frequency cores will go to the\n-\t\t * distributor first, then rx, then tx.\n+\t\t * distributor first, then Rx, then Tx.\n \t\t */\n \t\tRTE_LCORE_FOREACH_WORKER(lcore_id) {\n \n@@ -939,18 +934,18 @@ main(int argc, char *argv[])\n \t}\n \n \tif (enable_lcore_rx_distributor)\n-\t\tprintf(\" tx id %d, rx id %d\\n\",\n+\t\tprintf(\" Tx id %d, Rx id %d\\n\",\n \t\t\ttx_core_id,\n \t\t\trx_core_id);\n \telse\n-\t\tprintf(\" tx id %d, dist id %d, rx id %d\\n\",\n+\t\tprintf(\" Tx id %d, dist id %d, Rx id %d\\n\",\n \t\t\ttx_core_id,\n \t\t\tdistr_core_id,\n \t\t\trx_core_id);\n \n \t/*\n \t * Kick off all the worker threads first, avoiding the pre-assigned\n-\t * lcore_ids for tx, rx and distributor workloads.\n+\t * lcore_ids for Tx, Rx and distributor workloads.\n \t */\n \tRTE_LCORE_FOREACH_WORKER(lcore_id) {\n \t\tif (lcore_id == (unsigned int)distr_core_id ||\n@@ -970,7 +965,7 @@ main(int argc, char *argv[])\n \t\t\t\tp, lcore_id);\n \t}\n \n-\t/* Start tx core */\n+\t/* Start Tx core */\n \trte_eal_remote_launch((lcore_function_t *)lcore_tx,\n \t\t\tdist_tx_ring, tx_core_id);\n \n@@ -978,7 +973,7 @@ main(int argc, char *argv[])\n \tstruct lcore_params *pd = NULL;\n \tif (!enable_lcore_rx_distributor) {\n \t\tpd = rte_malloc(NULL, sizeof(*pd), 0);\n-\t\tif (!pd)\n+\t\tif (pd == NULL)\n \t\t\trte_panic(\"malloc failure\\n\");\n \t\t*pd = (struct lcore_params){worker_id++, d,\n \t\t\trx_dist_ring, dist_tx_ring, mbuf_pool};\n@@ -986,7 +981,7 @@ main(int argc, char *argv[])\n \t\t\t\tpd, distr_core_id);\n \t}\n \n-\t/* Start rx core */\n+\t/* Start Rx core */\n \tstruct lcore_params *pr =\n \t\trte_malloc(NULL, sizeof(*pr), 0);\n \tif (!pr)\n", "prefixes": [ "v7" ] }