Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/119970/?format=api
{ "id": 119970, "url": "http://patches.dpdk.org/api/patches/119970/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221118133547.1203417-1-tomasz.zawadzki@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221118133547.1203417-1-tomasz.zawadzki@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221118133547.1203417-1-tomasz.zawadzki@intel.com", "date": "2022-11-18T13:35:47", "name": "bus/pci: fix bus info memleak during PCI scan", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "b05d4e15532af50ec7d10618603c9f4a1d365078", "submitter": { "id": 2902, "url": "http://patches.dpdk.org/api/people/2902/?format=api", "name": "Tomasz Zawadzki", "email": "tomasz.zawadzki@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221118133547.1203417-1-tomasz.zawadzki@intel.com/mbox/", "series": [ { "id": 25820, "url": "http://patches.dpdk.org/api/series/25820/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=25820", "date": "2022-11-18T13:35:47", "name": "bus/pci: fix bus info memleak during PCI scan", "version": 1, "mbox": "http://patches.dpdk.org/series/25820/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/119970/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/119970/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4E379A0544;\n\tFri, 18 Nov 2022 14:35:54 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EF6454021F;\n\tFri, 18 Nov 2022 14:35:53 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by mails.dpdk.org (Postfix) with ESMTP id E5DC34003F\n for <dev@dpdk.org>; Fri, 18 Nov 2022 14:35:52 +0100 (CET)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 18 Nov 2022 05:35:52 -0800", "from wisla.igk.intel.com ([10.211.11.141])\n by FMSMGA003.fm.intel.com with ESMTP; 18 Nov 2022 05:35:50 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1668778553; x=1700314553;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=7onoy5YwhuDoD+68gcXcPA2cspHuNfpl2gOAB3l9pLU=;\n b=OlWEeHDygIhX3+9VmfblVEKpF5w505DYYyK8O6vSutZPsD2WbjrCeI0p\n hwIVs2+qmifDM1VYbKwdXgHQEEKpkUlRUoNgyQlyoghCJDKbj8qTEkomt\n yNP1jeZFBKXbQpzZwYAnqEltITWw6kgJATuRjAme/XDG+uBh5Kp7PETNz\n f1MQ9SXqPgswbhpF4P5RZGUA3WEf6Qmn7UkZ1xJm5zBUO/uz/erZQyYR2\n LemgFy4GLn5xl3rriuxbHR8usIDYmUcN2Gfdo3D3Qz0If0nnFhopEEQiG\n kgu/xN5I4FMbEcTTYf6XKSFRb9gxfSobK2AHG5XQjJJ/TgXZNZLxsE5hT g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10534\"; a=\"314953181\"", "E=Sophos;i=\"5.96,174,1665471600\"; d=\"scan'208\";a=\"314953181\"", "E=McAfee;i=\"6500,9779,10534\"; a=\"729232718\"", "E=Sophos;i=\"5.96,174,1665471600\"; d=\"scan'208\";a=\"729232718\"" ], "X-ExtLoop1": "1", "From": "Tomasz Zawadzki <tomasz.zawadzki@intel.com>", "To": "Bruce Richardson <bruce.richardson@intel.com>,\n David Marchand <david.marchand@redhat.com>", "Cc": "dev@dpdk.org,\n\tTomasz Zawadzki <tomasz.zawadzki@intel.com>", "Subject": "[PATCH] bus/pci: fix bus info memleak during PCI scan", "Date": "Fri, 18 Nov 2022 14:35:47 +0100", "Message-Id": "<20221118133547.1203417-1-tomasz.zawadzki@intel.com>", "X-Mailer": "git-send-email 2.38.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "During pci_scan_one() for devices that were already registered\nthe pci_common_set() is called to set some of the fields again.\n\nThis resulted in bus_info allocation leaking, so this patch\nensures they are always freed beforehand.\n\nFixes: 8f4de2dba9b9 (\"bus/pci: fill bus specific information\")\n\nSigned-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>\n---\n drivers/bus/pci/pci_common.c | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c\nindex 9901c34f4e..9a866055e8 100644\n--- a/drivers/bus/pci/pci_common.c\n+++ b/drivers/bus/pci/pci_common.c\n@@ -114,6 +114,7 @@ pci_common_set(struct rte_pci_device *dev)\n \t\t/* Otherwise, it uses the internal, canonical form. */\n \t\tdev->device.name = dev->name;\n \n+\tfree(dev->bus_info);\n \tif (asprintf(&dev->bus_info, \"vendor_id=%\"PRIx16\", device_id=%\"PRIx16,\n \t\t\tdev->id.vendor_id, dev->id.device_id) != -1)\n \t\tdev->device.bus_info = dev->bus_info;\n", "prefixes": [] }