Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/119604/?format=api
{ "id": 119604, "url": "http://patches.dpdk.org/api/patches/119604/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221109075309.958086-1-shunh@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221109075309.958086-1-shunh@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221109075309.958086-1-shunh@nvidia.com", "date": "2022-11-09T07:53:09", "name": "net/mlx5: fix assert when creating meter policy", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "98576bc87d7ede88e563df41c6518604732a0495", "submitter": { "id": 2212, "url": "http://patches.dpdk.org/api/people/2212/?format=api", "name": "Shun Hao", "email": "shunh@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221109075309.958086-1-shunh@nvidia.com/mbox/", "series": [ { "id": 25652, "url": "http://patches.dpdk.org/api/series/25652/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=25652", "date": "2022-11-09T07:53:09", "name": "net/mlx5: fix assert when creating meter policy", "version": 1, "mbox": "http://patches.dpdk.org/series/25652/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/119604/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/119604/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AB122A0093;\n\tWed, 9 Nov 2022 08:53:42 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 55D97400D7;\n\tWed, 9 Nov 2022 08:53:42 +0100 (CET)", "from NAM12-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam12on2057.outbound.protection.outlook.com [40.107.243.57])\n by mails.dpdk.org (Postfix) with ESMTP id DC7CE400D4;\n Wed, 9 Nov 2022 08:53:40 +0100 (CET)", "from BN9P221CA0005.NAMP221.PROD.OUTLOOK.COM (2603:10b6:408:10a::28)\n by BL3PR12MB6571.namprd12.prod.outlook.com (2603:10b6:208:38e::18)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Wed, 9 Nov\n 2022 07:53:39 +0000", "from BN8NAM11FT060.eop-nam11.prod.protection.outlook.com\n (2603:10b6:408:10a:cafe::63) by BN9P221CA0005.outlook.office365.com\n (2603:10b6:408:10a::28) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27 via Frontend\n Transport; Wed, 9 Nov 2022 07:53:39 +0000", "from mail.nvidia.com (216.228.117.160) by\n BN8NAM11FT060.mail.protection.outlook.com (10.13.177.211) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.5813.12 via Frontend Transport; Wed, 9 Nov 2022 07:53:38 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Tue, 8 Nov 2022\n 23:53:25 -0800", "from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Tue, 8 Nov 2022\n 23:53:23 -0800" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=D38mMas2cvEq0NVDLBapeSzEq3kXS7iHvHm9OShZakt/XLzCxMkUo1nqS2Cvrc6UkAte2QeDOHlfNCI98uNMZevrspZZeUtd/DO0+tSbdZQ0Vab/dw2KIO5Tk50jkgWbXO29+cTKCznpN/cUIhh8lVXAViT3JRxTFcMMGdC6ggNTjky6UWqvDpioKcIeGCRw1ILqYDKjLnTze/3dsFTP72uZDeMgBZgLZw9fEmUNihZPRYtt9EZ1cl1on3EfhKnExOzX3euWCbpzrxH0u2CaTdt/CW3fA8TqpzG6kxf87hU4smXFl6h0HOmVidG2s2sBJdhUQruTkxlVm0gdZAfdCA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=EDtquMdPSg4a7RYp0S/7MQX1yzl03R+jcXFiQBxyG3Q=;\n b=Sq3l2lFLilayhMClhFzhc9k5wHuFWqI8ZKlNDatWfTE/QDgBP51aRXAgO0bBCLzIWY6vQn4uMgzRfXBCN/t1SIlvdNcyNEfbSzBm+PPNok3+ZUXuE2pVCG6QsGyfoXgaTcThB82llCl0DvvFjYZBZ6mZSou+u93s56MjOliirgm43Q0B2QljprnM6nrlFVDU5n4iTcLUOajwFLhjk4oHXXMu29YGYeyCS8biROsR6UHvdrrmP6X5lNpGa7M69TOBXTBU57WaubviakEic0WJbfhAvI34Gb+RoYi1hd0zCKndh8BFgPJ0LxRIOC09oHbTR4dBJ4SnyYsqGTtYLlDODg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=EDtquMdPSg4a7RYp0S/7MQX1yzl03R+jcXFiQBxyG3Q=;\n b=Nj1Ga0QUhdi+P4seVfRw83AxDnG6OfMtgxCd0I2yZSN7LmroQ+w0k3PFyBt48IO0/ZHsAAIIp0/Bdh3whWFFwQnIViUot3lNcZbtOIz7vP9nLGlh+WWJo1RavBt9PQwHS5WRZI0UmnsU/X7Xv6Ks8rX3i3UQnqJ6uUb3wUuwrQC7pwSmB8Cqc6kPzCdpHHfsNMbqvID4NeYvGGVYNSJQOXiGXm0VQ8CsR7XfLepAyc1FfpfBDfmvG28CE5gkWUZdEPKT83gPsfWAJGheEH+9L4KDsx/6iVv+1ocLISK61Zf6dq5kZpanaZee1RbnKmh1eEYwU6bdP9n8EFV3xzAH1w==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.160)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.160 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C", "From": "Shun Hao <shunh@nvidia.com>", "To": "<viacheslavo@nvidia.com>, <matan@nvidia.com>, <orika@nvidia.com>, \"Jiawei\n Wang\" <jiaweiw@nvidia.com>", "CC": "<dev@dpdk.org>, <rasland@nvidia.com>, <stable@dpdk.org>", "Subject": "[PATCH] net/mlx5: fix assert when creating meter policy", "Date": "Wed, 9 Nov 2022 09:53:09 +0200", "Message-ID": "<20221109075309.958086-1-shunh@nvidia.com>", "X-Mailer": "git-send-email 2.20.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.230.35]", "X-ClientProxiedBy": "rnnvmail201.nvidia.com (10.129.68.8) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "BN8NAM11FT060:EE_|BL3PR12MB6571:EE_", "X-MS-Office365-Filtering-Correlation-Id": "25d24c85-d462-4d3a-11ce-08dac227833f", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n VJC0mwc32IMGAuEddWznmr4IKQvcCGoJRYU86rVh4a3xTXuDMtd/2jedcWGTQX8y7WV6d9TnJ7QZ96UtFCfusf5aPquSzxHl9rdWV1RfTPiOsEGO08TxmfAYsWUqJTLx9rpRlxpt6cI/cbaY7/hD0xBL03L+jYS7u36hrtnCPZOxCso/lXvGatH4AlOulHfWGXJagp4Z2Ow9yRPlv0zEJDdYvEpsil3oWplrxkeB1lYN8bfez9iCxnkydjazLhzsizTQNxWqrnvV6H1i8C6XGe4aYBdzA6FQB3uB8V8dpY5liM46Ij6m/4514NMX7CkxnftyKdlZ/6vtqMeb4skpsxBNwI4qmhQsdWxKjYZsQdh11rbQizhL3aowTputNyHpG9WmZuqSeogcdsjUWM9Rfi8vf1fKdKwQdOmxzNvZWQh8uGNIopOEu6W0xyx93SmHtCvKnFU/jexZgSNt3CGhnmvDEshBMEDoAg/dq85hxNiZGWiF56snIocKJga+PmjXxExhKFhgbffNQ7U4Yi5TKBHT78zqx0EeS4/O+zockt6nzRDeotv6eY5coz7d2PvgIB8Vsg6+yRhMq8e+/R54dPRY6N0ffRqM8ikQZxNnpjVZ1KihFCs2l7hvmHlWVwS70Rql4YUi9MTbsfWGhCdEyxquVQfQJSxzlmM2UItHvcOP5XavvmS9g8CJE4tTD+KyojeV9IjNspOVBYgZxHg0AhlqzyfFVs6J8FBo1OQ8hb2XV6X3pK0DEZh9S5Jua/bI/I4syrWj2DPSBeblLC1rAw==", "X-Forefront-Antispam-Report": "CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE;\n SFS:(13230022)(4636009)(346002)(136003)(376002)(39860400002)(396003)(451199015)(46966006)(40470700004)(36840700001)(36860700001)(36756003)(86362001)(47076005)(186003)(2906002)(8936002)(5660300002)(110136005)(82740400003)(54906003)(426003)(2616005)(356005)(6286002)(7636003)(83380400001)(26005)(336012)(16526019)(1076003)(316002)(41300700001)(6636002)(82310400005)(70586007)(70206006)(4326008)(8676002)(40460700003)(6666004)(40480700001)(7696005)(55016003)(450100002)(478600001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "09 Nov 2022 07:53:38.5777 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 25d24c85-d462-4d3a-11ce-08dac227833f", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BN8NAM11FT060.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BL3PR12MB6571", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When creating meter policy rules, it's possible to use flow items\ntranslation to add src port match criteria. Currently the items\ntranslation process needs to get thread workspace to store vport\nmetadata tag, but in policy creation, the thread workspace was not\ninitialized so it will cause assert failure.\n\nThis patch adds initialization of thread-local workspace when creating\nmeter policy rules to avoid that assert.\n\nFixes: 65c86202 (\"net/mlx5: fix flow source port checking in sample flow rule\")\nCC: stable@dpdk.org\n\nSigned-off-by: Shun Hao <shunh@nvidia.com>\nAcked-by: Matan Azrad <matan@nvidia.com>\n---\n drivers/net/mlx5/mlx5_flow_dv.c | 10 ++++++++--\n 1 file changed, 8 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex 57af95b8a9..e9da59320a 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -17425,8 +17425,11 @@ flow_dv_create_policy_rules(struct rte_eth_dev *dev,\n \t\t\t struct mlx5_flow_meter_policy *mtr_policy)\n {\n \tint i;\n+\tint ret = 0;\n \tuint16_t sub_policy_num;\n+\tstruct mlx5_flow_workspace *wks = mlx5_flow_push_thread_workspace();\n \n+\tRTE_SET_USED(wks);\n \tfor (i = 0; i < MLX5_MTR_DOMAIN_MAX; i++) {\n \t\tsub_policy_num = (mtr_policy->sub_policy_num >>\n \t\t\t(MLX5_MTR_SUB_POLICY_NUM_SHIFT * i)) &\n@@ -17438,10 +17441,13 @@ flow_dv_create_policy_rules(struct rte_eth_dev *dev,\n \t\t\tmtr_policy->sub_policys[i][0], i)) {\n \t\t\tDRV_LOG(ERR, \"Failed to create policy action \"\n \t\t\t\t\"list per domain.\");\n-\t\t\treturn -1;\n+\t\t\tret = -1;\n+\t\t\tgoto exit;\n \t\t}\n \t}\n-\treturn 0;\n+exit:\n+\tmlx5_flow_pop_thread_workspace();\n+\treturn ret;\n }\n \n static int\n", "prefixes": [] }