Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/119454/?format=api
{ "id": 119454, "url": "http://patches.dpdk.org/api/patches/119454/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221103154717.22368-2-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221103154717.22368-2-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221103154717.22368-2-david.marchand@redhat.com", "date": "2022-11-03T15:47:16", "name": "[1/2] devtools: unify configuration for ABI check", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4cdfd51880aca72e8cd8976cdbcd1f30a1e509c1", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221103154717.22368-2-david.marchand@redhat.com/mbox/", "series": [ { "id": 25557, "url": "http://patches.dpdk.org/api/series/25557/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=25557", "date": "2022-11-03T15:47:15", "name": "ABI check updates", "version": 1, "mbox": "http://patches.dpdk.org/series/25557/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/119454/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/119454/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D3678A00C2;\n\tThu, 3 Nov 2022 16:47:30 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3355842D11;\n\tThu, 3 Nov 2022 16:47:30 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id 2631E42D16\n for <dev@dpdk.org>; Thu, 3 Nov 2022 16:47:29 +0100 (CET)", "from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com\n [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-96-_itnaAEANfuqam-aOdz2WA-1; Thu, 03 Nov 2022 11:47:25 -0400", "from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com\n [10.11.54.3])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 46DC8380664D;\n Thu, 3 Nov 2022 15:47:25 +0000 (UTC)", "from fchome.redhat.com (ovpn-193-221.brq.redhat.com [10.40.193.221])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 765B71121319;\n Thu, 3 Nov 2022 15:47:24 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1667490448;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=LWW8PxfQ40jStjBcBNfNeNORRFTUGOyLX7oPiiImEQk=;\n b=dQnpcPSvswdQFMsLBngQi64trn8fg5l2ozSW4vEJu2y1UvrIvnrrMkiGt7uqPggHCX2qwL\n paxwbY53A3YKpzz+PNaaBcqsJhOQtm8qXqSf9RgO5JbdgVjgcV4LlGjHbrP5UHgFX3Tpe3\n jP2NfRqNpDlstb59VXdm9k8ju4dMvMQ=", "X-MC-Unique": "_itnaAEANfuqam-aOdz2WA-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net,\n\tci@dpdk.org", "Subject": "[PATCH 1/2] devtools: unify configuration for ABI check", "Date": "Thu, 3 Nov 2022 16:47:16 +0100", "Message-Id": "<20221103154717.22368-2-david.marchand@redhat.com>", "In-Reply-To": "<20221103154717.22368-1-david.marchand@redhat.com>", "References": "<20221103154717.22368-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.3", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "We have been skipping removed libraries in the ABI check by updating the\ncheck-abi.sh script itself.\nSee, for example, commit 33584c19ddc2 (\"raw/dpaa2_qdma: remove driver\").\n\nHaving two places for exception is a bit confusing, and those exceptions\nare best placed in a single configuration file out of the check script.\n\nBesides, a next patch will switch the check from comparing ABI xml files\nto directly comparing .so files. In this mode, libabigail does not\nsupport the soname_regexp syntax used for the mlx glue libraries.\n\nLet's handle these special cases in libabigail.abignore using comments.\n\nTaking the raw/dpaa2_qdma driver as an example, it would be possible to\nskip it by adding:\n\n ; SKIP_LIBRARY=librte_net_mlx4_glue\n+; SKIP_LIBRARY=librte_raw_dpaa2_qdma\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n devtools/check-abi.sh | 4 ++++\n devtools/libabigail.abignore | 12 +++++++++---\n 2 files changed, 13 insertions(+), 3 deletions(-)", "diff": "diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh\nindex c583eae2fd..b1bf633f2a 100755\n--- a/devtools/check-abi.sh\n+++ b/devtools/check-abi.sh\n@@ -37,6 +37,10 @@ fi\n error=\n for dump in $(find $refdir -name \"*.dump\"); do\n \tname=$(basename $dump)\n+\tif grep -q \"; SKIP_LIBRARY=${name%.dump}\\>\" $(dirname $0)/libabigail.abignore; then\n+\t\techo \"Skipped $name\" >&2\n+\t\tcontinue\n+\tfi\n \tdump2=$(find $newdir -name $name)\n \tif [ -z \"$dump2\" ] || [ ! -e \"$dump2\" ]; then\n \t\techo \"Error: cannot find $name in $newdir\" >&2\ndiff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore\nindex 7a93de3ba1..3ff51509de 100644\n--- a/devtools/libabigail.abignore\n+++ b/devtools/libabigail.abignore\n@@ -16,9 +16,15 @@\n [suppress_variable]\n name_regexp = _pmd_info$\n \n-; Ignore changes on soname for mlx glue internal drivers\n-[suppress_file]\n- soname_regexp = ^librte_.*mlx.*glue\\.\n+;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;\n+; Special rules to skip libraries ;\n+;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;\n+;\n+; This is not a libabigail rule (see check-abi.sh).\n+; This is used for driver removal and other special cases like mlx glue libs.\n+;\n+; SKIP_LIBRARY=librte_common_mlx5_glue\n+; SKIP_LIBRARY=librte_net_mlx4_glue\n \n ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;\n ; Experimental APIs exceptions ;\n", "prefixes": [ "1/2" ] }