Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/119089/?format=api
{ "id": 119089, "url": "http://patches.dpdk.org/api/patches/119089/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221025090052.429232-2-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221025090052.429232-2-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221025090052.429232-2-david.marchand@redhat.com", "date": "2022-10-25T09:00:49", "name": "[v3,1/4] telemetry: support boolean type", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4e0e725e09acfe106aa56415f74d6547aa30e34e", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221025090052.429232-2-david.marchand@redhat.com/mbox/", "series": [ { "id": 25415, "url": "http://patches.dpdk.org/api/series/25415/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=25415", "date": "2022-10-25T09:00:48", "name": "Telemetry support for traces", "version": 3, "mbox": "http://patches.dpdk.org/series/25415/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/119089/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/119089/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 47E96A0543;\n\tTue, 25 Oct 2022 11:01:19 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5BA7242BEF;\n\tTue, 25 Oct 2022 11:01:16 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id 584DB400D5\n for <dev@dpdk.org>; Tue, 25 Oct 2022 11:01:13 +0200 (CEST)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-21-Ir7Ou4meMtO9FqSDMptUXA-1; Tue, 25 Oct 2022 05:01:06 -0400", "from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com\n [10.11.54.10])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 53C81101A528;\n Tue, 25 Oct 2022 09:01:06 +0000 (UTC)", "from localhost.localdomain (ovpn-193-2.brq.redhat.com [10.40.193.2])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 16B6F492B11;\n Tue, 25 Oct 2022 09:01:04 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1666688472;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=CKHmHSIj2qKnpq233gjSqRB20AbSenB/I8C5EIkyDCo=;\n b=cZ7WfQQZuTckRiQKn1pMKET/Rh+BPWd5HpSPVxsXmasq693btqOFevhwpF8k0qWbwMcu2h\n EP2pL4rfx8GFk8giYXsHT0lryqFpoAedVehNcJbyMDkFVbeNDNJPSTERinCIeAOJaPMJ32\n OlU3toD39I8t3v1sTbbNcO3WWSNhRVA=", "X-MC-Unique": "Ir7Ou4meMtO9FqSDMptUXA-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "=?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Ciara Power <ciara.power@intel.com>", "Subject": "[PATCH v3 1/4] telemetry: support boolean type", "Date": "Tue, 25 Oct 2022 11:00:49 +0200", "Message-Id": "<20221025090052.429232-2-david.marchand@redhat.com>", "In-Reply-To": "<20221025090052.429232-1-david.marchand@redhat.com>", "References": "<20221013074928.3062458-1-david.marchand@redhat.com>\n <20221025090052.429232-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.10", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add the boolean type RTE_TEL_BOOL_VAL for values in arrays and dicts.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Ciara Power <ciara.power@intel.com>\n---\nChanges since v1:\n- fixed doxygen description,\n\n---\n app/test/test_telemetry_data.c | 88 +++++++++++++++++++++++++++++++++-\n lib/telemetry/rte_telemetry.h | 36 ++++++++++++++\n lib/telemetry/telemetry.c | 24 +++++++++-\n lib/telemetry/telemetry_data.c | 44 +++++++++++++++--\n lib/telemetry/telemetry_data.h | 5 ++\n lib/telemetry/telemetry_json.h | 34 +++++++++++++\n lib/telemetry/version.map | 10 ++++\n 7 files changed, 233 insertions(+), 8 deletions(-)", "diff": "diff --git a/app/test/test_telemetry_data.c b/app/test/test_telemetry_data.c\nindex d92667a527..134e018fde 100644\n--- a/app/test/test_telemetry_data.c\n+++ b/app/test/test_telemetry_data.c\n@@ -353,6 +353,84 @@ test_array_with_array_u64_values(void)\n \treturn CHECK_OUTPUT(\"[[0,1,2,3,4],[0,1,2,3,4]]\");\n }\n \n+static int\n+test_case_array_bool(void)\n+{\n+\tint i;\n+\n+\trte_tel_data_start_array(&response_data, RTE_TEL_BOOL_VAL);\n+\tfor (i = 0; i < 5; i++)\n+\t\trte_tel_data_add_array_bool(&response_data, (i % 2) == 0);\n+\treturn CHECK_OUTPUT(\"[true,false,true,false,true]\");\n+}\n+\n+static int\n+test_case_add_dict_bool(void)\n+{\n+\tint i = 0;\n+\tchar name_of_value[8];\n+\n+\trte_tel_data_start_dict(&response_data);\n+\n+\tfor (i = 0; i < 5; i++) {\n+\t\tsprintf(name_of_value, \"dict_%d\", i);\n+\t\trte_tel_data_add_dict_bool(&response_data, name_of_value,\n+\t\t\t(i % 2) == 0);\n+\t}\n+\treturn CHECK_OUTPUT(\"{\\\"dict_0\\\":true,\\\"dict_1\\\":false,\\\"dict_2\\\":true,\"\n+\t\t\"\\\"dict_3\\\":false,\\\"dict_4\\\":true}\");\n+}\n+\n+static int\n+test_dict_with_array_bool_values(void)\n+{\n+\tint i;\n+\n+\tstruct rte_tel_data *child_data = rte_tel_data_alloc();\n+\trte_tel_data_start_array(child_data, RTE_TEL_BOOL_VAL);\n+\n+\tstruct rte_tel_data *child_data2 = rte_tel_data_alloc();\n+\trte_tel_data_start_array(child_data2, RTE_TEL_BOOL_VAL);\n+\n+\trte_tel_data_start_dict(&response_data);\n+\n+\tfor (i = 0; i < 10; i++) {\n+\t\trte_tel_data_add_array_bool(child_data, (i % 2) == 0);\n+\t\trte_tel_data_add_array_bool(child_data2, (i % 2) == 1);\n+\t}\n+\n+\trte_tel_data_add_dict_container(&response_data, \"dict_0\",\n+\t child_data, 0);\n+\trte_tel_data_add_dict_container(&response_data, \"dict_1\",\n+\t child_data2, 0);\n+\n+\treturn CHECK_OUTPUT(\"{\\\"dict_0\\\":[true,false,true,false,true,false,true,false,true,false],\"\n+\t\t\"\\\"dict_1\\\":[false,true,false,true,false,true,false,true,false,true]}\");\n+}\n+\n+static int\n+test_array_with_array_bool_values(void)\n+{\n+\tint i;\n+\n+\tstruct rte_tel_data *child_data = rte_tel_data_alloc();\n+\trte_tel_data_start_array(child_data, RTE_TEL_BOOL_VAL);\n+\n+\tstruct rte_tel_data *child_data2 = rte_tel_data_alloc();\n+\trte_tel_data_start_array(child_data2, RTE_TEL_BOOL_VAL);\n+\n+\trte_tel_data_start_array(&response_data, RTE_TEL_CONTAINER);\n+\n+\tfor (i = 0; i < 5; i++) {\n+\t\trte_tel_data_add_array_bool(child_data, (i % 2) == 0);\n+\t\trte_tel_data_add_array_bool(child_data2, (i % 2) == 1);\n+\t}\n+\trte_tel_data_add_array_container(&response_data, child_data, 0);\n+\trte_tel_data_add_array_container(&response_data, child_data2, 0);\n+\n+\treturn CHECK_OUTPUT(\"[[true,false,true,false,true],[false,true,false,true,false]]\");\n+}\n+\n static int\n test_string_char_escaping(void)\n {\n@@ -428,15 +506,21 @@ telemetry_data_autotest(void)\n \t\t\ttest_null_return,\n \t\t\ttest_simple_string,\n \t\t\ttest_case_array_string,\n-\t\t\ttest_case_array_int, test_case_array_u64,\n-\t\t\ttest_case_add_dict_int, test_case_add_dict_u64,\n+\t\t\ttest_case_array_int,\n+\t\t\ttest_case_array_u64,\n+\t\t\ttest_case_array_bool,\n+\t\t\ttest_case_add_dict_int,\n+\t\t\ttest_case_add_dict_u64,\n+\t\t\ttest_case_add_dict_bool,\n \t\t\ttest_case_add_dict_string,\n \t\t\ttest_dict_with_array_int_values,\n \t\t\ttest_dict_with_array_u64_values,\n+\t\t\ttest_dict_with_array_bool_values,\n \t\t\ttest_dict_with_array_string_values,\n \t\t\ttest_dict_with_dict_values,\n \t\t\ttest_array_with_array_int_values,\n \t\t\ttest_array_with_array_u64_values,\n+\t\t\ttest_array_with_array_bool_values,\n \t\t\ttest_array_with_array_string_values,\n \t\t\ttest_string_char_escaping,\n \t\t\ttest_array_char_escaping,\ndiff --git a/lib/telemetry/rte_telemetry.h b/lib/telemetry/rte_telemetry.h\nindex a0d21d6b7f..e7f6c2ae43 100644\n--- a/lib/telemetry/rte_telemetry.h\n+++ b/lib/telemetry/rte_telemetry.h\n@@ -2,6 +2,7 @@\n * Copyright(c) 2018 Intel Corporation\n */\n \n+#include <stdbool.h>\n #include <stdint.h>\n \n #include <rte_compat.h>\n@@ -46,6 +47,7 @@ enum rte_tel_value_type {\n \tRTE_TEL_INT_VAL, /** a signed 32-bit int value */\n \tRTE_TEL_U64_VAL, /** an unsigned 64-bit int value */\n \tRTE_TEL_CONTAINER, /** a container struct */\n+\tRTE_TEL_BOOL_VAL, /** a boolean value */\n };\n \n /**\n@@ -155,6 +157,22 @@ int\n rte_tel_data_add_array_container(struct rte_tel_data *d,\n \t\tstruct rte_tel_data *val, int keep);\n \n+/**\n+ * Add a boolean to an array.\n+ * The array must have been started by rte_tel_data_start_array() with\n+ * RTE_TEL_BOOL_VAL as the type parameter.\n+ *\n+ * @param d\n+ * The data structure passed to the callback\n+ * @param x\n+ * The boolean value to be returned in the array\n+ * @return\n+ * 0 on success, negative errno on error\n+ */\n+__rte_experimental\n+int\n+rte_tel_data_add_array_bool(struct rte_tel_data *d, bool x);\n+\n /**\n * Add a string value to a dictionary.\n * The dict must have been started by rte_tel_data_start_dict().\n@@ -233,6 +251,24 @@ int\n rte_tel_data_add_dict_container(struct rte_tel_data *d, const char *name,\n \t\tstruct rte_tel_data *val, int keep);\n \n+/**\n+ * Add a boolean value to a dictionary.\n+ * The dict must have been started by rte_tel_data_start_dict().\n+ *\n+ * @param d\n+ * The data structure passed to the callback\n+ * @param name\n+ * The name the value is to be stored under in the dict\n+ * Must contain only alphanumeric characters or the symbols: '_' or '/'\n+ * @param val\n+ * The boolean value to be stored in the dict\n+ * @return\n+ * 0 on success, negative errno on error, E2BIG on string truncation of name.\n+ */\n+__rte_experimental\n+int\n+rte_tel_data_add_dict_bool(struct rte_tel_data *d, const char *name, bool val);\n+\n /**\n * This telemetry callback is used when registering a telemetry command.\n * It handles getting and formatting information to be returned to telemetry\ndiff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c\nindex 8fbb4f3060..276d0f337d 100644\n--- a/lib/telemetry/telemetry.c\n+++ b/lib/telemetry/telemetry.c\n@@ -168,7 +168,9 @@ container_to_json(const struct rte_tel_data *d, char *out_buf, size_t buf_len)\n \tunsigned int i;\n \n \tif (d->type != RTE_TEL_DICT && d->type != RTE_TEL_ARRAY_U64 &&\n-\t\td->type != RTE_TEL_ARRAY_INT && d->type != RTE_TEL_ARRAY_STRING)\n+\t\t\td->type != RTE_TEL_ARRAY_INT &&\n+\t\t\td->type != RTE_TEL_ARRAY_STRING &&\n+\t\t\td->type != RTE_TEL_ARRAY_BOOL)\n \t\treturn snprintf(out_buf, buf_len, \"null\");\n \n \tused = rte_tel_json_empty_array(out_buf, buf_len, 0);\n@@ -187,6 +189,11 @@ container_to_json(const struct rte_tel_data *d, char *out_buf, size_t buf_len)\n \t\t\tused = rte_tel_json_add_array_string(out_buf,\n \t\t\t\tbuf_len, used,\n \t\t\t\td->data.array[i].sval);\n+\tif (d->type == RTE_TEL_ARRAY_BOOL)\n+\t\tfor (i = 0; i < d->data_len; i++)\n+\t\t\tused = rte_tel_json_add_array_bool(out_buf,\n+\t\t\t\tbuf_len, used,\n+\t\t\t\td->data.array[i].boolval);\n \tif (d->type == RTE_TEL_DICT)\n \t\tfor (i = 0; i < d->data_len; i++) {\n \t\t\tconst struct tel_dict_entry *v = &d->data.dict[i];\n@@ -206,6 +213,11 @@ container_to_json(const struct rte_tel_data *d, char *out_buf, size_t buf_len)\n \t\t\t\t\t\tbuf_len, used,\n \t\t\t\t\t\tv->name, v->value.u64val);\n \t\t\t\tbreak;\n+\t\t\tcase RTE_TEL_BOOL_VAL:\n+\t\t\t\tused = rte_tel_json_add_obj_bool(out_buf,\n+\t\t\t\t\t\tbuf_len, used,\n+\t\t\t\t\t\tv->name, v->value.boolval);\n+\t\t\t\tbreak;\n \t\t\tcase RTE_TEL_CONTAINER:\n \t\t\t{\n \t\t\t\tchar temp[buf_len];\n@@ -273,6 +285,11 @@ output_json(const char *cmd, const struct rte_tel_data *d, int s)\n \t\t\t\t\t\tbuf_len, used,\n \t\t\t\t\t\tv->name, v->value.u64val);\n \t\t\t\tbreak;\n+\t\t\tcase RTE_TEL_BOOL_VAL:\n+\t\t\t\tused = rte_tel_json_add_obj_bool(cb_data_buf,\n+\t\t\t\t\t\tbuf_len, used,\n+\t\t\t\t\t\tv->name, v->value.boolval);\n+\t\t\t\tbreak;\n \t\t\tcase RTE_TEL_CONTAINER:\n \t\t\t{\n \t\t\t\tchar temp[buf_len];\n@@ -294,6 +311,7 @@ output_json(const char *cmd, const struct rte_tel_data *d, int s)\n \tcase RTE_TEL_ARRAY_STRING:\n \tcase RTE_TEL_ARRAY_INT:\n \tcase RTE_TEL_ARRAY_U64:\n+\tcase RTE_TEL_ARRAY_BOOL:\n \tcase RTE_TEL_ARRAY_CONTAINER:\n \t\tused = rte_tel_json_empty_array(cb_data_buf, buf_len, 0);\n \t\tfor (i = 0; i < d->data_len; i++)\n@@ -310,6 +328,10 @@ output_json(const char *cmd, const struct rte_tel_data *d, int s)\n \t\t\t\tused = rte_tel_json_add_array_u64(cb_data_buf,\n \t\t\t\t\t\tbuf_len, used,\n \t\t\t\t\t\td->data.array[i].u64val);\n+\t\t\telse if (d->type == RTE_TEL_ARRAY_BOOL)\n+\t\t\t\tused = rte_tel_json_add_array_bool(cb_data_buf,\n+\t\t\t\t\t\tbuf_len, used,\n+\t\t\t\t\t\td->data.array[i].boolval);\n \t\t\telse if (d->type == RTE_TEL_ARRAY_CONTAINER) {\n \t\t\t\tchar temp[buf_len];\n \t\t\t\tconst struct container *rec_data =\ndiff --git a/lib/telemetry/telemetry_data.c b/lib/telemetry/telemetry_data.c\nindex 34366ecee3..13a7ce7034 100644\n--- a/lib/telemetry/telemetry_data.c\n+++ b/lib/telemetry/telemetry_data.c\n@@ -16,10 +16,11 @@ int\n rte_tel_data_start_array(struct rte_tel_data *d, enum rte_tel_value_type type)\n {\n \tenum tel_container_types array_types[] = {\n-\t\t\tRTE_TEL_ARRAY_STRING, /* RTE_TEL_STRING_VAL = 0 */\n-\t\t\tRTE_TEL_ARRAY_INT, /* RTE_TEL_INT_VAL = 1 */\n-\t\t\tRTE_TEL_ARRAY_U64, /* RTE_TEL_u64_VAL = 2 */\n-\t\t\tRTE_TEL_ARRAY_CONTAINER, /* RTE_TEL_CONTAINER = 3 */\n+\t\t[RTE_TEL_STRING_VAL] = RTE_TEL_ARRAY_STRING,\n+\t\t[RTE_TEL_INT_VAL] = RTE_TEL_ARRAY_INT,\n+\t\t[RTE_TEL_U64_VAL] = RTE_TEL_ARRAY_U64,\n+\t\t[RTE_TEL_CONTAINER] = RTE_TEL_ARRAY_CONTAINER,\n+\t\t[RTE_TEL_BOOL_VAL] = RTE_TEL_ARRAY_BOOL,\n \t};\n \td->type = array_types[type];\n \td->data_len = 0;\n@@ -80,6 +81,17 @@ rte_tel_data_add_array_u64(struct rte_tel_data *d, uint64_t x)\n \treturn 0;\n }\n \n+int\n+rte_tel_data_add_array_bool(struct rte_tel_data *d, bool x)\n+{\n+\tif (d->type != RTE_TEL_ARRAY_BOOL)\n+\t\treturn -EINVAL;\n+\tif (d->data_len >= RTE_TEL_MAX_ARRAY_ENTRIES)\n+\t\treturn -ENOSPC;\n+\td->data.array[d->data_len++].boolval = x;\n+\treturn 0;\n+}\n+\n int\n rte_tel_data_add_array_container(struct rte_tel_data *d,\n \t\tstruct rte_tel_data *val, int keep)\n@@ -87,7 +99,8 @@ rte_tel_data_add_array_container(struct rte_tel_data *d,\n \tif (d->type != RTE_TEL_ARRAY_CONTAINER ||\n \t\t\t(val->type != RTE_TEL_ARRAY_U64\n \t\t\t&& val->type != RTE_TEL_ARRAY_INT\n-\t\t\t&& val->type != RTE_TEL_ARRAY_STRING))\n+\t\t\t&& val->type != RTE_TEL_ARRAY_STRING\n+\t\t\t&& val->type != RTE_TEL_ARRAY_BOOL))\n \t\treturn -EINVAL;\n \tif (d->data_len >= RTE_TEL_MAX_ARRAY_ENTRIES)\n \t\treturn -ENOSPC;\n@@ -179,6 +192,26 @@ rte_tel_data_add_dict_u64(struct rte_tel_data *d,\n \treturn bytes < RTE_TEL_MAX_STRING_LEN ? 0 : E2BIG;\n }\n \n+int\n+rte_tel_data_add_dict_bool(struct rte_tel_data *d,\n+\t\tconst char *name, bool val)\n+{\n+\tstruct tel_dict_entry *e = &d->data.dict[d->data_len];\n+\tif (d->type != RTE_TEL_DICT)\n+\t\treturn -EINVAL;\n+\tif (d->data_len >= RTE_TEL_MAX_DICT_ENTRIES)\n+\t\treturn -ENOSPC;\n+\n+\tif (!valid_name(name))\n+\t\treturn -EINVAL;\n+\n+\td->data_len++;\n+\te->type = RTE_TEL_BOOL_VAL;\n+\te->value.boolval = val;\n+\tconst size_t bytes = strlcpy(e->name, name, RTE_TEL_MAX_STRING_LEN);\n+\treturn bytes < RTE_TEL_MAX_STRING_LEN ? 0 : E2BIG;\n+}\n+\n int\n rte_tel_data_add_dict_container(struct rte_tel_data *d, const char *name,\n \t\tstruct rte_tel_data *val, int keep)\n@@ -188,6 +221,7 @@ rte_tel_data_add_dict_container(struct rte_tel_data *d, const char *name,\n \tif (d->type != RTE_TEL_DICT || (val->type != RTE_TEL_ARRAY_U64\n \t\t\t&& val->type != RTE_TEL_ARRAY_INT\n \t\t\t&& val->type != RTE_TEL_ARRAY_STRING\n+\t\t\t&& val->type != RTE_TEL_ARRAY_BOOL\n \t\t\t&& val->type != RTE_TEL_DICT))\n \t\treturn -EINVAL;\n \tif (d->data_len >= RTE_TEL_MAX_DICT_ENTRIES)\ndiff --git a/lib/telemetry/telemetry_data.h b/lib/telemetry/telemetry_data.h\nindex 26aa28e72c..c840486b18 100644\n--- a/lib/telemetry/telemetry_data.h\n+++ b/lib/telemetry/telemetry_data.h\n@@ -5,6 +5,9 @@\n #ifndef _TELEMETRY_DATA_H_\n #define _TELEMETRY_DATA_H_\n \n+#include <stdbool.h>\n+#include <stdint.h>\n+\n #include \"rte_telemetry.h\"\n \n enum tel_container_types {\n@@ -15,6 +18,7 @@ enum tel_container_types {\n \tRTE_TEL_ARRAY_INT, /** array of signed, 32-bit int values */\n \tRTE_TEL_ARRAY_U64, /** array of unsigned 64-bit int values */\n \tRTE_TEL_ARRAY_CONTAINER, /** array of container structs */\n+\tRTE_TEL_ARRAY_BOOL, /** array of boolean values */\n };\n \n struct container {\n@@ -30,6 +34,7 @@ union tel_value {\n \tchar sval[RTE_TEL_MAX_STRING_LEN];\n \tint ival;\n \tuint64_t u64val;\n+\tbool boolval;\n \tstruct container container;\n };\n \ndiff --git a/lib/telemetry/telemetry_json.h b/lib/telemetry/telemetry_json.h\nindex e3fae7c30d..c97da97366 100644\n--- a/lib/telemetry/telemetry_json.h\n+++ b/lib/telemetry/telemetry_json.h\n@@ -7,6 +7,7 @@\n \n #include <inttypes.h>\n #include <stdarg.h>\n+#include <stdbool.h>\n #include <stdio.h>\n #include <rte_common.h>\n #include <rte_telemetry.h>\n@@ -159,6 +160,21 @@ rte_tel_json_add_array_u64(char *buf, const int len, const int used,\n \treturn ret == 0 ? used : end + ret;\n }\n \n+/* Appends a boolean into the JSON array in the provided buffer. */\n+static inline int\n+rte_tel_json_add_array_bool(char *buf, const int len, const int used,\n+\t\tbool val)\n+{\n+\tint ret, end = used - 1; /* strip off final delimiter */\n+\tif (used <= 2) /* assume empty, since minimum is '[]' */\n+\t\treturn __json_snprintf(buf, len, \"[%s]\",\n+\t\t\t\tval ? \"true\" : \"false\");\n+\n+\tret = __json_snprintf(buf + end, len - end, \",%s]\",\n+\t\t\tval ? \"true\" : \"false\");\n+\treturn ret == 0 ? used : end + ret;\n+}\n+\n /*\n * Add a new element with raw JSON value to the JSON array stored in the\n * provided buffer.\n@@ -193,6 +209,24 @@ rte_tel_json_add_obj_u64(char *buf, const int len, const int used,\n \treturn ret == 0 ? used : end + ret;\n }\n \n+/**\n+ * Add a new element with boolean value to the JSON object stored in the\n+ * provided buffer.\n+ */\n+static inline int\n+rte_tel_json_add_obj_bool(char *buf, const int len, const int used,\n+\t\tconst char *name, bool val)\n+{\n+\tint ret, end = used - 1;\n+\tif (used <= 2) /* assume empty, since minimum is '{}' */\n+\t\treturn __json_snprintf(buf, len, \"{\\\"%s\\\":%s}\", name,\n+\t\t\t\tval ? \"true\" : \"false\");\n+\n+\tret = __json_snprintf(buf + end, len - end, \",\\\"%s\\\":%s}\",\n+\t\t\tname, val ? \"true\" : \"false\");\n+\treturn ret == 0 ? used : end + ret;\n+}\n+\n /**\n * Add a new element with int value to the JSON object stored in the\n * provided buffer.\ndiff --git a/lib/telemetry/version.map b/lib/telemetry/version.map\nindex 9794f9ea20..88f58d4d89 100644\n--- a/lib/telemetry/version.map\n+++ b/lib/telemetry/version.map\n@@ -19,7 +19,17 @@ DPDK_23 {\n \tlocal: *;\n };\n \n+EXPERIMENTAL {\n+\tglobal:\n+\n+\t# added in 22.11\n+\trte_tel_data_add_array_bool;\n+\trte_tel_data_add_dict_bool;\n+};\n+\n INTERNAL {\n+\tglobal:\n+\n \trte_telemetry_legacy_register;\n \trte_telemetry_init;\n };\n", "prefixes": [ "v3", "1/4" ] }