Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/117868/?format=api
{ "id": 117868, "url": "http://patches.dpdk.org/api/patches/117868/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221010214720.766459-2-mpiszczek@ddn.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221010214720.766459-2-mpiszczek@ddn.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221010214720.766459-2-mpiszczek@ddn.com", "date": "2022-10-10T21:47:20", "name": "[v3] pci: read amd iommu virtual address width", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "22b1ed0780bd29977aa0a96fc4a509a946a2b08c", "submitter": { "id": 2840, "url": "http://patches.dpdk.org/api/people/2840/?format=api", "name": "Michael Piszczek", "email": "mpiszczek@ddn.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221010214720.766459-2-mpiszczek@ddn.com/mbox/", "series": [ { "id": 25128, "url": "http://patches.dpdk.org/api/series/25128/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=25128", "date": "2022-10-10T21:47:20", "name": "[v3] pci: read amd iommu virtual address width", "version": 3, "mbox": "http://patches.dpdk.org/series/25128/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/117868/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/117868/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6CB3AA0544;\n\tTue, 11 Oct 2022 03:51:23 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5F3A242BD6;\n\tTue, 11 Oct 2022 03:51:12 +0200 (CEST)", "from NAM12-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam12on2054.outbound.protection.outlook.com [40.107.244.54])\n by mails.dpdk.org (Postfix) with ESMTP id B43B042B6F\n for <dev@dpdk.org>; Mon, 10 Oct 2022 23:47:39 +0200 (CEST)", "from BN9PR03CA0173.namprd03.prod.outlook.com (2603:10b6:408:f4::28)\n by BY5PR19MB3794.namprd19.prod.outlook.com (2603:10b6:a03:222::16)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Mon, 10 Oct\n 2022 21:47:35 +0000", "from BN8NAM04FT056.eop-NAM04.prod.protection.outlook.com\n (2603:10b6:408:f4:cafe::61) by BN9PR03CA0173.outlook.office365.com\n (2603:10b6:408:f4::28) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15 via Frontend\n Transport; Mon, 10 Oct 2022 21:47:34 +0000", "from uww-mx01.datadirectnet.com (50.222.100.11) by\n BN8NAM04FT056.mail.protection.outlook.com (10.13.161.127) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.5709.10 via Frontend Transport; Mon, 10 Oct 2022 21:47:34 +0000", "from localhost (unknown [10.68.0.8])\n by uww-mx01.datadirectnet.com (Postfix) with ESMTP id 16E6D20C684B;\n Mon, 10 Oct 2022 15:48:43 -0600 (MDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=KwON45Zj4Y4zt+YVm10/JPbx1hKUvpJn1p1/f1Ik11mXGrZP5XCbiBrGr294GFlpVqPUeUgUKPGTIXVJJSsex1I9VUDKkWgqtu47FBQzPRIfFsfwJzBYFghqXF+uUg24JGLPaZLzVcBHEVea84L3xS3aq8zE+G4Chfhu7ffxFXCwZJYWJTmFqKsuvhDV5a8vVZOKp/gNxAMRH/EKKXA+3aaR6QkuS3V1T4NQVN9xIQx3FtPFUSDDLeaDh7Rj3ceoyXVB1qDo9n9qt+eeUKKQ5Omo6k1F0i3n+WP7e+BGdaLnWbgGxuC2OhBZCshSzkm3n+55Lh5uCPUjTW7nyTk4kQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=6RFBDaZJY9leCz+YJ5hcLitKpkHpdJzxh8SVVyW4IOk=;\n b=Sla2EDdauZC+yvN177fUXkqDzQuyYBd/+Bupn4JfRHTpQpsaaMOtiAH1QMeS1Nm04npm5pHrqFc7vPIlTvmJCLo7OH0/SwTLNF92jXQlaU0olt+CpIbCSAK14wZTN3zDrsLG/oqU6K9PAVoqAyKbQk6jEkSaXFud5xl2ks5/2Hg5/bcbwXNuwU0w44+a1wdwVP15xvlxFeJLYXDzfbxUqYNn2DO7L5Rz3aOvlb02Ct8xKtyt2aKiw+uypowd4dIsW6vzHN+tn9Tf+OAvDlNxC/xUCTmHvGzG5nvHBIfJRTaK8ZeBtdMf6tNjA+cE8sB9sDBwCasPwb0Vgu20FnnfsA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 50.222.100.11) smtp.rcpttodomain=amd.com smtp.mailfrom=ddn.com; dmarc=pass\n (p=reject sp=none pct=100) action=none header.from=ddn.com; dkim=none\n (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ddn.com; s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=6RFBDaZJY9leCz+YJ5hcLitKpkHpdJzxh8SVVyW4IOk=;\n b=dWWjXlCQHrhiGFnyG1PNmvblhup8PeUwuksDBvFyyLkgTg0Ro3atcCYTMlCwtaKAA48ZDNvOm4dSigdod4OfyZhchVGs0EYNboiNyVj1VPWZxpTmdwGPFraoPSQji1ZtNCq5K+D8FAJP4DJC5WzYpMV/R7OhGJnpbw3it0qNO8g=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 50.222.100.11)\n smtp.mailfrom=ddn.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=ddn.com;", "Received-SPF": "Pass (protection.outlook.com: domain of ddn.com designates\n 50.222.100.11 as permitted sender) receiver=protection.outlook.com;\n client-ip=50.222.100.11; helo=uww-mx01.datadirectnet.com; pr=C", "From": "Michael Piszczek <mpiszczek@ddn.com>", "To": "dev@dpdk.org", "Cc": "Vipin.Varghese@amd.com,\n\tMichael Piszczek <mpiszczek@ddn.com>", "Subject": "[PATCH v3] pci: read amd iommu virtual address width", "Date": "Mon, 10 Oct 2022 23:47:20 +0200", "Message-Id": "<20221010214720.766459-2-mpiszczek@ddn.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20221010214720.766459-1-mpiszczek@ddn.com>", "References": "<20220912160157.3642968-2-mpiszczek@ddn.com>\n <20221010214720.766459-1-mpiszczek@ddn.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "BN8NAM04FT056:EE_|BY5PR19MB3794:EE_", "Content-Type": "text/plain", "X-MS-Office365-Filtering-Correlation-Id": "f9ce4a4d-6ed9-47b1-d01a-08daab090a5b", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 1WCdVLY3TwbtlsFpt8JPjfva0c7FbYY6/bTDqmQmQiTH7cwPhCx+lzrSyXasWfxpFs2WgaE7BIn3rtVqNu5X9jIrDATcpYnaJG21WE6X5zZQZrErXFQRANL5aUH5dYi7GM2MzODEkL0CaArl/9QLapDC8HNea7ADrlx7uQoNj7NQiecbOqXnl9n3fYkiokDV1lHAvvLXQP4kE9hCGyS/oLTYxtSnJw7V44B8zWDu88uL8GPG38Wz2uwgSI84damheRxDKfQ5HKrzVhVHlLf7RdxvhtwMmFlzVXm5Mtv2MNAm7EAycbaJnGvb8cVB+m7i9g4ZQ0fQc4FVe4nSrqlGeDWkYqmM7Vb434UhP+OqzXnsTfwH34ALvRMU1JJXAxxYfrTRd1DuiIFN1TSXZZF3wIigtbgqIhyCaeIJl0lmc1cJAUA/UkqSUHL+5n3/v+k+2SZuOG+uHoz5zOUp3cPMES+WmkkHJxfGfC5lSVCBLpkeR8vNjDqLDp1y19lAksWI8/ZAdS6cl3mPZPpa3rmsKUYhpHLV+cZuSvS1+fahsfjfe0FCNaz9FxhUs8qSrZ5STMsOC49M3H7bAzG/t5nX2keAqP9hfNA91A43vGfbTM06p7qtz9kWOIf7CcAzcQSiSe/uwkV6zX0B0IXAFJ9XieH5ZYvE2akquKgeq325A7NKkFaZqleYaIELDQ7C34wK5AOATJymYLKqJxaIsVVRH1Tai8juGHKyA/N64uN5wUGYYtehGjvQydAbwtXqc4yBHHTuCHsdz/Cqeja/pF6ppw==", "X-Forefront-Antispam-Report": "CIP:50.222.100.11; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:uww-mx01.datadirectnet.com; PTR:InfoDomainNonexistent;\n CAT:NONE;\n SFS:(13230022)(4636009)(39840400004)(346002)(376002)(396003)(136003)(451199015)(36840700001)(46966006)(336012)(47076005)(2616005)(2906002)(1076003)(186003)(8936002)(41300700001)(26005)(5660300002)(6266002)(356005)(81166007)(82310400005)(86362001)(40480700001)(36756003)(83380400001)(36860700001)(316002)(6916009)(478600001)(70206006)(8676002)(4326008)(70586007)(6666004)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "ddn.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "10 Oct 2022 21:47:34.1784 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n f9ce4a4d-6ed9-47b1-d01a-08daab090a5b", "X-MS-Exchange-CrossTenant-Id": "753b6e26-6fd3-43e6-8248-3f1735d59bb4", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=753b6e26-6fd3-43e6-8248-3f1735d59bb4; Ip=[50.222.100.11];\n Helo=[uww-mx01.datadirectnet.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BN8NAM04FT056.eop-NAM04.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BY5PR19MB3794", "X-Mailman-Approved-At": "Tue, 11 Oct 2022 03:51:08 +0200", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add code to read the virtual address width for AMD processors.\n\nSigned-off-by: Michael Piszczek <mpiszczek@ddn.com>\n---\n drivers/bus/pci/linux/pci.c | 47 +++++++++++++++++++++++--------------\n 1 file changed, 30 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c\nindex e521459870..8c6082ee7a 100644\n--- a/drivers/bus/pci/linux/pci.c\n+++ b/drivers/bus/pci/linux/pci.c\n@@ -492,15 +492,18 @@ rte_pci_scan(void)\n }\n \n #if defined(RTE_ARCH_X86)\n+\n bool\n pci_device_iommu_support_va(const struct rte_pci_device *dev)\n {\n #define VTD_CAP_MGAW_SHIFT\t16\n #define VTD_CAP_MGAW_MASK\t(0x3fULL << VTD_CAP_MGAW_SHIFT)\n+#define RD_AMD_CAP_VASIZE_SHIFT 15\n+#define RD_AMD_CAP_VASIZE_MASK (0x7F << RD_AMD_CAP_VASIZE_SHIFT)\n \tconst struct rte_pci_addr *addr = &dev->addr;\n \tchar filename[PATH_MAX];\n \tFILE *fp;\n-\tuint64_t mgaw, vtd_cap_reg = 0;\n+\tuint64_t mgaw, cap_reg = 0;\n \n \tsnprintf(filename, sizeof(filename),\n \t\t \"%s/\" PCI_PRI_FMT \"/iommu/intel-iommu/cap\",\n@@ -508,26 +511,36 @@ pci_device_iommu_support_va(const struct rte_pci_device *dev)\n \t\t addr->function);\n \n \tfp = fopen(filename, \"r\");\n-\tif (fp == NULL) {\n-\t\t/* We don't have an Intel IOMMU, assume VA supported */\n-\t\tif (errno == ENOENT)\n-\t\t\treturn true;\n-\n-\t\tRTE_LOG(ERR, EAL, \"%s(): can't open %s: %s\\n\",\n-\t\t\t__func__, filename, strerror(errno));\n-\t\treturn false;\n-\t}\n+\tif (fp != NULL) {\n+\t\t/* We have an Intel IOMMU */\n+\t\tif (fscanf(fp, \"%\" PRIx64, &cap_reg) != 1) {\n+\t\t\t RTE_LOG(ERR, EAL, \"%s(): can't read %s\\n\", __func__, filename);\n+\t\t\tfclose(fp);\n+\t\t\treturn false;\n+\t\t}\n \n-\t/* We have an Intel IOMMU */\n-\tif (fscanf(fp, \"%\" PRIx64, &vtd_cap_reg) != 1) {\n-\t\tRTE_LOG(ERR, EAL, \"%s(): can't read %s\\n\", __func__, filename);\n \t\tfclose(fp);\n-\t\treturn false;\n+\t\tmgaw = ((cap_reg & VTD_CAP_MGAW_MASK) >> VTD_CAP_MGAW_SHIFT) + 1;\n \t}\n+\telse {\n+\t\tsnprintf(filename, sizeof(filename),\n+\t\t\t \"%s/\" PCI_PRI_FMT \"/iommu/amd-iommu/cap\",\n+\t\t\t rte_pci_get_sysfs_path(), addr->domain, addr->bus, addr->devid,\n+\t\t\t addr->function);\n+\n+\t\tfp = fopen(filename, \"r\");\n+\t\tif (fp != NULL) {\n+\t\t\t/* We have an Amd IOMMU */\n+\t\t\tif (fscanf(fp, \"%\" PRIx64, &cap_reg) != 1) {\n+\t\t\t\t RTE_LOG(ERR, EAL, \"%s(): can't read %s\\n\", __func__, filename);\n+\t\t\t\tfclose(fp);\n+\t\t\t\treturn false;\n+\t\t\t}\n \n-\tfclose(fp);\n-\n-\tmgaw = ((vtd_cap_reg & VTD_CAP_MGAW_MASK) >> VTD_CAP_MGAW_SHIFT) + 1;\n+\t\t\tfclose(fp);\n+\t\t\tmgaw = ((cap_reg & RD_AMD_CAP_VASIZE_MASK) >> RD_AMD_CAP_VASIZE_SHIFT) + 1;\n+\t\t}\n+\t}\n \n \t/*\n \t * Assuming there is no limitation by now. We can not know at this point\n", "prefixes": [ "v3" ] }