Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1176/?format=api
{ "id": 1176, "url": "http://patches.dpdk.org/api/patches/1176/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/69a73749-cfb8-43fd-89be-b5d533ad7e8f@cinfotech.cn/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<69a73749-cfb8-43fd-89be-b5d533ad7e8f@cinfotech.cn>", "list_archive_url": "https://inbox.dpdk.org/dev/69a73749-cfb8-43fd-89be-b5d533ad7e8f@cinfotech.cn", "date": "2014-11-06T14:48:47", "name": "[dpdk-dev] 答复：[PATCH v2] eal: map uio resources after hugepages when the base_virtaddr is configured.", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "dd5fd4819a91addc739f74c69b4490bced55ee17", "submitter": { "id": 106, "url": "http://patches.dpdk.org/api/people/106/?format=api", "name": "lxu", "email": "liang.xu@cinfotech.cn" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/69a73749-cfb8-43fd-89be-b5d533ad7e8f@cinfotech.cn/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/1176/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/1176/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id A67617F18;\n\tThu, 6 Nov 2014 15:39:32 +0100 (CET)", "from out1134-227.mail.aliyun.com (out1134-227.mail.aliyun.com\n\t[42.120.134.227]) by dpdk.org (Postfix) with ESMTP id 310E87EC4\n\tfor <dev@dpdk.org>; Thu, 6 Nov 2014 15:39:26 +0100 (CET)", "from WS-web (liang.xu@cinfotech.cn[222.65.239.251]) by\n\tr41g06011.xy2.aliyun.com at Thu, 06 Nov 2014 22:48:47 +0800" ], "X-Alimail-AntiSpam": "AC=CONTINUE; BC=0.02410913|-1; FP=0|0|0|0|0|-1|-1|-1;\n\tHT=r41g08149; MF=liang.xu@cinfotech.cn; PH=DW; RN=2; RT=2; SR=0; ", "Date": "Thu, 06 Nov 2014 22:48:47 +0800", "From": "\"=?UTF-8?B?5b6Q5Lqu?=\" <liang.xu@cinfotech.cn>", "To": "\"=?UTF-8?B?QnVyYWtvdiwgQW5hdG9seQ==?=\" <anatoly.burakov@intel.com>,\n\t\"dev@dpdk.org\" <dev@dpdk.org>", "Message-ID": "<69a73749-cfb8-43fd-89be-b5d533ad7e8f@cinfotech.cn>", "X-Mailer": "Alimail-Mailagent revision 2667797", "MIME-Version": "1.0", "References": "<1415193919-17361-1-git-send-email-liang.xu@cinfotech.cn>\n\t<1415283104-29970-1-git-send-email-liang.xu@cinfotech.cn>,\n\tb4328080-b71e-4cb4-b41b-ccdf8523a0ea@alibaba.com", "In-Reply-To": "b4328080-b71e-4cb4-b41b-ccdf8523a0ea@alibaba.com", "x-aliyun-mail-creator": "Webmail4_2670074_M3LTW96aWxsYS81LjAgKE1hY2ludG9zaDsgSW50ZWwgTWFjIE9TIFggMTBfMTBfMCkgQXBwbGVXZWJLaXQvNTM3LjM2IChLSFRNTCwgbGlrZSBHZWNrbykgQ2hyb21lLzM4LjAuMjEyNS4xMTEgU2FmYXJpLzUzNy4zNg==vN", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "quoted-printable", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15", "Subject": "[dpdk-dev] =?utf-8?b?562U5aSN77yaW1BBVENIIHYyXSBlYWw6IG1hcCB1aW8g?=\n\t=?utf-8?q?resources_after_hugepages_when_the_base=5Fvirtaddr_is_configure?=\n\t=?utf-8?q?d=2E?=", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "Reply-To": "=?UTF-8?B?5b6Q5Lqu?= <liang.xu@cinfotech.cn>", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When user configure base_virtaddr, we should believe they can take care it.\nIn my case, I always check /proc/xxxx/maps to find a huge free address space, such as 0x20 0000 0000, to map all the hugepages and uio resource. \n------------------------------------------------------------------发件人：Burakov, Anatoly <anatoly.burakov@intel.com>发送时间：2014年11月6日(星期四) 22:29收件人：徐亮 <liang.xu@cinfotech.cn>，dev@dpdk.org <dev@dpdk.org>主 题：RE: [PATCH v2] eal: map uio resources after hugepages when the base_virtaddr is configured.\nFew nitpicks.\n\nStatic variables are always initialized to 0, so \"= NULL\" isn't necessary, a declaration will suffice. Also, we have a macro RTE_PTR_ADD to add numbers to pointers, I think it would be better to use those. Otherwise, looks fine to me.\n\nI still feel uneasy about depending on nothing being mapped directly after hugepages (perhaps we could do mmap(bar_size) before trying pci_map_resource, and increment requested_addr until we find a free spot?), but I imagine this case would be quite rare, so probably it's not worth the added kludge.\n\nThanks,\nAnatoly\n\n-----Original Message-----\nFrom: lxu [mailto:liang.xu@cinfotech.cn] \nSent: Thursday, November 6, 2014 2:12 PM\nTo: dev@dpdk.org\nCc: Burakov, Anatoly\nSubject: [PATCH v2] eal: map uio resources after hugepages when the base_virtaddr is configured.\n\n---\n lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 29 ++++++++++++++++++++++++++++-\n 1 file changed, 28 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c\nindex 7e62266..a591da3 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c\n@@ -273,6 +273,24 @@ pci_get_uio_dev(struct rte_pci_device *dev, char *dstbuf,\n \treturn uio_num;\n }\n \n+static inline const struct rte_memseg *\n+get_physmem_last(void)\n+{\n+\tconst struct rte_memseg * seg = rte_eal_get_physmem_layout();\n+\tconst struct rte_memseg * last = seg;\n+\tunsigned i = 0;\n+\n+\tfor (i=0; i<RTE_MAX_MEMSEG; i++, seg++) {\n+\t\tif (seg->addr == NULL)\n+\t\t\tbreak;\n+\n+\t\tif(seg->addr > last->addr)\n+\t\t \tlast = seg;\n+\n+\t}\n+\treturn last;\n+}\n+\n /* map the PCI resource of a PCI device in virtual memory */\n int\n pci_uio_map_resource(struct rte_pci_device *dev)\n@@ -290,6 +308,13 @@ pci_uio_map_resource(struct rte_pci_device *dev)\n \tstruct mapped_pci_resource *uio_res;\n \tstruct pci_map *maps;\n \n+\t/* map uio resource into user required virtual address */\n+\tstatic void * requested_addr = NULL;\n+\tif (internal_config.base_virtaddr && NULL == requested_addr) {\n+\t\tconst struct rte_memseg * last = get_physmem_last();\n+\t\trequested_addr = (void *)(last->addr_64 + last->len);\n+\t}\n+\n \tdev->intr_handle.fd = -1;\n \tdev->intr_handle.type = RTE_INTR_HANDLE_UNKNOWN;\n \n@@ -371,10 +396,12 @@ pci_uio_map_resource(struct rte_pci_device *dev)\n \t\t\tif (maps[j].addr != NULL)\n \t\t\t\tfail = 1;\n \t\t\telse {\n-\t\t\t\tmapaddr = pci_map_resource(NULL, fd, (off_t)offset,\n+\t\t\t\tmapaddr = pci_map_resource(requested_addr, fd, (off_t)offset,\n \t\t\t\t\t\t(size_t)maps[j].size);\n \t\t\t\tif (mapaddr == NULL)\n \t\t\t\t\tfail = 1;\n+\t\t\t\telse if (NULL != requested_addr)\n+\t\t\t\t\trequested_addr = (uint8_t *)mapaddr + maps[j].size;\n \t\t\t}\n \n \t\t\tif (fail) {\n", "prefixes": [ "dpdk-dev" ] }