Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/117579/?format=api
{ "id": 117579, "url": "http://patches.dpdk.org/api/patches/117579/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221007172921.3325250-5-andrew.rybchenko@oktetlabs.ru/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221007172921.3325250-5-andrew.rybchenko@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20221007172921.3325250-5-andrew.rybchenko@oktetlabs.ru", "date": "2022-10-07T17:29:21", "name": "[v8,4/4] app/testpmd: support mulitiple mbuf pools per Rx queue", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "bb36f15515d2536a7ac4d85b87886bdbbbc79778", "submitter": { "id": 2013, "url": "http://patches.dpdk.org/api/people/2013/?format=api", "name": "Andrew Rybchenko", "email": "Andrew.Rybchenko@oktetlabs.ru" }, "delegate": { "id": 3961, "url": "http://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221007172921.3325250-5-andrew.rybchenko@oktetlabs.ru/mbox/", "series": [ { "id": 25036, "url": "http://patches.dpdk.org/api/series/25036/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=25036", "date": "2022-10-07T17:29:17", "name": "ethdev: support mulitiple mbuf pools per Rx queue", "version": 8, "mbox": "http://patches.dpdk.org/series/25036/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/117579/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/117579/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CEA25A00C4;\n\tFri, 7 Oct 2022 19:29:45 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0245C4281C;\n\tFri, 7 Oct 2022 19:29:30 +0200 (CEST)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id CAC1C427EE\n for <dev@dpdk.org>; Fri, 7 Oct 2022 19:29:25 +0200 (CEST)", "by shelob.oktetlabs.ru (Postfix, from userid 115)\n id 999F298; Fri, 7 Oct 2022 20:29:25 +0300 (MSK)", "from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17])\n by shelob.oktetlabs.ru (Postfix) with ESMTP id 7103786;\n Fri, 7 Oct 2022 20:29:23 +0300 (MSK)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.6 (2021-04-09) on mail1.oktetlabs.ru", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.8 required=5.0 tests=ALL_TRUSTED, DKIM_ADSP_DISCARD\n autolearn=no autolearn_force=no version=3.4.6", "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 7103786", "Authentication-Results": "shelob.oktetlabs.ru/7103786; dkim=none;\n dkim-atps=neutral", "From": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "To": "Aman Singh <aman.deep.singh@intel.com>,\n Yuying Zhang <yuying.zhang@intel.com>", "Cc": "dev@dpdk.org,\n\tHanumanth Pothula <hpothula@marvell.com>", "Subject": "[PATCH v8 4/4] app/testpmd: support mulitiple mbuf pools per Rx queue", "Date": "Fri, 7 Oct 2022 20:29:21 +0300", "Message-Id": "<20221007172921.3325250-5-andrew.rybchenko@oktetlabs.ru>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20221007172921.3325250-1-andrew.rybchenko@oktetlabs.ru>", "References": "<20221006170126.1322852-1-hpothula@marvell.com>\n <20221007172921.3325250-1-andrew.rybchenko@oktetlabs.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Hanumanth Pothula <hpothula@marvell.com>\n\nSome of the HW has support for choosing memory pools based on the\npacket's size. The pool sort capability allows PMD/NIC to choose\na memory pool based on the packet's length.\n\nOn multiple mempool support enabled, populate mempool array and\nalso print pool name on which packet is received.\n\nSigned-off-by: Hanumanth Pothula <hpothula@marvell.com>\n---\n app/test-pmd/testpmd.c | 34 ++++++++++++++++++++++++----------\n app/test-pmd/testpmd.h | 3 +++\n app/test-pmd/util.c | 4 ++--\n 3 files changed, 29 insertions(+), 12 deletions(-)", "diff": "diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex de6ad00138..2ce9953c76 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -2624,6 +2624,7 @@ rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id,\n \t struct rte_eth_rxconf *rx_conf, struct rte_mempool *mp)\n {\n \tunion rte_eth_rxseg rx_useg[MAX_SEGS_BUFFER_SPLIT] = {};\n+\tstruct rte_mempool *rx_mempool[MAX_MEMPOOL] = {};\n \tunsigned int i, mp_n;\n \tint ret;\n \n@@ -2645,16 +2646,29 @@ rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id,\n \t\t */\n \t\tmp_n = (i >= mbuf_data_size_n) ? mbuf_data_size_n - 1 : i;\n \t\tmpx = mbuf_pool_find(socket_id, mp_n);\n-\t\t/* Handle zero as mbuf data buffer size. */\n-\t\trx_seg->length = rx_pkt_seg_lengths[i] ?\n-\t\t\t\t rx_pkt_seg_lengths[i] :\n-\t\t\t\t mbuf_data_size[mp_n];\n-\t\trx_seg->offset = i < rx_pkt_nb_offs ?\n-\t\t\t\t rx_pkt_seg_offsets[i] : 0;\n-\t\trx_seg->mp = mpx ? mpx : mp;\n-\t}\n-\trx_conf->rx_nseg = rx_pkt_nb_segs;\n-\trx_conf->rx_seg = rx_useg;\n+\t\tif (rx_conf->offloads & RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT) {\n+\t\t\t/**\n+\t\t\t * On Segment length zero, update length as,\n+\t\t\t * buffer size - headroom size\n+\t\t\t * to make sure enough space is accomidate for header.\n+\t\t\t */\n+\t\t\trx_seg->length = rx_pkt_seg_lengths[i] ?\n+\t\t\t\t\t rx_pkt_seg_lengths[i] :\n+\t\t\t\t\t mbuf_data_size[mp_n] - RTE_PKTMBUF_HEADROOM;\n+\t\t\trx_seg->offset = i < rx_pkt_nb_offs ?\n+\t\t\t\t\t rx_pkt_seg_offsets[i] : 0;\n+\t\t\trx_seg->mp = mpx ? mpx : mp;\n+\t\t} else {\n+\t\t\trx_mempool[i] = mpx ? mpx : mp;\n+\t\t}\n+\t}\n+\tif (rx_conf->offloads & RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT) {\n+\t\trx_conf->rx_nseg = rx_pkt_nb_segs;\n+\t\trx_conf->rx_seg = rx_useg;\n+\t} else {\n+\t\trx_conf->rx_mempools = rx_mempool;\n+\t\trx_conf->rx_nmempool = rx_pkt_nb_segs;\n+\t}\n \tret = rte_eth_rx_queue_setup(port_id, rx_queue_id, nb_rx_desc,\n \t\t\t\t socket_id, rx_conf, NULL);\n \trx_conf->rx_seg = NULL;\ndiff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h\nindex cbbc7cc350..2f50a10d1f 100644\n--- a/app/test-pmd/testpmd.h\n+++ b/app/test-pmd/testpmd.h\n@@ -80,6 +80,9 @@ extern uint8_t cl_quit;\n \n #define MIN_TOTAL_NUM_MBUFS 1024\n \n+/* Maximum number of pools supported per Rx queue */\n+#define MAX_MEMPOOL 8\n+\n typedef uint8_t lcoreid_t;\n typedef uint16_t portid_t;\n typedef uint16_t queueid_t;\ndiff --git a/app/test-pmd/util.c b/app/test-pmd/util.c\nindex fd98e8b51d..f9df5f69ef 100644\n--- a/app/test-pmd/util.c\n+++ b/app/test-pmd/util.c\n@@ -150,8 +150,8 @@ dump_pkt_burst(uint16_t port_id, uint16_t queue, struct rte_mbuf *pkts[],\n \t\tprint_ether_addr(\" - dst=\", ð_hdr->dst_addr,\n \t\t\t\t print_buf, buf_size, &cur_len);\n \t\tMKDUMPSTR(print_buf, buf_size, cur_len,\n-\t\t\t \" - type=0x%04x - length=%u - nb_segs=%d\",\n-\t\t\t eth_type, (unsigned int) mb->pkt_len,\n+\t\t\t \" - pool=%s - type=0x%04x - length=%u - nb_segs=%d\",\n+\t\t\t mb->pool->name, eth_type, (unsigned int) mb->pkt_len,\n \t\t\t (int)mb->nb_segs);\n \t\tol_flags = mb->ol_flags;\n \t\tif (ol_flags & RTE_MBUF_F_RX_RSS_HASH) {\n", "prefixes": [ "v8", "4/4" ] }