Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 117190,
    "url": "http://patches.dpdk.org/api/patches/117190/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220930072220.20753-17-liudongdong3@huawei.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20220930072220.20753-17-liudongdong3@huawei.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20220930072220.20753-17-liudongdong3@huawei.com",
    "date": "2022-09-30T07:22:17",
    "name": "[16/19] net/hns3: add check for L3 and L4 type",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "71eecd79775ec1f054711e4601e935b325c0af37",
    "submitter": {
        "id": 2718,
        "url": "http://patches.dpdk.org/api/people/2718/?format=api",
        "name": "Dongdong Liu",
        "email": "liudongdong3@huawei.com"
    },
    "delegate": {
        "id": 3961,
        "url": "http://patches.dpdk.org/api/users/3961/?format=api",
        "username": "arybchenko",
        "first_name": "Andrew",
        "last_name": "Rybchenko",
        "email": "andrew.rybchenko@oktetlabs.ru"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220930072220.20753-17-liudongdong3@huawei.com/mbox/",
    "series": [
        {
            "id": 24928,
            "url": "http://patches.dpdk.org/api/series/24928/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24928",
            "date": "2022-09-30T07:22:03",
            "name": "some bugfixes and clean code for hns3 - part2",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/24928/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/117190/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/117190/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E64CDA034C;\n\tFri, 30 Sep 2022 09:25:32 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8F5CB42B84;\n\tFri, 30 Sep 2022 09:24:25 +0200 (CEST)",
            "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 920F042BC9;\n Fri, 30 Sep 2022 09:24:22 +0200 (CEST)",
            "from kwepemi500017.china.huawei.com (unknown [172.30.72.53])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Mf1pN2lt6zVhk0;\n Fri, 30 Sep 2022 15:20:12 +0800 (CST)",
            "from localhost.localdomain (10.28.79.22) by\n kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2375.31; Fri, 30 Sep 2022 15:24:20 +0800"
        ],
        "From": "Dongdong Liu <liudongdong3@huawei.com>",
        "To": "<dev@dpdk.org>, <andrew.rybchenko@oktetlabs.ru>, <ferruh.yigit@amd.com>,\n <thomas@monjalon.net>",
        "CC": "<stable@dpdk.org>, <fengchengwen@huawei.com>, <yisen.zhuang@huawei.com>,\n <liudongdong3@huawei.com>, <lihuisong@huawei.com>, <haijie1@huawei.com>",
        "Subject": "[PATCH 16/19] net/hns3: add check for L3 and L4 type",
        "Date": "Fri, 30 Sep 2022 15:22:17 +0800",
        "Message-ID": "<20220930072220.20753-17-liudongdong3@huawei.com>",
        "X-Mailer": "git-send-email 2.22.0",
        "In-Reply-To": "<20220930072220.20753-1-liudongdong3@huawei.com>",
        "References": "<20220930072220.20753-1-liudongdong3@huawei.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[10.28.79.22]",
        "X-ClientProxiedBy": "dggems702-chm.china.huawei.com (10.3.19.179) To\n kwepemi500017.china.huawei.com (7.221.188.110)",
        "X-CFilter-Loop": "Reflected",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "From: Huisong Li <lihuisong@huawei.com>\n\nWhen user set 'L3_SRC/DST_ONLY' or 'L4_SRC/DST_ONLY' to 'rss_hf' and\ndo not specify the packet type, these types will be set to hardware.\nSo this patch adds a check for them.\n\nFixes: 806f1d5ab0e3 (\"net/hns3: set RSS hash type input configuration\")\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\n---\n drivers/net/hns3/hns3_rss.c | 31 +++++++++++++++++++++++++++++--\n 1 file changed, 29 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/hns3/hns3_rss.c b/drivers/net/hns3/hns3_rss.c\nindex ea745c791f..ca5a129234 100644\n--- a/drivers/net/hns3/hns3_rss.c\n+++ b/drivers/net/hns3/hns3_rss.c\n@@ -400,8 +400,34 @@ hns3_rss_reset_indir_table(struct hns3_hw *hw)\n \treturn ret;\n }\n \n+static void\n+hns3_rss_check_l3l4_types(struct hns3_hw *hw, uint64_t rss_hf)\n+{\n+\tuint64_t ip_mask = RTE_ETH_RSS_IPV4 | RTE_ETH_RSS_FRAG_IPV4 |\n+\t\t\t   RTE_ETH_RSS_NONFRAG_IPV4_OTHER |\n+\t\t\t   RTE_ETH_RSS_IPV6 | RTE_ETH_RSS_FRAG_IPV6 |\n+\t\t\t   RTE_ETH_RSS_NONFRAG_IPV6_OTHER;\n+\tuint64_t l4_mask = RTE_ETH_RSS_NONFRAG_IPV4_TCP |\n+\t\t\t   RTE_ETH_RSS_NONFRAG_IPV4_UDP |\n+\t\t\t   RTE_ETH_RSS_NONFRAG_IPV4_SCTP |\n+\t\t\t   RTE_ETH_RSS_NONFRAG_IPV6_TCP |\n+\t\t\t   RTE_ETH_RSS_NONFRAG_IPV6_UDP |\n+\t\t\t   RTE_ETH_RSS_NONFRAG_IPV6_SCTP;\n+\tuint64_t l3_src_dst_mask = RTE_ETH_RSS_L3_SRC_ONLY |\n+\t\t\t\t   RTE_ETH_RSS_L3_DST_ONLY;\n+\tuint64_t l4_src_dst_mask = RTE_ETH_RSS_L4_SRC_ONLY |\n+\t\t\t\t   RTE_ETH_RSS_L4_DST_ONLY;\n+\n+\tif (rss_hf & l3_src_dst_mask &&\n+\t    !(rss_hf & ip_mask || rss_hf & l4_mask))\n+\t\thns3_warn(hw, \"packet type isn't specified, L3_SRC/DST_ONLY is ignored.\");\n+\n+\tif (rss_hf & l4_src_dst_mask && !(rss_hf & l4_mask))\n+\t\thns3_warn(hw, \"packet type isn't specified, L4_SRC/DST_ONLY is ignored.\");\n+}\n+\n static uint64_t\n-hns3_rss_calc_tuple_filed(uint64_t rss_hf)\n+hns3_rss_calc_tuple_filed(struct hns3_hw *hw, uint64_t rss_hf)\n {\n \tuint64_t l3_only_mask = RTE_ETH_RSS_L3_SRC_ONLY |\n \t\t\t\tRTE_ETH_RSS_L3_DST_ONLY;\n@@ -430,6 +456,7 @@ hns3_rss_calc_tuple_filed(uint64_t rss_hf)\n \t\t    !has_l3_l4_only)\n \t\t\ttuple |= hns3_set_tuple_table[i].rss_field;\n \t}\n+\thns3_rss_check_l3l4_types(hw, rss_hf);\n \n \treturn tuple;\n }\n@@ -445,7 +472,7 @@ hns3_set_rss_tuple_by_rss_hf(struct hns3_hw *hw, uint64_t rss_hf)\n \thns3_cmd_setup_basic_desc(&desc, HNS3_OPC_RSS_INPUT_TUPLE, false);\n \treq = (struct hns3_rss_input_tuple_cmd *)desc.data;\n \n-\ttuple_field = hns3_rss_calc_tuple_filed(rss_hf);\n+\ttuple_field = hns3_rss_calc_tuple_filed(hw, rss_hf);\n \treq->tuple_field = rte_cpu_to_le_64(tuple_field);\n \tret = hns3_cmd_send(hw, &desc, 1);\n \tif (ret) {\n",
    "prefixes": [
        "16/19"
    ]
}