Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/117068/?format=api
{ "id": 117068, "url": "http://patches.dpdk.org/api/patches/117068/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220928155811.25016-2-arkadiuszx.kusztal@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220928155811.25016-2-arkadiuszx.kusztal@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220928155811.25016-2-arkadiuszx.kusztal@intel.com", "date": "2022-09-28T15:58:11", "name": "[2/2] crypto/qat: fix not set rsa lengths", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c22fbda324e26761a3be30b611b0672c614ce2ac", "submitter": { "id": 452, "url": "http://patches.dpdk.org/api/people/452/?format=api", "name": "Arkadiusz Kusztal", "email": "arkadiuszx.kusztal@intel.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220928155811.25016-2-arkadiuszx.kusztal@intel.com/mbox/", "series": [ { "id": 24884, "url": "http://patches.dpdk.org/api/series/24884/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24884", "date": "2022-09-28T15:58:10", "name": "[1/2] crypto/qat: fix uncleared cookies in asym", "version": 1, "mbox": "http://patches.dpdk.org/series/24884/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/117068/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/117068/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F147BA00C4;\n\tWed, 28 Sep 2022 19:07:27 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 760F24280C;\n\tWed, 28 Sep 2022 19:07:22 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by mails.dpdk.org (Postfix) with ESMTP id EC5954114E\n for <dev@dpdk.org>; Wed, 28 Sep 2022 19:07:20 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Sep 2022 10:07:20 -0700", "from silpixa00399302.ir.intel.com ([10.237.214.136])\n by fmsmga004.fm.intel.com with ESMTP; 28 Sep 2022 10:07:19 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1664384841; x=1695920841;\n h=from:to:cc:subject:date:message-id:in-reply-to: references;\n bh=eD5uVfMDl2E6fOgCM8RXRrOpS79geF0KPRyBPqyd5oY=;\n b=j0UViT14laDdJwEOyZTPgs/PAZHNQqEVXTNSEA9WntR+7HmsnoA5U/YQ\n MyqKux1711zhyu3EBa07VRHEg9QZ0ynTO2Uywh6a4L8p1UbhtZEo2JEzQ\n 3hcvAmiv/d7Kvrne5aTBLmCHBaKNZNhrP6N6PAeL5m/ZvIy1wRzgXqblt\n nhxUShdW3wUmwpI2wkDXm0c6S+xb/ODaqmU63vIiW8PaAZgcaRR1Qn7UE\n IryOfrC1LSm70JctBjkf8H7pBTeKUZG2HScYVHjllx3FTiNy5t5Lqcd2d\n 5ewJDSi/O9skw2NjPql29kOuHt6AWIUh1SvLIvPkV8Ls+7+pvDFCN9y+G w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10484\"; a=\"281376333\"", "E=Sophos;i=\"5.93,352,1654585200\"; d=\"scan'208\";a=\"281376333\"", "E=McAfee;i=\"6500,9779,10484\"; a=\"690470430\"", "E=Sophos;i=\"5.93,352,1654585200\"; d=\"scan'208\";a=\"690470430\"" ], "X-ExtLoop1": "1", "From": "Arek Kusztal <arkadiuszx.kusztal@intel.com>", "To": "dev@dpdk.org", "Cc": "gakhil@marvell.com, kai.ji@intel.com,\n Arek Kusztal <arkadiuszx.kusztal@intel.com>", "Subject": "[PATCH 2/2] crypto/qat: fix not set rsa lengths", "Date": "Wed, 28 Sep 2022 16:58:11 +0100", "Message-Id": "<20220928155811.25016-2-arkadiuszx.kusztal@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20220928155811.25016-1-arkadiuszx.kusztal@intel.com>", "References": "<20220928155811.25016-1-arkadiuszx.kusztal@intel.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Fixed not set output length in asym pmd\nwhen doing RSA.\n\nFixes: 002486db239e (\"crypto/qat: refactor asymmetric session\")\n\nSigned-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>\n---\n drivers/crypto/qat/qat_asym.c | 24 ++++++++++--------------\n 1 file changed, 10 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/crypto/qat/qat_asym.c b/drivers/crypto/qat/qat_asym.c\nindex 4b0538eea8..78e18dfc1a 100644\n--- a/drivers/crypto/qat/qat_asym.c\n+++ b/drivers/crypto/qat/qat_asym.c\n@@ -505,21 +505,19 @@ rsa_collect(struct rte_crypto_asym_op *asym_op,\n \n \t\tif (asym_op->rsa.op_type ==\n \t\t\t\tRTE_CRYPTO_ASYM_OP_ENCRYPT) {\n-\t\t\tuint8_t *rsa_result = asym_op->rsa.cipher.data;\n-\n-\t\t\trte_memcpy(rsa_result,\n+\t\t\trte_memcpy(asym_op->rsa.cipher.data,\n \t\t\t\t\tcookie->output_array[0],\n \t\t\t\t\talg_bytesize);\n+\t\t\tasym_op->rsa.cipher.length = alg_bytesize;\n \t\t\tHEXDUMP(\"RSA Encrypted data\", cookie->output_array[0],\n \t\t\t\talg_bytesize);\n \t\t} else {\n-\t\t\tuint8_t *rsa_result = asym_op->rsa.cipher.data;\n-\n \t\t\tswitch (asym_op->rsa.padding.type) {\n \t\t\tcase RTE_CRYPTO_RSA_PADDING_NONE:\n-\t\t\t\trte_memcpy(rsa_result,\n+\t\t\t\trte_memcpy(asym_op->rsa.cipher.data,\n \t\t\t\t\t\tcookie->output_array[0],\n \t\t\t\t\t\talg_bytesize);\n+\t\t\t\tasym_op->rsa.cipher.length = alg_bytesize;\n \t\t\t\tHEXDUMP(\"RSA signature\",\n \t\t\t\t\tcookie->output_array[0],\n \t\t\t\t\talg_bytesize);\n@@ -531,13 +529,12 @@ rsa_collect(struct rte_crypto_asym_op *asym_op,\n \t\t}\n \t} else {\n \t\tif (asym_op->rsa.op_type == RTE_CRYPTO_ASYM_OP_DECRYPT) {\n-\t\t\tuint8_t *rsa_result = asym_op->rsa.message.data;\n-\n \t\t\tswitch (asym_op->rsa.padding.type) {\n \t\t\tcase RTE_CRYPTO_RSA_PADDING_NONE:\n-\t\t\t\trte_memcpy(rsa_result,\n+\t\t\t\trte_memcpy(asym_op->rsa.message.data,\n \t\t\t\t\tcookie->output_array[0],\n \t\t\t\t\talg_bytesize);\n+\t\t\t\tasym_op->rsa.message.length = alg_bytesize;\n \t\t\t\tHEXDUMP(\"RSA Decrypted Message\",\n \t\t\t\t\tcookie->output_array[0],\n \t\t\t\t\talg_bytesize);\n@@ -547,11 +544,10 @@ rsa_collect(struct rte_crypto_asym_op *asym_op,\n \t\t\t\treturn RTE_CRYPTO_OP_STATUS_ERROR;\n \t\t\t}\n \t\t} else {\n-\t\t\tuint8_t *rsa_result = asym_op->rsa.sign.data;\n-\n-\t\t\trte_memcpy(rsa_result,\n-\t\t\t\t\tcookie->output_array[0],\n-\t\t\t\t\talg_bytesize);\n+\t\t\trte_memcpy(asym_op->rsa.sign.data,\n+\t\t\t\tcookie->output_array[0],\n+\t\t\t\talg_bytesize);\n+\t\t\tasym_op->rsa.sign.length = alg_bytesize;\n \t\t\tHEXDUMP(\"RSA Signature\", cookie->output_array[0],\n \t\t\t\talg_bytesize);\n \t\t}\n", "prefixes": [ "2/2" ] }