Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/117032/?format=api
{ "id": 117032, "url": "http://patches.dpdk.org/api/patches/117032/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220928052516.1279442-11-g.singh@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220928052516.1279442-11-g.singh@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220928052516.1279442-11-g.singh@nxp.com", "date": "2022-09-28T05:25:11", "name": "[10/15] net/dpaa: fix Jumbo packet Rx in case of VSP", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "90a438921a46e04cc09c9cff8772bc22fd4418b5", "submitter": { "id": 1068, "url": "http://patches.dpdk.org/api/people/1068/?format=api", "name": "Gagandeep Singh", "email": "g.singh@nxp.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220928052516.1279442-11-g.singh@nxp.com/mbox/", "series": [ { "id": 24872, "url": "http://patches.dpdk.org/api/series/24872/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24872", "date": "2022-09-28T05:25:01", "name": "DPAA and DPAA2 driver changes", "version": 1, "mbox": "http://patches.dpdk.org/series/24872/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/117032/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/117032/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 15117A00C2;\n\tWed, 28 Sep 2022 07:26:50 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9BB3742BA6;\n\tWed, 28 Sep 2022 07:25:59 +0200 (CEST)", "from EUR04-DB3-obe.outbound.protection.outlook.com\n (mail-eopbgr60077.outbound.protection.outlook.com [40.107.6.77])\n by mails.dpdk.org (Postfix) with ESMTP id 48DE7427EE;\n Wed, 28 Sep 2022 07:25:56 +0200 (CEST)", "from AS8PR04MB8198.eurprd04.prod.outlook.com (2603:10a6:20b:3b0::14)\n by PA4PR04MB7504.eurprd04.prod.outlook.com (2603:10a6:102:e6::23)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Wed, 28 Sep\n 2022 05:25:55 +0000", "from AS8PR04MB8198.eurprd04.prod.outlook.com\n ([fe80::14d0:4458:d6ec:b8b1]) by AS8PR04MB8198.eurprd04.prod.outlook.com\n ([fe80::14d0:4458:d6ec:b8b1%7]) with mapi id 15.20.5676.017; Wed, 28 Sep 2022\n 05:25:55 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=SbhzCaCOaRknE3VPBO/QoNbQn0EDymkZbuHzvFfAJuVtkNuggkgRmkHmjRGJwEUhx6v15XL9EUtqE927cOLiMbMc0KyR7UAOiqToi33tt84lfM8dCN5MReZtRGkqe93TvC4PWmf1/BhmiDRD8Z/2ngMJ25VzBwmvjF9cLITEECS8OzOhyuU0xWU8zXnHUtCbpb35Yj7MFcwZtl0TnWn9B9fYh1TXrfFjySiGqUVl/R6GnPAZ0E+ePRciCgYteFdSmuGGQOaxgMx6AvCt/ZwzSqRI49LVx7HaoLBXbd6OoaK3SzY5LYm4M75YkU+9haxAomd2sLj0pVVt3iHH3hpziw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=+Ibhu1iVGJjc2vYUg/dcNY30bt6arqIotwxS9xXAip4=;\n b=doRR84K9nfPYQh7kz1hKpQRF5CFF48N1MDgbBbQ0ZTReeMMu9Ex/V5kUnbUnRnIyquxXdlaWKn1lynOlJZmpBfe1R+EOA3hP4u9aFeRVJKLwMuXgNXjNuDCsM9AV+E9vaboku2aL3XQFsINSy5kEOoVusWyezTUm5ZSdQbDceGI/WV9J2uj3kd6HeM6alCprb10+UB+EEQXV9l+PiF7+gDyY3NxIw5pFT46YEBvoTX3S4mWrpQrQI/bwL9vo21UQ0OlnnmFf3OVYYgo51zHnVCZCEm4dHDZBw/n32usQHIoiWJKy4/kcH9eIl4s9KFBeyQ9nELCp6UNx3HvfpvSO5Q==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass\n header.d=nxp.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=+Ibhu1iVGJjc2vYUg/dcNY30bt6arqIotwxS9xXAip4=;\n b=Ad1KY46nNy14DVN6Lkrvm6bZ3XqxEB4yerejE7CxIA5UtWumdQGmPmSGDugXvg44Gn2gLgKUiCsQ/Yg+eGGEkJvzkXBPuBOICOzMtCCgpZE9tBtVMVGFVVIAj+sZcgIr6pHGd6rd+9JI913hVsqUcx78RoTbuUzTsSqI1/nAOfw=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nxp.com;", "From": "Gagandeep Singh <g.singh@nxp.com>", "To": "ferruh.yigit@amd.com,\n\tdev@dpdk.org", "Cc": "Rohit Raj <rohit.raj@nxp.com>,\n\tstable@dpdk.org", "Subject": "[PATCH 10/15] net/dpaa: fix Jumbo packet Rx in case of VSP", "Date": "Wed, 28 Sep 2022 10:55:11 +0530", "Message-Id": "<20220928052516.1279442-11-g.singh@nxp.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220928052516.1279442-1-g.singh@nxp.com>", "References": "<20220928052516.1279442-1-g.singh@nxp.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "SGBP274CA0015.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b0::27)\n To AS8PR04MB8198.eurprd04.prod.outlook.com\n (2603:10a6:20b:3b0::14)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "AS8PR04MB8198:EE_|PA4PR04MB7504:EE_", "X-MS-Office365-Filtering-Correlation-Id": "a3d34cd7-686f-4923-39e3-08daa111ea9e", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n ErxZETSA4vrx2R2wFZpXqc0B9d0zikEZ0R9fne7t8FwutCT7RsA8UyXC1+i8YRS8xbRWAAHjTtjJ4EPtLAv3btw9TwoCNRTwEP50UI2XcQp+4mdK8fYmcrSylDsAzWw0kMkRr1TgxFUk58I/mo2o0pqHwh+SNWTaw1L/DsC6tFMskYGkC8YKh6JTb92G0tUMsRQfagbgrNHc2GNQNdB5hxEocSOCDqotmcOsjMiEXrKrfjWGtawYcxbIhaAg297U9HwlDmpgFbTVxwU4dlwtSiMCV4a7PbAY2g2jVzizc/6xTUoTsfn5B6KL+6fQPCiLGWySU15mYQjEpvCmmVX/KlWGZURHQEQCIhuEAQlIKhFIGKs0u/l1y5ywYUZ90EZGY2A8FT6DBawwxqL+2YG+yZePImJNrsfa2QOM7/OeoTvftAUGVh+PjRW9G72NwV4XrsgnP2gYKrmJSEdXN4Cnzrk/tLP0wlifHUS0S6eDK8MoLIygkbXAk55iIQASDupZiRxFWr3zAE444o3+MlpErKbWnxqJKTFqESzjyJGkUbzefOSgmBZlbxswLLJj5Jt6M5gR4Xrq0DBqHOFQmKq9Vmg+8NHUjvcsvSwMgmsOY62uXla2abifE0eEVaVY/Y/ju6jyrDYZ7JzDkhjBXOUqQlPRKmCiRDbuwVp+jUTKl6IrZPllV+7ozR+YIhiaPWIdZbRu5Wl1GKzAcBhbRtgRULMhOxOTc+lSrGWroPzotlFI36Xxxwa91xY3sJjsaWcQLrhFnCHOuGm+PY9cO5BWCA==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AS8PR04MB8198.eurprd04.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230022)(4636009)(346002)(366004)(376002)(396003)(136003)(39860400002)(451199015)(1076003)(186003)(2616005)(8676002)(83380400001)(38350700002)(8936002)(6506007)(38100700002)(26005)(86362001)(6512007)(6666004)(2906002)(5660300002)(52116002)(478600001)(66556008)(66476007)(66946007)(316002)(36756003)(41300700001)(4326008)(6486002);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n HyT7B3vcu6JG4WCTy5eCY2FjcCrQX0Sy9So2r2BuZEjUoUWwp4knY3jKOuhuexErq6BHv9iWcqz2LVdU+bIFeq9fjQ2zJfqxE6/ox1c12VLHffzy0he1z1e3R7qBww4/MwImSHYem9zAS/ndl6WSGgVzwYG7ye/ux69gBBS65gmKiVKYDyYNRLigKd8JCQlqsjEmuG+9NqSKoIn1jlKbDrM+4TVt+eA29kdkDf/mJGNFaT+3NlJ6qD29jxbRl0+f4TGsML4o6n+KTbP7lHjkTWTKS6qVBPEDxEDYCAU3O7RqWkK2JmGYDGfwr7piJCtkR2CM1PUs6brFRoO/DECuT6E9B91kk+gMieGXGt8DmqxLvdTALvVc8ZwyQVO8I7hzXbKq6pZkoeRYKWCSiFBCpip6/F55x3trAUVVBM66KGjjQVi9b+zu5KWfNZi4IjF0usEDnwxIKmGoXziSfRp3tu1PGYNdPYmp0G22Aq/NkKaXcv//6dWUBnoAg/LDQZUoYE8AkYinfxKnzKmEzZ1AEGghX2QfiG1f44g39rbkKUEm1o7vmqPRbIqH2Y1BNv8HRAYacyaQwUi6vdza3Max1UpCSAu7aQmWoh+VBcCG82XEOZJejbso0kUT15hjyL63div8l2EfXrq6nSGdRAmFOncZ/2PnHYSotqVCMWBkx3tDsu53f7zNDTVobm77IkksHNJZ+A8CVPcazLvrkI7klfRUbJsow34zrCYrCFsFQJqBewVO15SVf+Rt3kNXk1xltjwu6zdvdRI9WyYNlKRDyWs+HfuizfdOMvmCoTM9ufWAwaCm68DGOTSyRoZiVpyE/S3Vhx/+bk39KxTQMyLR/HIJPBRBxny/vVTg4cmPdMTdA9eMLSYHozxuRlg0v9vD6K5/2eCMpsOVT/UtWzEUqkqBZWIQO+oifJ2E8dEDgR/CBMtrsjcjMcmJiRCLxLlKxRTFQNVBUhnVv3vmQVJHNxX0dGAkqBNPqxnVAmnvIHm90NbSKf2FfKHZLnR5C+kSLiUrDKLB6nm8EXljuk07l3KwNM+lifF+QMdrnesG5C3tnwrVWU9Ki8Tvx3fYeAGqaEoerDrRkVSMdHde2gFvkk8vfZXkN3B5hI3uAGgv68v0fmSSbMwR02LDB0/RT13C1Svwyd33Yay/MJoGHxKvzUOhsI25MMHeiXAvyXqjwqFwURluXuGPXjGOW2vkVpFT7Bpzw+fdVAnF22VCpc8cGNFrBLyu4U8SPE+8s9MApfqfMRiWAx2rZD2ipUL/xNo1fff7ZagfJUJA6ofNjC+gXyiq2AOfhZMSVZEUEw7sXCEPBFd5okpF4ZFgd6j/84JTXRAcdxtChxKSUQ7UARk9QkzTcwyj4/8Zd4EzHpYNIOHZxnA+p29h7jZja4ql1mbVoJaqAGEYMNfgCSRByZWR0ctfGzT+GS1cCsdLPwc8v2+wZ/tT0r2F7y/TYm7rUNx6mB4FrWvBdKntY8F44Wl8ZGeo9AI/hDp+dGo+yPOGh45sF372/TXmpEbXHNJnpFJiwKwg4PqqPJGm67OOIxlNFtCkXgSP30MJLIFfzN5V5yDwmBLG72Swrs195sFoE8y1", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n a3d34cd7-686f-4923-39e3-08daa111ea9e", "X-MS-Exchange-CrossTenant-AuthSource": "AS8PR04MB8198.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "28 Sep 2022 05:25:55.3005 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n TSnmgqZPmKmBqAy8IC+ON87gKqrNhEZWPjGlgiqym9zRuuUrt1wTLi+MDsvQz22+", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PA4PR04MB7504", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Rohit Raj <rohit.raj@nxp.com>\n\nFor packet length of size more than 2K bytes, segmented packets were\nbeing received in DPDK even if mbuf size was greater than packet\nlength. This is due to the configuration in VSP.\n\nThis patch fixes the issue by configurating the VSP according to the\nmbuf size configured during mempool configuration.\n\nFixes: e4abd4ff183c (\"net/dpaa: support virtual storage profile\")\nCc: stable@dpdk.org\n\nSigned-off-by: Rohit Raj <rohit.raj@nxp.com>\n---\n drivers/net/dpaa/dpaa_ethdev.c | 5 ++---\n drivers/net/dpaa/dpaa_flow.c | 13 ++++++-------\n drivers/net/dpaa/dpaa_flow.h | 5 +++--\n 3 files changed, 11 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c\nindex abcb1bc9ec..9b281ba8cb 100644\n--- a/drivers/net/dpaa/dpaa_ethdev.c\n+++ b/drivers/net/dpaa/dpaa_ethdev.c\n@@ -988,8 +988,7 @@ int dpaa_eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,\n \t} else {\n \t\tDPAA_PMD_WARN(\"The requested maximum Rx packet size (%u) is\"\n \t\t \" larger than a single mbuf (%u) and scattered\"\n-\t\t \" mode has not been requested\",\n-\t\t max_rx_pktlen, buffsz - RTE_PKTMBUF_HEADROOM);\n+\t\t \" mode has not been requested\", max_rx_pktlen, buffsz);\n \t}\n \n \tdpaa_intf->bp_info = DPAA_MEMPOOL_TO_POOL_INFO(mp);\n@@ -1004,7 +1003,7 @@ int dpaa_eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,\n \t\tif (vsp_id >= 0) {\n \t\t\tret = dpaa_port_vsp_update(dpaa_intf, fmc_q, vsp_id,\n \t\t\t\t\tDPAA_MEMPOOL_TO_POOL_INFO(mp)->bpid,\n-\t\t\t\t\tfif);\n+\t\t\t\t\tfif, buffsz + RTE_PKTMBUF_HEADROOM);\n \t\t\tif (ret) {\n \t\t\t\tDPAA_PMD_ERR(\"dpaa_port_vsp_update failed\");\n \t\t\t\treturn ret;\ndiff --git a/drivers/net/dpaa/dpaa_flow.c b/drivers/net/dpaa/dpaa_flow.c\nindex 1ccd036027..690ba6bcb3 100644\n--- a/drivers/net/dpaa/dpaa_flow.c\n+++ b/drivers/net/dpaa/dpaa_flow.c\n@@ -939,7 +939,7 @@ int dpaa_fm_term(void)\n \n static int dpaa_port_vsp_configure(struct dpaa_if *dpaa_intf,\n \t\tuint8_t vsp_id, t_handle fman_handle,\n-\t\tstruct fman_if *fif)\n+\t\tstruct fman_if *fif, u32 mbuf_data_room_size)\n {\n \tt_fm_vsp_params vsp_params;\n \tt_fm_buffer_prefix_content buf_prefix_cont;\n@@ -976,10 +976,8 @@ static int dpaa_port_vsp_configure(struct dpaa_if *dpaa_intf,\n \t\treturn -1;\n \t}\n \tvsp_params.ext_buf_pools.num_of_pools_used = 1;\n-\tvsp_params.ext_buf_pools.ext_buf_pool[0].id =\n-\t\tdpaa_intf->vsp_bpid[vsp_id];\n-\tvsp_params.ext_buf_pools.ext_buf_pool[0].size =\n-\t\tRTE_MBUF_DEFAULT_BUF_SIZE;\n+\tvsp_params.ext_buf_pools.ext_buf_pool[0].id = dpaa_intf->vsp_bpid[vsp_id];\n+\tvsp_params.ext_buf_pools.ext_buf_pool[0].size = mbuf_data_room_size;\n \n \tdpaa_intf->vsp_handle[vsp_id] = fm_vsp_config(&vsp_params);\n \tif (!dpaa_intf->vsp_handle[vsp_id]) {\n@@ -1023,7 +1021,7 @@ static int dpaa_port_vsp_configure(struct dpaa_if *dpaa_intf,\n \n int dpaa_port_vsp_update(struct dpaa_if *dpaa_intf,\n \t\tbool fmc_mode, uint8_t vsp_id, uint32_t bpid,\n-\t\tstruct fman_if *fif)\n+\t\tstruct fman_if *fif, u32 mbuf_data_room_size)\n {\n \tint ret = 0;\n \tt_handle fman_handle;\n@@ -1054,7 +1052,8 @@ int dpaa_port_vsp_update(struct dpaa_if *dpaa_intf,\n \n \tdpaa_intf->vsp_bpid[vsp_id] = bpid;\n \n-\treturn dpaa_port_vsp_configure(dpaa_intf, vsp_id, fman_handle, fif);\n+\treturn dpaa_port_vsp_configure(dpaa_intf, vsp_id, fman_handle, fif,\n+\t\t\t\t mbuf_data_room_size);\n }\n \n int dpaa_port_vsp_cleanup(struct dpaa_if *dpaa_intf, struct fman_if *fif)\ndiff --git a/drivers/net/dpaa/dpaa_flow.h b/drivers/net/dpaa/dpaa_flow.h\nindex f5e131acfa..4742b8dd0a 100644\n--- a/drivers/net/dpaa/dpaa_flow.h\n+++ b/drivers/net/dpaa/dpaa_flow.h\n@@ -1,5 +1,5 @@\n /* SPDX-License-Identifier: BSD-3-Clause\n- * Copyright 2017,2019 NXP\n+ * Copyright 2017,2019,2022 NXP\n */\n \n #ifndef __DPAA_FLOW_H__\n@@ -11,7 +11,8 @@ int dpaa_fm_config(struct rte_eth_dev *dev, uint64_t req_dist_set);\n int dpaa_fm_deconfig(struct dpaa_if *dpaa_intf, struct fman_if *fif);\n void dpaa_write_fm_config_to_file(void);\n int dpaa_port_vsp_update(struct dpaa_if *dpaa_intf,\n-\tbool fmc_mode, uint8_t vsp_id, uint32_t bpid, struct fman_if *fif);\n+\tbool fmc_mode, uint8_t vsp_id, uint32_t bpid, struct fman_if *fif,\n+\tu32 mbuf_data_room_size);\n int dpaa_port_vsp_cleanup(struct dpaa_if *dpaa_intf, struct fman_if *fif);\n int dpaa_port_fmc_init(struct fman_if *fif,\n \t\t uint32_t *fqids, int8_t *vspids, int max_nb_rxq);\n", "prefixes": [ "10/15" ] }