Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 11688,
    "url": "http://patches.dpdk.org/api/patches/11688/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1458801431-25886-2-git-send-email-wenzhuo.lu@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1458801431-25886-2-git-send-email-wenzhuo.lu@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1458801431-25886-2-git-send-email-wenzhuo.lu@intel.com",
    "date": "2016-03-24T06:37:10",
    "name": "[dpdk-dev,1/2] ixgbe: fix the wrong address of device data pointer",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "e4bc953ff29d3d1ae9cd27cd375a6217634c4849",
    "submitter": {
        "id": 258,
        "url": "http://patches.dpdk.org/api/people/258/?format=api",
        "name": "Wenzhuo Lu",
        "email": "wenzhuo.lu@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1458801431-25886-2-git-send-email-wenzhuo.lu@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/11688/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/11688/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id EA1D12BF4;\n\tThu, 24 Mar 2016 07:37:22 +0100 (CET)",
            "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 946B82C06\n\tfor <dev@dpdk.org>; Thu, 24 Mar 2016 07:37:21 +0100 (CET)",
            "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga102.fm.intel.com with ESMTP; 23 Mar 2016 23:37:22 -0700",
            "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga002.jf.intel.com with ESMTP; 23 Mar 2016 23:37:20 -0700",
            "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id u2O6bHS1025657;\n\tThu, 24 Mar 2016 14:37:17 +0800",
            "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid u2O6bEvs025928; Thu, 24 Mar 2016 14:37:16 +0800",
            "(from wenzhuol@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id u2O6bEG2025924; \n\tThu, 24 Mar 2016 14:37:14 +0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.24,383,1455004800\"; d=\"scan'208\";a=\"940474548\"",
        "From": "Wenzhuo Lu <wenzhuo.lu@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "Wenzhuo Lu <wenzhuo.lu@intel.com>",
        "Date": "Thu, 24 Mar 2016 14:37:10 +0800",
        "Message-Id": "<1458801431-25886-2-git-send-email-wenzhuo.lu@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "In-Reply-To": "<1458801431-25886-1-git-send-email-wenzhuo.lu@intel.com>",
        "References": "<1458801431-25886-1-git-send-email-wenzhuo.lu@intel.com>",
        "Subject": "[dpdk-dev] [PATCH 1/2] ixgbe: fix the wrong address of device data\n\tpointer",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "There's an issue reported. In the scenario DPDK PF + DPDK VF,\nif the VF port is closed, PF port cannot receive packets.\nI found at that time the promicuous mode is disabled on the PF\nport. But it should be enabled.\nWhen VF port is closed, it will send a message to its PF port to\nreset it. During this, PF port will also reset its own\npromicuous mode. Which promiscuous mode should be set depends on\nthe parameter stored in the device data. In the function\nset_rx_mode, the pointer of device data points to the wrong\naddress. So, the promiscuous mode is wrong.\n\nFixes: 00e30184daa0(\"ixgbe: add PF support\")\nSigned-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>\nReported-by: Bernard Iremonger <bernard.iremonger@intel.com>\n---\n drivers/net/ixgbe/ixgbe_pf.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c\nindex b854c72..0f8ad55 100644\n--- a/drivers/net/ixgbe/ixgbe_pf.c\n+++ b/drivers/net/ixgbe/ixgbe_pf.c\n@@ -313,7 +313,7 @@ static void\n set_rx_mode(struct rte_eth_dev *dev)\n {\n \tstruct rte_eth_dev_data *dev_data =\n-\t\t(struct rte_eth_dev_data*)dev->data->dev_private;\n+\t\t(struct rte_eth_dev_data *)dev->data;\n \tstruct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \tu32 fctrl, vmolr = IXGBE_VMOLR_BAM | IXGBE_VMOLR_AUPE;\n \tuint16_t vfn = dev_num_vf(dev);\n",
    "prefixes": [
        "dpdk-dev",
        "1/2"
    ]
}