Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/116753/?format=api
{ "id": 116753, "url": "http://patches.dpdk.org/api/patches/116753/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220923144334.27736-15-suanmingm@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220923144334.27736-15-suanmingm@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220923144334.27736-15-suanmingm@nvidia.com", "date": "2022-09-23T14:43:21", "name": "[14/27] net/mlx5: fix indirect action validate", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "106f25c16323eea19a5c07fab01e79d51f001d86", "submitter": { "id": 1887, "url": "http://patches.dpdk.org/api/people/1887/?format=api", "name": "Suanming Mou", "email": "suanmingm@nvidia.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220923144334.27736-15-suanmingm@nvidia.com/mbox/", "series": [ { "id": 24805, "url": "http://patches.dpdk.org/api/series/24805/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24805", "date": "2022-09-23T14:43:07", "name": "net/mlx5: HW steering PMD update", "version": 1, "mbox": "http://patches.dpdk.org/series/24805/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/116753/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/116753/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 823C9A054A;\n\tFri, 23 Sep 2022 16:46:21 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0738E42C10;\n\tFri, 23 Sep 2022 16:44:34 +0200 (CEST)", "from NAM11-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam11on2088.outbound.protection.outlook.com [40.107.223.88])\n by mails.dpdk.org (Postfix) with ESMTP id 7B3B942C0A\n for <dev@dpdk.org>; Fri, 23 Sep 2022 16:44:31 +0200 (CEST)", "from MW4PR04CA0293.namprd04.prod.outlook.com (2603:10b6:303:89::28)\n by SJ1PR12MB6028.namprd12.prod.outlook.com (2603:10b6:a03:489::8)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.20; Fri, 23 Sep\n 2022 14:44:29 +0000", "from CO1NAM11FT108.eop-nam11.prod.protection.outlook.com\n (2603:10b6:303:89:cafe::71) by MW4PR04CA0293.outlook.office365.com\n (2603:10b6:303:89::28) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.20 via Frontend\n Transport; Fri, 23 Sep 2022 14:44:29 +0000", "from mail.nvidia.com (216.228.117.161) by\n CO1NAM11FT108.mail.protection.outlook.com (10.13.175.226) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.5654.14 via Frontend Transport; Fri, 23 Sep 2022 14:44:29 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Fri, 23 Sep\n 2022 07:44:14 -0700", "from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Fri, 23 Sep\n 2022 07:44:12 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=aLwEqJuqMlJy9Gp6PK/IGRswVb3pGSa81D7Bb4AaW26fVSTk7G69pBNzuiT3Zeg7C5FXLVKmx5mmzzL7NAtzKRzokA7Hbn/3FWBi+B3D2zp1xzwJV6UjdfQhtWNDOXo1MAs/+QXebN1rHOcJMGytNKoy1zA52Oc2F1LcE3HxLQgdGSZ8GjZGcA30aur5OAAPvHBckwdexO8lzvK6dnepy2l9NdBgFy5BFdaKUoOtGVCx4MCrRKHkfvtgNtcOr6G/meYD6g+DmYrMwQ7+fOIUQ6mMzs92b7Is1bVEjLD6AeLfN9daR8DusurmRR1ozRBXujdzwmJL2+XRAHQK8RyZbg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=9904UsvJEfjQpFH7iw9pHt/WVYUfuDIuviy2PwJO/o0=;\n b=NSwOklCmjaFysCNRch7NoqOxtYQZTrlst8WLsllE8QoIkhy1xx0sCC9j/uJ7F/T7NUG5L9Xtm/sUL0t1hYIIE8KQL4AUNRU/QAOjnK0qulk3SQYd1zLUKGLwlBp12ZaWk72ocTAtZbEWbztVkPcfjSfIeuIb0M1tAeK2HV4wnQ4P+RkizBk7TWEA1gkiYgVBcQCXk+k+KV8x4FdRHcbl4h/DA3KQowCtvM71k3IcTySCaMsL9g+f9k1iA82WXCyip4itgF+ygj4QBrV73J2AhdM4bPr1vYQ/bfIuymWzR0p0Z1uO21ZokYbgWaVHrgtNr+t36CbTEhsiJ3K8bvERyA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=9904UsvJEfjQpFH7iw9pHt/WVYUfuDIuviy2PwJO/o0=;\n b=DJSJj4Mm4D22vIfAMb8WhOg6lzS8sgHVt+onsV+EJMlPIHPoHl+fSEsWF1A5fK7ZZNHKCTYJXGqNEWlaNeCVGIfSN1yphPqi0X2iNqkZNr0y9kUuwfKUjgSvQimhx0ELBPMS42aW3jugzZ8kunZ0iimfSpEpn9q7cgx+6dUQcZUtiquSbbcOM865zM/+9s6pCknRRTcAUxNP93ANEgrJVDaoRFsbRd+K92X9UMZgeBOh1Qmru1rDkk/1IDlRr3fbgvaavlbtcd7EiEZbTfOTHZsSe/gI1aCwJYvCAsqixI3UjNBEeuwxa66LWwQs/QFLKQwv0nIYojRVHytp9QcXrQ==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.161)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.161 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C", "From": "Suanming Mou <suanmingm@nvidia.com>", "To": "Matan Azrad <matan@nvidia.com>, Viacheslav Ovsiienko\n <viacheslavo@nvidia.com>, Dariusz Sosnowski <dsosnowski@nvidia.com>", "CC": "<dev@dpdk.org>", "Subject": "[PATCH 14/27] net/mlx5: fix indirect action validate", "Date": "Fri, 23 Sep 2022 17:43:21 +0300", "Message-ID": "<20220923144334.27736-15-suanmingm@nvidia.com>", "X-Mailer": "git-send-email 2.18.1", "In-Reply-To": "<20220923144334.27736-1-suanmingm@nvidia.com>", "References": "<20220923144334.27736-1-suanmingm@nvidia.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.231.35]", "X-ClientProxiedBy": "rnnvmail201.nvidia.com (10.129.68.8) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CO1NAM11FT108:EE_|SJ1PR12MB6028:EE_", "X-MS-Office365-Filtering-Correlation-Id": "d12b7cbf-5872-48e8-a05a-08da9d721f0c", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n af/X3FwH9/1n8LdDE4HOS+shGy0NPW90Wzt9pvl4Q+ixJ6s+/zvoqvJgIPr9ETmOTmEOmeVraPEKfaeExdjkvs7awZHRsUFKkWW5NQwyljIbirfKwmXhaZXZmJ8FNKFdyKtEfgfomtlrxF0Yc6uj7nwZq/yN1BwWiIswYw1ERliZQG9WPueK76PhhzBgcjU10I41rRg4klkA3TJlzldDZhWYpb3N68rIX8QHu8IyjzmkUdu7t1/s1luZ2eIilLBgONNq18nkcQNGeyPH9ukYNx6vIklkOcJwRjh7du9sf7pPBma5Y9FBb2Y71xzpJPUUh5fm2NRCnqXq7odl1EHcruhYhq/PU1zQ+NIiq+At7vDzg8WZ8UU2zPchUV95HqDSs02IXBSdU6EMYicQyQjeK5HDSfw/mS1s3CMuoLHSxHBNGorgndWnpXXH1qQXSUOaqZkTYBdjVy5CDTafU2BpZ7nNmp9mVAeD/zFDfSU04/Ah6ajZhCN59Ai4somd/PHlx6YwSjo70AWvovN98iSAaGhxSXwegyugkudSEeJKRE59dhUG/ieHW38it/DcHUiLXIqHPohL+DoHnfSSA4LIa7nmImWu6OLeNs+vQLtznVvLXVh2Cezq495En7JFSGES+w95FTFN2u3SBpKnuUQQsZ9eCXO/sKcQPZiiFZDwSFru/ycQGFGKS1sdDi2Tt+F/YfogH/xqW1gXvTl/3WT094o4hLe480rESseJgVPuNx3Cw4gQNJ9fthXpRvQ52XC6fQT4Nfs89KwkmllKC+6pCA==", "X-Forefront-Antispam-Report": "CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE;\n SFS:(13230022)(4636009)(396003)(136003)(39860400002)(376002)(346002)(451199015)(46966006)(40470700004)(36840700001)(16526019)(186003)(426003)(1076003)(47076005)(336012)(2616005)(86362001)(55016003)(40460700003)(6286002)(26005)(6666004)(7696005)(41300700001)(5660300002)(15650500001)(4326008)(36756003)(82740400003)(7636003)(40480700001)(356005)(82310400005)(83380400001)(2906002)(36860700001)(316002)(6636002)(8936002)(8676002)(110136005)(478600001)(70206006)(70586007);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "23 Sep 2022 14:44:29.7537 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n d12b7cbf-5872-48e8-a05a-08da9d721f0c", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT108.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SJ1PR12MB6028", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "For indirect actions, the action mask type indicates the indirect\naction type. And action mask conf be NULL means the indirect action\nwill be provided by flow action conf.\n\nThis commit fixes the indirect action validate.\n\nFixes: 393e0eb555c0 (\"net/mlx5: support DR action template API\")\n\nSigned-off-by: Suanming Mou <suanmingm@nvidia.com>\n---\n drivers/net/mlx5/mlx5_flow_hw.c | 16 ++++++++++------\n 1 file changed, 10 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c\nindex 6a1ed7e790..d828d49613 100644\n--- a/drivers/net/mlx5/mlx5_flow_hw.c\n+++ b/drivers/net/mlx5/mlx5_flow_hw.c\n@@ -2726,7 +2726,8 @@ flow_hw_actions_validate(struct rte_eth_dev *dev,\n \t\tconst struct rte_flow_action *mask = &masks[i];\n \n \t\tMLX5_ASSERT(i < MLX5_HW_MAX_ACTS);\n-\t\tif (action->type != mask->type)\n+\t\tif (action->type != RTE_FLOW_ACTION_TYPE_INDIRECT &&\n+\t\t action->type != mask->type)\n \t\t\treturn rte_flow_error_set(error, ENOTSUP,\n \t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\n \t\t\t\t\t\t action,\n@@ -2824,22 +2825,25 @@ flow_hw_dr_actions_template_handle_shared(const struct rte_flow_action *mask,\n \t\t\t\t\t uint16_t *curr_off,\n \t\t\t\t\t struct rte_flow_actions_template *at)\n {\n-\tuint32_t act_idx;\n \tuint32_t type;\n \n-\tif (!mask->conf) {\n+\tif (!mask) {\n \t\tDRV_LOG(WARNING, \"Unable to determine indirect action type \"\n \t\t\t\"without a mask specified\");\n \t\treturn -EINVAL;\n \t}\n-\tact_idx = (uint32_t)(uintptr_t)mask->conf;\n-\ttype = act_idx >> MLX5_INDIRECT_ACTION_TYPE_OFFSET;\n+\ttype = mask->type;\n \tswitch (type) {\n-\tcase MLX5_INDIRECT_ACTION_TYPE_RSS:\n+\tcase RTE_FLOW_ACTION_TYPE_RSS:\n \t\tat->actions_off[action_src] = *curr_off;\n \t\taction_types[*curr_off] = MLX5DR_ACTION_TYP_TIR;\n \t\t*curr_off = *curr_off + 1;\n \t\tbreak;\n+\tcase RTE_FLOW_ACTION_TYPE_COUNT:\n+\t\tat->actions_off[action_src] = *curr_off;\n+\t\taction_types[*curr_off] = MLX5DR_ACTION_TYP_CTR;\n+\t\t*curr_off = *curr_off + 1;\n+\t\tbreak;\n \tdefault:\n \t\tDRV_LOG(WARNING, \"Unsupported shared action type: %d\", type);\n \t\treturn -EINVAL;\n", "prefixes": [ "14/27" ] }