Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 116132,
    "url": "http://patches.dpdk.org/api/patches/116132/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220909093523.471727-3-bruce.richardson@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20220909093523.471727-3-bruce.richardson@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20220909093523.471727-3-bruce.richardson@intel.com",
    "date": "2022-09-09T09:35:12",
    "name": "[v3,02/13] test/telemetry_json: print success or failure per subtest",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "dcbe7952717caf1ffc053de28ff5358ad2187f91",
    "submitter": {
        "id": 20,
        "url": "http://patches.dpdk.org/api/people/20/?format=api",
        "name": "Bruce Richardson",
        "email": "bruce.richardson@intel.com"
    },
    "delegate": {
        "id": 24651,
        "url": "http://patches.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220909093523.471727-3-bruce.richardson@intel.com/mbox/",
    "series": [
        {
            "id": 24617,
            "url": "http://patches.dpdk.org/api/series/24617/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24617",
            "date": "2022-09-09T09:35:13",
            "name": "telemetry JSON escaping and other enhancements",
            "version": 3,
            "mbox": "http://patches.dpdk.org/series/24617/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/116132/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/116132/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1A06CA0540;\n\tFri,  9 Sep 2022 11:36:17 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 46ECD42B75;\n\tFri,  9 Sep 2022 11:35:52 +0200 (CEST)",
            "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id E499E4003F\n for <dev@dpdk.org>; Fri,  9 Sep 2022 11:35:48 +0200 (CEST)",
            "from orsmga004.jf.intel.com ([10.7.209.38])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Sep 2022 02:35:41 -0700",
            "from silpixa00401385.ir.intel.com ([10.237.214.161])\n by orsmga004.jf.intel.com with ESMTP; 09 Sep 2022 02:35:40 -0700"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1662716149; x=1694252149;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=meo/0pHiYWPh3MuMPnK0dfOYgBnhXJTnsuJS8dOq1pk=;\n b=JEuvBVzIdncbULqlZvEZxeYqHkZs5nAM8uxwFTYmXQdJf+jaPCdjEgZh\n mAUwn0tTaAzfmLv89xDKa+WZXT+QsCteCFpdOp4Bdn4USj/fUTk598/jC\n ECFmRntWl9nOcxYc/6Qi8qTluQgaIJKjhYZr9ZUqS7nA/GVbvdMJ5tIzl\n yRacg0PqIZuvWyIelFHhPYUi0DW41Ns3aO5vCajPDTed3ZQBMPcDxfgsa\n 49Ss1JpptKtSG8WSjSGgiFq38AsxRQX1dWcBQ0zTUTdfEKRKFgzngwUTV\n 1Qu0A8ISsl8UcDhRIhd4IUFd+uXJdzSUTevuSOBeAMas+ax1wZX6Fz/6y g==;",
        "X-IronPort-AV": [
            "E=McAfee;i=\"6500,9779,10464\"; a=\"298241089\"",
            "E=Sophos;i=\"5.93,302,1654585200\"; d=\"scan'208\";a=\"298241089\"",
            "E=Sophos;i=\"5.93,302,1654585200\"; d=\"scan'208\";a=\"740996353\""
        ],
        "X-ExtLoop1": "1",
        "From": "Bruce Richardson <bruce.richardson@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n Ciara Power <ciara.power@intel.com>,\n =?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>",
        "Subject": "[PATCH v3 02/13] test/telemetry_json: print success or failure per\n subtest",
        "Date": "Fri,  9 Sep 2022 10:35:12 +0100",
        "Message-Id": "<20220909093523.471727-3-bruce.richardson@intel.com>",
        "X-Mailer": "git-send-email 2.34.1",
        "In-Reply-To": "<20220909093523.471727-1-bruce.richardson@intel.com>",
        "References": "<20220623164245.561371-1-bruce.richardson@intel.com>\n <20220909093523.471727-1-bruce.richardson@intel.com>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=UTF-8",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "rather than just printing out success or failure at the end of the test\nonly, print out \"OK\" or \"ERROR\" for each individual test case within the\noverall test. As part of this, ensure each case returns 0 on success and\nany other value on failure.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Ciara Power <ciara.power@intel.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\n---\n app/test/test_telemetry_json.c | 33 ++++++++++++++++++++++++---------\n 1 file changed, 24 insertions(+), 9 deletions(-)",
    "diff": "diff --git a/app/test/test_telemetry_json.c b/app/test/test_telemetry_json.c\nindex 790181d316..748b7cfe5a 100644\n--- a/app/test/test_telemetry_json.c\n+++ b/app/test/test_telemetry_json.c\n@@ -102,8 +102,10 @@ test_large_array_element(void)\n \n \tused = rte_tel_json_add_array_string(buf, sizeof(buf), used, str);\n \tprintf(\"%s: buf = '%s', expected = '%s'\\n\", __func__, buf, expected);\n+\tif (used != 0)\n+\t\treturn -1;\n \n-\treturn strlen(buf) != 0;\n+\treturn strncmp(expected, buf, sizeof(buf));\n }\n \n static int\n@@ -117,20 +119,33 @@ test_large_obj_element(void)\n \n \tused = rte_tel_json_add_obj_u64(buf, sizeof(buf), used, str, 0);\n \tprintf(\"%s: buf = '%s', expected = '%s'\\n\", __func__, buf, expected);\n+\tif (used != 0)\n+\t\treturn -1;\n \n-\treturn strlen(buf) != 0;\n+\treturn strncmp(expected, buf, sizeof(buf));\n }\n \n+typedef int (*test_fn)(void);\n+\n static int\n test_telemetry_json(void)\n {\n-\tif (test_basic_array() < 0 ||\n-\t\t\ttest_basic_obj() < 0 ||\n-\t\t\ttest_overflow_array() < 0 ||\n-\t\t\ttest_overflow_obj() < 0 ||\n-\t\t\ttest_large_array_element() < 0 ||\n-\t\t\ttest_large_obj_element() < 0)\n-\t\treturn -1;\n+\tunsigned int i;\n+\ttest_fn fns[] = {\n+\t\t\ttest_basic_array,\n+\t\t\ttest_basic_obj,\n+\t\t\ttest_overflow_array,\n+\t\t\ttest_overflow_obj,\n+\t\t\ttest_large_array_element,\n+\t\t\ttest_large_obj_element,\n+\t};\n+\tfor (i = 0; i < RTE_DIM(fns); i++)\n+\t\tif (fns[i]() == 0)\n+\t\t\tprintf(\"OK\\n\");\n+\t\telse {\n+\t\t\tprintf(\"ERROR\\n\");\n+\t\t\treturn -1;\n+\t\t}\n \treturn 0;\n }\n \n",
    "prefixes": [
        "v3",
        "02/13"
    ]
}