Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/115718/?format=api
{ "id": 115718, "url": "http://patches.dpdk.org/api/patches/115718/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220901093307.284903-1-peng1x.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220901093307.284903-1-peng1x.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220901093307.284903-1-peng1x.zhang@intel.com", "date": "2022-09-01T09:33:07", "name": "[v2] net/iavf: enable inner and outer Tx checksum offload", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "28a541d4ccc820e1b1db34fca147e4b72b4aa78f", "submitter": { "id": 2475, "url": "http://patches.dpdk.org/api/people/2475/?format=api", "name": "Zhang, Peng1X", "email": "peng1x.zhang@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220901093307.284903-1-peng1x.zhang@intel.com/mbox/", "series": [ { "id": 24498, "url": "http://patches.dpdk.org/api/series/24498/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24498", "date": "2022-09-01T09:33:07", "name": "[v2] net/iavf: enable inner and outer Tx checksum offload", "version": 2, "mbox": "http://patches.dpdk.org/series/24498/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/115718/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/115718/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 63703A0032;\n\tThu, 1 Sep 2022 11:32:20 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 02E6940684;\n\tThu, 1 Sep 2022 11:32:20 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id 619F840395\n for <dev@dpdk.org>; Thu, 1 Sep 2022 11:32:18 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 01 Sep 2022 02:32:17 -0700", "from unknown (HELO localhost.localdomain) ([10.239.252.103])\n by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 01 Sep 2022 02:32:15 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1662024738; x=1693560738;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=N2CRJXFYvamch5aZtPjt1M3sEKH+kKb4WsBFwMAxnKk=;\n b=leZcOjgyACmJTgW900CONjyLSQbE81TjuoZAv3xa6ksgYcNaQDkkbXfj\n kH3wdeWL/v4RkecHbNXkL+jtD6DUtpdATTYpgOBHE8IYai7KtbtoLMjwt\n MMKVsb1cXN6iZK9LlvgSbjhrzzbphbzyG82TEaf8pojH2mNeRCphgI7Dn\n qvc0W8bp3tbyN1q5og6dmxL/56aPTHPvGmWIshldA1RCLJNyUH2UMyVYy\n 0ilEIDLY56oJj5pWRXWyd2A6n95cBab488zCufMPCWgMKdKYmz0EIP/sy\n GOxIWJ98jfGZExp9Y5EULNT1/Dlti6Gys5cYkCFlyO+FkoNqyZyUgT2MJ Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10456\"; a=\"321815433\"", "E=Sophos;i=\"5.93,280,1654585200\"; d=\"scan'208\";a=\"321815433\"", "E=Sophos;i=\"5.93,280,1654585200\"; d=\"scan'208\";a=\"642260262\"" ], "From": "Peng Zhang <peng1x.zhang@intel.com>", "To": "dev@dpdk.org", "Cc": "qiming.yang@intel.com, qi.z.zhang@intel.com,\n Peng Zhang <peng1x.zhang@intel.com>", "Subject": "[PATCH v2] net/iavf: enable inner and outer Tx checksum offload", "Date": "Thu, 1 Sep 2022 17:33:07 +0800", "Message-Id": "<20220901093307.284903-1-peng1x.zhang@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220812165223.470777-2-peng1x.zhang@intel.com>", "References": "<20220812165223.470777-2-peng1x.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Enable inner and outer Tx checksum offload for tunnel packet by configure\nol_flags.\n\nSigned-off-by: Peng Zhang <peng1x.zhang@intel.com>\n\n---\nv2: add outer udp cksum flag and remove unrelated code\n---\n drivers/net/iavf/iavf_ethdev.c | 1 +\n drivers/net/iavf/iavf_rxtx.c | 48 ++++++++++++++++++++++++++++++++--\n drivers/net/iavf/iavf_rxtx.h | 9 ++++++-\n 3 files changed, 55 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c\nindex 506fcff6e3..fa040766e5 100644\n--- a/drivers/net/iavf/iavf_ethdev.c\n+++ b/drivers/net/iavf/iavf_ethdev.c\n@@ -1134,6 +1134,7 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \t\tRTE_ETH_TX_OFFLOAD_TCP_CKSUM |\n \t\tRTE_ETH_TX_OFFLOAD_SCTP_CKSUM |\n \t\tRTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM |\n+\t\tRTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM |\n \t\tRTE_ETH_TX_OFFLOAD_TCP_TSO |\n \t\tRTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO |\n \t\tRTE_ETH_TX_OFFLOAD_GRE_TNL_TSO |\ndiff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c\nindex 3deabe1d7e..b784c5cc18 100644\n--- a/drivers/net/iavf/iavf_rxtx.c\n+++ b/drivers/net/iavf/iavf_rxtx.c\n@@ -2334,7 +2334,8 @@ static inline uint16_t\n iavf_calc_context_desc(uint64_t flags, uint8_t vlan_flag)\n {\n \tif (flags & (RTE_MBUF_F_TX_TCP_SEG | RTE_MBUF_F_TX_UDP_SEG |\n-\t\t\tRTE_MBUF_F_TX_TUNNEL_MASK))\n+\t RTE_MBUF_F_TX_TUNNEL_MASK | RTE_MBUF_F_TX_OUTER_IP_CKSUM |\n+\t RTE_MBUF_F_TX_OUTER_UDP_CKSUM))\n \t\treturn 1;\n \tif (flags & RTE_MBUF_F_TX_VLAN &&\n \t vlan_flag & IAVF_TX_FLAGS_VLAN_TAG_LOC_L2TAG2)\n@@ -2399,6 +2400,44 @@ iavf_fill_ctx_desc_tunnelling_field(volatile uint64_t *qw0,\n \tbreak;\n \t}\n \n+\t/* L4TUNT: L4 Tunneling Type */\n+\tswitch (m->ol_flags & RTE_MBUF_F_TX_TUNNEL_MASK) {\n+\tcase RTE_MBUF_F_TX_TUNNEL_IPIP:\n+\t\t/* for non UDP / GRE tunneling, set to 00b */\n+\t\tbreak;\n+\tcase RTE_MBUF_F_TX_TUNNEL_VXLAN:\n+\tcase RTE_MBUF_F_TX_TUNNEL_GTP:\n+\tcase RTE_MBUF_F_TX_TUNNEL_GENEVE:\n+\t\teip_typ |= IAVF_TXD_CTX_UDP_TUNNELING;\n+\t\tbreak;\n+\tcase RTE_MBUF_F_TX_TUNNEL_GRE:\n+\t\teip_typ |= IAVF_TXD_CTX_GRE_TUNNELING;\n+\t\tbreak;\n+\tdefault:\n+\t\tPMD_TX_LOG(ERR, \"Tunnel type not supported\");\n+\t\treturn;\n+\t}\n+\n+\t/* L4TUNLEN: L4 Tunneling Length, in Words\n+\t *\n+\t * We depend on app to set rte_mbuf.l2_len correctly.\n+\t * For IP in GRE it should be set to the length of the GRE\n+\t * header;\n+\t * For MAC in GRE or MAC in UDP it should be set to the length\n+\t * of the GRE or UDP headers plus the inner MAC up to including\n+\t * its last Ethertype.\n+\t * If MPLS labels exists, it should include them as well.\n+\t */\n+\teip_typ |= (m->l2_len >> 1) << IAVF_TXD_CTX_QW0_NATLEN_SHIFT;\n+\n+\t/**\n+\t * Calculate the tunneling UDP checksum.\n+\t * Shall be set only if L4TUNT = 01b and EIPT is not zero\n+\t */\n+\tif (!(eip_typ & IAVF_TX_CTX_EXT_IP_NONE) &&\n+\t (eip_typ & IAVF_TXD_CTX_UDP_TUNNELING))\n+\t\teip_typ |= IAVF_TXD_CTX_QW0_L4T_CS_MASK;\n+\n \t*qw0 = eip_typ << IAVF_TXD_CTX_QW0_TUN_PARAMS_EIPT_SHIFT |\n \t\teip_len << IAVF_TXD_CTX_QW0_TUN_PARAMS_EIPLEN_SHIFT |\n \t\teip_noinc << IAVF_TXD_CTX_QW0_TUN_PARAMS_EIP_NOINC_SHIFT;\n@@ -2535,7 +2574,12 @@ iavf_build_data_desc_cmd_offset_fields(volatile uint64_t *qw1,\n \t}\n \n \t/* Set MACLEN */\n-\toffset |= (m->l2_len >> 1) << IAVF_TX_DESC_LENGTH_MACLEN_SHIFT;\n+\tif (m->ol_flags & RTE_MBUF_F_TX_TUNNEL_MASK)\n+\t\toffset |= (m->outer_l2_len >> 1)\n+\t\t\t<< IAVF_TX_DESC_LENGTH_MACLEN_SHIFT;\n+\telse\n+\t\toffset |= (m->l2_len >> 1)\n+\t\t\t<< IAVF_TX_DESC_LENGTH_MACLEN_SHIFT;\n \n \t/* Enable L3 checksum offloading inner */\n \tif (m->ol_flags & RTE_MBUF_F_TX_IP_CKSUM) {\ndiff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h\nindex 1695e43cd5..66e832713c 100644\n--- a/drivers/net/iavf/iavf_rxtx.h\n+++ b/drivers/net/iavf/iavf_rxtx.h\n@@ -26,6 +26,8 @@\n #define IAVF_TX_NO_VECTOR_FLAGS (\t\t\t\t \\\n \t\tRTE_ETH_TX_OFFLOAD_MULTI_SEGS |\t\t \\\n \t\tRTE_ETH_TX_OFFLOAD_TCP_TSO |\t\t \\\n+\t\tRTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM | \\\n+\t\tRTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM |\t\\\n \t\tRTE_ETH_TX_OFFLOAD_SECURITY)\n \n #define IAVF_TX_VECTOR_OFFLOAD (\t\t\t\t \\\n@@ -56,7 +58,9 @@\n #define IAVF_TX_CKSUM_OFFLOAD_MASK (\t\t \\\n \t\tRTE_MBUF_F_TX_IP_CKSUM |\t\t \\\n \t\tRTE_MBUF_F_TX_L4_MASK |\t\t \\\n-\t\tRTE_MBUF_F_TX_TCP_SEG)\n+\t\tRTE_MBUF_F_TX_TCP_SEG | \\\n+\t\tRTE_MBUF_F_TX_OUTER_IP_CKSUM | \\\n+\t\tRTE_MBUF_F_TX_OUTER_UDP_CKSUM)\n \n #define IAVF_TX_OFFLOAD_MASK ( \\\n \t\tRTE_MBUF_F_TX_OUTER_IPV6 |\t\t \\\n@@ -67,6 +71,9 @@\n \t\tRTE_MBUF_F_TX_IP_CKSUM |\t\t \\\n \t\tRTE_MBUF_F_TX_L4_MASK |\t\t \\\n \t\tRTE_MBUF_F_TX_TCP_SEG |\t\t \\\n+\t\tRTE_MBUF_F_TX_TUNNEL_MASK |\t\\\n+\t\tRTE_MBUF_F_TX_OUTER_IP_CKSUM | \\\n+\t\tRTE_MBUF_F_TX_OUTER_UDP_CKSUM | \\\n \t\tRTE_ETH_TX_OFFLOAD_SECURITY)\n \n #define IAVF_TX_OFFLOAD_NOTSUP_MASK \\\n", "prefixes": [ "v2" ] }