Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/115350/?format=api
{ "id": 115350, "url": "http://patches.dpdk.org/api/patches/115350/?format=api", "web_url": "http://patches.dpdk.org/project/dts/patch/20220823055939.4186198-2-ke1.xu@intel.com/", "project": { "id": 3, "url": "http://patches.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<20220823055939.4186198-2-ke1.xu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dts/20220823055939.4186198-2-ke1.xu@intel.com", "date": "2022-08-23T05:59:38", "name": "[V1,1/2] tests/tso: modify get_chksum_value_and_verify to fix a checksum-verify error", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d8202785b184b2f1c8f4d0ede231bebf9d19cc53", "submitter": { "id": 2810, "url": "http://patches.dpdk.org/api/people/2810/?format=api", "name": "Ke Xu", "email": "ke1.xu@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dts/patch/20220823055939.4186198-2-ke1.xu@intel.com/mbox/", "series": [ { "id": 24388, "url": "http://patches.dpdk.org/api/series/24388/?format=api", "web_url": "http://patches.dpdk.org/project/dts/list/?series=24388", "date": "2022-08-23T05:59:37", "name": "tests/tso: modify get_chksum_value_and_verify to fix a checksum-verify error and improve the performance", "version": 1, "mbox": "http://patches.dpdk.org/series/24388/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/115350/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/115350/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 845A0A0093;\n\tTue, 23 Aug 2022 08:01:24 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8063A40DFD;\n\tTue, 23 Aug 2022 08:01:24 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id 4068E400D6\n for <dts@dpdk.org>; Tue, 23 Aug 2022 08:01:23 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Aug 2022 23:01:21 -0700", "from unknown (HELO DPDK-XUKE-LAB.sh.intel.com) ([10.67.116.226])\n by orsmga003.jf.intel.com with ESMTP; 22 Aug 2022 23:01:19 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1661234483; x=1692770483;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=+cp0Y3JKE1jzz2mVlBql+fp/dgkP1Oar/Ne7fmWxyOQ=;\n b=g2ilEQv2MgS/m9cA5wY3cLLGnhvHoL2K5CrwHlaaQ175uIh3tNJvPvmd\n tJLpCELEwlSYSd/miME8w4ts3pmg8ZXcAjVDIXmXHjZRXukaBxB9X3Nzl\n kwHCWOTu5PaGvDWbQvMrFV1TcrQuy1tv7PFD1dU1eBBu9COJtsVVu8eDR\n +4Kvkl/MP7h9t1/0QhJL1qHppeH4Jpsnvi0Opfu8sc9ExuCYT8WILt9iW\n NEzDbJ7ZPHxDVVpDcO+N/UxxUQs7XttgV6ynWZiHBx9Ug2YUuehV416gJ\n ClC4Ze3zcCa6HyJUIvfOnf7sUE+nHBhUCj+dV5/5bzlLc/LXCrrO2BrG0 Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10447\"; a=\"319640151\"", "E=Sophos;i=\"5.93,256,1654585200\"; d=\"scan'208\";a=\"319640151\"", "E=Sophos;i=\"5.93,256,1654585200\"; d=\"scan'208\";a=\"560034955\"" ], "X-ExtLoop1": "1", "From": "Ke Xu <ke1.xu@intel.com>", "To": "dts@dpdk.org", "Cc": "qi.fu@intel.com,\n\tke1.xu@intel.com", "Subject": "[dts][PATCH V1 1/2] tests/tso: modify get_chksum_value_and_verify to\n fix a checksum-verify error", "Date": "Tue, 23 Aug 2022 05:59:38 +0000", "Message-Id": "<20220823055939.4186198-2-ke1.xu@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220823055939.4186198-1-ke1.xu@intel.com>", "References": "<20220823055939.4186198-1-ke1.xu@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org" }, "content": "Function \"get_chksum_value_and_verify\" in test suite TSO case test_tso_tunneling\n cannot verify checksum error.\n\nThis function uses the auto checksum calculation of scapy by reading the pcap\n file, erasing the checksum and writing back to a new pcap file. Duplicated\n call to method \"packet.read_pcapfile\" at line 149 and line 162 will append\n extra packets to the packet sequence stored in \"packet.pktgen.pkts\". And\n erasing the checksum at line 153 to line 160 will modify the appended packets.\n This leads to a wrongly organized packet sequence writen to file at line 161,\n causing the checksum verifying wrongly use the raw checksum as the corrected\n checksum. This fails the following checksum verifying.\n\nBy removing duplicated method call at line 149 and creating new object for\n temporary use at line 162. This bug is fixed.\n\nSigned-off-by: Ke Xu <ke1.xu@intel.com>\n---\n tests/TestSuite_tso.py | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/tests/TestSuite_tso.py b/tests/TestSuite_tso.py\nindex 778ba3cc..ef63b7cf 100644\n--- a/tests/TestSuite_tso.py\n+++ b/tests/TestSuite_tso.py\n@@ -146,7 +146,6 @@ class TestTSO(TestCase):\n packet = Packet()\n self.pks = packet.read_pcapfile(dump_pcap, self.tester)\n for i in range(len(self.pks)):\n- self.pks = packet.read_pcapfile(dump_pcap, self.tester)\n pks = self.pks[i]\n out = pks.show\n chksum_list = re.findall(r\"chksum=(0x\\w+)\", str(out))\n@@ -159,7 +158,7 @@ class TestTSO(TestCase):\n pks[\"GRE\"][\"IP\"].chksum = None\n pks[\"GRE\"][\"TCP\"].chksum = None\n packet.save_pcapfile(self.tester, filename=save_file)\n- self.pks1 = packet.read_pcapfile(save_file, self.tester)\n+ self.pks1 = Packet().read_pcapfile(save_file, self.tester)\n out1 = self.pks1[i].show\n chksum_list1 = re.findall(r\"chksum=(0x\\w+)\", str(out1))\n self.tester.send_expect(\"rm -rf %s\" % save_file, \"#\")\n", "prefixes": [ "V1", "1/2" ] }