Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/113658/?format=api
{ "id": 113658, "url": "http://patches.dpdk.org/api/patches/113658/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/b7ac7db51e01301b70899ae6dcff225952a7f37c.1656928437.git.gmuthukrishn@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<b7ac7db51e01301b70899ae6dcff225952a7f37c.1656928437.git.gmuthukrishn@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/b7ac7db51e01301b70899ae6dcff225952a7f37c.1656928437.git.gmuthukrishn@marvell.com", "date": "2022-07-04T09:55:03", "name": "[v3] examples/fips_validation: fix memory leak in sha test", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f8d7ee1599b7ad330c367af2e945233a54b65d3a", "submitter": { "id": 2301, "url": "http://patches.dpdk.org/api/people/2301/?format=api", "name": "Gowrishankar Muthukrishnan", "email": "gmuthukrishn@marvell.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/b7ac7db51e01301b70899ae6dcff225952a7f37c.1656928437.git.gmuthukrishn@marvell.com/mbox/", "series": [ { "id": 23875, "url": "http://patches.dpdk.org/api/series/23875/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23875", "date": "2022-07-04T09:55:03", "name": "[v3] examples/fips_validation: fix memory leak in sha test", "version": 3, "mbox": "http://patches.dpdk.org/series/23875/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/113658/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/113658/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5FCDDA0540;\n\tMon, 4 Jul 2022 11:55:13 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 44F0D410E5;\n\tMon, 4 Jul 2022 11:55:13 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 7801640E09\n for <dev@dpdk.org>; Mon, 4 Jul 2022 11:55:11 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id\n 263M0aVs015540;\n Mon, 4 Jul 2022 02:55:10 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3h2nhnn2m3-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Mon, 04 Jul 2022 02:55:10 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Mon, 4 Jul 2022 02:55:08 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Mon, 4 Jul 2022 02:55:08 -0700", "from localhost.localdomain (unknown [10.28.34.38])\n by maili.marvell.com (Postfix) with ESMTP id EFF9A3F7096;\n Mon, 4 Jul 2022 02:55:05 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=sp4UG1zyU0W0Iq4jhcQFPIa4lidvjTjXN3GQxT7J84o=;\n b=UMUeuP/kh02glz+oKj62AqRakiIvBwLgJ+MEC81yGxqF4EIcXOz/Ev8twj+0iSMoyj9e\n aZp5Nvc5sUmZDXoO+fdx7U0AbnTMzfoFP0XfhutpWk8RloeXwcwyS6aOwTj7qW3/RiuK\n w/kCld+AVvpdPdmeLia+/DAfSgEB56mM8D7sB1/+AVmcCBSVY435HRCzmDR8OX/HaJ4o\n xewn1zjjPLVWr6C4EpILkV9qAI4NB2yrcW2RCj7InNSQ5onmTDVEftPXORIBTS+qZnlW\n e/kTp84qGarlO6qE3q38aN3uWH/4gxBQHmnNTqG+am/6SJJScIk9eImY/9HEBF3Gbyde lQ==", "From": "Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>", "To": "<dev@dpdk.org>", "CC": "Akhil Goyal <gakhil@marvell.com>, Fan Zhang <roy.fan.zhang@intel.com>,\n Brian Dooley <brian.dooley@intel.com>, Anoob Joseph <anoobj@marvell.com>,\n Archana Muniganti <marchana@marvell.com>, Jerin Jacob <jerinj@marvell.com>,\n Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>", "Subject": "[PATCH v3] examples/fips_validation: fix memory leak in sha test", "Date": "Mon, 4 Jul 2022 15:25:03 +0530", "Message-ID": "\n <b7ac7db51e01301b70899ae6dcff225952a7f37c.1656928437.git.gmuthukrishn@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "\n <d94e6a9aa3e5ba95d5d1b3018d6e6a5da4875fdb.1656787423.git.gmuthukrishn@marvell.com>", "References": "\n <d94e6a9aa3e5ba95d5d1b3018d6e6a5da4875fdb.1656787423.git.gmuthukrishn@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "OCCJSredozX7rcCgNUIBYP4pGYyxPkh3", "X-Proofpoint-GUID": "OCCJSredozX7rcCgNUIBYP4pGYyxPkh3", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1\n definitions=2022-07-04_09,2022-06-28_01,2022-06-22_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "There is wrong size used for allocation of digest buffer which in\nsome cases cause memory corruption. Also, fixed places where memory\nleak is observed. This fix would enable sha 384 and 512 NIST vectors\nbe supported fully.\n\nSigned-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>\n---\nv3:\n - addes fixes for suggestions in v2.\n---\n doc/guides/sample_app_ug/fips_validation.rst | 2 +-\n examples/fips_validation/fips_validation_sha.c | 11 +++++++++--\n examples/fips_validation/main.c | 1 +\n 3 files changed, 11 insertions(+), 3 deletions(-)", "diff": "diff --git a/doc/guides/sample_app_ug/fips_validation.rst b/doc/guides/sample_app_ug/fips_validation.rst\nindex 4b68226665..6f4bd34726 100644\n--- a/doc/guides/sample_app_ug/fips_validation.rst\n+++ b/doc/guides/sample_app_ug/fips_validation.rst\n@@ -63,7 +63,7 @@ ACVP\n * AES-CMAC (128,192,256) - AFT\n * AES-XTS (128,256) - AFT\n * HMAC (SHA1, SHA224, SHA256, SHA384, SHA512)\n- * SHA (1,256) - AFT, MCT\n+ * SHA (1, 256, 384, 512) - AFT, MCT\n \n \n Application Information\ndiff --git a/examples/fips_validation/fips_validation_sha.c b/examples/fips_validation/fips_validation_sha.c\nindex a2928618d7..dff552586f 100644\n--- a/examples/fips_validation/fips_validation_sha.c\n+++ b/examples/fips_validation/fips_validation_sha.c\n@@ -229,13 +229,20 @@ parse_test_sha_json_algorithm(void)\n \tfor (i = 0; i < RTE_DIM(phsc); i++) {\n \t\tif (info.interim_info.sha_data.algo == phsc[i].algo) {\n \t\t\tvec.cipher_auth.digest.len = atoi(phsc[i].str);\n-\t\t\tvec.cipher_auth.digest.val = calloc(0, vec.cipher_auth.digest.len * 8);\n+\t\t\tfree(vec.cipher_auth.digest.val);\n+\t\t\tvec.cipher_auth.digest.val = calloc(1, vec.cipher_auth.digest.len);\n+\t\t\tif (vec.cipher_auth.digest.val == NULL)\n+\t\t\t\treturn -1;\n+\n \t\t\tbreak;\n \t\t}\n \t}\n \n-\tif (i == RTE_DIM(phsc))\n+\tif (i == RTE_DIM(phsc)) {\n+\t\tfree(vec.cipher_auth.digest.val);\n+\t\tvec.cipher_auth.digest.val = NULL;\n \t\treturn -1;\n+\t}\n \n \treturn 0;\n }\ndiff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c\nindex 6d52048b5c..8bd5a66889 100644\n--- a/examples/fips_validation/main.c\n+++ b/examples/fips_validation/main.c\n@@ -2099,6 +2099,7 @@ fips_test_one_json_file(void)\n \t\tjson_info.json_vector_set = json_array_get(json_info.json_root, vector_set_idx);\n \t\tfips_test_one_vector_set();\n \t\tjson_array_append_new(json_info.json_write_root, json_info.json_write_set);\n+\t\tjson_incref(json_info.json_write_set);\n \t}\n \n \tjson_dumpf(json_info.json_write_root, info.fp_wr, JSON_INDENT(4));\n", "prefixes": [ "v3" ] }