Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/113467/?format=api
{ "id": 113467, "url": "http://patches.dpdk.org/api/patches/113467/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220627095702.8047-2-pbhagavatula@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220627095702.8047-2-pbhagavatula@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220627095702.8047-2-pbhagavatula@marvell.com", "date": "2022-06-27T09:57:02", "name": "[2/2] eventdev: add function to enq new events to the same queue", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "7f9a4e77f97a94c674730b5c3446db97d23e5c7d", "submitter": { "id": 1183, "url": "http://patches.dpdk.org/api/people/1183/?format=api", "name": "Pavan Nikhilesh Bhagavatula", "email": "pbhagavatula@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220627095702.8047-2-pbhagavatula@marvell.com/mbox/", "series": [ { "id": 23783, "url": "http://patches.dpdk.org/api/series/23783/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23783", "date": "2022-06-27T09:57:02", "name": "[1/2] doc: add enqueue depth for new event type", "version": 1, "mbox": "http://patches.dpdk.org/series/23783/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/113467/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/113467/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5E3EAA0552;\n\tMon, 27 Jun 2022 11:57:10 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E440C400D7;\n\tMon, 27 Jun 2022 11:57:09 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 213B1400D5\n for <dev@dpdk.org>; Mon, 27 Jun 2022 11:57:09 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id\n 25QNrtBt014669\n for <dev@dpdk.org>; Mon, 27 Jun 2022 02:57:08 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3gx1vkwvde-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Mon, 27 Jun 2022 02:57:08 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Mon, 27 Jun 2022 02:57:06 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Mon, 27 Jun 2022 02:57:06 -0700", "from MININT-80QBFE8.corp.innovium.com (unknown [10.28.161.88])\n by maili.marvell.com (Postfix) with ESMTP id 8A3423F70B9;\n Mon, 27 Jun 2022 02:57:04 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=wfGSglM1LaZfZt4ofvpDIBfWREcx+OtX9ODmZ308WGw=;\n b=apPvHW9jcnzcJ8+maH+6WfUMZyZRB+0dP4No6c30bnE4LQJ+69GHYIhypjezPeBYgLpI\n NPqGq4PPI9iBThRxdYh0Tn4pCNWx363JmmHyMPYEbfBs0YqkwgJ4n9ZO5mipnc9fBi9n\n IRzRA/YtMRUzLkmv2Vu9hB3AN60yxCouzUmTthVoWTKdAUnfnSxvlYRztjngws7Klw/M\n K0uCj4pH368oGZi17REirvBUAWFDCVKP90dziqbNjf4tG9qU7Xgokw9Ic12NGIGAYKhn\n 04x6y8BXwWeEBsKzU4VDlbVwNU80QINhsnKBkiXgA0qf4+7cqEZkLuzIKi7/dKVO63iE RA==", "From": "<pbhagavatula@marvell.com>", "To": "<jerinj@marvell.com>", "CC": "<dev@dpdk.org>, Pavan Nikhilesh <pbhagavatula@marvell.com>", "Subject": "[PATCH 2/2] eventdev: add function to enq new events to the same\n queue", "Date": "Mon, 27 Jun 2022 15:27:02 +0530", "Message-ID": "<20220627095702.8047-2-pbhagavatula@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220627095702.8047-1-pbhagavatula@marvell.com>", "References": "<20220627095702.8047-1-pbhagavatula@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "pxF_KhclL6OtChu3fxNvgvLVdKyCp95K", "X-Proofpoint-GUID": "pxF_KhclL6OtChu3fxNvgvLVdKyCp95K", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1\n definitions=2022-06-27_06,2022-06-24_01,2022-06-22_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Pavan Nikhilesh <pbhagavatula@marvell.com>\n\nIntroduce new fastpath function to enqueue events with type *OP_NEW*\nto the same destination event queue.\nThis function can be used as a hint to the PMD to use optimized the\nenqueue sequence.\n\nSigned-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>\n---\n lib/eventdev/eventdev_pmd.h | 5 +-\n lib/eventdev/eventdev_private.c | 13 ++++++\n lib/eventdev/rte_eventdev.h | 80 +++++++++++++++++++++++++++++++-\n lib/eventdev/rte_eventdev_core.h | 11 ++++-\n 4 files changed, 105 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/eventdev/eventdev_pmd.h b/lib/eventdev/eventdev_pmd.h\nindex 69402668d8..f0bb97fb89 100644\n--- a/lib/eventdev/eventdev_pmd.h\n+++ b/lib/eventdev/eventdev_pmd.h\n@@ -178,7 +178,10 @@ struct rte_eventdev {\n \t/**< Pointer to PMD eth Tx adapter enqueue function. */\n \tevent_crypto_adapter_enqueue_t ca_enqueue;\n \n-\tuint64_t reserved_64s[4]; /**< Reserved for future fields */\n+\tevent_enqueue_queue_burst_t enqueue_new_same_dest;\n+\t/**< PMD enqueue burst queue new function to same destination queue. */\n+\n+\tuint64_t reserved_64s[3]; /**< Reserved for future fields */\n \tvoid *reserved_ptrs[3];\t /**< Reserved for future fields */\n } __rte_cache_aligned;\n \ndiff --git a/lib/eventdev/eventdev_private.c b/lib/eventdev/eventdev_private.c\nindex 1d3d9d357e..53d1db281b 100644\n--- a/lib/eventdev/eventdev_private.c\n+++ b/lib/eventdev/eventdev_private.c\n@@ -24,6 +24,17 @@ dummy_event_enqueue_burst(__rte_unused void *port,\n \treturn 0;\n }\n \n+static uint16_t\n+dummy_event_enqueue_queue_burst(__rte_unused void *port,\n+\t\t\t\t__rte_unused uint8_t queue,\n+\t\t\t\t__rte_unused const struct rte_event ev[],\n+\t\t\t\t__rte_unused uint16_t nb_events)\n+{\n+\tRTE_EDEV_LOG_ERR(\n+\t\t\"event enqueue burst requested for unconfigured event device\");\n+\treturn 0;\n+}\n+\n static uint16_t\n dummy_event_dequeue(__rte_unused void *port, __rte_unused struct rte_event *ev,\n \t\t __rte_unused uint64_t timeout_ticks)\n@@ -90,6 +101,7 @@ event_dev_fp_ops_reset(struct rte_event_fp_ops *fp_op)\n \t\t.enqueue_burst = dummy_event_enqueue_burst,\n \t\t.enqueue_new_burst = dummy_event_enqueue_burst,\n \t\t.enqueue_forward_burst = dummy_event_enqueue_burst,\n+\t\t.enqueue_new_same_dest = dummy_event_enqueue_queue_burst,\n \t\t.dequeue = dummy_event_dequeue,\n \t\t.dequeue_burst = dummy_event_dequeue_burst,\n \t\t.maintain = dummy_event_maintain,\n@@ -111,6 +123,7 @@ event_dev_fp_ops_set(struct rte_event_fp_ops *fp_op,\n \tfp_op->enqueue_burst = dev->enqueue_burst;\n \tfp_op->enqueue_new_burst = dev->enqueue_new_burst;\n \tfp_op->enqueue_forward_burst = dev->enqueue_forward_burst;\n+\tfp_op->enqueue_new_same_dest = dev->enqueue_new_same_dest;\n \tfp_op->dequeue = dev->dequeue;\n \tfp_op->dequeue_burst = dev->dequeue_burst;\n \tfp_op->maintain = dev->maintain;\ndiff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h\nindex 6a6f6ea4c1..2aa563740b 100644\n--- a/lib/eventdev/rte_eventdev.h\n+++ b/lib/eventdev/rte_eventdev.h\n@@ -425,8 +425,9 @@ struct rte_event_dev_info {\n \t * A device that does not support bulk dequeue will set this as 1.\n \t */\n \tuint32_t max_event_port_enqueue_depth;\n-\t/**< Maximum number of events can be enqueued at a time from an\n-\t * event port by this device.\n+\t/**< Maximum number of events that can be enqueued at a time to a\n+\t * event port by this device, applicable for rte_event::op is either\n+\t * *RTE_EVENT_OP_FORWARD* or *RTE_EVENT_OP_RELEASE*\n \t * A device that does not support bulk enqueue will set this as 1.\n \t */\n \tuint8_t max_event_port_links;\n@@ -446,6 +447,12 @@ struct rte_event_dev_info {\n \t * device. These ports and queues are not accounted for in\n \t * max_event_ports or max_event_queues.\n \t */\n+\tint16_t max_event_port_enqueue_new_burst;\n+\t/**< Maximum number of events that can be enqueued at a time to a\n+\t * event port by this device, applicable when rte_event::op is set to\n+\t * *RTE_EVENT_OP_NEW*.\n+\t * A device with no limits will set this value to -1.\n+\t */\n };\n \n /**\n@@ -2082,6 +2089,75 @@ rte_event_enqueue_forward_burst(uint8_t dev_id, uint8_t port_id,\n \t\t\t\t\t fp_ops->enqueue_forward_burst);\n }\n \n+/**\n+ * Enqueue a burst of events objects of operation type *RTE_EVENT_OP_NEW* on\n+ * an event device designated by its *dev_id* through the event port specified\n+ * by *port_id* to the same queue specified by *queue_id*.\n+ *\n+ * Provides the same functionality as rte_event_enqueue_burst(), expect that\n+ * application can use this API when the all objects in the burst contains\n+ * the enqueue operation of the type *RTE_EVENT_OP_NEW* and are destined to the\n+ * same queue. This specialized function can provide the additional hint to the\n+ * PMD and optimize if possible.\n+ *\n+ * The rte_event_enqueue_new_queue_burst() result is undefined if the enqueue\n+ * burst has event object of operation type != RTE_EVENT_OP_NEW.\n+ *\n+ * @param dev_id\n+ * The identifier of the device.\n+ * @param port_id\n+ * The identifier of the event port.\n+ * @param queue_id\n+ * The identifier of the event port.\n+ * @param ev\n+ * Points to an array of *nb_events* objects of type *rte_event* structure\n+ * which contain the event object enqueue operations to be processed.\n+ * @param nb_events\n+ * The number of event objects to enqueue, typically number of\n+ * rte_event_port_attr_get(...RTE_EVENT_PORT_ATTR_ENQ_DEPTH...)\n+ * available for this port.\n+ *\n+ * @return\n+ * The number of event objects actually enqueued on the event device. The\n+ * return value can be less than the value of the *nb_events* parameter when\n+ * the event devices queue is full or if invalid parameters are specified in a\n+ * *rte_event*. If the return value is less than *nb_events*, the remaining\n+ * events at the end of ev[] are not consumed and the caller has to take care\n+ * of them, and rte_errno is set accordingly. Possible errno values include:\n+ * - EINVAL The port ID is invalid, device ID is invalid, an event's queue\n+ * ID is invalid, or an event's sched type doesn't match the\n+ * capabilities of the destination queue.\n+ * - ENOSPC The event port was backpressured and unable to enqueue\n+ * one or more events. This error code is only applicable to\n+ * closed systems.\n+ * @see rte_event_port_attr_get(), RTE_EVENT_PORT_ATTR_ENQ_DEPTH\n+ * @see rte_event_enqueue_burst()\n+ */\n+static inline uint16_t\n+rte_event_enqueue_new_queue_burst(uint8_t dev_id, uint8_t port_id,\n+\t\t\t\t uint8_t queue_id, const struct rte_event ev[],\n+\t\t\t\t uint16_t nb_events)\n+{\n+\tconst struct rte_event_fp_ops *fp_ops;\n+\tvoid *port;\n+\n+\tfp_ops = &rte_event_fp_ops[dev_id];\n+\tport = fp_ops->data[port_id];\n+#ifdef RTE_LIBRTE_EVENTDEV_DEBUG\n+\tif (dev_id >= RTE_EVENT_MAX_DEVS ||\n+\t port_id >= RTE_EVENT_MAX_PORTS_PER_DEV) {\n+\t\trte_errno = EINVAL;\n+\t\treturn 0;\n+\t}\n+\n+\tif (port == NULL) {\n+\t\trte_errno = EINVAL;\n+\t\treturn 0;\n+\t}\n+#endif\n+\treturn fp_ops->enqueue_new_same_dest(port, queue_id, ev, nb_events);\n+}\n+\n /**\n * Dequeue a burst of events objects or an event object from the event port\n * designated by its *event_port_id*, on an event device designated\ndiff --git a/lib/eventdev/rte_eventdev_core.h b/lib/eventdev/rte_eventdev_core.h\nindex c328bdbc82..4d7d27e82d 100644\n--- a/lib/eventdev/rte_eventdev_core.h\n+++ b/lib/eventdev/rte_eventdev_core.h\n@@ -20,6 +20,13 @@ typedef uint16_t (*event_enqueue_burst_t)(void *port,\n \t\t\t\t\t uint16_t nb_events);\n /**< @internal Enqueue burst of events on port of a device */\n \n+typedef uint16_t (*event_enqueue_queue_burst_t)(void *port, uint8_t queue_id,\n+\t\t\t\t\t\tconst struct rte_event ev[],\n+\t\t\t\t\t\tuint16_t nb_events);\n+/**< @internal Enqueue burst of events on port of a device to a specific\n+ * event queue.\n+ */\n+\n typedef uint16_t (*event_dequeue_t)(void *port, struct rte_event *ev,\n \t\t\t\t uint64_t timeout_ticks);\n /**< @internal Dequeue event from port of a device */\n@@ -65,7 +72,9 @@ struct rte_event_fp_ops {\n \t/**< PMD Tx adapter enqueue same destination function. */\n \tevent_crypto_adapter_enqueue_t ca_enqueue;\n \t/**< PMD Crypto adapter enqueue function. */\n-\tuintptr_t reserved[6];\n+\tevent_enqueue_queue_burst_t enqueue_new_same_dest;\n+\t/**< PMD enqueue burst new function to same destination queue. */\n+\tuintptr_t reserved[5];\n } __rte_cache_aligned;\n \n extern struct rte_event_fp_ops rte_event_fp_ops[RTE_EVENT_MAX_DEVS];\n", "prefixes": [ "2/2" ] }